From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web08.3416.1615967557223733128 for ; Wed, 17 Mar 2021 00:52:37 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=rPo8fQgM; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: zhiguang.liu@intel.com) IronPort-SDR: 5Ozm1R/+YYJbsn/4k7fcNNra2AFaDDDud2FBLh2sbgR9M0DEF1+ZMdfqHWROy9N5+FLMT0Jb44 ULZSkYuQ+v0Q== X-IronPort-AV: E=McAfee;i="6000,8403,9925"; a="189504084" X-IronPort-AV: E=Sophos;i="5.81,255,1610438400"; d="scan'208";a="189504084" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Mar 2021 00:52:36 -0700 IronPort-SDR: NNAGiXKKVY2WDulg7egdq/tbSpKgqDdkl6sGjXkYLsBcdln/mt/rTxZ6C511sUSpesdbKgcBIz dqShwPtguGAw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,255,1610438400"; d="scan'208";a="602135949" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga006.fm.intel.com with ESMTP; 17 Mar 2021 00:52:36 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Wed, 17 Mar 2021 00:52:35 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Wed, 17 Mar 2021 00:52:35 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.49) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Wed, 17 Mar 2021 00:52:35 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N1OHq6vHg5Vo1Q3k7kITCbF5XEf5QzwWtcED6z9KNPVP/B1yCOvs7+a/Csko+qA3q5Q3SZpgzFT74zJrwKVD0sTSZYKKHv34E8KK338Z/NuHjDuFHSi4HvNsviV0vZ3Y6qhc4kdg7pLlDiQ5CS+O0YWrnPkTxvfJmH1KQ9VN0a+5HpguarLixAGZKNlR4CA8qENv41+mgvyQU+PcZwnisBOYB/Qt8X+jz5LqtjJAjOaju7JWXsY2vkIm7BDlD56q3PEWNYWRSqd2DlTgT2uJbxGeeSHK2eCcuVCuLJWdz2+Ijx7flMkjsrRqvf17t70yDtL73bdakX8Jw/TfvMrz7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+U1PI8Bmkfy5Vs1IOFf4YrFQc9MqB5LcvAt0TqWMiJc=; b=L5MeER3sAv+EPLz780A22hqhSvYAtQTjtC4pyfDzEhZbiLICIxDyWrlXpH0BZcFXE2yrh4cPGeBVXPGzibTQEvOcLZuLYhcZSbJ1amwRY0+8jZoFsn2eAdY1R21WDczIME5zcxqo9cg+/bfeWgKYGsvoa6WL6WEqxGE+n6QctA+7/fyBjePWo0fmQj6+ffZnBn57NQw0M2kuhVNsQtGrN9F7sampEfMhWWh0A+xxr6Xom/NgYrdGIL7LVy2TD6taNfMmEbUw4CfbGAjgOoNMlfITqtRpY8Zfts89lF16g6xF3Vexy8EnGuOIxpanO+Ywrx1+clMAwQDysyU988XKdQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+U1PI8Bmkfy5Vs1IOFf4YrFQc9MqB5LcvAt0TqWMiJc=; b=rPo8fQgMI27z/THyGt937QIzKf6Y2Oe4BZZ5j29bjs4cexo0FSuenErM/ONQbwFvazNwP3j9k/T/kijuzxAvk+qGrpj7wDm5j0eysZD8TOvZOzzFl4VlzqpfNBngZ4KwEcHPWJcqY/40HuoNbt6SqPfaqWqXqEmYQKjTuBCQmVs= Received: from PH0PR11MB5048.namprd11.prod.outlook.com (2603:10b6:510:3d::14) by PH0PR11MB4775.namprd11.prod.outlook.com (2603:10b6:510:34::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.31; Wed, 17 Mar 2021 07:52:34 +0000 Received: from PH0PR11MB5048.namprd11.prod.outlook.com ([fe80::f490:d71f:fbbe:3b7f]) by PH0PR11MB5048.namprd11.prod.outlook.com ([fe80::f490:d71f:fbbe:3b7f%5]) with mapi id 15.20.3933.032; Wed, 17 Mar 2021 07:52:34 +0000 From: "Zhiguang Liu" To: "devel@edk2.groups.io" , "kuqin12@gmail.com" CC: "Chiu, Chasel" , "Desimone, Nathaniel L" , Liming Gao , "Dong, Eric" Subject: Re: [edk2-devel] [edk2-platforms][PATCH v2 1/5] MinPlatformPkg: CoreCommonLib: Added new library for VariableSmmRuntimeDxe Thread-Topic: [edk2-devel] [edk2-platforms][PATCH v2 1/5] MinPlatformPkg: CoreCommonLib: Added new library for VariableSmmRuntimeDxe Thread-Index: AQHXGpAN7TgsRzvVxEqr1YamSpDE1KqHuSAQ Date: Wed, 17 Mar 2021 07:52:34 +0000 Message-ID: References: <20210316181038.1413-1-kuqin12@gmail.com> <20210316181038.1413-2-kuqin12@gmail.com> In-Reply-To: <20210316181038.1413-2-kuqin12@gmail.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.46.54] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ad048239-7a9d-4181-48ba-08d8e919a06c x-ms-traffictypediagnostic: PH0PR11MB4775: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2958; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: mik3tuK+N50gRyOEy2KxdOrzQJwXeqSIE/Lm2vTnAvloG8aDfaMb8BUgv9tf3JFSXzRfOm6a23UlcfAKaF811O9fiqT079ojoRB2E9mc/S2ZP6HPX9371jBtg9pkjam9gbZxSY62pgdgYSSW1P3eb3fOZabMewuJPqnBZSbi21bSwuijoF0/P2aeRRj2NUdHnkQ6xpPFJhHm9CKUjgCTh2dkKm7ZHmBfZIR+gLtPAz5IwHxQdOcyYU6EVdc2gKUCmt9z88erTiKOHrQGmv19J67j+DoMolCNLPK/S1lBCMh1gi3aNkwjC1XMQ7H5v/kaDV8tQckVV0WPvScbfIPal7KTh4vGHvKX9W434xZnK1Quma9HdwVpiX2lK01H5OcdGgHfoeA1ftHzOn+pnxxsED0WgLzNCeucOed6kqjWW+0e2Iy69lCp5cGkKlT3e/vui+dhGgv00BgXULbQ8JgDaVNCPb0gYgjCApn+TGOgH1OSvq87ZDzMif1vfcdYNNe/COmkNC1YoG0+2+cP+2xprwH+uEXy31a1NSIIxJJlozEpoYIp7qhCop09n3VXmplOH3uf0gPxhRYycpzF/q7oWhy3COLBHoqoAWUU3BOpr9PH1hKUiDtPXNyZc8DDkfdT1fImhkvDmxKbq+235PFQAQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5048.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(396003)(136003)(346002)(39860400002)(366004)(376002)(54906003)(7696005)(55016002)(9686003)(76116006)(6506007)(4326008)(2906002)(5660300002)(86362001)(26005)(53546011)(316002)(33656002)(66476007)(8676002)(110136005)(52536014)(186003)(66946007)(966005)(478600001)(71200400001)(83380400001)(66446008)(64756008)(66556008)(8936002)(107886003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?Hbmg7N9GVD2l0kbx3//H1Se8zzVvnt4n+iH2xSyCF6UVwmme9ac7kqT7S++2?= =?us-ascii?Q?Da0r09dHZI3q3DVPRDqLDTMzPNJDI2DmNjVzHAOFU74+02LmtIi/s8OT9jrN?= =?us-ascii?Q?alREMVtfhwsaR4qb2ikId/++7QMS3Y/0dLL4gmAErlBA2ap8pg/hoV2x7c9t?= =?us-ascii?Q?zhQDcwjkr9vg6/+k4CrrXXF5N+7QQqezFyj9LtjufKM2jPTfqC8MaAm8zktQ?= =?us-ascii?Q?3JwDlXro5RfkOUVvt8r32qJLVk1DXwR1nsORF8sbupPCo9SvB67ebFwMVv80?= =?us-ascii?Q?d3aN7hqmsEtHEFeJo67WBzHE27Kkpz2YdMdckAbvNiQD6LIwI9NkS6m9xhsY?= =?us-ascii?Q?1FzIfx/B37axLOJWBWtJcb9bAqea9uoqq51ga2piWazTucJb/M3lBU4J3Xgr?= =?us-ascii?Q?cVAcIdnUUUFCr2mqAZeaETKBbwTEcbfaKnIc0EZ8lWSsu7nsahGa3zUITMM0?= =?us-ascii?Q?+HUxjOC3glUZ/gLKCqm23gZweC2EltA8uXWDYcVnG3m8srIomv7T/vOFuMAq?= =?us-ascii?Q?Sc7B3D3ETn2mPsiYwI5B+f2qWv2Q6wjyBdi6xZ8qawTW7y3OQ+KitvbQpeBU?= =?us-ascii?Q?iY8eGtQXwF3tNXchJjKpvwhnRRxywdQwuw6ihZWtJQUnEjhq85WCnCVG1Y1D?= =?us-ascii?Q?k1D8P1Vsn8R5ME3SzNQgKD8lvtsHFmJ9NeDno/7W2E2aBIP3hvIwxG1LBAGf?= =?us-ascii?Q?DZdBYoTiCAinh7WWKqLnfae8wDR+2XRgIzc1dwyq2aIP0/VBtBqpaJhZdUgw?= =?us-ascii?Q?HfW86hFlrRNzLw2CCp2wCpeo40DHJGAWxEV2gZOMghBq54ACfmsREhBtuD22?= =?us-ascii?Q?BE82PolDN7ZIuY3ecU1Fg0f91EoDEsGwZB3+Owfu2kPaJJYVeyb0tsitL4VQ?= =?us-ascii?Q?2SBidKl4QjQBMeDHWxjKsKjeh3I57goFub6i4BLfxlMwwkkyMF7sAXwDI5nm?= =?us-ascii?Q?4Sv5A77tRZrW7r8TqiJJw3k1W9Nrati4k9nAh/R41P7A0rGEfQul/57UsGEN?= =?us-ascii?Q?rM7gEBLtPKVs4SuPVIGC2BfY28e16Ul/f/KxTlhuvoeAMsPLzMuVUCJPY5Wr?= =?us-ascii?Q?aKkG4j8chf1cwbhf/f6i9bTl2PiZXsiusSU7uWYorB8HW6vdzcLnqIvX009b?= =?us-ascii?Q?DoX0o2EaFpFt1kAp3vJE4TtZIy5LtVaVq3f9AMZhT90qRXaqsnob2khMez13?= =?us-ascii?Q?YFHP/Kwb2ZVGRFDFJ8nimcLEr8i+50Ffn1z2XH7zwzVHYVUWMvpxUjm60tTF?= =?us-ascii?Q?a6W+0dKAqYQv/xWgPXPFPfw4GG1AlV1htj0TSVZISUI2CrrzAxU42t7y/Fex?= =?us-ascii?Q?hF4=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5048.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ad048239-7a9d-4181-48ba-08d8e919a06c X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Mar 2021 07:52:34.6038 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: s5RHkl0esDrzlh086t//fuF7tFSel668emX1nbIlWHg4di6EALNDC01CTFBY54xGVCqkA0i+nKdlA3nQhTsY7Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4775 Return-Path: zhiguang.liu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Zhiguang Liu Hi Kun, Since the first two changes about MinPlatformPkg already got reviewed, can= we first check them in? Thanks Zhiguang > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Kun Qin > Sent: Wednesday, March 17, 2021 2:11 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Liming Gao > ; Dong, Eric > Subject: [edk2-devel] [edk2-platforms][PATCH v2 1/5] MinPlatformPkg: > CoreCommonLib: Added new library for VariableSmmRuntimeDxe >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3250 >=20 > This change added NULL MmUnblockMemoryLib instance in dsc files of > CoreCommonLib to resolve newly introduced dependency. The library > interface is consumed by VariableSmmRuntimeDxe to better support > variable runtime cache feature. >=20 > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Liming Gao > Cc: Eric Dong >=20 > Signed-off-by: Kun Qin > Reviewed-by: Liming Gao > --- >=20 > Notes: > v2: > - Added reviewed-by tag [Liming] >=20 > Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc > b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc > index cb40e111b5dd..bcabb797e91a 100644 > --- a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc > +++ b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc > @@ -159,6 +159,7 @@ [LibraryClasses.common] > LockBoxLib|MdeModulePkg/Library/LockBoxNullLib/LockBoxNullLib.inf >=20 > SmmMemLib|MdePkg/Library/SmmMemLib/SmmMemLib.inf > + > + > MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblo > ckMemoryLi > + bNull.inf >=20 > SmbusLib|MdePkg/Library/BaseSmbusLibNull/BaseSmbusLibNull.inf >=20 > VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyL= i > b.inf > -- > 2.30.0.windows.1 >=20 >=20 >=20 >=20 >=20