From: "Zhiguang Liu" <zhiguang.liu@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Gao, Liming" <gaoliming@byosoft.com.cn>
Cc: "Jiang, Guomin" <guomin.jiang@intel.com>
Subject: Re: [edk2-devel] [PATCH] Wiki: Add optional steps for developer to run CI test before sending
Date: Fri, 14 Jan 2022 01:42:01 +0000 [thread overview]
Message-ID: <PH0PR11MB5048DA3CF86793FE8C0A8E5890549@PH0PR11MB5048.namprd11.prod.outlook.com> (raw)
In-Reply-To: <01c901d80689$4068dd10$c13a9730$@byosoft.com.cn>
Hi Liming,
Could you help merge this change?
This change also get Guomin's reviewed-by.
Thanks
Zhiguang
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> gaoliming
> Sent: Tuesday, January 11, 2022 9:19 AM
> To: devel@edk2.groups.io; Liu, Zhiguang <zhiguang.liu@intel.com>
> Subject: 回复: [edk2-devel] [PATCH] Wiki: Add optional steps for developer
> to run CI test before sending
>
> Zhiguang:
> Thanks for your update. Reviewed-by: Liming Gao
> <gaoliming@byosoft.com.cn>
>
> Thanks
> Liming
> > -----邮件原件-----
> > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Zhiguang Liu
> > 发送时间: 2022年1月10日 11:26
> > 收件人: devel@edk2.groups.io
> > 抄送: Liming Gao <gaoliming@byosoft.com.cn>
> > 主题: [edk2-devel] [PATCH] Wiki: Add optional steps for developer to run
> CI
> > test before sending
> >
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Signed-off-by: Zhiguang Liu <zhiguang.liu@intel.com>
> > ---
> > EDK-II-Development-Process.md | 60
> > +++++++++++++++++++++++++++++++++++++++++++++---------------
> > 1 file changed, 45 insertions(+), 15 deletions(-)
> >
> > diff --git a/EDK-II-Development-Process.md
> > b/EDK-II-Development-Process.md index 469a979..747c6e1 100644
> > --- a/EDK-II-Development-Process.md
> > +++ b/EDK-II-Development-Process.md
> > @@ -59,20 +59,50 @@ The developer process for the EDK II project
> >
> > `$ git rebase origin/master`
> >
> > -9. Run the automated code formatting tool (Uncrustify) against your
> changes
> >
> > -
> >
> > - - [EDK-II-Code-Formatting](EDK-II-Code-Formatting "wikilink")
> >
> > -
> >
> > - - The changes must pass local CI which includes a code formatting
> check
> >
> > - in order to be merged into the code base.
> >
> > -
> >
> > - - It is strongly recommended that you format the code after each
> commit.
> >
> > - The code can then be easily amended with the formatted output.
> > Some
> >
> > - developers might also prefer to format frequently while writing the
> >
> > - code using the plugin instructions described in the code formatting
> >
> > - wiki page.
> >
> > -
> >
> > -10. Create patch (serial) to the [[edk2-devel]] mailing list
> >
> > +9. Run the automated code formatting tool (Uncrustify) against your
> changes
> > +
> > + - [EDK-II-Code-Formatting](EDK-II-Code-Formatting "wikilink")
> > +
> > + - The changes must pass local CI which includes a code formatting
> check
> > + in order to be merged into the code base.
> > +
> > + - It is strongly recommended that you format the code after each
> > commit.
> > + The code can then be easily amended with the formatted output.
> > Some
> > + developers might also prefer to format frequently while writing the
> > + code using the plugin instructions described in the code formatting
> > + wiki page.
> > +
> > +10. (Optional) Push changes to the developer's fork of the EDK II project
> > + repository.
> > +
> > + - How to create a [GitHub
> >
> fork](https://help.github.com/en/github/getting-started-with-github/fork-
> a-r
> > epo)
> > + - **NOTE:** A GitHub fork can also be created using the command
> > line
> > + utility called [`hub`](https://github.com/github/hub/releases).
> > The
> > + `hub` usage information can be found
> > [here](https://hub.github.com/hub.1.html).
> > +
> > + - Add remote to the developer's fork of the EDK II project
> > +
> > + `$ git remote add <developer-id>
> > https://github.com/<developer-id>/edk2.git`
> > +
> > + - Push the integration branch.
> > +
> > + `$ git push <developer-id> <new-integration-branch>`
> > +
> > +11. (Optional) Create a GitHub pull request from the developer's
> > + <new-integration-branch> to edk2/master to run CI check.
> > +
> > + - How to create a [GitHub pull
> >
> request](https://help.github.com/en/github/collaborating-with-issues-and-
> pu
> > ll-requests/creating-a-pull-request)
> > + - **NOTE:** A GitHub pull request can also be created using the
> > command
> > + line utility called
> [`hub`](https://github.com/github/hub/releases).
> > + The `hub` usage information can be found
> > [here](https://hub.github.com/hub.1.html).
> > +
> > + - Declare that it is for CI check test in the pull request title and
> > + description.
> > +
> > + - Resolve GitHub pull request issues if it fails. Please refrence
> step 8
> > + in the below **The maintainer process for the EDK II project**
> > +
> > +12. Create patch (serial) to the [[edk2-devel]] mailing list
> >
> > - Clean out any old patches: `$ rm *.patch`
> >
> > @@ -86,7 +116,7 @@ The developer process for the EDK II project
> >
> > - `$ git send-email *.patch`
> >
> > -11. Modify local commits based on the review feedbacks and repeat
> > steps
> >
> > +13. Modify local commits based on the review feedbacks and repeat
> > +steps
> > 3 to 9
> >
> > - For the latest commit, you can use `$ git commit --amend`
> > --
> > 2.32.0.windows.2
> >
> >
> >
> > -=-=-=-=-=-=
> > Groups.io Links: You receive all messages sent to this group.
> > View/Reply Online (#85435):
> > https://edk2.groups.io/g/devel/message/85435
> > Mute This Topic: https://groups.io/mt/88316431/4905953
> > Group Owner: devel+owner@edk2.groups.io
> > Unsubscribe: https://edk2.groups.io/g/devel/unsub
> > [gaoliming@byosoft.com.cn]
> > -=-=-=-=-=-=
> >
>
>
>
>
>
>
>
next prev parent reply other threads:[~2022-01-14 1:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-10 3:25 [PATCH] Wiki: Add optional steps for developer to run CI test before sending Zhiguang Liu
2022-01-11 1:19 ` 回复: [edk2-devel] " gaoliming
2022-01-14 1:42 ` Zhiguang Liu [this message]
2022-01-11 1:24 ` Guomin Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR11MB5048DA3CF86793FE8C0A8E5890549@PH0PR11MB5048.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox