From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web11.9942.1670226260986682036 for ; Sun, 04 Dec 2022 23:44:21 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=C6Jzg5Og; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: zhiguang.liu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1670226261; x=1701762261; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=ublD/gczBB2Bn/lSIT3ByVknDgWDm/3lXcJ/hVTU85U=; b=C6Jzg5OgyHIxTE9ahmhkQkmZszpujR51wKEgu8JGU8OQ8UwAqtuvOeCA SHL+HHOlTv77E5JdjXfjJmPrIDD4CJedJ1ub/ltXjINrtNY6dOJhUkfZR GRGYjO3MM1bzuq0+pTApkqtM+UnIKMRSDur/2rDXswHHClLWHBGv1fC4F y1iK4DDJmuwfo8VZamTMFd9g1eH6OhCurqk3bwqHqrNCjbFNEYeemazus imkBDZwIeURGixBx0Rf76azGbL3vk+7G9OB+4eWvR3Dc2CFMDgf5OmF9U r63bRY54zlahcBlczrzjQLW6T8scrY8rlmtG/d+GoNH/Ng8mkXBGER8qd g==; X-IronPort-AV: E=McAfee;i="6500,9779,10551"; a="299711137" X-IronPort-AV: E=Sophos;i="5.96,218,1665471600"; d="scan'208";a="299711137" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Dec 2022 23:44:20 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10551"; a="890859976" X-IronPort-AV: E=Sophos;i="5.96,218,1665471600"; d="scan'208";a="890859976" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga006.fm.intel.com with ESMTP; 04 Dec 2022 23:44:19 -0800 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Sun, 4 Dec 2022 23:44:19 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Sun, 4 Dec 2022 23:44:19 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Sun, 4 Dec 2022 23:44:18 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gyHdOKy73e71kMqGmKTpu/SWXgbO8O069N/lbyidpxyDSC2OEH0+nLMNVdDPkMdwWkMFZNoTerkPQAlcrn3hYsSaatb6c8fndEAsDYedEoDeZZFaIWr6QCyAwIDrRUwZEgJoGfQUtavqSaXHqHR5HDJ4WDZt5aaRQW4y0icrLZhwneTd+T4KUBYAQ370Fi+JNowW466vfeguq2J7qYkzjGqL8y2letAdmHTNgRC1iuLs8vPdOiTNPSgnlLB+YEFcXWl7ZFcRSMARrA3tkG1ar50TgdT9S/+D6JZa4GKWzNyG+qPS4lHCPzTvrSrnEtm8r+mE3cpH+1kn5+cI6imU6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JGyMaywh9YdCGu7xrp6ntFtG0O9/KmiO0K7e4t7Rihg=; b=WiJ8rmX6e+uu8lY5kjAix1xyz0blux0kwJb0YqtJ206l0FV5n1217tf9/58gYMElT4Kt2UUKiSte2ML/WI0v6lkt6aUQpoMqg2h2loCqWxcRY49S7GykOgCIg4b2Sdl6I5cYDbLBeeUE+hUewd2fApGZbddylYd+ig3s5/M/5CpccnZGeZ047OMli5/gga49YoSNl5LWCp1GRbqtLEWgYiasbamxPZv0v+Mjt6EBpeY8a4UswGqd7hh+LPcr+JUkXthoGjymdlAH7doMta+6XnMpClLq2PI4m7POygjZPY95MN7n0HDBR3aIQ86CcdX/L69iAGqvKNXPAPEGOMgeaQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5048.namprd11.prod.outlook.com (2603:10b6:510:3d::14) by SJ0PR11MB4878.namprd11.prod.outlook.com (2603:10b6:a03:2d8::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.13; Mon, 5 Dec 2022 07:44:10 +0000 Received: from PH0PR11MB5048.namprd11.prod.outlook.com ([fe80::bf9a:7d68:2ee8:dfd9]) by PH0PR11MB5048.namprd11.prod.outlook.com ([fe80::bf9a:7d68:2ee8:dfd9%6]) with mapi id 15.20.5880.014; Mon, 5 Dec 2022 07:44:10 +0000 From: "Zhiguang Liu" To: "Kinney, Michael D" , "devel@edk2.groups.io" CC: Michael Kubacki , Sean Brogan , "Ni, Ray" Subject: Re: [Patch 1/1] UnitTestFrameworkPkg: Library classes private to public Thread-Topic: [Patch 1/1] UnitTestFrameworkPkg: Library classes private to public Thread-Index: AQHZBQGTEw9mOxm1uUud7M736AxFI65e601g Date: Mon, 5 Dec 2022 07:44:10 +0000 Message-ID: References: <20221130211956.584-1-michael.d.kinney@intel.com> In-Reply-To: <20221130211956.584-1-michael.d.kinney@intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR11MB5048:EE_|SJ0PR11MB4878:EE_ x-ms-office365-filtering-correlation-id: 34ca9852-1391-42b7-cf4c-08dad6947f3d x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 6ztMfuf+n9+oRY8Asuum7sVGrixMq9DBv6/c+kQ2ZNfpSRW7C1tHQgBu2J9IBcXPWBOrzhqk4uP3axtSaAR/UYHC9ojls34sh2DrP1TU9r/kVdpRPvlKbd3q9rPT81pFt/VyfmSb9BH/y/QNzkPVkNoe63Y69wavWylrmuFPJiS4k3Z7AaU8byHOiWow7keCY16Z9IQDSuzNg+CmPZxbkZBsaFggpnM3q1mw36UV+dxKoiHV5TLu2/x39r5BG6sCqE6yP6/1Z+0YuvSY6xNq9EASZVLELbOvOy1e/cVioLLjf0splhDSa/BxtBKye+nIjhWPZheeIsI4gNMO2D1Zzat+NiIxj0Jmc7qdXGA/SRWDH+NF4AOr+l5gdJnQG3U6fx+g3wXe2Q/IN8tpdsi8WxbJf4v67Dqk6q0uxJXtt8CaPw/1eS6SuHovYShZfzvLJaDRtfzQloVc/uwJBieH4W+q26MrbV0AnuuEs+wmomBjBqh7B05T5IYNA0qcRHcYviaqSbks6IqchAw/fONVvgiBeqS9J5IyD6zKDxdfVbABKUJU2rLQYlAIUvry4DWX2K3fLlXNKB4bsxGAhpSAv29zoGDOkxeBGs2QGJGbpnGz4Y0xArvU5Zenmst+16+0txoodpNnJGImFdxLeeAAcjQQ5/ZDJ43/Hkc/oyTA2PCStqf+8yvrs+pEXZSTGhk219i1Kc2M6OvDpVtd4GoGslgTnGD/MJm2sI49DLsndj4= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5048.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(136003)(346002)(396003)(376002)(366004)(451199015)(7696005)(316002)(966005)(83380400001)(54906003)(53546011)(9686003)(107886003)(6506007)(110136005)(26005)(86362001)(186003)(2906002)(55016003)(33656002)(66556008)(66476007)(66446008)(64756008)(76116006)(4326008)(122000001)(8676002)(66946007)(38100700002)(38070700005)(82960400001)(71200400001)(478600001)(8936002)(41300700001)(5660300002)(52536014);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?EoruJtPz18TzfbLCKKP1AvRRH1VtecU7+VZ5uvy1czhDEkHCl1B7GRoPWW1b?= =?us-ascii?Q?m63oTHDqE99ACrIsSzN4XC9KiqWsWEo9gwsxc/XSNaRZVMxRUDFc01tXEPKn?= =?us-ascii?Q?+fTnlH1HuAsAC+lUbVkWN4gcJ6dPXQKIzP4/mXT2obWDla0yJ2RxH/VRT+uc?= =?us-ascii?Q?s6kmAFAY2BcnFrg8aYKsaMAcuShzDUgAnFX0DecpP1NzMCG0P3z2ShNLSR9X?= =?us-ascii?Q?U7Ycj3eXoHG23qjlqx2+8FokKwNB0AQJkqu3f2rpvJPyPSG6OtEL6KvrKNNr?= =?us-ascii?Q?Y9KaNCrmIB13IO4ICYRc1RD5tustoIN5PP3QmH03bEPEVEiMx5ej2ox0DHij?= =?us-ascii?Q?JUKg1haaf3GjaJEHqnq7N5NjyImXWmyXgDtoTvr3CgGAofe2RWCu7KfVtGVR?= =?us-ascii?Q?pqV3kjBjdJ7jvapY04Yh2w94l9v6hnXHkP1FlgY9i+bS+vT8cI92FuxGPtkn?= =?us-ascii?Q?tZyGI8PQuCUHNUTgiypawpZuFLUs9SM7KkLjwb4H1tnscjVbQ1ycO3Cd+MZp?= =?us-ascii?Q?N2XFK7IN0++THj7G030SajGoqSWVUC6ej1Ha/LTWrDOiu6oYm5SO7qoFWjJS?= =?us-ascii?Q?HKr7BxScd7WnACPDdbadrPRVoLmv/ZP+wA538MMP8j+QAqipJuiJbBSR+FTZ?= =?us-ascii?Q?XUu3THEQupRSypMbOLI6pj+HRmVn5xsPZYfkIWXvUBDNvzKgUA8CZd9VFWXl?= =?us-ascii?Q?0X+fsEtloZ52MOuJEGOyZfxpV50IX0PegksykOIdnvFog65VCxVYod7y/LtC?= =?us-ascii?Q?xBsMmvEE/Q4dXHVLQ8QgMhR7C84HnVMRVZIt330tcbUjlJNKw+BYdKln4Mlc?= =?us-ascii?Q?bj7XbFy3hl2u2epoC1ECTnAkbcOEnMDIS8QOOXTS5VX51T0B+YP+FXFNDsX+?= =?us-ascii?Q?NEy/POb6j9H8vdUiTUkgXD+H70Rmknbc0zr+A3n73Eb0GZpskJT7H6Yb4r/E?= =?us-ascii?Q?iDC9D54qAVF8wKcjumeq7MmIuN17vT4guRq1U4sRiq6cKcG39obxtLODCQ+F?= =?us-ascii?Q?QSTtr1+JmGqXzN1LT1xuOfu5xQH8vkI+Omo4ZlL1oCGfBHEn7WHa00G8UJse?= =?us-ascii?Q?IBSmq+78OKVGQc3BRgH0CLhoO7RvI4fLLP/lIQNwJfBmaeOzUZy8nTwdWM0Y?= =?us-ascii?Q?uiPUeFqnMqjC8DOR9GDo5YdjcIFFdV3CyfpSqVEq5lXFoll75jgVk+0SdoUD?= =?us-ascii?Q?EyBgAbcvL9qUl4QWBIi2BTtCFx99tTvBr9DFxe8dKwvzRsMUUvpI/aYQeClS?= =?us-ascii?Q?K5fv8ZAdk0m617gfp7QFwpaLul3giaA9kuek4cZvQWx8nOYXNiSCpT1LTo8n?= =?us-ascii?Q?Lo8p1yqrOQRBB3HusGR6I8Wpc834aGEZhM5fwsJhQK77m8PrZVWnyBKuwk43?= =?us-ascii?Q?+WKItzoBP7xIsE0KjtEqwLPo7trdlD3Pcwt5ex5E/hG08byhFz/ijX7DzAMA?= =?us-ascii?Q?nOCQztSGSEdvVjU52CUFzE1GHZRNwG6VrtPO2Jva0hw8BSp3Mpf0U38DIOJe?= =?us-ascii?Q?RuE6+wnu14KqQZ2P26KM0I+QCnLcrpsG/gKHrG0iBYDDQ2g04suDXkPFaEkW?= =?us-ascii?Q?GVsAsYBltNm85CNCugfMJhAx1hjgnW4UpUdjrUIz?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5048.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 34ca9852-1391-42b7-cf4c-08dad6947f3d X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Dec 2022 07:44:10.4295 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 3VQDPdA0INwBhnLXePbL3r5NAPBHnY7jPiTVAfk2mnP5mnc1+uly/k4c23vi3BnN0P+nixilG7Jnuu54yIyHuQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4878 Return-Path: zhiguang.liu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Mike,=20 Thanks for the patch.=20 One comment is that UnitTestPersistenceLib depends on a struct definition U= NIT_TEST_SAVE_HEADER, which is defined in private headers. Do you think it is ok to also move it into UnitTestPersistenceLib.h? Or what we really need from the struct in UnitTestPersistenceLib is the Sav= eStateSize, we can define a new public struct UNIT_TEST_SAVE_HEADER_PUBLIC = to only contains the needed fields, like typedef struct { UINT8 Version; UINT32 SaveStateSize; // Size of the entir= e serialized buffer. UINT8 RawData[];=20 } UNIT_TEST_SAVE_HEADER; Thanks Zhiguang > -----Original Message----- > From: Kinney, Michael D > Sent: Thursday, December 1, 2022 5:20 AM > To: devel@edk2.groups.io > Cc: Michael Kubacki ; Sean Brogan > ; Ni, Ray ; Liu, Zhiguang > > Subject: [Patch 1/1] UnitTestFrameworkPkg: Library classes private to pub= lic >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4178 >=20 > * Change GoogleTestLib class from private to public. > * Change UnitTestPersistenceLib class from private to public. >=20 > Cc: Michael Kubacki > Cc: Sean Brogan > Cc: Ray Ni > Cc: Zhiguang Liu > Signed-off-by: Michael D Kinney > --- > .../Library/UnitTestPersistenceLib.h | 0 > UnitTestFrameworkPkg/UnitTestFrameworkPkg.dec | 13 +++++++------ > 2 files changed, 7 insertions(+), 6 deletions(-) rename > UnitTestFrameworkPkg/{PrivateInclude =3D> > Include}/Library/UnitTestPersistenceLib.h (100%) >=20 > diff --git > a/UnitTestFrameworkPkg/PrivateInclude/Library/UnitTestPersistenceLib.h > b/UnitTestFrameworkPkg/Include/Library/UnitTestPersistenceLib.h > similarity index 100% > rename from > UnitTestFrameworkPkg/PrivateInclude/Library/UnitTestPersistenceLib.h > rename to UnitTestFrameworkPkg/Include/Library/UnitTestPersistenceLib.h > diff --git a/UnitTestFrameworkPkg/UnitTestFrameworkPkg.dec > b/UnitTestFrameworkPkg/UnitTestFrameworkPkg.dec > index ed12f32009d8..14e387d63a0f 100644 > --- a/UnitTestFrameworkPkg/UnitTestFrameworkPkg.dec > +++ b/UnitTestFrameworkPkg/UnitTestFrameworkPkg.dec > @@ -26,11 +26,16 @@ [Includes.Common.Private] > Library/CmockaLib/cmocka/include/cmockery > Library/GoogleTestLib/googletest/googletest >=20 > -[LibraryClasses.Common.Private] > +[LibraryClasses] > ## @libraryclass Allows save and restore unit test internal state > # > - UnitTestPersistenceLib|PrivateInclude/Library/UnitTestPersistenceLib.h > + UnitTestPersistenceLib|Include/Library/UnitTestPersistenceLib.h >=20 > + ## @libraryclass GoogleTest infrastructure # > + GoogleTestLib|Include/Library/GoogleTestLib.h > + > +[LibraryClasses.Common.Private] > ## @libraryclass Provides a unit test result report > # > UnitTestResultReportLib|PrivateInclude/Library/UnitTestResultReportLib= .h > @@ -39,10 +44,6 @@ [LibraryClasses.Common.Private] > # > UnitTestBootLib|PrivateInclude/Library/UnitTestBootLib.h >=20 > - ## @libraryclass GoogleTest infrastructure > - # > - GoogleTestLib|Include/Library/GoogleTestLib.h > - > [Guids] > gUnitTestFrameworkPkgTokenSpaceGuid =3D { 0x833d3aba, 0x39b4, 0x43a2, > { 0xb9, 0x30, 0x7a, 0x34, 0x53, 0x39, 0x31, 0xb3 } } >=20 > -- > 2.37.1.windows.1