public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH EDK2 v1 0/1] CryptoPkg/BaseCryptLib:Remove redundant init
@ 2022-09-15  9:26 wenyi,xie
  2022-09-15  9:26 ` [PATCH EDK2 v1 1/1] " wenyi,xie
  0 siblings, 1 reply; 10+ messages in thread
From: wenyi,xie @ 2022-09-15  9:26 UTC (permalink / raw)
  To: devel, jiewen.yao, jian.j.wang, xiaoyu1.lu, guomin.jiang
  Cc: songdongkuang, xiewenyi2

Main Changes :
1.Remove redundant memory init.

Wenyi Xie (1):
  CryptoPkg/BaseCryptLib:Remove redundant init

 CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyCommon.c | 2 --
 1 file changed, 2 deletions(-)

-- 
2.20.1.windows.1


^ permalink raw reply	[flat|nested] 10+ messages in thread
* [PATCH EDK2 v1 1/1] CryptoPkg/BaseCryptLib:Remove redundant init
  2022-09-15  9:26 [PATCH EDK2 v1 0/1] CryptoPkg/BaseCryptLib:Remove redundant init wenyi,xie
@ 2022-09-15  9:26 ` wenyi,xie
  2022-09-15  9:42   ` Xiaoyu Lu
                     ` (3 more replies)
  0 siblings, 4 replies; 10+ messages in thread
From: wenyi,xie @ 2022-09-15  9:26 UTC (permalink / raw)
  To: devel, jiewen.yao, jian.j.wang, xiaoyu1.lu, guomin.jiang
  Cc: songdongkuang, xiewenyi2

CertCtx is used to be defined as a struct and ZeroMem is called to
init this struct. But now CertCtx is defined as a point, so use
ZeroMem (&CertCtx, sizeof (CertCtx)) is not correct any more.

Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Xiaoyu Lu <xiaoyu1.lu@intel.com>
Cc: Guomin Jiang <guomin.jiang@intel.com>
Signed-off-by: Wenyi Xie <xiewenyi2@huawei.com>
---
 CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyCommon.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyCommon.c b/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyCommon.c
index 3336d2f60a6a..f8028181e47f 100644
--- a/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyCommon.c
+++ b/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyCommon.c
@@ -502,8 +502,6 @@ Pkcs7GetCertificatesList (
   OldBuf       = NULL;
   Signers      = NULL;
 
-  ZeroMem (&CertCtx, sizeof (CertCtx));
-
   //
   // Parameter Checking
   //
-- 
2.20.1.windows.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread
* Re: [PATCH EDK2 v1 1/1] CryptoPkg/BaseCryptLib:Remove redundant init
  2022-09-15  9:26 ` [PATCH EDK2 v1 1/1] " wenyi,xie
@ 2022-09-15  9:42   ` Xiaoyu Lu
  2022-09-20 23:03   ` Yao, Jiewen
                     ` (2 subsequent siblings)
  3 siblings, 0 replies; 10+ messages in thread
From: Xiaoyu Lu @ 2022-09-15  9:42 UTC (permalink / raw)
  To: Wenyi Xie, devel@edk2.groups.io, Yao, Jiewen, Wang, Jian J,
	Jiang, Guomin
  Cc: songdongkuang@huawei.com, Lu, Xiaoyu1

Reviewed-by: Xiaoyu Lu <xiaoyu1.lu@intel.com>

-----Original Message-----
From: Wenyi Xie <xiewenyi2@huawei.com> 
Sent: Thursday, September 15, 2022 5:26 PM
To: devel@edk2.groups.io; Yao, Jiewen <jiewen.yao@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; Lu, Xiaoyu1 <xiaoyu1.lu@intel.com>; Jiang, Guomin <guomin.jiang@intel.com>
Cc: songdongkuang@huawei.com; xiewenyi2@huawei.com
Subject: [PATCH EDK2 v1 1/1] CryptoPkg/BaseCryptLib:Remove redundant init

CertCtx is used to be defined as a struct and ZeroMem is called to init this struct. But now CertCtx is defined as a point, so use ZeroMem (&CertCtx, sizeof (CertCtx)) is not correct any more.

Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Xiaoyu Lu <xiaoyu1.lu@intel.com>
Cc: Guomin Jiang <guomin.jiang@intel.com>
Signed-off-by: Wenyi Xie <xiewenyi2@huawei.com>
---
 CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyCommon.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyCommon.c b/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyCommon.c
index 3336d2f60a6a..f8028181e47f 100644
--- a/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyCommon.c
+++ b/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyCommon.c
@@ -502,8 +502,6 @@ Pkcs7GetCertificatesList (
   OldBuf       = NULL;
   Signers      = NULL;
 
-  ZeroMem (&CertCtx, sizeof (CertCtx));
-
   //
   // Parameter Checking
   //
--
2.20.1.windows.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread
* Re: [PATCH EDK2 v1 1/1] CryptoPkg/BaseCryptLib:Remove redundant init
  2022-09-15  9:26 ` [PATCH EDK2 v1 1/1] " wenyi,xie
  2022-09-15  9:42   ` Xiaoyu Lu
@ 2022-09-20 23:03   ` Yao, Jiewen
       [not found]   ` <1716B3FB06A49EB8.26483@groups.io>
  2022-09-23  6:31   ` [PATCH EDK2 v1 1/1] CryptoPkg/BaseCryptLib:Remove redundant init Yao, Jiewen
  3 siblings, 0 replies; 10+ messages in thread
From: Yao, Jiewen @ 2022-09-20 23:03 UTC (permalink / raw)
  To: Wenyi Xie, devel@edk2.groups.io, Wang, Jian J, Lu, Xiaoyu1,
	Jiang, Guomin
  Cc: songdongkuang@huawei.com

Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>


> -----Original Message-----
> From: Wenyi Xie <xiewenyi2@huawei.com>
> Sent: Thursday, September 15, 2022 5:26 PM
> To: devel@edk2.groups.io; Yao, Jiewen <jiewen.yao@intel.com>; Wang, Jian
> J <jian.j.wang@intel.com>; Lu, Xiaoyu1 <xiaoyu1.lu@intel.com>; Jiang,
> Guomin <guomin.jiang@intel.com>
> Cc: songdongkuang@huawei.com; xiewenyi2@huawei.com
> Subject: [PATCH EDK2 v1 1/1] CryptoPkg/BaseCryptLib:Remove redundant
> init
> 
> CertCtx is used to be defined as a struct and ZeroMem is called to
> init this struct. But now CertCtx is defined as a point, so use
> ZeroMem (&CertCtx, sizeof (CertCtx)) is not correct any more.
> 
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Xiaoyu Lu <xiaoyu1.lu@intel.com>
> Cc: Guomin Jiang <guomin.jiang@intel.com>
> Signed-off-by: Wenyi Xie <xiewenyi2@huawei.com>
> ---
>  CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyCommon.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyCommon.c
> b/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyCommon.c
> index 3336d2f60a6a..f8028181e47f 100644
> --- a/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyCommon.c
> +++ b/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyCommon.c
> @@ -502,8 +502,6 @@ Pkcs7GetCertificatesList (
>    OldBuf       = NULL;
>    Signers      = NULL;
> 
> -  ZeroMem (&CertCtx, sizeof (CertCtx));
> -
>    //
>    // Parameter Checking
>    //
> --
> 2.20.1.windows.1


^ permalink raw reply	[flat|nested] 10+ messages in thread
* [edk2-devel] EDKII CI Failure
       [not found]   ` <1716B3FB06A49EB8.26483@groups.io>
@ 2022-09-20 23:05     ` Yao, Jiewen
  2022-09-20 23:36       ` Michael D Kinney
  0 siblings, 1 reply; 10+ messages in thread
From: Yao, Jiewen @ 2022-09-20 23:05 UTC (permalink / raw)
  To: devel@edk2.groups.io

Hi
I notice that EDKII CI failed on step "Build Base Tools from source" for https://github.com/DMTF/libspdm/pull/1218

https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=62090&view=logs&j=c0929384-5a08-5c0f-b36d-6f51b6b81732&t=dc6c8514-4845-5cff-3ead-20e6776e3d52


Anyone knows what is happening on the CI?

Thank you
Yao Jiewen


> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Yao,
> Jiewen
> Sent: Wednesday, September 21, 2022 7:03 AM
> To: Wenyi Xie <xiewenyi2@huawei.com>; devel@edk2.groups.io; Wang,
> Jian J <jian.j.wang@intel.com>; Lu, Xiaoyu1 <xiaoyu1.lu@intel.com>; Jiang,
> Guomin <guomin.jiang@intel.com>
> Cc: songdongkuang@huawei.com
> Subject: Re: [edk2-devel] [PATCH EDK2 v1 1/1]
> CryptoPkg/BaseCryptLib:Remove redundant init
> 
> Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>
> 
> 
> > -----Original Message-----
> > From: Wenyi Xie <xiewenyi2@huawei.com>
> > Sent: Thursday, September 15, 2022 5:26 PM
> > To: devel@edk2.groups.io; Yao, Jiewen <jiewen.yao@intel.com>; Wang,
> Jian
> > J <jian.j.wang@intel.com>; Lu, Xiaoyu1 <xiaoyu1.lu@intel.com>; Jiang,
> > Guomin <guomin.jiang@intel.com>
> > Cc: songdongkuang@huawei.com; xiewenyi2@huawei.com
> > Subject: [PATCH EDK2 v1 1/1] CryptoPkg/BaseCryptLib:Remove
> redundant
> > init
> >
> > CertCtx is used to be defined as a struct and ZeroMem is called to
> > init this struct. But now CertCtx is defined as a point, so use
> > ZeroMem (&CertCtx, sizeof (CertCtx)) is not correct any more.
> >
> > Cc: Jiewen Yao <jiewen.yao@intel.com>
> > Cc: Jian J Wang <jian.j.wang@intel.com>
> > Cc: Xiaoyu Lu <xiaoyu1.lu@intel.com>
> > Cc: Guomin Jiang <guomin.jiang@intel.com>
> > Signed-off-by: Wenyi Xie <xiewenyi2@huawei.com>
> > ---
> >  CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyCommon.c | 2 --
> >  1 file changed, 2 deletions(-)
> >
> > diff --git
> a/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyCommon.c
> > b/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyCommon.c
> > index 3336d2f60a6a..f8028181e47f 100644
> > --- a/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyCommon.c
> > +++ b/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyCommon.c
> > @@ -502,8 +502,6 @@ Pkcs7GetCertificatesList (
> >    OldBuf       = NULL;
> >    Signers      = NULL;
> >
> > -  ZeroMem (&CertCtx, sizeof (CertCtx));
> > -
> >    //
> >    // Parameter Checking
> >    //
> > --
> > 2.20.1.windows.1
> 
> 
> 
> 
> 


^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [edk2-devel] EDKII CI Failure
  2022-09-20 23:05     ` [edk2-devel] EDKII CI Failure Yao, Jiewen
@ 2022-09-20 23:36       ` Michael D Kinney
  2022-09-21  0:01         ` Sean
  0 siblings, 1 reply; 10+ messages in thread
From: Michael D Kinney @ 2022-09-20 23:36 UTC (permalink / raw)
  To: devel@edk2.groups.io, Yao, Jiewen, Kubacki, Michael,
	Kinney, Michael D, Sean Brogan

Hi Jiewen,

Looks like it is not limited to that one PR.

I see this PR has similar failure.  The artifacts show a more detailed log
with nmake.exe not found.  That does not make sense for a windows/VS2019
build after vswhere is used to find path to VS2019 tools.  Perhaps Michael
or Sean can help evaluate.  Maybe there was a change in the Windows agent
profile or the VS2019 tools profile.

	https://github.com/tianocore/edk2/pull/3354

	https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=62007&view=logs&jobId=4a97f94c-8e1f-5e76-68ba-50872604dd63&j=898a5c7a-7a49-5be1-c417-92a6761a8039

INFO - Log Started: Tuesday, September 20, 2022 02:49PM
SECTION - Init SDE
DEBUG - --- self_describing_environment.__init__()
DEBUG - Skipped directories specified = ()
DEBUG - --- self_describing_environment.load_workspace()
DEBUG - Loading workspace: D:\a\1\s\BaseTools
DEBUG -   Including scopes: global
DEBUG - --- self_describing_environment._gather_env_files()
DEBUG - Adding descriptor D:\a\1\s\BaseTools\basetools_calling_path_env.yaml to the environment with scope global
DEBUG - Adding descriptor D:\a\1\s\BaseTools\basetools_path_env.yaml to the environment with scope global
DEBUG - Adding descriptor D:\a\1\s\BaseTools\Source\Python\basetool_tiano_python_path_env.yaml to the environment with scope global
DEBUG - Adding descriptor D:\a\1\s\BaseTools\Plugin\BuildToolsReport\BuildToolsReportGenerator_plug_in.yaml to the environment with scope global
DEBUG - --- self_describing_environment.update_simple_paths()
DEBUG - --- self_describing_environment.update_extdep_paths()
DEBUG - --- self_describing_environment.report_extdep_version()
SECTION - Loading Plugins
DEBUG - Loading Plugin from D:\a\1\s\BaseTools\Plugin\BuildToolsReport\BuildToolsReportGenerator.py
SECTION - Start Invocable Tool
INFO - Running Python version: sys.version_info(major=3, minor=10, micro=7, releaselevel='final', serial=0)
INFO - Cmd to run is: c:\hostedtoolcache\windows\python\3.10.7\x64\lib\site-packages\edk2toollib\bin\vswhere.exe -latest -nologo -all -property installationPath -products * -version 16.0,17.0
INFO - ------------------------------------------------
INFO - --------------Cmd Output Starting---------------
INFO - ------------------------------------------------
INFO - C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise
INFO - ------------------------------------------------
INFO - --------------Cmd Output Finished---------------
INFO - --------- Running Time (mm:ss): 00:00 ----------
INFO - ----------- Return Code: 0x00000000 ------------
INFO - ------------------------------------------------
DEBUG - Calling 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Auxiliary\Build\vcvarsall.bat x86'
DEBUG - Var - ExtensionSdkDir = C:\Program Files (x86)\Microsoft SDKs\Windows Kits\10\ExtensionSDKs
DEBUG - Var - INCLUDE = C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\ATLMFC\include;C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\include;C:\Program Files (x86)\Windows Kits\NETFXSDK\4.8\include\um;C:\Program Files (x86)\Windows Kits\10\include\10.0.22621.0\ucrt;C:\Program Files (x86)\Windows Kits\10\include\10.0.22621.0\shared;C:\Program Files (x86)\Windows Kits\10\include\10.0.22621.0\um;C:\Program Files (x86)\Windows Kits\10\include\10.0.22621.0\winrt;C:\Program Files (x86)\Windows Kits\10\include\10.0.22621.0\cppwinrt
DEBUG - Var - LIB = C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\ATLMFC\lib\x86;C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\lib\x86;C:\Program Files (x86)\Windows Kits\NETFXSDK\4.8\lib\um\x86;C:\Program Files (x86)\Windows Kits\10\lib\10.0.22621.0\ucrt\x86;C:\Program Files (x86)\Windows Kits\10\lib\10.0.22621.0\um\x86
DEBUG - Var - LIBPATH = C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\ATLMFC\lib\x86;C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\lib\x86;C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\lib\x86\store\references;C:\Program Files (x86)\Windows Kits\10\UnionMetadata\10.0.22621.0;C:\Program Files (x86)\Windows Kits\10\References\10.0.22621.0;C:\Windows\Microsoft.NET\Framework\v4.0.30319
DEBUG - Var - Path = C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\Common7\IDE\\Extensions\Microsoft\IntelliCode\CLI;C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\bin\HostX86\x86;C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\Common7\IDE\VC\VCPackages;C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\Common7\IDE\CommonExtensions\Microsoft\TestWindow;C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\Common7\IDE\CommonExtensions\Microsoft\TeamFoundation\Team Explorer;C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Current\bin\Roslyn;C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\Team Tools\Performance Tools;C:\Program Files (x86)\Microsoft Visual Studio\Shared\Common\VSPerfCollectionTools\vs2019\;C:\Program Files (x86)\Microsoft SDKs\Windows\v10.0A\bin\NETFX 4.8 Tools\;C:\Program Files (x86)\HTML Help Workshop;C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\Common7\IDE\CommonExtensions\Microsoft\FSharp\Tools;C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\Common7\Tools\devinit;C:\Program Files (x86)\Windows Kits\10\bin\10.0.22621.0\x86;C:\Program Files (x86)\Windows Kits\10\bin\x86;C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\\MSBuild\Current\Bin;C:\Windows\Microsoft.NET\Framework\v4.0.30319;C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\Common7\IDE\;C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\Common7\Tools\;C:\hostedtoolcache\windows\node\14.20.0\x64;C:\Users\VssAdministrator\AppData\Roaming\Python\Python310\Scripts;C:\hostedtoolcache\windows\Python\3.10.7\x64\Scripts;C:\hostedtoolcache\windows\Python\3.10.7\x64;C:\agents\2.210.1\externals\git\cmd;C:\agents\2.210.1\externals\git\mingw64\bin;C:\Program Files\MongoDB\Server\5.0\bin;C:\aliyun-cli;C:\vcpkg;C:\cf-cli;C:\Program Files (x86)\NSIS\;C:\tools\zstd;C:\Program Files\Mercurial\;C:\hostedtoolcache\windows\stack\2.7.5\x64;C:\cabal\bin;C:\\ghcup\bin;C:\tools\ghc-9.4.2\bin;C:\Program Files\dotnet;C:\mysql\bin;C:\Program Files\R\R-4.2.1\bin\x64;C:\SeleniumWebDrivers\GeckoDriver;C:\Program Files (x86)\sbt\bin;C:\Program Files (x86)\GitHub CLI;C:\Program Files\Git\bin;C:\Program Files (x86)\pipx_bin;C:\npm\prefix;C:\hostedtoolcache\windows\go\1.17.13\x64\bin;C:\hostedtoolcache\windows\Python\3.7.9\x64\Scripts;C:\hostedtoolcache\windows\Python\3.7.9\x64;C:\hostedtoolcache\windows\Ruby\2.5.9\x64\bin;C:\tools\kotlinc\bin;C:\hostedtoolcache\windows\Java_Temurin-Hotspot_jdk\8.0.345-1\x64\bin;C:\Program Files\ImageMagick-7.1.0-Q16-HDRI;C:\Program Files (x86)\Microsoft SDKs\Azure\CLI2\wbin;C:\ProgramData\kind;C:\Program Files\Eclipse Foundation\jdk-8.0.302.8-hotspot\bin;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0\;C:\Windows\System32\OpenSSH\;C:\ProgramData\Chocolatey\bin;C:\Program Files\PowerShell\7\;C:\Program Files\Microsoft\Web Platform Installer\;C:\Program Files\dotnet\;C:\Program Files\Microsoft SQL Server\130\Tools\Binn\;C:\Program Files\Microsoft SQL Server\Client SDK\ODBC\170\Tools\Binn\;C:\Program Files (x86)\Windows Kits\10\Windows Performance Toolkit\;C:\Program Files (x86)\Microsoft SQL Server\110\DTS\Binn\;C:\Program Files (x86)\Microsoft SQL Server\120\DTS\Binn\;C:\Program Files (x86)\Microsoft SQL Server\130\DTS\Binn\;C:\Program Files (x86)\Microsoft SQL Server\140\DTS\Binn\;C:\Program Files (x86)\Microsoft SQL Server\150\DTS\Binn\;C:\Program Files (x86)\Microsoft SQL Server\160\DTS\Binn\;C:\Program Files\OpenSSL\bin;C:\Strawberry\c\bin;C:\Strawberry\perl\site\bin;C:\Strawberry\perl\bin;C:\ProgramData\chocolatey\lib\pulumi\tools\Pulumi\bin;C:\Program Files\TortoiseSVN\bin;C:\Program Files\CMake\bin;C:\ProgramData\chocolatey\lib\maven\apache-maven-3.8.6\bin;C:\Program Files\Microsoft Service Fabric\bin\Fabric\Fabric.Code;C:\Program Files\Microsoft SDKs\Service Fabric\Tools\ServiceFabricLocalClusterManager;C:\Program Files\nodejs\;C:\Program Files\Git\cmd;C:\Program Files\Git\mingw64\bin;C:\Program Files\Git\usr\bin;C:\Program Files\GitHub CLI\;c:\tools\php;C:\Program Files (x86)\sbt\bin;C:\SeleniumWebDrivers\ChromeDriver\;C:\SeleniumWebDrivers\EdgeDriver\;C:\Program Files\Amazon\AWSCLIV2\;C:\Program Files\Amazon\SessionManagerPlugin\bin\;C:\Program Files\Amazon\AWSSAMCLI\bin\;C:\Program Files (x86)\Google\Cloud SDK\google-cloud-sdk\bin;C:\Program Files (x86)\Microsoft BizTalk Server\;C:\Program Files\LLVM\bin;C:\Users\VssAdministrator\.dotnet\tools;C:\Users\VssAdministrator\.cargo\bin;C:\Users\VssAdministrator\AppData\Local\Microsoft\WindowsApps;C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\Llvm\bin;C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\Common7\IDE\CommonExtensions\Microsoft\CMake\CMake\bin;C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\Common7\IDE\CommonExtensions\Microsoft\CMake\Ninja;C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\Common7\IDE\VC\Linux\bin\ConnectionManagerExe
DEBUG - Var - UCRTVersion = 10.0.22621.0
DEBUG - Var - UniversalCRTSdkDir = C:\Program Files (x86)\Windows Kits\10\
DEBUG - Var - VCToolsInstallDir = C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\
DEBUG - Var - WindowsLibPath = C:\Program Files (x86)\Windows Kits\10\UnionMetadata\10.0.22621.0;C:\Program Files (x86)\Windows Kits\10\References\10.0.22621.0
DEBUG - Var - WindowsSdkBinPath = C:\Program Files (x86)\Windows Kits\10\bin\
DEBUG - Var - WindowsSdkDir = C:\Program Files (x86)\Windows Kits\10\
DEBUG - Var - WindowsSdkVerBinPath = C:\Program Files (x86)\Windows Kits\10\bin\10.0.22621.0\
DEBUG - Var - WindowsSDKVersion = 10.0.22621.0\
INFO - Cmd to run is: nmake.exe
INFO - ------------------------------------------------
INFO - --------------Cmd Output Starting---------------
INFO - ------------------------------------------------
INFO - 'nmake.exe' is not recognized as an internal or external command,
INFO - operable program or batch file.
INFO - ------------------------------------------------
INFO - --------------Cmd Output Finished---------------
INFO - --------- Running Time (mm:ss): 00:00 ----------
INFO - ----------- Return Code: 0x00000001 ------------
INFO - ------------------------------------------------


Mike

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Yao, Jiewen
> Sent: Tuesday, September 20, 2022 4:06 PM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] EDKII CI Failure
> 
> Hi
> I notice that EDKII CI failed on step "Build Base Tools from source" for https://github.com/DMTF/libspdm/pull/1218
> 
> https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=62090&view=logs&j=c0929384-5a08-5c0f-b36d-
> 6f51b6b81732&t=dc6c8514-4845-5cff-3ead-20e6776e3d52
> 
> 
> Anyone knows what is happening on the CI?
> 
> Thank you
> Yao Jiewen
> 
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Yao,
> > Jiewen
> > Sent: Wednesday, September 21, 2022 7:03 AM
> > To: Wenyi Xie <xiewenyi2@huawei.com>; devel@edk2.groups.io; Wang,
> > Jian J <jian.j.wang@intel.com>; Lu, Xiaoyu1 <xiaoyu1.lu@intel.com>; Jiang,
> > Guomin <guomin.jiang@intel.com>
> > Cc: songdongkuang@huawei.com
> > Subject: Re: [edk2-devel] [PATCH EDK2 v1 1/1]
> > CryptoPkg/BaseCryptLib:Remove redundant init
> >
> > Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>
> >
> >
> > > -----Original Message-----
> > > From: Wenyi Xie <xiewenyi2@huawei.com>
> > > Sent: Thursday, September 15, 2022 5:26 PM
> > > To: devel@edk2.groups.io; Yao, Jiewen <jiewen.yao@intel.com>; Wang,
> > Jian
> > > J <jian.j.wang@intel.com>; Lu, Xiaoyu1 <xiaoyu1.lu@intel.com>; Jiang,
> > > Guomin <guomin.jiang@intel.com>
> > > Cc: songdongkuang@huawei.com; xiewenyi2@huawei.com
> > > Subject: [PATCH EDK2 v1 1/1] CryptoPkg/BaseCryptLib:Remove
> > redundant
> > > init
> > >
> > > CertCtx is used to be defined as a struct and ZeroMem is called to
> > > init this struct. But now CertCtx is defined as a point, so use
> > > ZeroMem (&CertCtx, sizeof (CertCtx)) is not correct any more.
> > >
> > > Cc: Jiewen Yao <jiewen.yao@intel.com>
> > > Cc: Jian J Wang <jian.j.wang@intel.com>
> > > Cc: Xiaoyu Lu <xiaoyu1.lu@intel.com>
> > > Cc: Guomin Jiang <guomin.jiang@intel.com>
> > > Signed-off-by: Wenyi Xie <xiewenyi2@huawei.com>
> > > ---
> > >  CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyCommon.c | 2 --
> > >  1 file changed, 2 deletions(-)
> > >
> > > diff --git
> > a/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyCommon.c
> > > b/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyCommon.c
> > > index 3336d2f60a6a..f8028181e47f 100644
> > > --- a/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyCommon.c
> > > +++ b/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyCommon.c
> > > @@ -502,8 +502,6 @@ Pkcs7GetCertificatesList (
> > >    OldBuf       = NULL;
> > >    Signers      = NULL;
> > >
> > > -  ZeroMem (&CertCtx, sizeof (CertCtx));
> > > -
> > >    //
> > >    // Parameter Checking
> > >    //
> > > --
> > > 2.20.1.windows.1
> >
> >
> >
> >
> >
> 
> 
> 
> 
> 


^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [edk2-devel] EDKII CI Failure
  2022-09-20 23:36       ` Michael D Kinney
@ 2022-09-21  0:01         ` Sean
  2022-09-21  0:09           ` Yao, Jiewen
  0 siblings, 1 reply; 10+ messages in thread
From: Sean @ 2022-09-21  0:01 UTC (permalink / raw)
  To: devel, michael.d.kinney, Yao, Jiewen, Kubacki, Michael,
	Sean Brogan

Looking at it.

The vm image for VS2019 did change between working and failing build.

Will update once we figure something out.


Thanks

Sean


On 9/20/2022 4:36 PM, Michael D Kinney wrote:
> Hi Jiewen,
>
> Looks like it is not limited to that one PR.
>
> I see this PR has similar failure.  The artifacts show a more detailed log
> with nmake.exe not found.  That does not make sense for a windows/VS2019
> build after vswhere is used to find path to VS2019 tools.  Perhaps Michael
> or Sean can help evaluate.  Maybe there was a change in the Windows agent
> profile or the VS2019 tools profile.
>
> 	https://github.com/tianocore/edk2/pull/3354
>
> 	https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=62007&view=logs&jobId=4a97f94c-8e1f-5e76-68ba-50872604dd63&j=898a5c7a-7a49-5be1-c417-92a6761a8039
>
> INFO - Log Started: Tuesday, September 20, 2022 02:49PM
> SECTION - Init SDE
> DEBUG - --- self_describing_environment.__init__()
> DEBUG - Skipped directories specified = ()
> DEBUG - --- self_describing_environment.load_workspace()
> DEBUG - Loading workspace: D:\a\1\s\BaseTools
> DEBUG -   Including scopes: global
> DEBUG - --- self_describing_environment._gather_env_files()
> DEBUG - Adding descriptor D:\a\1\s\BaseTools\basetools_calling_path_env.yaml to the environment with scope global
> DEBUG - Adding descriptor D:\a\1\s\BaseTools\basetools_path_env.yaml to the environment with scope global
> DEBUG - Adding descriptor D:\a\1\s\BaseTools\Source\Python\basetool_tiano_python_path_env.yaml to the environment with scope global
> DEBUG - Adding descriptor D:\a\1\s\BaseTools\Plugin\BuildToolsReport\BuildToolsReportGenerator_plug_in.yaml to the environment with scope global
> DEBUG - --- self_describing_environment.update_simple_paths()
> DEBUG - --- self_describing_environment.update_extdep_paths()
> DEBUG - --- self_describing_environment.report_extdep_version()
> SECTION - Loading Plugins
> DEBUG - Loading Plugin from D:\a\1\s\BaseTools\Plugin\BuildToolsReport\BuildToolsReportGenerator.py
> SECTION - Start Invocable Tool
> INFO - Running Python version: sys.version_info(major=3, minor=10, micro=7, releaselevel='final', serial=0)
> INFO - Cmd to run is: c:\hostedtoolcache\windows\python\3.10.7\x64\lib\site-packages\edk2toollib\bin\vswhere.exe -latest -nologo -all -property installationPath -products * -version 16.0,17.0
> INFO - ------------------------------------------------
> INFO - --------------Cmd Output Starting---------------
> INFO - ------------------------------------------------
> INFO - C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise
> INFO - ------------------------------------------------
> INFO - --------------Cmd Output Finished---------------
> INFO - --------- Running Time (mm:ss): 00:00 ----------
> INFO - ----------- Return Code: 0x00000000 ------------
> INFO - ------------------------------------------------
> DEBUG - Calling 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Auxiliary\Build\vcvarsall.bat x86'
> DEBUG - Var - ExtensionSdkDir = C:\Program Files (x86)\Microsoft SDKs\Windows Kits\10\ExtensionSDKs
> DEBUG - Var - INCLUDE = C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\ATLMFC\include;C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\include;C:\Program Files (x86)\Windows Kits\NETFXSDK\4.8\include\um;C:\Program Files (x86)\Windows Kits\10\include\10.0.22621.0\ucrt;C:\Program Files (x86)\Windows Kits\10\include\10.0.22621.0\shared;C:\Program Files (x86)\Windows Kits\10\include\10.0.22621.0\um;C:\Program Files (x86)\Windows Kits\10\include\10.0.22621.0\winrt;C:\Program Files (x86)\Windows Kits\10\include\10.0.22621.0\cppwinrt
> DEBUG - Var - LIB = C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\ATLMFC\lib\x86;C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\lib\x86;C:\Program Files (x86)\Windows Kits\NETFXSDK\4.8\lib\um\x86;C:\Program Files (x86)\Windows Kits\10\lib\10.0.22621.0\ucrt\x86;C:\Program Files (x86)\Windows Kits\10\lib\10.0.22621.0\um\x86
> DEBUG - Var - LIBPATH = C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\ATLMFC\lib\x86;C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\lib\x86;C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\lib\x86\store\references;C:\Program Files (x86)\Windows Kits\10\UnionMetadata\10.0.22621.0;C:\Program Files (x86)\Windows Kits\10\References\10.0.22621.0;C:\Windows\Microsoft.NET\Framework\v4.0.30319
> DEBUG - Var - Path = C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\Common7\IDE\\Extensions\Microsoft\IntelliCode\CLI;C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\bin\HostX86\x86;C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\Common7\IDE\VC\VCPackages;C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\Common7\IDE\CommonExtensions\Microsoft\TestWindow;C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\Common7\IDE\CommonExtensions\Microsoft\TeamFoundation\Team Explorer;C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Current\bin\Roslyn;C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\Team Tools\Performance Tools;C:\Program Files (x86)\Microsoft Visual Studio\Shared\Common\VSPerfCollectionTools\vs2019\;C:\Program Files (x86)\Microsoft SDKs\Windows\v10.0A\bin\NETFX 4.8 Tools\;C:\Program Files (x86)\HTML Help Workshop;C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\Common7\IDE\CommonExtensions\Microsoft\FSharp\Tools;C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\Common7\Tools\devinit;C:\Program Files (x86)\Windows Kits\10\bin\10.0.22621.0\x86;C:\Program Files (x86)\Windows Kits\10\bin\x86;C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\\MSBuild\Current\Bin;C:\Windows\Microsoft.NET\Framework\v4.0.30319;C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\Common7\IDE\;C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\Common7\Tools\;C:\hostedtoolcache\windows\node\14.20.0\x64;C:\Users\VssAdministrator\AppData\Roaming\Python\Python310\Scripts;C:\hostedtoolcache\windows\Python\3.10.7\x64\Scripts;C:\hostedtoolcache\windows\Python\3.10.7\x64;C:\agents\2.210.1\externals\git\cmd;C:\agents\2.210.1\externals\git\mingw64\bin;C:\Program Files\MongoDB\Server\5.0\bin;C:\aliyun-cli;C:\vcpkg;C:\cf-cli;C:\Program Files (x86)\NSIS\;C:\tools\zstd;C:\Program Files\Mercurial\;C:\hostedtoolcache\windows\stack\2.7.5\x64;C:\cabal\bin;C:\\ghcup\bin;C:\tools\ghc-9.4.2\bin;C:\Program Files\dotnet;C:\mysql\bin;C:\Program Files\R\R-4.2.1\bin\x64;C:\SeleniumWebDrivers\GeckoDriver;C:\Program Files (x86)\sbt\bin;C:\Program Files (x86)\GitHub CLI;C:\Program Files\Git\bin;C:\Program Files (x86)\pipx_bin;C:\npm\prefix;C:\hostedtoolcache\windows\go\1.17.13\x64\bin;C:\hostedtoolcache\windows\Python\3.7.9\x64\Scripts;C:\hostedtoolcache\windows\Python\3.7.9\x64;C:\hostedtoolcache\windows\Ruby\2.5.9\x64\bin;C:\tools\kotlinc\bin;C:\hostedtoolcache\windows\Java_Temurin-Hotspot_jdk\8.0.345-1\x64\bin;C:\Program Files\ImageMagick-7.1.0-Q16-HDRI;C:\Program Files (x86)\Microsoft SDKs\Azure\CLI2\wbin;C:\ProgramData\kind;C:\Program Files\Eclipse Foundation\jdk-8.0.302.8-hotspot\bin;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0\;C:\Windows\System32\OpenSSH\;C:\ProgramData\Chocolatey\bin;C:\Program Files\PowerShell\7\;C:\Program Files\Microsoft\Web Platform Installer\;C:\Program Files\dotnet\;C:\Program Files\Microsoft SQL Server\130\Tools\Binn\;C:\Program Files\Microsoft SQL Server\Client SDK\ODBC\170\Tools\Binn\;C:\Program Files (x86)\Windows Kits\10\Windows Performance Toolkit\;C:\Program Files (x86)\Microsoft SQL Server\110\DTS\Binn\;C:\Program Files (x86)\Microsoft SQL Server\120\DTS\Binn\;C:\Program Files (x86)\Microsoft SQL Server\130\DTS\Binn\;C:\Program Files (x86)\Microsoft SQL Server\140\DTS\Binn\;C:\Program Files (x86)\Microsoft SQL Server\150\DTS\Binn\;C:\Program Files (x86)\Microsoft SQL Server\160\DTS\Binn\;C:\Program Files\OpenSSL\bin;C:\Strawberry\c\bin;C:\Strawberry\perl\site\bin;C:\Strawberry\perl\bin;C:\ProgramData\chocolatey\lib\pulumi\tools\Pulumi\bin;C:\Program Files\TortoiseSVN\bin;C:\Program Files\CMake\bin;C:\ProgramData\chocolatey\lib\maven\apache-maven-3.8.6\bin;C:\Program Files\Microsoft Service Fabric\bin\Fabric\Fabric.Code;C:\Program Files\Microsoft SDKs\Service Fabric\Tools\ServiceFabricLocalClusterManager;C:\Program Files\nodejs\;C:\Program Files\Git\cmd;C:\Program Files\Git\mingw64\bin;C:\Program Files\Git\usr\bin;C:\Program Files\GitHub CLI\;c:\tools\php;C:\Program Files (x86)\sbt\bin;C:\SeleniumWebDrivers\ChromeDriver\;C:\SeleniumWebDrivers\EdgeDriver\;C:\Program Files\Amazon\AWSCLIV2\;C:\Program Files\Amazon\SessionManagerPlugin\bin\;C:\Program Files\Amazon\AWSSAMCLI\bin\;C:\Program Files (x86)\Google\Cloud SDK\google-cloud-sdk\bin;C:\Program Files (x86)\Microsoft BizTalk Server\;C:\Program Files\LLVM\bin;C:\Users\VssAdministrator\.dotnet\tools;C:\Users\VssAdministrator\.cargo\bin;C:\Users\VssAdministrator\AppData\Local\Microsoft\WindowsApps;C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\Llvm\bin;C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\Common7\IDE\CommonExtensions\Microsoft\CMake\CMake\bin;C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\Common7\IDE\CommonExtensions\Microsoft\CMake\Ninja;C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\Common7\IDE\VC\Linux\bin\ConnectionManagerExe
> DEBUG - Var - UCRTVersion = 10.0.22621.0
> DEBUG - Var - UniversalCRTSdkDir = C:\Program Files (x86)\Windows Kits\10\
> DEBUG - Var - VCToolsInstallDir = C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\
> DEBUG - Var - WindowsLibPath = C:\Program Files (x86)\Windows Kits\10\UnionMetadata\10.0.22621.0;C:\Program Files (x86)\Windows Kits\10\References\10.0.22621.0
> DEBUG - Var - WindowsSdkBinPath = C:\Program Files (x86)\Windows Kits\10\bin\
> DEBUG - Var - WindowsSdkDir = C:\Program Files (x86)\Windows Kits\10\
> DEBUG - Var - WindowsSdkVerBinPath = C:\Program Files (x86)\Windows Kits\10\bin\10.0.22621.0\
> DEBUG - Var - WindowsSDKVersion = 10.0.22621.0\
> INFO - Cmd to run is: nmake.exe
> INFO - ------------------------------------------------
> INFO - --------------Cmd Output Starting---------------
> INFO - ------------------------------------------------
> INFO - 'nmake.exe' is not recognized as an internal or external command,
> INFO - operable program or batch file.
> INFO - ------------------------------------------------
> INFO - --------------Cmd Output Finished---------------
> INFO - --------- Running Time (mm:ss): 00:00 ----------
> INFO - ----------- Return Code: 0x00000001 ------------
> INFO - ------------------------------------------------
>
>
> Mike
>
>> -----Original Message-----
>> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Yao, Jiewen
>> Sent: Tuesday, September 20, 2022 4:06 PM
>> To: devel@edk2.groups.io
>> Subject: [edk2-devel] EDKII CI Failure
>>
>> Hi
>> I notice that EDKII CI failed on step "Build Base Tools from source" for https://github.com/DMTF/libspdm/pull/1218
>>
>> https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=62090&view=logs&j=c0929384-5a08-5c0f-b36d-
>> 6f51b6b81732&t=dc6c8514-4845-5cff-3ead-20e6776e3d52
>>
>>
>> Anyone knows what is happening on the CI?
>>
>> Thank you
>> Yao Jiewen
>>
>>
>>> -----Original Message-----
>>> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Yao,
>>> Jiewen
>>> Sent: Wednesday, September 21, 2022 7:03 AM
>>> To: Wenyi Xie <xiewenyi2@huawei.com>; devel@edk2.groups.io; Wang,
>>> Jian J <jian.j.wang@intel.com>; Lu, Xiaoyu1 <xiaoyu1.lu@intel.com>; Jiang,
>>> Guomin <guomin.jiang@intel.com>
>>> Cc: songdongkuang@huawei.com
>>> Subject: Re: [edk2-devel] [PATCH EDK2 v1 1/1]
>>> CryptoPkg/BaseCryptLib:Remove redundant init
>>>
>>> Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>
>>>
>>>
>>>> -----Original Message-----
>>>> From: Wenyi Xie <xiewenyi2@huawei.com>
>>>> Sent: Thursday, September 15, 2022 5:26 PM
>>>> To: devel@edk2.groups.io; Yao, Jiewen <jiewen.yao@intel.com>; Wang,
>>> Jian
>>>> J <jian.j.wang@intel.com>; Lu, Xiaoyu1 <xiaoyu1.lu@intel.com>; Jiang,
>>>> Guomin <guomin.jiang@intel.com>
>>>> Cc: songdongkuang@huawei.com; xiewenyi2@huawei.com
>>>> Subject: [PATCH EDK2 v1 1/1] CryptoPkg/BaseCryptLib:Remove
>>> redundant
>>>> init
>>>>
>>>> CertCtx is used to be defined as a struct and ZeroMem is called to
>>>> init this struct. But now CertCtx is defined as a point, so use
>>>> ZeroMem (&CertCtx, sizeof (CertCtx)) is not correct any more.
>>>>
>>>> Cc: Jiewen Yao <jiewen.yao@intel.com>
>>>> Cc: Jian J Wang <jian.j.wang@intel.com>
>>>> Cc: Xiaoyu Lu <xiaoyu1.lu@intel.com>
>>>> Cc: Guomin Jiang <guomin.jiang@intel.com>
>>>> Signed-off-by: Wenyi Xie <xiewenyi2@huawei.com>
>>>> ---
>>>>   CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyCommon.c | 2 --
>>>>   1 file changed, 2 deletions(-)
>>>>
>>>> diff --git
>>> a/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyCommon.c
>>>> b/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyCommon.c
>>>> index 3336d2f60a6a..f8028181e47f 100644
>>>> --- a/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyCommon.c
>>>> +++ b/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyCommon.c
>>>> @@ -502,8 +502,6 @@ Pkcs7GetCertificatesList (
>>>>     OldBuf       = NULL;
>>>>     Signers      = NULL;
>>>>
>>>> -  ZeroMem (&CertCtx, sizeof (CertCtx));
>>>> -
>>>>     //
>>>>     // Parameter Checking
>>>>     //
>>>> --
>>>> 2.20.1.windows.1
>>>
>>>
>>>
>>>
>>
>>
>>
>>
>
>
> 
>
>

^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [edk2-devel] EDKII CI Failure
  2022-09-21  0:01         ` Sean
@ 2022-09-21  0:09           ` Yao, Jiewen
  2022-09-22  0:21             ` Sean
  0 siblings, 1 reply; 10+ messages in thread
From: Yao, Jiewen @ 2022-09-21  0:09 UTC (permalink / raw)
  To: devel@edk2.groups.io, spbrogan@outlook.com, Kinney, Michael D,
	Kubacki, Michael, Sean Brogan

Thank you Sean and Mike!

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Sean
> Sent: Wednesday, September 21, 2022 8:01 AM
> To: devel@edk2.groups.io; Kinney, Michael D
> <michael.d.kinney@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>;
> Kubacki, Michael <michael.kubacki@microsoft.com>; Sean Brogan
> <sean.brogan@microsoft.com>
> Subject: Re: [edk2-devel] EDKII CI Failure
> 
> Looking at it.
> 
> The vm image for VS2019 did change between working and failing build.
> 
> Will update once we figure something out.
> 
> 
> Thanks
> 
> Sean
> 
> 
> On 9/20/2022 4:36 PM, Michael D Kinney wrote:
> > Hi Jiewen,
> >
> > Looks like it is not limited to that one PR.
> >
> > I see this PR has similar failure.  The artifacts show a more detailed log
> > with nmake.exe not found.  That does not make sense for a
> windows/VS2019
> > build after vswhere is used to find path to VS2019 tools.  Perhaps Michael
> > or Sean can help evaluate.  Maybe there was a change in the Windows
> agent
> > profile or the VS2019 tools profile.
> >
> > 	https://github.com/tianocore/edk2/pull/3354
> >
> > 	https://dev.azure.com/tianocore/edk2-
> ci/_build/results?buildId=62007&view=logs&jobId=4a97f94c-8e1f-5e76-
> 68ba-50872604dd63&j=898a5c7a-7a49-5be1-c417-92a6761a8039
> >
> > INFO - Log Started: Tuesday, September 20, 2022 02:49PM
> > SECTION - Init SDE
> > DEBUG - --- self_describing_environment.__init__()
> > DEBUG - Skipped directories specified = ()
> > DEBUG - --- self_describing_environment.load_workspace()
> > DEBUG - Loading workspace: D:\a\1\s\BaseTools
> > DEBUG -   Including scopes: global
> > DEBUG - --- self_describing_environment._gather_env_files()
> > DEBUG - Adding descriptor
> D:\a\1\s\BaseTools\basetools_calling_path_env.yaml to the environment
> with scope global
> > DEBUG - Adding descriptor D:\a\1\s\BaseTools\basetools_path_env.yaml
> to the environment with scope global
> > DEBUG - Adding descriptor
> D:\a\1\s\BaseTools\Source\Python\basetool_tiano_python_path_env.yam
> l to the environment with scope global
> > DEBUG - Adding descriptor
> D:\a\1\s\BaseTools\Plugin\BuildToolsReport\BuildToolsReportGenerator_p
> lug_in.yaml to the environment with scope global
> > DEBUG - --- self_describing_environment.update_simple_paths()
> > DEBUG - --- self_describing_environment.update_extdep_paths()
> > DEBUG - --- self_describing_environment.report_extdep_version()
> > SECTION - Loading Plugins
> > DEBUG - Loading Plugin from
> D:\a\1\s\BaseTools\Plugin\BuildToolsReport\BuildToolsReportGenerator.p
> y
> > SECTION - Start Invocable Tool
> > INFO - Running Python version: sys.version_info(major=3, minor=10,
> micro=7, releaselevel='final', serial=0)
> > INFO - Cmd to run is:
> c:\hostedtoolcache\windows\python\3.10.7\x64\lib\site-
> packages\edk2toollib\bin\vswhere.exe -latest -nologo -all -property
> installationPath -products * -version 16.0,17.0
> > INFO - ------------------------------------------------
> > INFO - --------------Cmd Output Starting---------------
> > INFO - ------------------------------------------------
> > INFO - C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise
> > INFO - ------------------------------------------------
> > INFO - --------------Cmd Output Finished---------------
> > INFO - --------- Running Time (mm:ss): 00:00 ----------
> > INFO - ----------- Return Code: 0x00000000 ------------
> > INFO - ------------------------------------------------
> > DEBUG - Calling 'C:\Program Files (x86)\Microsoft Visual
> Studio\2019\Enterprise\VC\Auxiliary\Build\vcvarsall.bat x86'
> > DEBUG - Var - ExtensionSdkDir = C:\Program Files (x86)\Microsoft
> SDKs\Windows Kits\10\ExtensionSDKs
> > DEBUG - Var - INCLUDE = C:\Program Files (x86)\Microsoft Visual
> Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\ATLMFC\include;C:\
> Program Files (x86)\Microsoft Visual
> Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\include;C:\Program
> Files (x86)\Windows Kits\NETFXSDK\4.8\include\um;C:\Program Files
> (x86)\Windows Kits\10\include\10.0.22621.0\ucrt;C:\Program Files
> (x86)\Windows Kits\10\include\10.0.22621.0\shared;C:\Program Files
> (x86)\Windows Kits\10\include\10.0.22621.0\um;C:\Program Files
> (x86)\Windows Kits\10\include\10.0.22621.0\winrt;C:\Program Files
> (x86)\Windows Kits\10\include\10.0.22621.0\cppwinrt
> > DEBUG - Var - LIB = C:\Program Files (x86)\Microsoft Visual
> Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\ATLMFC\lib\x86;C:\
> Program Files (x86)\Microsoft Visual
> Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\lib\x86;C:\Program
> Files (x86)\Windows Kits\NETFXSDK\4.8\lib\um\x86;C:\Program Files
> (x86)\Windows Kits\10\lib\10.0.22621.0\ucrt\x86;C:\Program Files
> (x86)\Windows Kits\10\lib\10.0.22621.0\um\x86
> > DEBUG - Var - LIBPATH = C:\Program Files (x86)\Microsoft Visual
> Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\ATLMFC\lib\x86;C:\
> Program Files (x86)\Microsoft Visual
> Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\lib\x86;C:\Program
> Files (x86)\Microsoft Visual
> Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\lib\x86\store\refere
> nces;C:\Program Files (x86)\Windows
> Kits\10\UnionMetadata\10.0.22621.0;C:\Program Files (x86)\Windows
> Kits\10\References\10.0.22621.0;C:\Windows\Microsoft.NET\Framework\
> v4.0.30319
> > DEBUG - Var - Path = C:\Program Files (x86)\Microsoft Visual
> Studio\2019\Enterprise\Common7\IDE\\Extensions\Microsoft\IntelliCode\
> CLI;C:\Program Files (x86)\Microsoft Visual
> Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\bin\HostX86\x86;C:
> \Program Files (x86)\Microsoft Visual
> Studio\2019\Enterprise\Common7\IDE\VC\VCPackages;C:\Program Files
> (x86)\Microsoft Visual
> Studio\2019\Enterprise\Common7\IDE\CommonExtensions\Microsoft\Tes
> tWindow;C:\Program Files (x86)\Microsoft Visual
> Studio\2019\Enterprise\Common7\IDE\CommonExtensions\Microsoft\Tea
> mFoundation\Team Explorer;C:\Program Files (x86)\Microsoft Visual
> Studio\2019\Enterprise\MSBuild\Current\bin\Roslyn;C:\Program Files
> (x86)\Microsoft Visual Studio\2019\Enterprise\Team Tools\Performance
> Tools;C:\Program Files (x86)\Microsoft Visual
> Studio\Shared\Common\VSPerfCollectionTools\vs2019\;C:\Program Files
> (x86)\Microsoft SDKs\Windows\v10.0A\bin\NETFX 4.8 Tools\;C:\Program
> Files (x86)\HTML Help Workshop;C:\Program Files (x86)\Microsoft Visual
> Studio\2019\Enterprise\Common7\IDE\CommonExtensions\Microsoft\FSh
> arp\Tools;C:\Program Files (x86)\Microsoft Visual
> Studio\2019\Enterprise\Common7\Tools\devinit;C:\Program Files
> (x86)\Windows Kits\10\bin\10.0.22621.0\x86;C:\Program Files
> (x86)\Windows Kits\10\bin\x86;C:\Program Files (x86)\Microsoft Visual
> Studio\2019\Enterprise\\MSBuild\Current\Bin;C:\Windows\Microsoft.NET
> \Framework\v4.0.30319;C:\Program Files (x86)\Microsoft Visual
> Studio\2019\Enterprise\Common7\IDE\;C:\Program Files (x86)\Microsoft
> Visual
> Studio\2019\Enterprise\Common7\Tools\;C:\hostedtoolcache\windows\n
> ode\14.20.0\x64;C:\Users\VssAdministrator\AppData\Roaming\Python\Py
> thon310\Scripts;C:\hostedtoolcache\windows\Python\3.10.7\x64\Scripts;
> C:\hostedtoolcache\windows\Python\3.10.7\x64;C:\agents\2.210.1\extern
> als\git\cmd;C:\agents\2.210.1\externals\git\mingw64\bin;C:\Program
> Files\MongoDB\Server\5.0\bin;C:\aliyun-cli;C:\vcpkg;C:\cf-cli;C:\Program
> Files (x86)\NSIS\;C:\tools\zstd;C:\Program
> Files\Mercurial\;C:\hostedtoolcache\windows\stack\2.7.5\x64;C:\cabal\bi
> n;C:\\ghcup\bin;C:\tools\ghc-9.4.2\bin;C:\Program
> Files\dotnet;C:\mysql\bin;C:\Program Files\R\R-
> 4.2.1\bin\x64;C:\SeleniumWebDrivers\GeckoDriver;C:\Program Files
> (x86)\sbt\bin;C:\Program Files (x86)\GitHub CLI;C:\Program
> Files\Git\bin;C:\Program Files
> (x86)\pipx_bin;C:\npm\prefix;C:\hostedtoolcache\windows\go\1.17.13\x6
> 4\bin;C:\hostedtoolcache\windows\Python\3.7.9\x64\Scripts;C:\hostedto
> olcache\windows\Python\3.7.9\x64;C:\hostedtoolcache\windows\Ruby\2.
> 5.9\x64\bin;C:\tools\kotlinc\bin;C:\hostedtoolcache\windows\Java_Temur
> in-Hotspot_jdk\8.0.345-1\x64\bin;C:\Program Files\ImageMagick-7.1.0-
> Q16-HDRI;C:\Program Files (x86)\Microsoft
> SDKs\Azure\CLI2\wbin;C:\ProgramData\kind;C:\Program Files\Eclipse
> Foundation\jdk-8.0.302.8-
> hotspot\bin;C:\Windows\system32;C:\Windows;C:\Windows\System32\
> Wbem;C:\Windows\System32\WindowsPowerShell\v1.0\;C:\Windows\Sys
> tem32\OpenSSH\;C:\ProgramData\Chocolatey\bin;C:\Program
> Files\PowerShell\7\;C:\Program Files\Microsoft\Web Platform
> Installer\;C:\Program Files\dotnet\;C:\Program Files\Microsoft SQL
> Server\130\Tools\Binn\;C:\Program Files\Microsoft SQL Server\Client
> SDK\ODBC\170\Tools\Binn\;C:\Program Files (x86)\Windows
> Kits\10\Windows Performance Toolkit\;C:\Program Files (x86)\Microsoft
> SQL Server\110\DTS\Binn\;C:\Program Files (x86)\Microsoft SQL
> Server\120\DTS\Binn\;C:\Program Files (x86)\Microsoft SQL
> Server\130\DTS\Binn\;C:\Program Files (x86)\Microsoft SQL
> Server\140\DTS\Binn\;C:\Program Files (x86)\Microsoft SQL
> Server\150\DTS\Binn\;C:\Program Files (x86)\Microsoft SQL
> Server\160\DTS\Binn\;C:\Program
> Files\OpenSSL\bin;C:\Strawberry\c\bin;C:\Strawberry\perl\site\bin;C:\Stra
> wberry\perl\bin;C:\ProgramData\chocolatey\lib\pulumi\tools\Pulumi\bin;
> C:\Program Files\TortoiseSVN\bin;C:\Program
> Files\CMake\bin;C:\ProgramData\chocolatey\lib\maven\apache-maven-
> 3.8.6\bin;C:\Program Files\Microsoft Service
> Fabric\bin\Fabric\Fabric.Code;C:\Program Files\Microsoft SDKs\Service
> Fabric\Tools\ServiceFabricLocalClusterManager;C:\Program
> Files\nodejs\;C:\Program Files\Git\cmd;C:\Program
> Files\Git\mingw64\bin;C:\Program Files\Git\usr\bin;C:\Program
> Files\GitHub CLI\;c:\tools\php;C:\Program Files
> (x86)\sbt\bin;C:\SeleniumWebDrivers\ChromeDriver\;C:\SeleniumWebDriv
> ers\EdgeDriver\;C:\Program Files\Amazon\AWSCLIV2\;C:\Program
> Files\Amazon\SessionManagerPlugin\bin\;C:\Program
> Files\Amazon\AWSSAMCLI\bin\;C:\Program Files (x86)\Google\Cloud
> SDK\google-cloud-sdk\bin;C:\Program Files (x86)\Microsoft BizTalk
> Server\;C:\Program
> Files\LLVM\bin;C:\Users\VssAdministrator\.dotnet\tools;C:\Users\VssAdm
> inistrator\.cargo\bin;C:\Users\VssAdministrator\AppData\Local\Microsoft\
> WindowsApps;C:\Program Files (x86)\Microsoft Visual
> Studio\2019\Enterprise\VC\Tools\Llvm\bin;C:\Program Files
> (x86)\Microsoft Visual
> Studio\2019\Enterprise\Common7\IDE\CommonExtensions\Microsoft\CM
> ake\CMake\bin;C:\Program Files (x86)\Microsoft Visual
> Studio\2019\Enterprise\Common7\IDE\CommonExtensions\Microsoft\CM
> ake\Ninja;C:\Program Files (x86)\Microsoft Visual
> Studio\2019\Enterprise\Common7\IDE\VC\Linux\bin\ConnectionManagerE
> xe
> > DEBUG - Var - UCRTVersion = 10.0.22621.0
> > DEBUG - Var - UniversalCRTSdkDir = C:\Program Files (x86)\Windows
> Kits\10\
> > DEBUG - Var - VCToolsInstallDir = C:\Program Files (x86)\Microsoft Visual
> Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\
> > DEBUG - Var - WindowsLibPath = C:\Program Files (x86)\Windows
> Kits\10\UnionMetadata\10.0.22621.0;C:\Program Files (x86)\Windows
> Kits\10\References\10.0.22621.0
> > DEBUG - Var - WindowsSdkBinPath = C:\Program Files (x86)\Windows
> Kits\10\bin\
> > DEBUG - Var - WindowsSdkDir = C:\Program Files (x86)\Windows Kits\10\
> > DEBUG - Var - WindowsSdkVerBinPath = C:\Program Files (x86)\Windows
> Kits\10\bin\10.0.22621.0\
> > DEBUG - Var - WindowsSDKVersion = 10.0.22621.0\
> > INFO - Cmd to run is: nmake.exe
> > INFO - ------------------------------------------------
> > INFO - --------------Cmd Output Starting---------------
> > INFO - ------------------------------------------------
> > INFO - 'nmake.exe' is not recognized as an internal or external command,
> > INFO - operable program or batch file.
> > INFO - ------------------------------------------------
> > INFO - --------------Cmd Output Finished---------------
> > INFO - --------- Running Time (mm:ss): 00:00 ----------
> > INFO - ----------- Return Code: 0x00000001 ------------
> > INFO - ------------------------------------------------
> >
> >
> > Mike
> >
> >> -----Original Message-----
> >> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Yao,
> Jiewen
> >> Sent: Tuesday, September 20, 2022 4:06 PM
> >> To: devel@edk2.groups.io
> >> Subject: [edk2-devel] EDKII CI Failure
> >>
> >> Hi
> >> I notice that EDKII CI failed on step "Build Base Tools from source" for
> https://github.com/DMTF/libspdm/pull/1218
> >>
> >> https://dev.azure.com/tianocore/edk2-
> ci/_build/results?buildId=62090&view=logs&j=c0929384-5a08-5c0f-b36d-
> >> 6f51b6b81732&t=dc6c8514-4845-5cff-3ead-20e6776e3d52
> >>
> >>
> >> Anyone knows what is happening on the CI?
> >>
> >> Thank you
> >> Yao Jiewen
> >>
> >>
> >>> -----Original Message-----
> >>> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Yao,
> >>> Jiewen
> >>> Sent: Wednesday, September 21, 2022 7:03 AM
> >>> To: Wenyi Xie <xiewenyi2@huawei.com>; devel@edk2.groups.io; Wang,
> >>> Jian J <jian.j.wang@intel.com>; Lu, Xiaoyu1 <xiaoyu1.lu@intel.com>;
> Jiang,
> >>> Guomin <guomin.jiang@intel.com>
> >>> Cc: songdongkuang@huawei.com
> >>> Subject: Re: [edk2-devel] [PATCH EDK2 v1 1/1]
> >>> CryptoPkg/BaseCryptLib:Remove redundant init
> >>>
> >>> Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>
> >>>
> >>>
> >>>> -----Original Message-----
> >>>> From: Wenyi Xie <xiewenyi2@huawei.com>
> >>>> Sent: Thursday, September 15, 2022 5:26 PM
> >>>> To: devel@edk2.groups.io; Yao, Jiewen <jiewen.yao@intel.com>;
> Wang,
> >>> Jian
> >>>> J <jian.j.wang@intel.com>; Lu, Xiaoyu1 <xiaoyu1.lu@intel.com>; Jiang,
> >>>> Guomin <guomin.jiang@intel.com>
> >>>> Cc: songdongkuang@huawei.com; xiewenyi2@huawei.com
> >>>> Subject: [PATCH EDK2 v1 1/1] CryptoPkg/BaseCryptLib:Remove
> >>> redundant
> >>>> init
> >>>>
> >>>> CertCtx is used to be defined as a struct and ZeroMem is called to
> >>>> init this struct. But now CertCtx is defined as a point, so use
> >>>> ZeroMem (&CertCtx, sizeof (CertCtx)) is not correct any more.
> >>>>
> >>>> Cc: Jiewen Yao <jiewen.yao@intel.com>
> >>>> Cc: Jian J Wang <jian.j.wang@intel.com>
> >>>> Cc: Xiaoyu Lu <xiaoyu1.lu@intel.com>
> >>>> Cc: Guomin Jiang <guomin.jiang@intel.com>
> >>>> Signed-off-by: Wenyi Xie <xiewenyi2@huawei.com>
> >>>> ---
> >>>>   CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyCommon.c | 2
> --
> >>>>   1 file changed, 2 deletions(-)
> >>>>
> >>>> diff --git
> >>> a/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyCommon.c
> >>>> b/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyCommon.c
> >>>> index 3336d2f60a6a..f8028181e47f 100644
> >>>> --- a/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyCommon.c
> >>>> +++
> b/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyCommon.c
> >>>> @@ -502,8 +502,6 @@ Pkcs7GetCertificatesList (
> >>>>     OldBuf       = NULL;
> >>>>     Signers      = NULL;
> >>>>
> >>>> -  ZeroMem (&CertCtx, sizeof (CertCtx));
> >>>> -
> >>>>     //
> >>>>     // Parameter Checking
> >>>>     //
> >>>> --
> >>>> 2.20.1.windows.1
> >>>
> >>>
> >>>
> >>>
> >>
> >>
> >>
> >>
> >
> >
> >
> >
> >
> 
> 
> 
> 


^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [edk2-devel] EDKII CI Failure
  2022-09-21  0:09           ` Yao, Jiewen
@ 2022-09-22  0:21             ` Sean
  0 siblings, 0 replies; 10+ messages in thread
From: Sean @ 2022-09-22  0:21 UTC (permalink / raw)
  To: Yao, Jiewen, devel@edk2.groups.io, Kinney, Michael D,
	Kubacki, Michael, Sean Brogan

[-- Attachment #1: Type: text/plain, Size: 15543 bytes --]

BaseTools: Edk2ToolsBuild: Fixing pipeline build due to path too long by 
kuqin12 · Pull Request #3371 · tianocore/edk2 (github.com) 
<https://github.com/tianocore/edk2/pull/3371>


[PATCH v1 0/1] Fixing BaseTool build break (groups.io) 
<https://edk2.groups.io/g/devel/message/94087>


Needs to be reviewed by Basetools maintainers and the push tag added.


Thanks

Sean



On 9/20/2022 5:09 PM, Yao, Jiewen wrote:
> Thank you Sean and Mike!
>
>> -----Original Message-----
>> From:devel@edk2.groups.io  <devel@edk2.groups.io>  On Behalf Of Sean
>> Sent: Wednesday, September 21, 2022 8:01 AM
>> To:devel@edk2.groups.io; Kinney, Michael D
>> <michael.d.kinney@intel.com>; Yao, Jiewen<jiewen.yao@intel.com>;
>> Kubacki, Michael<michael.kubacki@microsoft.com>; Sean Brogan
>> <sean.brogan@microsoft.com>
>> Subject: Re: [edk2-devel] EDKII CI Failure
>>
>> Looking at it.
>>
>> The vm image for VS2019 did change between working and failing build.
>>
>> Will update once we figure something out.
>>
>>
>> Thanks
>>
>> Sean
>>
>>
>> On 9/20/2022 4:36 PM, Michael D Kinney wrote:
>>> Hi Jiewen,
>>>
>>> Looks like it is not limited to that one PR.
>>>
>>> I see this PR has similar failure.  The artifacts show a more detailed log
>>> with nmake.exe not found.  That does not make sense for a
>> windows/VS2019
>>> build after vswhere is used to find path to VS2019 tools.  Perhaps Michael
>>> or Sean can help evaluate.  Maybe there was a change in the Windows
>> agent
>>> profile or the VS2019 tools profile.
>>>
>>> 	https://github.com/tianocore/edk2/pull/3354
>>>
>>> 	https://dev.azure.com/tianocore/edk2-
>> ci/_build/results?buildId=62007&view=logs&jobId=4a97f94c-8e1f-5e76-
>> 68ba-50872604dd63&j=898a5c7a-7a49-5be1-c417-92a6761a8039
>>> INFO - Log Started: Tuesday, September 20, 2022 02:49PM
>>> SECTION - Init SDE
>>> DEBUG - --- self_describing_environment.__init__()
>>> DEBUG - Skipped directories specified = ()
>>> DEBUG - --- self_describing_environment.load_workspace()
>>> DEBUG - Loading workspace: D:\a\1\s\BaseTools
>>> DEBUG -   Including scopes: global
>>> DEBUG - --- self_describing_environment._gather_env_files()
>>> DEBUG - Adding descriptor
>> D:\a\1\s\BaseTools\basetools_calling_path_env.yaml to the environment
>> with scope global
>>> DEBUG - Adding descriptor D:\a\1\s\BaseTools\basetools_path_env.yaml
>> to the environment with scope global
>>> DEBUG - Adding descriptor
>> D:\a\1\s\BaseTools\Source\Python\basetool_tiano_python_path_env.yam
>> l to the environment with scope global
>>> DEBUG - Adding descriptor
>> D:\a\1\s\BaseTools\Plugin\BuildToolsReport\BuildToolsReportGenerator_p
>> lug_in.yaml to the environment with scope global
>>> DEBUG - --- self_describing_environment.update_simple_paths()
>>> DEBUG - --- self_describing_environment.update_extdep_paths()
>>> DEBUG - --- self_describing_environment.report_extdep_version()
>>> SECTION - Loading Plugins
>>> DEBUG - Loading Plugin from
>> D:\a\1\s\BaseTools\Plugin\BuildToolsReport\BuildToolsReportGenerator.p
>> y
>>> SECTION - Start Invocable Tool
>>> INFO - Running Python version: sys.version_info(major=3, minor=10,
>> micro=7, releaselevel='final', serial=0)
>>> INFO - Cmd to run is:
>> c:\hostedtoolcache\windows\python\3.10.7\x64\lib\site-
>> packages\edk2toollib\bin\vswhere.exe -latest -nologo -all -property
>> installationPath -products * -version 16.0,17.0
>>> INFO - ------------------------------------------------
>>> INFO - --------------Cmd Output Starting---------------
>>> INFO - ------------------------------------------------
>>> INFO - C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise
>>> INFO - ------------------------------------------------
>>> INFO - --------------Cmd Output Finished---------------
>>> INFO - --------- Running Time (mm:ss): 00:00 ----------
>>> INFO - ----------- Return Code: 0x00000000 ------------
>>> INFO - ------------------------------------------------
>>> DEBUG - Calling 'C:\Program Files (x86)\Microsoft Visual
>> Studio\2019\Enterprise\VC\Auxiliary\Build\vcvarsall.bat x86'
>>> DEBUG - Var - ExtensionSdkDir = C:\Program Files (x86)\Microsoft
>> SDKs\Windows Kits\10\ExtensionSDKs
>>> DEBUG - Var - INCLUDE = C:\Program Files (x86)\Microsoft Visual
>> Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\ATLMFC\include;C:\
>> Program Files (x86)\Microsoft Visual
>> Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\include;C:\Program
>> Files (x86)\Windows Kits\NETFXSDK\4.8\include\um;C:\Program Files
>> (x86)\Windows Kits\10\include\10.0.22621.0\ucrt;C:\Program Files
>> (x86)\Windows Kits\10\include\10.0.22621.0\shared;C:\Program Files
>> (x86)\Windows Kits\10\include\10.0.22621.0\um;C:\Program Files
>> (x86)\Windows Kits\10\include\10.0.22621.0\winrt;C:\Program Files
>> (x86)\Windows Kits\10\include\10.0.22621.0\cppwinrt
>>> DEBUG - Var - LIB = C:\Program Files (x86)\Microsoft Visual
>> Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\ATLMFC\lib\x86;C:\
>> Program Files (x86)\Microsoft Visual
>> Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\lib\x86;C:\Program
>> Files (x86)\Windows Kits\NETFXSDK\4.8\lib\um\x86;C:\Program Files
>> (x86)\Windows Kits\10\lib\10.0.22621.0\ucrt\x86;C:\Program Files
>> (x86)\Windows Kits\10\lib\10.0.22621.0\um\x86
>>> DEBUG - Var - LIBPATH = C:\Program Files (x86)\Microsoft Visual
>> Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\ATLMFC\lib\x86;C:\
>> Program Files (x86)\Microsoft Visual
>> Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\lib\x86;C:\Program
>> Files (x86)\Microsoft Visual
>> Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\lib\x86\store\refere
>> nces;C:\Program Files (x86)\Windows
>> Kits\10\UnionMetadata\10.0.22621.0;C:\Program Files (x86)\Windows
>> Kits\10\References\10.0.22621.0;C:\Windows\Microsoft.NET\Framework\
>> v4.0.30319
>>> DEBUG - Var - Path = C:\Program Files (x86)\Microsoft Visual
>> Studio\2019\Enterprise\Common7\IDE\\Extensions\Microsoft\IntelliCode\
>> CLI;C:\Program Files (x86)\Microsoft Visual
>> Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\bin\HostX86\x86;C:
>> \Program Files (x86)\Microsoft Visual
>> Studio\2019\Enterprise\Common7\IDE\VC\VCPackages;C:\Program Files
>> (x86)\Microsoft Visual
>> Studio\2019\Enterprise\Common7\IDE\CommonExtensions\Microsoft\Tes
>> tWindow;C:\Program Files (x86)\Microsoft Visual
>> Studio\2019\Enterprise\Common7\IDE\CommonExtensions\Microsoft\Tea
>> mFoundation\Team Explorer;C:\Program Files (x86)\Microsoft Visual
>> Studio\2019\Enterprise\MSBuild\Current\bin\Roslyn;C:\Program Files
>> (x86)\Microsoft Visual Studio\2019\Enterprise\Team Tools\Performance
>> Tools;C:\Program Files (x86)\Microsoft Visual
>> Studio\Shared\Common\VSPerfCollectionTools\vs2019\;C:\Program Files
>> (x86)\Microsoft SDKs\Windows\v10.0A\bin\NETFX 4.8 Tools\;C:\Program
>> Files (x86)\HTML Help Workshop;C:\Program Files (x86)\Microsoft Visual
>> Studio\2019\Enterprise\Common7\IDE\CommonExtensions\Microsoft\FSh
>> arp\Tools;C:\Program Files (x86)\Microsoft Visual
>> Studio\2019\Enterprise\Common7\Tools\devinit;C:\Program Files
>> (x86)\Windows Kits\10\bin\10.0.22621.0\x86;C:\Program Files
>> (x86)\Windows Kits\10\bin\x86;C:\Program Files (x86)\Microsoft Visual
>> Studio\2019\Enterprise\\MSBuild\Current\Bin;C:\Windows\Microsoft.NET
>> \Framework\v4.0.30319;C:\Program Files (x86)\Microsoft Visual
>> Studio\2019\Enterprise\Common7\IDE\;C:\Program Files (x86)\Microsoft
>> Visual
>> Studio\2019\Enterprise\Common7\Tools\;C:\hostedtoolcache\windows\n
>> ode\14.20.0\x64;C:\Users\VssAdministrator\AppData\Roaming\Python\Py
>> thon310\Scripts;C:\hostedtoolcache\windows\Python\3.10.7\x64\Scripts;
>> C:\hostedtoolcache\windows\Python\3.10.7\x64;C:\agents\2.210.1\extern
>> als\git\cmd;C:\agents\2.210.1\externals\git\mingw64\bin;C:\Program
>> Files\MongoDB\Server\5.0\bin;C:\aliyun-cli;C:\vcpkg;C:\cf-cli;C:\Program
>> Files (x86)\NSIS\;C:\tools\zstd;C:\Program
>> Files\Mercurial\;C:\hostedtoolcache\windows\stack\2.7.5\x64;C:\cabal\bi
>> n;C:\\ghcup\bin;C:\tools\ghc-9.4.2\bin;C:\Program
>> Files\dotnet;C:\mysql\bin;C:\Program Files\R\R-
>> 4.2.1\bin\x64;C:\SeleniumWebDrivers\GeckoDriver;C:\Program Files
>> (x86)\sbt\bin;C:\Program Files (x86)\GitHub CLI;C:\Program
>> Files\Git\bin;C:\Program Files
>> (x86)\pipx_bin;C:\npm\prefix;C:\hostedtoolcache\windows\go\1.17.13\x6
>> 4\bin;C:\hostedtoolcache\windows\Python\3.7.9\x64\Scripts;C:\hostedto
>> olcache\windows\Python\3.7.9\x64;C:\hostedtoolcache\windows\Ruby\2.
>> 5.9\x64\bin;C:\tools\kotlinc\bin;C:\hostedtoolcache\windows\Java_Temur
>> in-Hotspot_jdk\8.0.345-1\x64\bin;C:\Program Files\ImageMagick-7.1.0-
>> Q16-HDRI;C:\Program Files (x86)\Microsoft
>> SDKs\Azure\CLI2\wbin;C:\ProgramData\kind;C:\Program Files\Eclipse
>> Foundation\jdk-8.0.302.8-
>> hotspot\bin;C:\Windows\system32;C:\Windows;C:\Windows\System32\
>> Wbem;C:\Windows\System32\WindowsPowerShell\v1.0\;C:\Windows\Sys
>> tem32\OpenSSH\;C:\ProgramData\Chocolatey\bin;C:\Program
>> Files\PowerShell\7\;C:\Program Files\Microsoft\Web Platform
>> Installer\;C:\Program Files\dotnet\;C:\Program Files\Microsoft SQL
>> Server\130\Tools\Binn\;C:\Program Files\Microsoft SQL Server\Client
>> SDK\ODBC\170\Tools\Binn\;C:\Program Files (x86)\Windows
>> Kits\10\Windows Performance Toolkit\;C:\Program Files (x86)\Microsoft
>> SQL Server\110\DTS\Binn\;C:\Program Files (x86)\Microsoft SQL
>> Server\120\DTS\Binn\;C:\Program Files (x86)\Microsoft SQL
>> Server\130\DTS\Binn\;C:\Program Files (x86)\Microsoft SQL
>> Server\140\DTS\Binn\;C:\Program Files (x86)\Microsoft SQL
>> Server\150\DTS\Binn\;C:\Program Files (x86)\Microsoft SQL
>> Server\160\DTS\Binn\;C:\Program
>> Files\OpenSSL\bin;C:\Strawberry\c\bin;C:\Strawberry\perl\site\bin;C:\Stra
>> wberry\perl\bin;C:\ProgramData\chocolatey\lib\pulumi\tools\Pulumi\bin;
>> C:\Program Files\TortoiseSVN\bin;C:\Program
>> Files\CMake\bin;C:\ProgramData\chocolatey\lib\maven\apache-maven-
>> 3.8.6\bin;C:\Program Files\Microsoft Service
>> Fabric\bin\Fabric\Fabric.Code;C:\Program Files\Microsoft SDKs\Service
>> Fabric\Tools\ServiceFabricLocalClusterManager;C:\Program
>> Files\nodejs\;C:\Program Files\Git\cmd;C:\Program
>> Files\Git\mingw64\bin;C:\Program Files\Git\usr\bin;C:\Program
>> Files\GitHub CLI\;c:\tools\php;C:\Program Files
>> (x86)\sbt\bin;C:\SeleniumWebDrivers\ChromeDriver\;C:\SeleniumWebDriv
>> ers\EdgeDriver\;C:\Program Files\Amazon\AWSCLIV2\;C:\Program
>> Files\Amazon\SessionManagerPlugin\bin\;C:\Program
>> Files\Amazon\AWSSAMCLI\bin\;C:\Program Files (x86)\Google\Cloud
>> SDK\google-cloud-sdk\bin;C:\Program Files (x86)\Microsoft BizTalk
>> Server\;C:\Program
>> Files\LLVM\bin;C:\Users\VssAdministrator\.dotnet\tools;C:\Users\VssAdm
>> inistrator\.cargo\bin;C:\Users\VssAdministrator\AppData\Local\Microsoft\
>> WindowsApps;C:\Program Files (x86)\Microsoft Visual
>> Studio\2019\Enterprise\VC\Tools\Llvm\bin;C:\Program Files
>> (x86)\Microsoft Visual
>> Studio\2019\Enterprise\Common7\IDE\CommonExtensions\Microsoft\CM
>> ake\CMake\bin;C:\Program Files (x86)\Microsoft Visual
>> Studio\2019\Enterprise\Common7\IDE\CommonExtensions\Microsoft\CM
>> ake\Ninja;C:\Program Files (x86)\Microsoft Visual
>> Studio\2019\Enterprise\Common7\IDE\VC\Linux\bin\ConnectionManagerE
>> xe
>>> DEBUG - Var - UCRTVersion = 10.0.22621.0
>>> DEBUG - Var - UniversalCRTSdkDir = C:\Program Files (x86)\Windows
>> Kits\10\
>>> DEBUG - Var - VCToolsInstallDir = C:\Program Files (x86)\Microsoft Visual
>> Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\
>>> DEBUG - Var - WindowsLibPath = C:\Program Files (x86)\Windows
>> Kits\10\UnionMetadata\10.0.22621.0;C:\Program Files (x86)\Windows
>> Kits\10\References\10.0.22621.0
>>> DEBUG - Var - WindowsSdkBinPath = C:\Program Files (x86)\Windows
>> Kits\10\bin\
>>> DEBUG - Var - WindowsSdkDir = C:\Program Files (x86)\Windows Kits\10\
>>> DEBUG - Var - WindowsSdkVerBinPath = C:\Program Files (x86)\Windows
>> Kits\10\bin\10.0.22621.0\
>>> DEBUG - Var - WindowsSDKVersion = 10.0.22621.0\
>>> INFO - Cmd to run is: nmake.exe
>>> INFO - ------------------------------------------------
>>> INFO - --------------Cmd Output Starting---------------
>>> INFO - ------------------------------------------------
>>> INFO - 'nmake.exe' is not recognized as an internal or external command,
>>> INFO - operable program or batch file.
>>> INFO - ------------------------------------------------
>>> INFO - --------------Cmd Output Finished---------------
>>> INFO - --------- Running Time (mm:ss): 00:00 ----------
>>> INFO - ----------- Return Code: 0x00000001 ------------
>>> INFO - ------------------------------------------------
>>>
>>>
>>> Mike
>>>
>>>> -----Original Message-----
>>>> From:devel@edk2.groups.io  <devel@edk2.groups.io>  On Behalf Of Yao,
>> Jiewen
>>>> Sent: Tuesday, September 20, 2022 4:06 PM
>>>> To:devel@edk2.groups.io
>>>> Subject: [edk2-devel] EDKII CI Failure
>>>>
>>>> Hi
>>>> I notice that EDKII CI failed on step "Build Base Tools from source" for
>> https://github.com/DMTF/libspdm/pull/1218
>>>> https://dev.azure.com/tianocore/edk2-
>> ci/_build/results?buildId=62090&view=logs&j=c0929384-5a08-5c0f-b36d-
>>>> 6f51b6b81732&t=dc6c8514-4845-5cff-3ead-20e6776e3d52
>>>>
>>>>
>>>> Anyone knows what is happening on the CI?
>>>>
>>>> Thank you
>>>> Yao Jiewen
>>>>
>>>>
>>>>> -----Original Message-----
>>>>> From:devel@edk2.groups.io  <devel@edk2.groups.io>  On Behalf Of Yao,
>>>>> Jiewen
>>>>> Sent: Wednesday, September 21, 2022 7:03 AM
>>>>> To: Wenyi Xie<xiewenyi2@huawei.com>;devel@edk2.groups.io; Wang,
>>>>> Jian J<jian.j.wang@intel.com>; Lu, Xiaoyu1<xiaoyu1.lu@intel.com>;
>> Jiang,
>>>>> Guomin<guomin.jiang@intel.com>
>>>>> Cc:songdongkuang@huawei.com
>>>>> Subject: Re: [edk2-devel] [PATCH EDK2 v1 1/1]
>>>>> CryptoPkg/BaseCryptLib:Remove redundant init
>>>>>
>>>>> Reviewed-by: Jiewen Yao<Jiewen.yao@intel.com>
>>>>>
>>>>>
>>>>>> -----Original Message-----
>>>>>> From: Wenyi Xie<xiewenyi2@huawei.com>
>>>>>> Sent: Thursday, September 15, 2022 5:26 PM
>>>>>> To:devel@edk2.groups.io; Yao, Jiewen<jiewen.yao@intel.com>;
>> Wang,
>>>>> Jian
>>>>>> J<jian.j.wang@intel.com>; Lu, Xiaoyu1<xiaoyu1.lu@intel.com>; Jiang,
>>>>>> Guomin<guomin.jiang@intel.com>
>>>>>> Cc:songdongkuang@huawei.com;xiewenyi2@huawei.com
>>>>>> Subject: [PATCH EDK2 v1 1/1] CryptoPkg/BaseCryptLib:Remove
>>>>> redundant
>>>>>> init
>>>>>>
>>>>>> CertCtx is used to be defined as a struct and ZeroMem is called to
>>>>>> init this struct. But now CertCtx is defined as a point, so use
>>>>>> ZeroMem (&CertCtx, sizeof (CertCtx)) is not correct any more.
>>>>>>
>>>>>> Cc: Jiewen Yao<jiewen.yao@intel.com>
>>>>>> Cc: Jian J Wang<jian.j.wang@intel.com>
>>>>>> Cc: Xiaoyu Lu<xiaoyu1.lu@intel.com>
>>>>>> Cc: Guomin Jiang<guomin.jiang@intel.com>
>>>>>> Signed-off-by: Wenyi Xie<xiewenyi2@huawei.com>
>>>>>> ---
>>>>>>    CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyCommon.c | 2
>> --
>>>>>>    1 file changed, 2 deletions(-)
>>>>>>
>>>>>> diff --git
>>>>> a/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyCommon.c
>>>>>> b/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyCommon.c
>>>>>> index 3336d2f60a6a..f8028181e47f 100644
>>>>>> --- a/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyCommon.c
>>>>>> +++
>> b/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyCommon.c
>>>>>> @@ -502,8 +502,6 @@ Pkcs7GetCertificatesList (
>>>>>>      OldBuf       = NULL;
>>>>>>      Signers      = NULL;
>>>>>>
>>>>>> -  ZeroMem (&CertCtx, sizeof (CertCtx));
>>>>>> -
>>>>>>      //
>>>>>>      // Parameter Checking
>>>>>>      //
>>>>>> --
>>>>>> 2.20.1.windows.1
>>>>>
>>>>>
>>>>>
>>>>
>>>>
>>>>
>>>
>>>
>>>
>>>
>>
>> 
>>

[-- Attachment #2: Type: text/html, Size: 24290 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH EDK2 v1 1/1] CryptoPkg/BaseCryptLib:Remove redundant init
  2022-09-15  9:26 ` [PATCH EDK2 v1 1/1] " wenyi,xie
                     ` (2 preceding siblings ...)
       [not found]   ` <1716B3FB06A49EB8.26483@groups.io>
@ 2022-09-23  6:31   ` Yao, Jiewen
  3 siblings, 0 replies; 10+ messages in thread
From: Yao, Jiewen @ 2022-09-23  6:31 UTC (permalink / raw)
  To: Wenyi Xie, devel@edk2.groups.io, Wang, Jian J, Lu, Xiaoyu1,
	Jiang, Guomin
  Cc: songdongkuang@huawei.com

Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>

Merged https://github.com/tianocore/edk2/pull/3356

> -----Original Message-----
> From: Wenyi Xie <xiewenyi2@huawei.com>
> Sent: Thursday, September 15, 2022 5:26 PM
> To: devel@edk2.groups.io; Yao, Jiewen <jiewen.yao@intel.com>; Wang, Jian
> J <jian.j.wang@intel.com>; Lu, Xiaoyu1 <xiaoyu1.lu@intel.com>; Jiang,
> Guomin <guomin.jiang@intel.com>
> Cc: songdongkuang@huawei.com; xiewenyi2@huawei.com
> Subject: [PATCH EDK2 v1 1/1] CryptoPkg/BaseCryptLib:Remove redundant
> init
> 
> CertCtx is used to be defined as a struct and ZeroMem is called to
> init this struct. But now CertCtx is defined as a point, so use
> ZeroMem (&CertCtx, sizeof (CertCtx)) is not correct any more.
> 
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Xiaoyu Lu <xiaoyu1.lu@intel.com>
> Cc: Guomin Jiang <guomin.jiang@intel.com>
> Signed-off-by: Wenyi Xie <xiewenyi2@huawei.com>
> ---
>  CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyCommon.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyCommon.c
> b/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyCommon.c
> index 3336d2f60a6a..f8028181e47f 100644
> --- a/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyCommon.c
> +++ b/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyCommon.c
> @@ -502,8 +502,6 @@ Pkcs7GetCertificatesList (
>    OldBuf       = NULL;
>    Signers      = NULL;
> 
> -  ZeroMem (&CertCtx, sizeof (CertCtx));
> -
>    //
>    // Parameter Checking
>    //
> --
> 2.20.1.windows.1


^ permalink raw reply	[flat|nested] 10+ messages in thread
end of thread, other threads:[~2022-09-23  6:31 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-15  9:26 [PATCH EDK2 v1 0/1] CryptoPkg/BaseCryptLib:Remove redundant init wenyi,xie
2022-09-15  9:26 ` [PATCH EDK2 v1 1/1] " wenyi,xie
2022-09-15  9:42   ` Xiaoyu Lu
2022-09-20 23:03   ` Yao, Jiewen
     [not found]   ` <1716B3FB06A49EB8.26483@groups.io>
2022-09-20 23:05     ` [edk2-devel] EDKII CI Failure Yao, Jiewen
2022-09-20 23:36       ` Michael D Kinney
2022-09-21  0:01         ` Sean
2022-09-21  0:09           ` Yao, Jiewen
2022-09-22  0:21             ` Sean
2022-09-23  6:31   ` [PATCH EDK2 v1 1/1] CryptoPkg/BaseCryptLib:Remove redundant init Yao, Jiewen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox