From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web10.7986.1663234946841341905 for ; Thu, 15 Sep 2022 02:42:26 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=f9KIuYnF; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: xiaoyu1.lu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663234946; x=1694770946; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=tf7n2XWcRoIp4h2YTvS4547Ta28dVIsaV5FktrnN+Pc=; b=f9KIuYnFAi+aM2BsTdOaT9vjDzV0lxuuSKnHnuFF9gKapZDV6H41v+Yb 3CpirlpZ3Ulyrm2yruDp+5lrH5rbdtm3EcsxZzWu+hIyO2Md03YQLiw73 9mQgVuIhw8Ia1odogxhhGNNQMOL0tvQCZxjD/Cxxc8s6GZxym8sM6CRhH qZEgx6Un2UETvi43f2UlMVAgxBkCqLsJq14m1FqhpQntmETd57e6I4kxY BomLr6Ca0bOOwKHoSefNg7uSb18K3JWF0CWS8EGaFsiy+5SB7RQPhwbXY G13Qv0Db8AtipebyUUFnZpF+hHfpFYYs5y14wzlbqAZfqrskr0POUggDr w==; X-IronPort-AV: E=McAfee;i="6500,9779,10470"; a="279051594" X-IronPort-AV: E=Sophos;i="5.93,317,1654585200"; d="scan'208";a="279051594" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Sep 2022 02:42:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,317,1654585200"; d="scan'208";a="792638246" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga005.jf.intel.com with ESMTP; 15 Sep 2022 02:42:25 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 15 Sep 2022 02:42:25 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 15 Sep 2022 02:42:24 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Thu, 15 Sep 2022 02:42:24 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.177) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Thu, 15 Sep 2022 02:42:23 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GyOtqi3iRIJOAqqgr5L1Yj3bJcVZqMk0qx1ISyKI1YUCON7KcKSAFfncvVh38u+LIMpBRUGAjAJlkdykKocn80VH4COJYU2RNZrT25uMCmPZ5EVq0nJ0SsEnEF4L2EdxZEJ/ql4IS/R5DWNrMYzMpWpXfZpHhq49paHToR0ATD3SKHG7HjZ42qMbpcjEnn3l1x7/uGItYjQdbLLqS9jdxij5fWYKloA7d/iswXaq5+Wcl2Rk7KpkDr2MpYUqRQHd8iOemCsJBUa4HCeTXwR+XR6aaZzLp6lpYjZMLgXmeLH+iNQKh8x6HdZHKTIdB/E6qwUIuboDXKsD6Dnai8BBKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pHMsSOkuwZuUvgW/Ow9twM5ZB15T5zSoNek7RxyoRyQ=; b=MmMLVtuDThGozUh94rREt887qE+dxul9+lHwxF5maBSInA4CcYlMWFUMfoP+i8GVdf0y/Ea7+QxFwmAQQ/8fADUtNOZZWRqbmbMj05LNNZAePvyjMtcy5z2LRa1ibuU5Htx4DKNA3bcD85ERygLaSrnPjveR7vCcCVWORFz225xL7OwOU0/NVGEuU9nl3kVUbZV78Pjwh5GZbG/jDnqg8zaiCsDA6tblv022fha3HHGTzmcsZMqPbsOVnenHhNYB1IrET8cuxhusySaddWSOBxReunNW1ovuliJd7p4lcKpKOCrd95Z9PpmuweklVv1F+LY8wbFfMeHDM8+4AbDzYA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5062.namprd11.prod.outlook.com (2603:10b6:510:3e::12) by BL1PR11MB5336.namprd11.prod.outlook.com (2603:10b6:208:316::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.15; Thu, 15 Sep 2022 09:42:22 +0000 Received: from PH0PR11MB5062.namprd11.prod.outlook.com ([fe80::b867:24f7:6dea:1813]) by PH0PR11MB5062.namprd11.prod.outlook.com ([fe80::b867:24f7:6dea:1813%7]) with mapi id 15.20.5612.022; Thu, 15 Sep 2022 09:42:21 +0000 From: "Xiaoyu Lu" To: Wenyi Xie , "devel@edk2.groups.io" , "Yao, Jiewen" , "Wang, Jian J" , "Jiang, Guomin" CC: "songdongkuang@huawei.com" , "Lu, Xiaoyu1" Subject: Re: [PATCH EDK2 v1 1/1] CryptoPkg/BaseCryptLib:Remove redundant init Thread-Topic: [PATCH EDK2 v1 1/1] CryptoPkg/BaseCryptLib:Remove redundant init Thread-Index: AQHYyOVGyuHHp3G4IkuR+/ifpT9STa3gPF+A Date: Thu, 15 Sep 2022 09:42:21 +0000 Message-ID: References: <20220915092620.3341564-1-xiewenyi2@huawei.com> <20220915092620.3341564-2-xiewenyi2@huawei.com> In-Reply-To: <20220915092620.3341564-2-xiewenyi2@huawei.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.500.17 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR11MB5062:EE_|BL1PR11MB5336:EE_ x-ms-office365-filtering-correlation-id: 448c566f-c27a-4066-c582-08da96fe969c x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: xzkyMGEAII9BStApa0SvVzySqVdFb27jUGU2H1z1RzngmFe2VKtsevyJ7+wn64lLpEW37f8EixMKhXfgB8CbPWA1WfPVnpOWPjRWI79wXhXCRnMLIaK6Qp4pfjH1HZeYgKZkH1FjZ78vNWx8s5bpoxmQvdiJevEAwXplYcRnRZ9Ra6mYrDBzhpkFy8/A4XL3QSluQ+dkd82utWsCgV/pambXpB5vuLucappLM6EwLXIDizumuAL8+eIy732VRsrrvbdbA60dN7QFUSAloihhuTCONdwPnE6T3g22lLb7UNowWu0y+Qvm2Ss4iwI3R9ZOOburcOb6ihqAtHmjD5DzYzHqlbfutP1IRWZ9zbyU3vEXLoC0UO80Q8WzgrtBINKoHSY9OOgKB0UqBOEIQ36109leS5XgMb0vZez6sQOeEZRROYhnvyxSA552LQCA57EEsxxOLPGX+gxGqZq+eDviDylx2AQiZ1EWdWz75twi9uyqu1LLNZ7OrNGpef7kEEVym7cNWrd46++9OzorSrQlahnAn9HkBB0jr8VMV3IGdJDhvVEWba0lMq3tGRFwzRh0AXagubUL4PoScU7uegEpbBvy+AmeGhaM/r9XoBh7qsVVgu4L2zjhvp58zoIkRx67EQYmuaI9gcfzJU8sVnAcpBeYVV0kWPhA05iF/Jr3rWlWwq/YQH2WwXNKMuLs9QuD2ctwyeq7D353YRkCaPr9MnLPFUpIIC187qylymBZcSA3umISx95N3iWZnR+/nQHs3P8Qj2atCUzs9UnpqeWuZQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5062.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(346002)(39860400002)(376002)(396003)(136003)(451199015)(53546011)(186003)(83380400001)(26005)(9686003)(7696005)(107886003)(6506007)(76116006)(4326008)(66556008)(66446008)(66946007)(64756008)(66476007)(5660300002)(82960400001)(86362001)(52536014)(2906002)(478600001)(38070700005)(8936002)(71200400001)(55016003)(41300700001)(38100700002)(6636002)(122000001)(316002)(19627235002)(110136005)(54906003)(8676002)(33656002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?qvEUzvNCpnMAsb6R5eEL7iSM+CrRVt/uL7uMvb6Z5SGe4ORh28V0CwZ1H/nY?= =?us-ascii?Q?tmjcQL9S2u+wyKkvbQ38KpkDL66ZXiLQz7L4lu4U/z33JWSW7RBCPwOea8t1?= =?us-ascii?Q?5dbN48gRpm+ECLqNA+DSY5BdMn1oI/1jhzGr+BfvnSozDzMFNw4QrxxpLDbm?= =?us-ascii?Q?/MtYcS3fkDPviqeBiuIP+VQGn3JAcMl0sEVGdO1oBUH9mLCSktiRN/PpstsN?= =?us-ascii?Q?BQeE43O2/PXvKO6MM0ynxH6K0h3C8DF7b5W5+9r6H7lm3iG18vAD2Kgv7l+j?= =?us-ascii?Q?+dXuIzxMCb32EufJmqX1ivY7m1G7WlA9Kg0pjX2R59UGn/kEfdag/nfS9dvJ?= =?us-ascii?Q?gVy5VUIdf5/PbzGn3YB2M4ZAI7I7Eh8B1WSSxTZDnyefO+0kyqMDVUmwxcs6?= =?us-ascii?Q?ea7PUxFFKsv/Yw8PqhV4nPIg4x3Z1tPZ1DirlY7g1/jtKMQtWR8N9Xt+b3ea?= =?us-ascii?Q?p0N1He7Ldtp1mjuD7XBaOUdKjfxgP9wEJP9/MuB2IGkViZQGIyApwajJYqU8?= =?us-ascii?Q?MDHSltbifsndjc0vEhoThj/kgpGKPoRvCP0vh2vX8M5Rr2VqDsuYxEbj52q6?= =?us-ascii?Q?tQj71hLRUMfLzOSpZGvlRs9EOFDKKecJEl+A6n2wGIhixS6Rep1K181dA6Ly?= =?us-ascii?Q?m2fQiCjswzRvKfB4DcBdaPnvvSZNYiJPzRIjy3kXnxnlsFISqy1n01iKcn5A?= =?us-ascii?Q?/stETjaSbqNYRh8THqXlSQIJvLL+bnj8JHz4t3fWmz1lqbCVYOimlnifRzrW?= =?us-ascii?Q?Jx7RmAmiTRQcNwzF/Wp4DUPfq1xfOZIBE9m/6uexULoSf3CRout6Uay5VduI?= =?us-ascii?Q?UWopDkJdgyv6iYwBxrm+hYZ01DZV56fwf3b0+kbia0m/WJqMVtCIgf98TkT+?= =?us-ascii?Q?sJP43fcIhoHp0WWP/p1Y3NIHvqH42EMv4ydhSy679HzZG/XAIw4ZuMX8s0Rf?= =?us-ascii?Q?i7W+wgZ4tg8p2UDNvl08aG2MJQoqUimqUvX2et7QWVcB5a8BUzqUoWEMVBVn?= =?us-ascii?Q?aA8tN94HpU0Jn91zCbwxzctWl44IqXncFewz7Uxy5ySqmE45ErNO9M7xUg6q?= =?us-ascii?Q?TP4yFyje5jtiEisX/Qsnrj/BIu8YpQfJxqBkWBpUCsrsKo99ep19m4ZW1xrF?= =?us-ascii?Q?kngw61ZlkwlK9dAv9Q3kKKe6L8iEDE2+niOtk/sp+kRkqNvds6VhKZbs1qee?= =?us-ascii?Q?yHpQR6oBL1YOIkIcn9ygOjWq0crZFBsHwpCBeIil16Ml2xqWY5CkWXngzdvu?= =?us-ascii?Q?+VfwKnLFlsYGKUEM2Jl0CDRc6FGdpWIokxFtVvjYNhjahwUZTbCObdTzmrxu?= =?us-ascii?Q?qfHsP22IuTZkRiObA5BdYMY8MhTuCmFmUV2VzPzFsuBP5sZ5D+r+3BzvAgOm?= =?us-ascii?Q?7z0nPHAW7Fama3gA5fM/U3gpV6X/lP4MLgrG3JIgb44bZUml72T7tsRyeTGT?= =?us-ascii?Q?ejBAZ5mfPoGMICliVtrVc5iMZlrHekKR+dZPcGLer4j+iBiFfToGpvya3rTn?= =?us-ascii?Q?4JMDXz/+nLgGZYHf95ZwiNGNstY3XNep6EtKYE9lV78eA2gaDEk80df5q3cE?= =?us-ascii?Q?9CXV0Q1cA+XiqO2osKe711BExPa1kLLdDibl+6zg?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5062.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 448c566f-c27a-4066-c582-08da96fe969c X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Sep 2022 09:42:21.8750 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: d00hLSAqljbgVVhJeUhaqRdVhHxOWPIBPK1SavOeMCvETH277oY0vzgEBsIAv/OS3QEkRViUmPloX3rfd2KhGw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5336 Return-Path: xiaoyu1.lu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Xiaoyu Lu -----Original Message----- From: Wenyi Xie =20 Sent: Thursday, September 15, 2022 5:26 PM To: devel@edk2.groups.io; Yao, Jiewen ; Wang, Jian J = ; Lu, Xiaoyu1 ; Jiang, Guomin = Cc: songdongkuang@huawei.com; xiewenyi2@huawei.com Subject: [PATCH EDK2 v1 1/1] CryptoPkg/BaseCryptLib:Remove redundant init CertCtx is used to be defined as a struct and ZeroMem is called to init thi= s struct. But now CertCtx is defined as a point, so use ZeroMem (&CertCtx, = sizeof (CertCtx)) is not correct any more. Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang Signed-off-by: Wenyi Xie --- CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyCommon.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyCommon.c b/C= ryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyCommon.c index 3336d2f60a6a..f8028181e47f 100644 --- a/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyCommon.c +++ b/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyCommon.c @@ -502,8 +502,6 @@ Pkcs7GetCertificatesList ( OldBuf =3D NULL; Signers =3D NULL; =20 - ZeroMem (&CertCtx, sizeof (CertCtx)); - // // Parameter Checking // -- 2.20.1.windows.1