From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web11.7379.1628996433493752543 for ; Sat, 14 Aug 2021 20:00:33 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=isOUYSzF; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: min.m.xu@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10076"; a="195984746" X-IronPort-AV: E=Sophos;i="5.84,322,1620716400"; d="scan'208";a="195984746" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Aug 2021 20:00:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,322,1620716400"; d="scan'208";a="440735293" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by orsmga002.jf.intel.com with ESMTP; 14 Aug 2021 20:00:31 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Sat, 14 Aug 2021 20:00:31 -0700 Received: from orsmsx606.amr.corp.intel.com (10.22.229.19) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Sat, 14 Aug 2021 20:00:30 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Sat, 14 Aug 2021 20:00:30 -0700 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.168) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Sat, 14 Aug 2021 20:00:29 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gxd9QRUg+HqLgco2pbxSyWTLSsqeRZurQUBPyiKuhtcQyz9zIyNvlZDTRpRvke3LAAK3JWPjcuYP1GDEHZ3bPzDnqi36WtgTByPeeRkGPGU6JiilssciXrkdDwpkrg79GyN1e4gb7zo94Fasckd3Z7QCSillJdcWNisiOHYPLOixSRYF6sKQO7f26KyierBAQ5NqWbtYIg99TPU58VF6Q3/O9D71Fw+2FM15ogJAc5j/RCpSY4or/QLRGhfyOuInuQ14Rf/KPh75h6sloFmQwgcByD5gTmbo7s/8AluRB1Dxqr6vY7advO/nJK1Z6pWJopibMmRzrsmrfbdaFXHoRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2NcQKT4hgzbgtW40WAGpiITTWbydVQpHI89URlLGRqY=; b=idHrcUIMLxPRm+sfG45D6/NrO9HFJDdY9j4PRZQpNaMbc5JgyukZ136AIFJLzxjXFcKTbF3ZS5C1kX8qpguqb5Nvd/DFeXdtaO/wIQZm62BI0/P3++iP794rYHkjxeJ+dM37maqVJjDoHJCAt5oGRTWeQiMsNTNSF1QzvuTY7Xh+BbtT4iw4me7EigNuQ0d56AEuVi3TQrYgBOdGkSANdK6R3TGRPwIL11iRqYHBvkD75EveXC1QSxjT8jpkK9HUKXVGWCoi/wrXaWEFULfPH0mqAgfe2ZlPnW18Y6j5TSzR7YDvEtTgYRfP1AFVIzpYqPeAGv5B0WNUJK2UwgVV7w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2NcQKT4hgzbgtW40WAGpiITTWbydVQpHI89URlLGRqY=; b=isOUYSzFL20qoZ0LMMOUDm9LZVk73QNMxXkLrZZwEyJX1MppuK7oGHAs3vk/pJK0Y8TPTS0OtqD51be+yRGpvkUFxrYV6deZIRRiuhTYFOehFnblGrOba/eUEuFwDRdAT9p91B4IV1dmb1obCJ9QuZCnm5Q+dg9cCJtDCzF++IU= Received: from PH0PR11MB5064.namprd11.prod.outlook.com (2603:10b6:510:3b::15) by PH0PR11MB4824.namprd11.prod.outlook.com (2603:10b6:510:38::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.16; Sun, 15 Aug 2021 03:00:27 +0000 Received: from PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::c93:200e:5aeb:e11b]) by PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::c93:200e:5aeb:e11b%3]) with mapi id 15.20.4415.022; Sun, 15 Aug 2021 03:00:27 +0000 From: "Min Xu" To: Brijesh Singh , "devel@edk2.groups.io" CC: James Bottomley , "Yao, Jiewen" , Tom Lendacky , "Justen, Jordan L" , Ard Biesheuvel , Erdem Aktas , "Michael Roth" Subject: Re: [PATCH v2 0/3] reuse the SevEsWork area Thread-Topic: [PATCH v2 0/3] reuse the SevEsWork area Thread-Index: AQHXijpvBON1bBsiMkepOgwSMQ71MKtz7aoA Date: Sun, 15 Aug 2021 03:00:27 +0000 Message-ID: References: <20210805204214.27792-1-brijesh.singh@amd.com> In-Reply-To: <20210805204214.27792-1-brijesh.singh@amd.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: amd.com; dkim=none (message not signed) header.d=none;amd.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 07184e48-8e7d-478f-dc5f-08d95f98d5f9 x-ms-traffictypediagnostic: PH0PR11MB4824: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ihCx72r93I4iQzfhqdNKeoQL4MpaEKAUs9V6Y64DCX0sryIuYF/irefc4uxMg4MTGyu6fpbNwM2tugHD9A7MBlXk3INAgamv7libUXgvcgNvJaO5SOfImFy9bxWOFKIOXgYzWQWzdnq+CqWKI/O95cM4AjCR7TRIdgMpBgOqGeYGzlRdeqbpyzTi2FMHW0CJjkPxol52zjadkVrmzSLxo/q28OpJvU3Jm+3VwVwYOGR5pphSsAQ7B9HaB/xO1cL7b8Y7W5kjjJEzA6mCs/ZKlM5a1FtljiYj7z7EVOP1wKJp5JscMYvhlrf8v0ZBnmrF1+AGRDTpBXKjUX6mpAbLOhANbejNQ7lTO9rxAeRQ4ZZvhSm4dCCgB1kfSHyfFO8tzvq0t+8hCan+aixpnwvCzPB/3n0T4BhQlst/yv9YpcAfmmpHnrFC7nw8jbcDJj+KX60jcy59mXwMYWOJY/NF7tE4wef7ZwWNo2iuZKueoIIrDlXUvj9UCe99YAhgfa2xJPLiHWrwQkZ86d+mVMXOs+IjhrPog5WbJ5paLYFm3i3gga87GphbK+oD1JXb98NHaDRBhYEYraOI52WG6uszI/EHbJkCPS9uwUelcMYpUHq0Bwx2HctuvxjOBY0FEgC+bYDVVLRMi/golTYJoSkirvz16t6SdSAY9cKDifdAuOiQfXRFP3WVho96eSgUZICmFRefQg32WsJgKs7xtGRY+9NQgWfSK9Fetbyf4AXwdD64rV4xjsxQRjWzS4YC7md9GPSfHSbTG/nrF4iigo2hDi0bpQbvV582xv5Uuby635w= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5064.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(6029001)(4636009)(366004)(39860400002)(136003)(346002)(376002)(396003)(9686003)(478600001)(76116006)(66556008)(64756008)(86362001)(66946007)(66476007)(966005)(8676002)(6506007)(19627235002)(53546011)(66446008)(186003)(7696005)(71200400001)(122000001)(55016002)(38100700002)(8936002)(52536014)(83380400001)(33656002)(5660300002)(54906003)(316002)(4326008)(2906002)(110136005)(38070700005)(26005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?KqH24kLLQUlWnVLc1ZUW0AA0oDWq3QPnFFWnTm6kRHmoleng4S+PnazAQvkV?= =?us-ascii?Q?DUBgk1Z1ll5ZTkaTWKGg6eoirMv4hfZk5bJI1P32E3+1Q9KrS7UKVEuG81Qj?= =?us-ascii?Q?0yDuXVovpDG6pRlLpUImWpKjlBHjcgzyQXe7Iv2MJMnnjwh1O1O+HtIh3WO+?= =?us-ascii?Q?neV+7ofRbOOHWyZ2YLa2dBIn3kVOGSKjegf31b5X6u/OlAcPBJ6J50yCHkzI?= =?us-ascii?Q?CRKHCH5XbcUjcKkK/YVSJLwQFgRWfaEtvBz492LFyNdRqCvYwgj4AvJtQ0Y0?= =?us-ascii?Q?RVpr50xJUDGregM5XVuhN5YzImgNFPXRr+Iroj3Dct9VXgU1VMCDFXTaHVZ7?= =?us-ascii?Q?9Az1ioflo8+RK2dfUap6LuECcCF5BidCnEU91Ua2eDhnWx7QuPWubjZmIccQ?= =?us-ascii?Q?ddvi+Y0ogrWJ22zPCc8YbeCIynfO/19Z2UD4ve1/rksbDKdUJKNWFfNAwn9B?= =?us-ascii?Q?G4zp3vT9Kfx7c0AwWAf58xCvb2npCtJomIIrLYFOJK6RcRGquXIIcnLs3H1+?= =?us-ascii?Q?hlA2idvXcm9WsJbl5Gv6fhOxgp7TR8Pnvr7E41SKool3R+B3TKogpKR6JYCG?= =?us-ascii?Q?ccKb9D508Laq7Ud5DH6cMISB8AUouEqkInAhB9HCGvEy1UgIwp9Jk/EKwjEk?= =?us-ascii?Q?oQ1oU0UUsbA6yDkFcntkVsinnAf6TlwA7yXgz89XPY82iOxyHFBQaEwiMGFU?= =?us-ascii?Q?839PVZql7GMkgju8HQsJ++A7JfYjikbY7y6Y2zOVIQkdBn4dqZdKxHNQuWgJ?= =?us-ascii?Q?Vde+ppJ792PYrH9C5uRxjIbjZrwkiI6iRfMnoujUQzHUP4Xrc+QXD0x1Ek/F?= =?us-ascii?Q?IQw8dfbFIxk7YlgNuVRNpTAFm/zfqWq9eulUTABqbsDn26vaMa/bg/giwIi8?= =?us-ascii?Q?xlPAQxr1xvwbj+PkEZQsv6pBqFsfEnPEYUqwtSz5f1ber5djmQ87ybO7OpuS?= =?us-ascii?Q?XK8pFW4QG6HwsXQ/mramFOUQCYQV/uQ/wNNyFqBVnaDnGyJQMC/g0BF126sP?= =?us-ascii?Q?P9yTCKY3Rk/tbEcyfgscZyA+9fkh2LRpURKOCpY1k/fQuPsHfRTbZzDD1RlZ?= =?us-ascii?Q?gpq2gKIRM1kHqwcT9MPjiIv1phU5oV0EUN4bdlMzg1FKoDuuxiHJdtC+68LZ?= =?us-ascii?Q?8BMpkAtxCotVq44X5UCk0bqZkqwuEYGUdXEzjBSq9rxAalfTsdaLB96HwB4O?= =?us-ascii?Q?zq678PEZ6oBAJDtnHkmYv0WzAVafAzuvgEplgapt61jvzKxwctTIrax0rxL2?= =?us-ascii?Q?NoY7ayxDwV+tJG9JpXIbxPZyqt6ddfy412xRZlX1zSpMhZ6kGoWDloPSfmZQ?= =?us-ascii?Q?3d6fa3hIvDQbg/SYbTlKjjDh?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5064.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 07184e48-8e7d-478f-dc5f-08d95f98d5f9 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Aug 2021 03:00:27.7124 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: wuK5qTQzWeHDIizWgZOYscdnrID4BrcqRUQiisXOius68rPBYyOvAzfp8PTDoHQBGuS/eqFVt3AWhRV2weH78w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4824 Return-Path: min.m.xu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi, Brijesh May I know is there some progress of this patch set? I noticed some comment= s have been given to the patch-set. Thanks! Min > -----Original Message----- > From: Brijesh Singh > Sent: Friday, August 6, 2021 4:42 AM > To: devel@edk2.groups.io > Cc: James Bottomley ; Xu, Min M > ; Yao, Jiewen ; Tom > Lendacky ; Justen, Jordan L > ; Ard Biesheuvel ; > Erdem Aktas ; Michael Roth > ; Brijesh Singh > Subject: [PATCH v2 0/3] reuse the SevEsWork area >=20 > Based on the discussion on the mailing list, we agreed that instead of wa= sting > extra page in the MEMFD, we can reuse the SevEsWorkArea buffer for the > TDX. To avoid any confusion, lets introduce a OvmfWorkArea that will > contains 32 bytes of header followed by the actual workarea. >=20 > While at it, move the code to clear the GHCB page from PageTable build to > AmdSev.asm. >=20 > I have used the existing TDX BZ for it because the request came during th= e > TDX patch review. if anyone have concern please let me know and I will > happily create a new BZ. >=20 > Full tree is at: https://github.com/AMDESE/ovmf/tree/sev-new-work-area >=20 > Brijesh Singh (3): > OvmfPkg: introduce a common work area > OvmfPkg/ResetVector: update SEV support to use new work area format > OvmfPkg/ResetVector: move the GHCB page setup in AmdSev.asm >=20 > Cc: James Bottomley > Cc: Min Xu > Cc: Jiewen Yao > Cc: Tom Lendacky > Cc: Jordan Justen > Cc: Ard Biesheuvel > Cc: Erdem Aktas >=20 > Changes since v1: > - address Jiewen's feedback. >=20 > Brijesh Singh (3): > OvmfPkg: introduce a common work area > OvmfPkg/ResetVector: update SEV support to use new work area format > OvmfPkg/ResetVector: move the GHCB page setup in AmdSev.asm >=20 > OvmfPkg/OvmfPkg.dec | 12 +++ > OvmfPkg/OvmfPkgX64.fdf | 9 +- > OvmfPkg/PlatformPei/PlatformPei.inf | 4 +- > OvmfPkg/ResetVector/ResetVector.inf | 1 + > OvmfPkg/Sec/SecMain.inf | 2 + > OvmfPkg/Include/Library/MemEncryptSevLib.h | 21 +--- > OvmfPkg/Include/WorkArea.h | 67 +++++++++++++ > OvmfPkg/PlatformPei/MemDetect.c | 32 +++--- > OvmfPkg/Sec/SecMain.c | 32 +++++- > OvmfPkg/OvmfPkgDefines.fdf.inc | 6 ++ > OvmfPkg/ResetVector/Ia32/AmdSev.asm | 111 +++++++++++++++++--- > - > OvmfPkg/ResetVector/Ia32/PageTables64.asm | 57 ++--------- > OvmfPkg/ResetVector/ResetVector.nasmb | 1 + > 13 files changed, 247 insertions(+), 108 deletions(-) create mode 10064= 4 > OvmfPkg/Include/WorkArea.h >=20 > -- > 2.17.1