From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web09.34771.1661502216997166675 for ; Fri, 26 Aug 2022 01:23:37 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=XWgzhkEr; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: min.m.xu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1661502217; x=1693038217; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=zMusEAfa+PqjhbpJ8est8WsP0aPBjrZyslrb3ifRHmw=; b=XWgzhkErb1udS9CVNr35MdZughHlJGXQ5yla+TBWGcWt4jgEvde6Wj+w sDfKeSfh932G1Wgms5O3OkxKti6jdFf+QzzAkDf1BI6DrzWLd4Xk6Y0GN AbO1P+K6+ZEVKxswsYE909R9yMAkN+apHt0JSvYJSinaTbfu9qoLStwjQ 6gSb4Wm3rERUMMq5ubD7hcGzPIhgNxL3lYlT2rs/eGwpt5Ki96ox8unj8 svdhqzNR4zcs/YmlprvR5M8yEfXxLzMmwDxR84EPADurNpJGDiJBcGauD Ait7rl4WOXuJ2a5MScYkwRQG8/J6up/5JjeM/rUJEHU2iOqN2tryShoIz Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10450"; a="358422571" X-IronPort-AV: E=Sophos;i="5.93,264,1654585200"; d="scan'208";a="358422571" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Aug 2022 01:22:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,264,1654585200"; d="scan'208";a="736555337" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga004.jf.intel.com with ESMTP; 26 Aug 2022 01:22:12 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 26 Aug 2022 01:22:12 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 26 Aug 2022 01:22:09 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Fri, 26 Aug 2022 01:22:09 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.175) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Fri, 26 Aug 2022 01:21:55 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Tv5QGALUn+UKTWU63BdplT5Dgmw9EECHGxbk/+pH3EtKG6nXmqaDNFrQBHiZdYu5AQkvMf0R/swjD1ZYifmrzaiRXGrMV8nrkhc8t0Qo/R/Opx8HcKdCkw6kFIOr3fOUrEZ6gqZKzmT/s1zaJNnYDlY2x/0RqvadwOLGPoxQYc4bHXRzWKr4pGhLHPWU4ccvVi//uBrZOzzZENYkFRVFz29JOy2z+hyaoPmF1yftc8RAso/i/3tsRyzrd6UC5OAGs5+TUeRxWL+rKisygNGZ8Sx0YVtUCGNS9pk2urA34BMVF5RAEwcdlY3mOVYYP7bEduObaiU2NbMKGt+22RbHHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XZofx0KSVHWZaEuXnaWzzNX5JQTQ4NT0HQas2qwOX3s=; b=KVrPbzTrfbuyuIZhK4RLIFxHytB4BaTVg5S/dUDLpzuacHn2hiA2eQ1+oxdHUrhP3B16cNjm/vF0j/Y5Iv9rDyi7STMzT9pAVYpzUaJHY63081tzZMANJr6ITzyy79SPcT46ru+k7qFSXo+Yq5xr/GcEMwnv3e44cjdUiqBqwN99pUn1n6szkWSpO54jhe5J95LcCQunYFvpZLy36B53YGpGhDNFm/Le2Vhb605bdqUsFgu/5I6VqQqcd7PkqZO04A+1K9b8z1IZXQ/ZWKAhBVPdLny+cEKJcUeWts8GascSo2UKpcOdt8MdaKt31YLVAatB8EXF+YfNAXuqPKfdaQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5064.namprd11.prod.outlook.com (2603:10b6:510:3b::15) by SN6PR11MB3119.namprd11.prod.outlook.com (2603:10b6:805:cc::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5546.22; Fri, 26 Aug 2022 08:21:49 +0000 Received: from PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::ec3f:8428:41d6:3284]) by PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::ec3f:8428:41d6:3284%4]) with mapi id 15.20.5566.014; Fri, 26 Aug 2022 08:21:49 +0000 From: "Min Xu" To: "devel@edk2.groups.io" , "kraxel@redhat.com" CC: "Aktas, Erdem" , James Bottomley , "Yao, Jiewen" , Tom Lendacky Subject: Re: [edk2-devel] [PATCH V3 2/2] OvmfPkg: Update CcProbeLib to DxeCcProbeLib Thread-Topic: [edk2-devel] [PATCH V3 2/2] OvmfPkg: Update CcProbeLib to DxeCcProbeLib Thread-Index: AQHYuI6NfmY2KAH5DEOZbSDNefFj6K3AptGAgAAsMxA= Date: Fri, 26 Aug 2022 08:21:49 +0000 Message-ID: References: <20220826052325.aiwch3qrbrnvj4mq@sirius.home.kraxel.org> In-Reply-To: <20220826052325.aiwch3qrbrnvj4mq@sirius.home.kraxel.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.500.17 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: aecb917a-a2be-4516-2f2a-08da873c05db x-ms-traffictypediagnostic: SN6PR11MB3119:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: WKoWLTsA3H8COVLiOHhUSzp077MP0AJD5c9zP7HFw/dOkFcsfmFINZmO7Nu7rILwGlVDE74LD3XgjIjWYzS/abevlcpgE0eijVhZhMlz1YvYRrjpQmRfXuVomK8UllY4cpbqCHhmh8f3bMDqV+v8yRTIRD9Ib4CMdkmt2ETSK9nV/vWKvqU5FIklE2SwvurtbhXrCtVR66ez6Wn/ub2hx0s+8sGwcTmliY4ccn1WyqL9ttunXGTbAbL52wtva+0c25nOdKoYc+SZC5d4FEl0o6Ax/0TflOk3MqBOZ8r3y0sHT6W7v0lNcTHgnn55D1Q8GgL7iBRIHJnMY8WTmvuqT1TBeP81Pj1OwCOYFYacfpFrDp7S2BeQNjUBmMzCsOLuVCrejIaz/7bNrzQ4iG1Tgv/M7YU6nrtwTlnjCyDsd/JSdQT3Ir+mpqgTYmDGEeR2apzODxuw1KIiQL4ytEvP+Ps1IX03Y/9p8inAkF0TPQyd097Pvk1y9+OrgItly9mEBC4UGTvcT7/IKK97z6vkYopkHjhlcz1yhR6hLHUktfcbdy6mTyF6E3yYaNizYed0OUV0+9W6qQUP8saFLo3HSkRqqLpuycLDMh2Wi9h/y6OWcXUbc8rqCgEvHiFHLHSuMcLeSJUG8klUvmTejk67KIoWoeO+BM10xeqvZTtPUDO2Ys1YS4kVMlJz3BL/kuG0iU6b54Zl2jsVBd9BTw/ol5ch5tpuWzuSJjLAseH0PbZUEjE2Us4vTUEoGMw1QtuHA5GfSTmaYnAl/z+cpwYqmw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5064.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(6029001)(366004)(136003)(396003)(346002)(376002)(39860400002)(9686003)(86362001)(26005)(316002)(71200400001)(55016003)(6506007)(478600001)(7696005)(41300700001)(2906002)(54906003)(33656002)(82960400001)(83380400001)(110136005)(38070700005)(38100700002)(186003)(8676002)(52536014)(8936002)(4326008)(66476007)(66946007)(76116006)(5660300002)(66556008)(64756008)(66446008)(122000001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ZNPGISkCQ8z2r14IZQdGmVbn1aiLjj6o3nF+Z4Q+1wd8NVop7EAsKweqDxSP?= =?us-ascii?Q?wAyhLbQMUCaWSjJZxW/mHXcnIB+rSLD6LIL2oNxQTjQRj2IFGcU8KZiCwl9U?= =?us-ascii?Q?ihfDr+gaVZVFxhtK8vry/OSL5TjGLkqu16am8WHIKkMdfLfgH4wLTKwvM98Z?= =?us-ascii?Q?pC2MCs/mhYiowK/IgyBk8XAbOTlVlTiVprKBy1uukiteLXDvupJDldXNRwE4?= =?us-ascii?Q?GdNVpQjGka72FJI3h+gr7EYhzTpamjKL7Ni5U2NPe4RRgtTyPNTCAxTMgbOF?= =?us-ascii?Q?bIsv5Xz8UDv+p44mW5P9KIDYawWXb13/7QQZAOZ0uU/3GNU4OI06v0PzceD8?= =?us-ascii?Q?7AVQBPRrrrHnN2XfPVh44oHuL3jFFiuN5ONvIb+xlOcJH2KvF84Lm4cWiyI5?= =?us-ascii?Q?gANGF91Fj3mj+tY5PRwDaum7yOyEYCY6FjZicmAgGqqONX6w2eol9aa9O7P4?= =?us-ascii?Q?H3NkFj26LAQU5WSGY5xUJwsvFSNkPfApXeMHQjkLAyUDx9NlCyAkwHS9eF3u?= =?us-ascii?Q?WNCHuybjn3wpy19hovBC2QMSjy3Ny49jYhj1FJ9VeZd1qyzskhSZ2OKv2MHE?= =?us-ascii?Q?Oro8ljswfJku5rh+bz4ALeVvpPmOrqAq+abM/KW/FWJlTQkJ/LRPXTq6ENyu?= =?us-ascii?Q?+Cg2uwfcgVLTv/TO1y8Veqt8gOroTbY9w417F7B08z38zRBs9LS3fEhCFhhi?= =?us-ascii?Q?QUSc7BCuicydtGfhCn0vHkPH96KE0nCi+RPmOOLcKDmVDGP+nzDWwuaFD7T9?= =?us-ascii?Q?Pf0K8aHPe/6dmo9CVNRz47vbPpsHqk2Jlzxa3tkiG0/NgQqM/jjdwFu2Ru9Q?= =?us-ascii?Q?H16ud4Owz7KZuBIvYKuJCoooCIbf84cEEYJ1U5mmcq8xSVVX3ZPWyOp59DWU?= =?us-ascii?Q?Lr7/KkxKSPqK8Oxgbu/YSPsaYXs4JM6QylvTgHMEL5RP0N1Z+M5jXKmis/t5?= =?us-ascii?Q?iU4LNNfrkOYyPFAi2+QITjuucJD470USrBGAYsLa/lxIWR2JAjcy/WRkyz4P?= =?us-ascii?Q?nf8PV0p3mW/D/uuKfCyAaa6D78otgfCD07oct9yR9nTQkRQQdQcU7s+LP6PP?= =?us-ascii?Q?154wCVHYbhvCmM+E2XwBb1C8NLwf8I+F5S5kioBBSn4GBQelKqBNoGvOXFct?= =?us-ascii?Q?yW5J1+LqSx6DoJOAkcd0OuSjIotMnRLsxIXFOWuMvVCA+J0R7/4W1uA1E6WV?= =?us-ascii?Q?mQCHeN3apbsJk+/4yEAL5eHBXLRhkFYlRquee57qMZZ0oKThrq1I4qSJBL83?= =?us-ascii?Q?rUSLLh8pfBw46+XPP1j4sgkR3FcM7XATAtuYtkn9NLdWlE48H2fnXnUOQJPb?= =?us-ascii?Q?Tf9NZuzH0m/eyXEQEGEiuBARTUt2mgP0uvy8brTn14GIPHFyr0Oj1ZGRvReH?= =?us-ascii?Q?71l71LYEkyLtO9dfnkXycOc1GtEY6ckSByqdGjokadgBXBinxgQYvki1NDR+?= =?us-ascii?Q?dV7wsFiupxM7hQ6W7CZAj7fy5hwShnwKUXDcgZSACH9pgV37lHKvRTCoOHiN?= =?us-ascii?Q?PIgVoO5Z2rWSmgxhLJPii3vlPjUluGDDgxwFdHXRoave1OVWMiA4iVryXc6P?= =?us-ascii?Q?7pbH7atNbm4Za6bsTDgNwAl0E/R6BvgZapgxyGbG?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5064.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: aecb917a-a2be-4516-2f2a-08da873c05db X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Aug 2022 08:21:49.1759 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: BXb7Zf4C5dAUMttXR6WDjoLctXXgBQ6E9M9iqwk79jXzP6gcGWd4SiViu1cZ2cTksWEmro4H1yDG70N1KtENww== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3119 Return-Path: min.m.xu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable On August 26, 2022 1:23 PM, Gerd Hoffmann wrote: > Hi, >=20 > > In DxeCcProbeLib we cache the GuestType in Ovmf work area in first-call= . > > After that the Guest type is returned with the cached value. So that > > we don't need to worry about the access to Ovmf work area after > > ExitBootService. >=20 > This only works in case the first call is early enough. > Better use a CONSTRUCTOR instead. >=20 Thanks for reminder. There is another situation that the first call of DxeCcProbeLib is earlier = than its CONSTRUCTOR. For example, in MdeModulePkg/Core/Dxe/DxeMain, BaseDebugLibSerialPortConstr= uctor is called before DxeCcProbeLibConstructor. While CcProbe () is called= in BaseDebugLibSerialPortConstructor. So I would like to read the Cc guest type in both CONSTRUCTOR and CcProbe. ProcessLibraryConstructorList ( IN EFI_HANDLE ImageHandle, IN EFI_SYSTEM_TABLE *SystemTable ) { EFI_STATUS Status; Status =3D BaseDebugLibSerialPortConstructor (); ASSERT_RETURN_ERROR (Status); Status =3D DxeCcProbeLibConstructor (); ASSERT_RETURN_ERROR (Status); ... ... } Thanks Min