From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web10.972.1645573076792718096 for ; Tue, 22 Feb 2022 15:37:56 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=j3/WoIX7; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: min.m.xu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645573076; x=1677109076; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=CI+rpwK9DvON46vH5zIz8JVUAxiZWzwUXRVp2f/f6W0=; b=j3/WoIX7zQ7jehfjcSKti5nkNa7OlJldPU2q+MIJFzLKWLBnBXkJpE2A 7sJQuQ8SMBdW7Gu3SE7ARr5QlVGPQoXPLnyEl/4+gWRrPD8JGu/QWXIJb S1WFLeRIMKjwWJzGQT5tIjUA9KwUYwTrvXbHN1+BNjRnx51wAYITe9TY2 TVa5Dy2HEvKIJ5AHibV7Fg5rWWVs6GV86o4aJW/JGkyPQAbYbZ96Vobx9 wv7iemddD7JNj3X6BB5eFfr10NgwZG408O6OVlayvTr1/F7kXDsXzCjcw RVcejETn3ISI2ZeKv9EnVHPSwVKQVPn4qbq7hmiHCvIaTlWco05XxYOyn A==; X-IronPort-AV: E=McAfee;i="6200,9189,10266"; a="250663855" X-IronPort-AV: E=Sophos;i="5.88,389,1635231600"; d="scan'208";a="250663855" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Feb 2022 15:37:56 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,389,1635231600"; d="scan'208";a="706809796" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by orsmga005.jf.intel.com with ESMTP; 22 Feb 2022 15:37:55 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 22 Feb 2022 15:37:55 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Tue, 22 Feb 2022 15:37:55 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.100) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 22 Feb 2022 15:37:55 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IRdI4Ji2y8o00JyLom1r6AXlazKVaNaTx4NyciQewTh8GoaRcKgb5NMEeniOFT7qDH0yHHyPMvu/2ojD5PLwybmYHUQzUrQkZIAanr3EAuku3DAiEbOaZXSkGaEH+QYNlhqv2N7IhicPAADss6DYGXhA8PGc3sKyYU+mmWoF+b42BfUJkpJzyKQTRDK/+nAtZmDg63BtIC+UCOC+O9O2p00MKSMsIqKKAcvTnHwami0u4E25238cdyElz6/rmE0MY2nxTt2dOaAob+mqvHuMvxio5/E9np+MCZF4yqd8wjY+sJrjxNf3KjAYTlONblqzhvY78mpwHlYX7zDlpV5MOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pd5NrEoIy6vyQxpJkg6k57sOEEIcDkPt6XynKHLRyME=; b=Ezo9thP2420OSj7A2TjEWpknliWCTOhKy73HZZO6XLJKJgpIae3hzCC6jHmiFOxiTx9afkKiBkAGw8OvzHDZxowwxWHTe8eHBrH+WoQ92t/JMsIjzXvhiBC/8WeVQh9btIvJzaZYY4FhKaAKpoIV2/EG3wMOu5N+1vfGp6yHJmONyTG/AG0OPy0Ff/EmSJI1B4MgFtccEWXd63hIpIllY6V+9brnZZEpiLIXtz09pv9sHTs/3x3QYu67/5wstLSMAk0BAfzT8rHO5GYYRicWK6eiz03wZsoxhyD22ZpfyaJil6AcJaUTNDNq8W/Frrbl63EAHgYtehA4+RSMloKQeg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5064.namprd11.prod.outlook.com (2603:10b6:510:3b::15) by BYAPR11MB2935.namprd11.prod.outlook.com (2603:10b6:a03:82::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.24; Tue, 22 Feb 2022 23:37:52 +0000 Received: from PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::98f5:edb6:aee6:6886]) by PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::98f5:edb6:aee6:6886%8]) with mapi id 15.20.4995.026; Tue, 22 Feb 2022 23:37:52 +0000 From: "Min Xu" To: Gerd Hoffmann CC: "devel@edk2.groups.io" , Ard Biesheuvel , "Justen, Jordan L" , Brijesh Singh , "Aktas, Erdem" , James Bottomley , "Yao, Jiewen" , Tom Lendacky Subject: Re: [PATCH V6 18/42] OvmfPkg/PlatformPei: Update Cmos functions with PlatformInitLib Thread-Topic: [PATCH V6 18/42] OvmfPkg/PlatformPei: Update Cmos functions with PlatformInitLib Thread-Index: AQHYJYf3E8MtMgBDCE+cTTzouRYAHqyfjViAgACxlyA= Date: Tue, 22 Feb 2022 23:37:52 +0000 Message-ID: References: <20220222130045.m5ue42qfxrbtmusi@sirius.home.kraxel.org> In-Reply-To: <20220222130045.m5ue42qfxrbtmusi@sirius.home.kraxel.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2b3f5274-1ded-4242-2ba0-08d9f65c57f6 x-ms-traffictypediagnostic: BYAPR11MB2935:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: K4HhJvGGrJhO40kyH8wBAgKtThHAagxrWW4kMfjPgvEUN+jcVJuqtZOSpjOOtPYzRhwYxuaY8x5uTqUcb9N6Phis9esNFDsvB0vKRviiyjGf132MacVXU3PcRUXt2BecJFlSWt+BgwCdcjfi2COh+x7fhncS7zJxlVpSE715atXYmN0ge63uDrTguSfYl6OsalWn/Xu7YqsqPOO43bHew7StyjJko/1GCNA6hN6TWYjiml4IwlW9MQEBsQBJymDXMpfjw8K/e5YVrFXo9CjQi+c6MIIIoUXNhav7d+kestZz6//6XF0su1P19783aiEOBEpRNolhrmS5uwbjEQC+VPXv49rlV9KImSuJ9CMHS6HBHqGMWWmOkaik96qB9wAx8s3W6YC5fpX29/WZiwx1ZRzusk82b8D9jZetHZP6Y08WFORdXzogktccVsVBI/7zLWm2qlsqaFfamEJnRvX2b431Y+Mcr19AY0lo3F9/M2M28AKAc9MIAIwMHYXpHEBFxB+xOlnvpv171Hd/cBKBnH3uUePK0cKJKIF2E0Bceb7prBKAYXVFGo8YDQyNxIyoQNoyXuGJU9QykUcsgLoQDYPKUk5mldweCRBYcRRkG4rB3aRv3g/tz9GGlNX4M8mcN70NvIY0Pib/bIK4i6KKa9TjApKoK06+gz9ePDF66Pqdn90g4/7ZjtnsSOr3goX2M8tKKDnzKZPV0h9ncIvvRw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5064.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(38070700005)(4326008)(8676002)(66556008)(26005)(66446008)(66946007)(76116006)(64756008)(66476007)(186003)(508600001)(122000001)(9686003)(33656002)(71200400001)(38100700002)(86362001)(82960400001)(316002)(2906002)(55016003)(7696005)(4744005)(83380400001)(6506007)(8936002)(5660300002)(6916009)(52536014)(54906003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?x4CiXP3i0Pzn27LZa6mZbdPv0gg6AeX2NR2ez4IJD7ORiD+AYYOcPqVAsFsI?= =?us-ascii?Q?9qEfNzbSLCR1iVw3K7w51KTp++symc29oVz5MKlSgTf1hHOr8sXnIyzw5Rd+?= =?us-ascii?Q?mCSoQeyDP0qbpTW5fwlRwRorivWzTgnQT7SBG5PK4B/OfOCqGNSPy57psa66?= =?us-ascii?Q?X3xh/8zQQItw70ZC9Yo3dHOFVuwjK+YOJeFRc+wrBauASNBDPk3UYXhUJh2X?= =?us-ascii?Q?Ksnq2hbH3Nlla7iZ8OVQ1XvAfOsI0RlIChkiRPVENFnhOI/VbMsfkThdHgHH?= =?us-ascii?Q?dpXtG/a+2X82x4UnaB+4scNKhgHIcvgknWFPGoT7FiyX6Gvtcdl0r96yMWlp?= =?us-ascii?Q?JUcn0s7o0tCg3DAveTJNJtfXBz5rCx/3+no6qIo5lmik4cHiWlP+Y8O1blVW?= =?us-ascii?Q?kqzz8idYLlUmOFEN3kAULgcswOZj0mFI4/c8h3wY/E9l6Pj60yuLUwQT/F3e?= =?us-ascii?Q?EosmkuJglQA3VCImgY1+OOslNFiuJrBVX2oDeaMqH63xm0Pmtj6ZRK6Q5mxT?= =?us-ascii?Q?s60UHqXk4zymLL1m0lQ7PKKJ8jAVRQ5/MRSzF7yQ0OHhPYqNOzjMhCbInNas?= =?us-ascii?Q?1xmGTHoaJyn+GfamWcw081MRmt9uoU1yBV7jJC/eftkYKHYlOnKg3IrmJz4W?= =?us-ascii?Q?lqqx8sx8WBj1bop4kJ4njPEbo/z94ob21fLb5xx1sldmzYIyMgVcWkAQGFmt?= =?us-ascii?Q?nNMChIsLfTvrr1qe4Wudl9T0vEOEgvWF/kSOssdXUHRid7E5aU1i+PPzcnxz?= =?us-ascii?Q?T/ObcR7KAgxLYhDSidgHEQ3rEfBTyuWeFSdb/RlcyVmer0qUq9qsG8y6ugwm?= =?us-ascii?Q?hSyNKT+Qvk2aQltnw2jjQs0DvhnKHjIm1BKas0MvHQKEMxEzon0dM0vnP7Nl?= =?us-ascii?Q?prbb6uyFXEGa5djpY8NF05E4DO5H2M+jW9r+kjdSUNYtatOoIrjpQTxbeZKD?= =?us-ascii?Q?U8k4CACjFwJwKBtA4N5Bam1mxGSI55s8ju1XnRVBGlAqeu6jV8hPWJAldbpw?= =?us-ascii?Q?67vAD6PhZDKYCZg3+JPLgo7xn/cNboBctzYz1ZlPWw2/Lwj2hhfuYGqnO/ib?= =?us-ascii?Q?Sa5MlRjjvB7USpVxFGnTFfQfCh5V0wAmUhwLeJyHWlQEAYEUFEWc52F4qbks?= =?us-ascii?Q?xB+VhxAGRfNvBDN6E61Ug02S1QN6CqSCY5QzRUhWw/XLtDDw4+Edzm6LWXLp?= =?us-ascii?Q?a31Of3pvDS0fwwTuUElufa50hnMFjR7D6A2GBCzOWkXVOz3P2s8AGAfC2Dqz?= =?us-ascii?Q?XRqNI/emiZep0UdV5kr1x6dEu6jeYfg5UEKtTaAM4vSCRPyumYr5kmxZNXWE?= =?us-ascii?Q?cGW0GYKA5zzEMQZ0rIjUB8P+BTD4yDUxNjbhYXyG/LzuTgZ9CyfM7TJL/2VM?= =?us-ascii?Q?9+wp+3pO2cB1AXgqWByOXqvz/rWjiMOrUiOiI9b4byBpHFTH7TrctlrBusl0?= =?us-ascii?Q?3/ae71gQ4MJZkEiUqvpzOhf8U3XeWsca3+jsTyd3bmbpvK4PRK/CagpdX4B0?= =?us-ascii?Q?MjyS3p11ezSaHDDBpUhWgxCjyf3L/tg7gmp8f55wB4c4U2Kd7+8oN/FyBiz+?= =?us-ascii?Q?IyohalZFEmfZEFRQ4DIInV98Aq1h3hXYu9kJYuHjxKgY3MSepV0Q7Ty2FPpt?= =?us-ascii?Q?jK2jsVK0gzIw79bPvyDwu10=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5064.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2b3f5274-1ded-4242-2ba0-08d9f65c57f6 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Feb 2022 23:37:52.2186 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: AfKbcL/KZl8Z85S0BCfMuR7b0vfP7ZtOShMuN8M1Fg+uc0dlff6VoyXevxfVAjMIOoqV+C9nUrTFa3/eSHFnug== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB2935 Return-Path: min.m.xu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable On February 22, 2022 9:01 PM, Gerd Hoffmann wrote: > > OvmfPkg/PlatformPei/Cmos.c | 55 ----------------------------- > > OvmfPkg/PlatformPei/Cmos.h | 48 ------------------------- >=20 > That kills the git history. Better have adding the cmos function to > PlatformInitLib and removing them from PlatformPei in the same patch, git > will detect that you are effectively moving code then. >=20 > Ideally we'd have a one patch doing the buildsystem changes (add empty > PlatformInitLib and add the lib to .inf and .dsc files), and one patch mo= ving > the cmos code over. But given that the cmos code is rather small I'm als= o > fine with a single patch doing both (i.e. squash this patch with #17). >=20 Thanks for reminder. It will be squashed in the next version. Thanks Min