From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web09.1260.1655273917082314937 for ; Tue, 14 Jun 2022 23:18:38 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=Dx9K8pN2; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: min.m.xu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655273917; x=1686809917; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=4aHCKGlfI8OZDKLS6YNIPEvxHmsYZ+dsyjMg6A1h7rw=; b=Dx9K8pN2V6Q83HSvRrS0tzstYMFRXXOqjCguVqWItS4UIMYh67HnynHP IQL+kQrTJXvdjZJ+948HPF32IWocDJpbq7b0LTObCPl1fagKF7pUgGWGV WIFU18w69lx9ymFeaRqaDnEeExZldCHOsU/BOPJ0xR9jyp6KBkTow/C/+ Dqb1MjL9iSzrxCpiQIu+l+Pdh/fa9EqJ8zVaKLY6UKza7eWAeWyoiCZ4b 2rP2vOAiDFgojLQW4pun9OiVLwxJ10XmTN6ctOA8dL0fuxykYtyJp8Bzl rDnRkyKc9MblX5nTn4FsciQebFyclXgaEegyUQhVUGYlJucxjjvxyYT0w w==; X-IronPort-AV: E=McAfee;i="6400,9594,10378"; a="340513510" X-IronPort-AV: E=Sophos;i="5.91,300,1647327600"; d="scan'208";a="340513510" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jun 2022 23:18:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,300,1647327600"; d="scan'208";a="640813526" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by fmsmga008.fm.intel.com with ESMTP; 14 Jun 2022 23:18:21 -0700 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 14 Jun 2022 23:18:19 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Tue, 14 Jun 2022 23:18:19 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.177) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Tue, 14 Jun 2022 23:18:17 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YGcPqz2JS1eGo5O7dNNdkKzb3VJR8lFRCdyU1Tt2LbG7X+6SYz88x3q2t83o9pfv7FJjEIE9CFasOBNhLAsDVJc6zKIInYPFlC+WGsi3xg5v2Wx0XIh4aTpg41euPsHYDLpxquBBGlFJ011Kn6ejpIr2wVWfGmvDDn7LQevDCodGn51TJiDNzjdzpMfV+74yOM7+LTt8HvqFpKA7ktFb4d9kLUP/x4ceQ8B6TOyepAnrXn9BOdwZM/Y+Jz1zkVIwA09F1OEwxoNZn7qeX/2inj5ZLHNIY5Wmd3pKzaQT/J7VwXCcJe8Eo5FvVFZ42oNtoQxOWl8OpgNOJl/kvHanpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xOVn5+9d5JsqLlY8zjdMYKfCJClnSTtWdQgI+Kirgco=; b=KoMSBbBYdGskZSSaDD3I8PCUdAOS/gzOL/AENBYI9KOvXv+Rf5Wx9jwugyLEVSV9Ci5F7auBQ20zqkWMcz9pDDLLdgimJJxptSdHe2PH/hd9WP9oSHPSD5UmG/CprC/zSgYog08meuhm4lfD/fU2gVtBqe6o6UHt5M58gQ3yXuUGrQX5qBEcvmE1tFwP6JRNTQL2rm5vimrmOWccsHCQGZU5r4CN1uZT8T3GuHLET3cB6WfrEpmK2GI9sbZaZ9uu+/2YJa7vVgCkKWrVOR9mpLOGluXPTev8WGAAH8+2J7QOsxO1DeKxv2Rw91/b2FoQ5Zlb3TM0Aw36ML4r7fkFPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5064.namprd11.prod.outlook.com (2603:10b6:510:3b::15) by SN6PR11MB3280.namprd11.prod.outlook.com (2603:10b6:805:bb::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5332.14; Wed, 15 Jun 2022 06:18:13 +0000 Received: from PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::a0ea:2e53:9c0e:9148]) by PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::a0ea:2e53:9c0e:9148%4]) with mapi id 15.20.5332.022; Wed, 15 Jun 2022 06:18:13 +0000 From: "Min Xu" To: "Gao, Liming" , "devel@edk2.groups.io" CC: "Wang, Jian J" , "Ni, Ray" , "Aktas, Erdem" , 'Gerd Hoffmann' , 'James Bottomley' , "Yao, Jiewen" , 'Tom Lendacky' Subject: Re: [edk2-devel] [PATCH 05/14] MdeModulePkg: Update Dxe to handle unaccepted memory type Thread-Topic: [edk2-devel] [PATCH 05/14] MdeModulePkg: Update Dxe to handle unaccepted memory type Thread-Index: AQHYeVGjSRLV/8akbEirwWqEq1XI0a1MnlsAgANmS1A= Date: Wed, 15 Jun 2022 06:18:13 +0000 Message-ID: References: <48f0b328f456550ac532462b7034da53cfe99886.1654420875.git.min.m.xu@intel.com> <005601d87ec8$7f6f7700$7e4e6500$@byosoft.com.cn> In-Reply-To: <005601d87ec8$7f6f7700$7e4e6500$@byosoft.com.cn> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.500.17 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 521cb643-e276-4d68-23e2-08da4e96d3f3 x-ms-traffictypediagnostic: SN6PR11MB3280:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: NyKGq8oRYAdzfnbwOuiGz2/GbnMszNy+4GGqgeoGfNn0pJh2y0n6gJS60mAc7rHU21xwLIYMDGYykB6YQfXgresVSZScRi6Nm+T9h9tWMrfaFOSadIPN2o9k8QMSzK84BOWxHel+o1L09idQ3W+2DKzXpk9SruMGH5BgxHztaqahjbyh9e+QI03onrx/b9et3JUaJqLBiuRAeTrdN/2LzLMiGuQGPbNXf2kxcVxVy9ZKVidTmVFhrLalQqcEL88k+K3hg2fS9QxKKqF0SMXZ0SvC7bLb8QEdviYni9glDqOv0Djf14/Eh3POWpl1lMZ+N/gSJhacbExOhhk4Pe8YzOX37ptAYYmMXuCeMcpKO/qRmzlAQqKD0rST2lmqT3XjcOYeUUuVD/JvjiF3u08Ip5namwlB2buXVRPy+8N0CI01cQBUFnVaUj8lN+MBsd0INGaADDrllf0sM3almu+05f2e9vMyzNh8SS+0UkLIPqNSnbLSz49B5mQEIn+9YVtxD0pC5FSBDFjwfbu7bIp/1ShAx2QDjg0ZYJ/O8tVm95foR/Oyrwer5QeO0kQGQQVbF+rvJfn/y2ciziTc0d7Y5lUGK5EwSjg1oYOWWnmdKyVv083YDKHRfMTK7kGSGqHP76/2A3UJvBenhPb15TWy04DIoP8ZV75vJsM2JyJKdn8EmYp4Smmh0Z9ijQfPqpBHLtao5PLmeFRTt/7HDkqC+Q== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5064.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(33656002)(2906002)(55016003)(83380400001)(26005)(15650500001)(7696005)(186003)(4744005)(9686003)(6506007)(52536014)(8936002)(5660300002)(508600001)(86362001)(38100700002)(66946007)(8676002)(66476007)(66446008)(4326008)(71200400001)(76116006)(38070700005)(316002)(66556008)(64756008)(122000001)(110136005)(54906003)(82960400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?GYUjcNVLKm68kek7aV7RE0mlAyxJYAWy7AO1KEIowP+nXu1T1Nq5tKw9QFnU?= =?us-ascii?Q?9z226Y4zFoD3JEzB+E38YP8F7690uA0JtUwyFR92PiXlCdUQWH8wvMLRLRdM?= =?us-ascii?Q?yFJe8Bu6BMLOsdMR975G3Jv1cLZ4Q1/EtRdldWck9lIOHANbgicYEiipSB95?= =?us-ascii?Q?JkoOvu/ZtAH51T2V1/57mWioXjhcSkH1Ksf09esQuQ76brK58wiLAkh7m/+4?= =?us-ascii?Q?qp0M1tY8wAgfkYDY+stOwrhRQ1pGn5e3KJb+Kdn9SDtARonNz3dfuL3VMrwW?= =?us-ascii?Q?M4TPlcMrlhvmhjAa5vFZihghN7XeR3nhtDzAmMyo3OmBf2TGDAEVlCzf4u9s?= =?us-ascii?Q?Uf2lg725pVFSWafzzatdaRRRC9nvcVaMj5TZHvY9EI3VCtCl40x2wdGnt44b?= =?us-ascii?Q?4USlFw3nxgKVrKwMeufYw4lUNmFiAJXXcEuYuxz9kuZsOOPzbyvToRkZPoHL?= =?us-ascii?Q?RszLoSQqGx6A23OpDksT/HBbvpKqDwJ1Lm48hZHTS+1NrM5C6LcNGW/v8ZIB?= =?us-ascii?Q?m/HlJcBJG1usEE32FulwB9dyDd3Ihrp/r5Je+rLTKIN0vPZmRr7lKc1gASdJ?= =?us-ascii?Q?jT6YW3zTCrXHaodjIDROf4IQryyFzHNZu8+9rrJOzXacmKN+on5xEF0TYhMe?= =?us-ascii?Q?DGgf9Yz4qIi60PCncczqQInqtIFgIaTsQK53aHPigZOdGIUsUTu96yu4LEMS?= =?us-ascii?Q?8nfffEDI7jolVY/uS4+pWf/2CIVPUUJ/An7IG7I1rHCkqXI9X0EU7Dgo4X9i?= =?us-ascii?Q?0lgaJm5fgGvNTdqdrAEomNoWYEpVPkXX0MnIAycBp196IamY3MUnjQNGQdNB?= =?us-ascii?Q?f5kOkPowYi3X5qBqFvBOarHdlLia8LY8Cag1nAsoabz3kFF531vTWV1j1Twt?= =?us-ascii?Q?SdtjGQpbeaWMS/iY9yWJMf7JVdi7HcSa8PbFBNzSbeWWsOC/NXBftvk9tVCn?= =?us-ascii?Q?I6VumFgg2dfTMH504n6JqRyWHG8f3PkWPklu7y8b+GKU1n3bwZIla0/Er+5k?= =?us-ascii?Q?g2pDi/dE3d3KXpENFMJySY3gKgRwTlhI8e3/Wx6fblIiqNNxhkhFFMW0Vxn3?= =?us-ascii?Q?gyTC1NFf98QQ6GArjc6tKFS2pGF/N8XFH8bl8WaHPCKcXvjMkskyZZqQqc3O?= =?us-ascii?Q?arDPWXRx8i3/uvr9hGVr/hap4RdjTs+9nGiCxdreEnL20WssEZHrydwnG2eN?= =?us-ascii?Q?gSManc9bDq/iueSW7DH6c3ci7dmyoFgXFB9yoWXs5VFbn00q7+pI39YxLypb?= =?us-ascii?Q?FWkppkptW6hekI4YJVVlEQg+GPT0MoJMmapLzRn4k88k7r0Zz9IyxAXTOm22?= =?us-ascii?Q?JZzaoXIIIK8wMWX8SBkzvxRKGpUDJAajEG/ukyJbAZT8qrAy3b2NmCkRZkha?= =?us-ascii?Q?TQEi9L9EmFUkViSol94BDQWlHxVTZp5P2z145wBbCp2fVh3OhGvYY/6uU1jv?= =?us-ascii?Q?ZDGw0OJGgXfhr7b/dvRjWwoRIZStC/aPTqG9lvlBxeAb3r2X3mCPTeXdKKhm?= =?us-ascii?Q?javZ9lxjTZ+N4n1wlUd4HHlZ4VTjOfSKCuyxr5RKSADVbA6p3o0YRKbLFNzL?= =?us-ascii?Q?vLkoBcHGkBNL5ge7pqdN6Hgo4kEEkF+P6abMWlCB4PKWZutnQyq0/cLaVAy0?= =?us-ascii?Q?BfHyIZZ/fHU66qUWrhA0NF7zg8JcG2vaEv2H+P6+e62WygnI0AEcFxwKpmO6?= =?us-ascii?Q?DjTnp7cl6X1jQDMcCEm1lFSxCkyeu/nQsSbTAJblGc9MzOHVa+MixPoo8Pg4?= =?us-ascii?Q?YVXwjWehmw=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5064.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 521cb643-e276-4d68-23e2-08da4e96d3f3 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Jun 2022 06:18:13.4021 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jcnwu2LMNPW66hjGMij3tLCmbHVHHagsIoBcS1hha/rrx/jFYJAW6txUYkrYHu9g5peGWmbvE5mQl4ItVYkXyQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3280 Return-Path: min.m.xu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable On June 13, 2022 9:54 AM, Gao Liming wrote: > Min: > I add my comments below. >=20 > > > > @@ -83,6 +84,7 @@ EFI_MEMORY_TYPE_INFORMATION > > gMemoryTypeInformation[EfiMaxMemoryType + 1] =3D { > > { EfiMemoryMappedIOPortSpace, 0 }, > > { EfiPalCode, 0 }, > > { EfiPersistentMemory, 0 }, > > + { EfiGcdMemoryTypeUnaccepted, 0 }, > > { EfiMaxMemoryType, 0 } > > }; >=20 > Here should be EfiUnacceptedMemoryType instead of > EfiGcdMemoryTypeUnaccepted. Sure. It will be updated in the next version. >=20 > And, based on UEFI spec 2.9, AllocatePages should return > EFI_INVALID_PARAMETER when EfiUnacceptedMemoryType is specified. > Please add this check. Thanks for reminder. It will be fixed in the next version. Thanks Min