From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web09.4349.1645663764180657904 for ; Wed, 23 Feb 2022 16:49:24 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=nPYSQUgs; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: min.m.xu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645663764; x=1677199764; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=eM6FIR4LR8kJVedCafvgcGYr4DeVKT6LETJtN2LEqi0=; b=nPYSQUgs5GNl0+44I/NlZmjxQsA/gmLKW8Tvtuwyy7WpiMl/KcthILdg ATds6eD/wx3eDBgfR7Odsl/0f7DoAglil3VSariIQ5RXKRuXp9IWZFXb9 xbcZwAhk5TTGBz7CMWqHM5Uu3EPGKNnvI3cKeof7E2QtgQ9fMlgUdDU5h KmGqkGzpj9wKCrg7urKKc2bfwLZnDGzMHjsblp8STPk17+sn/ApiLtZuJ TubwphBJdrxq+K0tzfufnFYCcyuYsSDOvUySQ6UESlDyc1wz8y6keDIvv 5IAFeNuRU4sJgBsKER2GmH5/+9RiVZm2YMpwk/EKsIW5trMnoKCCu6ZEl Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10267"; a="251853876" X-IronPort-AV: E=Sophos;i="5.88,392,1635231600"; d="scan'208";a="251853876" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2022 16:49:23 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,392,1635231600"; d="scan'208";a="639527227" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga004.jf.intel.com with ESMTP; 23 Feb 2022 16:49:23 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Wed, 23 Feb 2022 16:49:23 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Wed, 23 Feb 2022 16:49:23 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.177) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Wed, 23 Feb 2022 16:49:22 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eg+wyKjwBlUlUgouyOWcVUAPx9pwx4T6OQeWKucJUTJF7AHqEdAeyebPG3eAwiOVNzcfPYnyxi9LK3S90VVtudxm23tFM7SMvNazf208PD9Pyn3w+7Iv9RZ0AZR5AOQl/1bYwgFI/tqiF6yh3zlN7GNdiu57eKkxqUF0+v10FxnUaErWSwE0l+cDzmeiWbAXS5fXTYg63udJTW+RIP/ArYKXniUsXXiYe1nCQNXjWmVCzkGQvIzNCCxXxI1vrH3Qp2g/hYj5ZIYA72JEVdB2YNawrzUQh9hY5TKcYrpSvs9Rxca5rV1CcOqg22tGVF5lnebvY5zNCJvw4pzrAE7Mbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=npAy4McCgiCUjZmVhzM1iWC24z88EdG1UxhViTzoiK4=; b=L9YLtXE5qhvd7rtbt/mcuNSXt/Z9tAax7z9UE5EflsAuf/H7/1GqTJoGu4MWKYDyM41cMUdugosee/C8LrmrQoRjvEwimeumjfuzsER/+DOgtqGta4UCnP+EFln1je5DH3dQYhFAJDEH1uL90+xdremI1OQLcVlHz+TNwrUurMwutbltCCrcse48yFM+zXNla5dwokkesx2f601YP/9Q0hp9GD19TAmcRzXShbJWRnpKq2643Cb36B6dq/dIXI2dWMp4y4aZjYA2TL8oLaQgiJiXHBJTNH8Im7FCJinP8dQZg5y1sa4evC6jyX/J9cQELoq74ltsL2Vdl3NRny7iPQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5064.namprd11.prod.outlook.com (2603:10b6:510:3b::15) by CO1PR11MB4771.namprd11.prod.outlook.com (2603:10b6:303:9f::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.24; Thu, 24 Feb 2022 00:49:15 +0000 Received: from PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::98f5:edb6:aee6:6886]) by PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::98f5:edb6:aee6:6886%8]) with mapi id 15.20.4995.026; Thu, 24 Feb 2022 00:49:15 +0000 From: "Min Xu" To: Gerd Hoffmann CC: "devel@edk2.groups.io" , Ard Biesheuvel , "Justen, Jordan L" , Brijesh Singh , "Aktas, Erdem" , James Bottomley , "Yao, Jiewen" , Tom Lendacky Subject: Re: [PATCH V6 34/42] OvmfPkg: Update PlatformPei to support Tdx guest Thread-Topic: [PATCH V6 34/42] OvmfPkg: Update PlatformPei to support Tdx guest Thread-Index: AQHYJYgZw7Lo49iRxkijY04W4NG6EKyg8Q8AgADzVsA= Date: Thu, 24 Feb 2022 00:49:15 +0000 Message-ID: References: <20220223101354.u5z5n2zdjkohx6kq@sirius.home.kraxel.org> In-Reply-To: <20220223101354.u5z5n2zdjkohx6kq@sirius.home.kraxel.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7ee4e572-8893-46d6-a509-08d9f72f7b53 x-ms-traffictypediagnostic: CO1PR11MB4771:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: PJ0eXKeCGRPMOZzu1mlwBXhKw4axq9iaJpAy8aSVeQjEf/y3JeWSaEEPWmtL7BdzwzoguPicMca26HxDisZSP7xBO/5suTj74fJRT9YATzQUjNzsRjrJ/2sYpHxpWidJPwsnCJGBO30QRVa1s1/mgwIrX5W4aFIC8PePAv6FkkLSt+YYZ8Y44r3fDJ1RavfvmLJ1K6EsAOf0JRu5EoYgVdVcUU9jrUZtUSOKf7UZjiypCNR+aNinCEUeP3TOTY8trOgOcqJX98hjoDzvXXPlbHGGc55BOK0bm5pygLFW4+J/Z+W712HpJict9vJPBHR5aCZMBupj3y6/c0mhOgOLjIxfJVJ3da3J6sbgvHIqJLwfRm/NqBLcRs8P+lMj6G4ZcmWLr2JBN6HWSTr9DXPf1Vdrs3pKZTWZ92djYFNW7VEt5VEX83bLHBjjbB2UIFRyQOhuBnU71v3j0hBLrqfHVnGw9yOjw8R5pzXAZ+FsuB7PcbjnlWJiWkcAvwsRC2oElPeSjWvJ6lXnVtb/hjqZD7ZVEFYBFk1x4/j0fwE+tE4DrWhqRWD0QNzz9UHprLeiyJFSlJRvpmUwGTFCDyeTsdGX5vnl+od1sTZ1Q6JscT/JFrouN09Ve4Jkbjelrh0YS+/hJ5k2xDaX7yuD6sP9NqaidkWbPaqNSd4TH7C7tRBPmdjUD01qnRdnMhJ4Hujm8fIgumNLjNpCD1EUytlAUg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5064.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(186003)(71200400001)(508600001)(9686003)(54906003)(66556008)(76116006)(26005)(66946007)(66476007)(6916009)(7696005)(316002)(86362001)(64756008)(66446008)(122000001)(82960400001)(8676002)(6506007)(4744005)(15650500001)(83380400001)(4326008)(52536014)(38100700002)(55016003)(5660300002)(8936002)(33656002)(2906002)(38070700005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?TJs1VOmahHInzBlJx6rlJgwhrtfyxfnvVsc1bhZOG25RfNOijxToSkBD4CTI?= =?us-ascii?Q?eSZtAqK+/4ob9t6nbaQWJdFKcWW5HHSu/qAjsWMnJmYQG22jmVo2fPyE9FKQ?= =?us-ascii?Q?bqfBYWQpVWcM9YmH044lYr38XU/C2us0bIDEjsYfaxGwtG8sDKb2G+Nr+AJg?= =?us-ascii?Q?JSW9vmKE4C2y9sJPQXIgbzEzQdoP/lhRr20yjo/wAnK3OvJmUx5/fGC6s3o6?= =?us-ascii?Q?aMZzbmvsggcZzT97+1GlHb1KXqeiTv6gZsOuUyZRzATW47sbIAJfHPhwk1Gu?= =?us-ascii?Q?+Dq421ZognUzjalQmOEo+z9drhoUzfKwGkRgahY6siVu1Q9E4za6iPZh+eyu?= =?us-ascii?Q?NKk/e4xf1C2ps2avgvc8W+iJA5J8muCc/gaF1dI4JcZkqx7h/q1OWPI0nta4?= =?us-ascii?Q?+uVzIfdupGA1w4v/ek0B054W9Acj6HIqFz2mPC5EjWSore9AstD3pnXiRtjF?= =?us-ascii?Q?Yb12mWPdfemZB+HaZKaMNrI/K4+59H5Erli2PKllU+IL1EBx0VdEKN7GyVhU?= =?us-ascii?Q?J1H8WeMf7XdLyatjAKMZBZ83K/0VHR6ZmYDc9TlJdWYl7JQvO/1XpLNOZFEc?= =?us-ascii?Q?9ztoPKSy/LLmWcphN9RIks6mCurLZuWdlsVqPbf+hVkwlUwkI+9CvUAgGtyN?= =?us-ascii?Q?p6nCeQJknIb/5XyHj77G1MniAS4UJv/jkP3pOcOjjljhu6f7bWPrtujXw6ZO?= =?us-ascii?Q?cQSCqGzULJfYefo2Cz0MFGMzr9ggTorGsQ8gO/HRTRzAeGXtfXWz8dVt1/9w?= =?us-ascii?Q?7cEaXvOsPF6Gu+KO4eGncsAQ8tcO/uH7GqACmo44uHovh1taygdpjwiY2faM?= =?us-ascii?Q?lrauDu5Hl6XG5PnQEm6RHAXwxbPHleaZF5ztA/WUhWXkpq7+mBcg6tD0X1p7?= =?us-ascii?Q?uo0IWDk3y8dLImpSX6aWT5R6KMJZhVUKk28Gs6l1kTxayXZgW6DQ8aMpvATp?= =?us-ascii?Q?aAXPz2d5QcTA43ZWCIDIgNhEQe6CktbDwWZuIyMBvb2R7mt+brsCdPkPcmkn?= =?us-ascii?Q?0XWWrhgqeGWCaAce/WFq1IiQad1MleU1n1joLkNMLTYMmTtamPqiJsFAYvQ8?= =?us-ascii?Q?HD3TXP3qz6eubQlyzrIzcROGXm6E/YU6Eb850uvKvbSx3B4cEVxmTlScCYnG?= =?us-ascii?Q?ROA3bpkR53MbC44zB5F6dBqNdDCX4udusIIhTNNGGJaeo6ZvoL1XL6W0Rz0O?= =?us-ascii?Q?gT+zldDtZPowAsb1hd5/llsLQMpfPdHfmV1rdqKNVi7TpQiwY/k+nq++FY8Q?= =?us-ascii?Q?h52MA+BThpSwjsCDHPCrT5SCj6IjXq5sBeP4cMRD7rniuKGBeqKjyPNYqRDs?= =?us-ascii?Q?JVvpOCxXCH/h/mTQ5x2WQ/bLQOoCTd4jZojW4zEMS85lMcoL9IK8+HsJQ+ms?= =?us-ascii?Q?Kd/ELbfihv8szFZf5eSDoUEM2yrNTcJaYL2PIYjVAkK8JmwBk5Zbhn2/SZvl?= =?us-ascii?Q?x8aYJhrUpAoJOuMLjyGAa0LWcub55N6ySBp1lR/G+lGNyQ39L1MbiLYI95g4?= =?us-ascii?Q?/hYIAMmHVExo8py1pVeDu/vhbavoAt6HrLMC99yjVerZvlvdxUNsrrVLv5eR?= =?us-ascii?Q?qZqC5oLxHWB7D0ZhDpRjiuN9ZfgqVLWEpmKhcHHUSOgT/Nod4LaXbI2UKT6R?= =?us-ascii?Q?Wnk3O45oRyXw2eX3W5TgcPU=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5064.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7ee4e572-8893-46d6-a509-08d9f72f7b53 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Feb 2022 00:49:15.3613 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: EGKNDO3zKC0phuaEWvDp3mrwG/GgD+FyIWibPLQyd4hSDebYFACN/GM4iSEJUQChpska1CZVaX2/PtTPDgS33Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4771 Return-Path: min.m.xu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable OnFebruary 23, 2022 6:14 PM, Gerd Hoffmann wrote: > > - Pml4Entries =3D 1 << (mPhysMemAddressWidth - 39); > > + if (TdIsEnabled ()) { > > + Pml4Entries =3D 0x200; > > + } else { > > + Pml4Entries =3D 1 << (mPhysMemAddressWidth - 39); > > + } >=20 > With the PlatformAddressWidthInitialization() update in patch #33 it shou= ld > not be needed to special-case TDX here. You might need a check for 5-lev= el > paging support (mPhysMemAddressWidth > 48) though, or just cap > Pml4Entries at 512 entries. >=20 As we agree in current stage 5-level paging is not supported, I will cap Pm= l4Entries at 512 entries when mPhysMemAddressWidth > 48. Thanks Min