From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web09.6280.1631068195805774490 for ; Tue, 07 Sep 2021 19:29:56 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=jz3vRwHu; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: min.m.xu@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10100"; a="207592520" X-IronPort-AV: E=Sophos;i="5.85,276,1624345200"; d="scan'208";a="207592520" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Sep 2021 19:29:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,276,1624345200"; d="scan'208";a="524547317" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga004.fm.intel.com with ESMTP; 07 Sep 2021 19:29:54 -0700 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 7 Sep 2021 19:29:53 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Tue, 7 Sep 2021 19:29:53 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.170) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Tue, 7 Sep 2021 19:29:53 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XGFacSgtQCLrXQpqq46+tHo/pDZGmT9INq/gdBz12VakTlEqqnGZlCx0fvRuT14YRJZQnJZfoZfp8OClLf9a4TVXULSaP5HY9nzDiTHwQeK+7kZ4Tw91qQ69FkBRHC1xiFYhJH5bqT8kCMZcwf18oL1P9wCRCG9qAb2iUPqaIHF1cQRb/+h+ZTS3ScQgA2xPvpuZzK9KYfZ/PnZiMN6bmhobLUBrrxYLzlyDdU+IS7Xt1F6a/CiWJg92x4Mj4+s+78hqUIXv1dy+oOmHIlFVZUq8YRSgstLjVIHW7bA5a1+PzFxtGwD6dih2X3uwDHmD8cnaZopH+YDVOM8jhwc2LA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=WfoD+3h+0JWNvSn7PCuQ3lRgTbV8RsYSYa8maayo/jQ=; b=l5/aX/XqvVS/RjLnnE0wbv1r4uUYUmFgpDsHeWC8t027/npFyc63vbHrUxjy/DqdSRFDXccWREA7KovtsnMSDyY3xtL+Ns75ksbtxAy94ZZJzCV5RfAXRG/Dgoh5+PpOcKD0i347UBVeIDOBOVrA8FOpOsqBoh6wQubp09OkUfuzgzym0jcXXRUBzq2BHImBT1iGQLpqjFNZikHTxHctaPvx19gbi2srFupOS/1cONJPPKF1zV58UVN/5aQBHCu2Bw4n7AklDHhdVBBZ+JzDOWvo82bn51xGAxe9as8iOuozuoyTKmDqaqp7Mu7a8O0FhGJ0rDxq/cNiIAsHWdWTuw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WfoD+3h+0JWNvSn7PCuQ3lRgTbV8RsYSYa8maayo/jQ=; b=jz3vRwHu4jyvxlxYHbre7sHe+3j5pNpOHE9+HQQQvg0LZniP6s7SO8mQPhXiYZnTcb86ImxY4C5Nhz47wPBgVbNy4HGOqbWjK13xFkfSRJ8JJLTRto07ibuFfNPSPM0qeqn9RvMdiODTKwUfCCs5z6ov2aj8bIaDieJg6opVRn4= Received: from PH0PR11MB5064.namprd11.prod.outlook.com (2603:10b6:510:3b::15) by PH0PR11MB5127.namprd11.prod.outlook.com (2603:10b6:510:3c::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14; Wed, 8 Sep 2021 02:29:51 +0000 Received: from PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::c93:200e:5aeb:e11b]) by PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::c93:200e:5aeb:e11b%3]) with mapi id 15.20.4415.029; Wed, 8 Sep 2021 02:29:51 +0000 From: "Min Xu" To: "Yao, Jiewen" , Brijesh Singh , "devel@edk2.groups.io" CC: James Bottomley , Tom Lendacky , "Justen, Jordan L" , Ard Biesheuvel , Erdem Aktas , Michael Roth , Gerd Hoffmann Subject: Re: [PATCH v6 00/29] Add AMD Secure Nested Paging (SEV-SNP) support Thread-Topic: [PATCH v6 00/29] Add AMD Secure Nested Paging (SEV-SNP) support Thread-Index: AQHXo5E4nsspU/9ZuUepvgCzxphUg6uZZ6WQ Date: Wed, 8 Sep 2021 02:29:51 +0000 Message-ID: References: <20210901161646.24763-1-brijesh.singh@amd.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: edd27b96-4e43-4098-47fa-08d97270897e x-ms-traffictypediagnostic: PH0PR11MB5127: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6108; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: pTomQtzVKhP56RNoX81xteGxUnPbjAdZLQ5aW23gnOc3bwyiUi6mYmrdjHYzdabywiDP49/fyiuhLYyvirsWYvref+1ysBgq6SRvkXKVnF16S5ZNuT6avOK6fSHrs8J0F2Ig460Av7FbfJbhG5aGu/GgMxRyV1CY1P9Rab3RrlFNdxUOoNTtJp+EmVZrZB04Om/yNryyg4rn2LNlGA2QfEfQxNdVF+vBXNFqbzckYYnQrwbJS2Rx0SXcVq6EpLseRgCfApe1ZV9W73AVlInOhdrdqtX9WwV0m1MApRe+HikYa97WSpGaUdN/uq71Md8BxiIu9SNzIye30b9StZdhQYiu3lDgv8jZMWIs/a4IOrXnbgJ8f0BY6cAHpbYW06qUiLoShE9G6qF7cgupbcKX3OKS/aTPUa9ZR95dZ74r+rkUS2vXlecMzkF7GLO5tbFu+CoUi5Vff1nJhshxvjZ7CtF2bJkn5wJbTDa6cgWS+4qD69lA9388nmgI2EhQoO4CQxfKxKRsqis30j1iHgJWGAdGoWDj/URkfHnCpccX+Dtj0qKq6XYosbHb3gqEW62/cXkWTnpFdxWg3B2T089B9nufW6rKuzYQZoHbHvqlekNpJd5H0IUbQENWNt5WeE7l/ZGtIxvT6NuFi8KDY+1WQlyog2zuHRlHUth5NJB385tr90DbvLFM4h6fAWo/qOuNbxqTk7gSBAeS5BRVJNubVA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5064.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(346002)(396003)(376002)(366004)(39860400002)(8676002)(2906002)(8936002)(66446008)(7696005)(110136005)(6506007)(66476007)(55016002)(9686003)(33656002)(64756008)(54906003)(316002)(66556008)(122000001)(52536014)(38100700002)(71200400001)(86362001)(26005)(4326008)(186003)(38070700005)(66946007)(478600001)(76116006)(5660300002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?HjhmpS105pNF2DtmoFui0zvyT8b0kZVFgnrBUUVnQZUDrbXnVr8cPkXjCQ1j?= =?us-ascii?Q?d+wDU4Ve++/c5yIiyLzHemPwEpHWQBCK2EwmHLS70RXVc8LkcLpCY+vlSr9u?= =?us-ascii?Q?ex/H2LU8u1BQdqeon/Z91R7PZwoWa/UrO0LDqfG5g0OQ5dmkoBaXuB8q8pae?= =?us-ascii?Q?tMIkcae50JlnDV/+3VYuO/xl/X2P/Ie0Nurt6SJFvKNVXrstWgi0PMb9h8/d?= =?us-ascii?Q?dhhDFJ5v8JDtnTVsoJsCb2K78hnVFFDRKO92uD5j07Z0snVeLS2r6ozT07Mp?= =?us-ascii?Q?f1xVciObOlFsqrg4js53h6HFaPtMix3gIF51WDZUNmlwUrui3HX9+npVBppU?= =?us-ascii?Q?Tvb4yByyCISt48mxQ4D2huqVy1D/YoHoAqMuUqRnr8NpHhzmDDaYE6yWNdOJ?= =?us-ascii?Q?AttHYsUakBNHj2H8Khsd+EaBDrLAigJkgkW/9ZGRJf+OqRrCS33kdGaTEdBq?= =?us-ascii?Q?lRjpT7olLIphUgC2WDi6+i2XkPDT+z0s4eAfLDGXgO4+DgkDUeVXKBcbL+qn?= =?us-ascii?Q?jA/XnnlM2vSO5U1E2V/sECV1p9IWbIF//mHqmsF7YjrQ+6Irb/pQR7j/clYo?= =?us-ascii?Q?xJKyxaWNjiOQ7eyqL0WoZIAbEvvVeXzrB73zaqVGM9mmtIY+h1Y9pcYhngYu?= =?us-ascii?Q?9wGHrKGcOyNgIaEV4Z0VtAr0Kj/FWaDxNa91eSyc1HDfhofxSDYXr8ajNSDP?= =?us-ascii?Q?Z/e0FHjJIpwcnldMc8+cZ/8MtuNz4BdTKuS0pDDvtyETlobfIqo5ZI6Jsh+F?= =?us-ascii?Q?Wzt75wHZXLzBQ4pcRwuDcB/vX00L/EmKkw50p7DnHbu+nqtROaQ22eu8NsHo?= =?us-ascii?Q?UGdbDXF0Qbs/xvf5jOJmWhvkRzJKITV0m7HF2fBn2LNHXbv9YpDvkh+VtMFV?= =?us-ascii?Q?T1nKh5zxC0/FSGv2CbU26/+NIKgM2nijd4qot7kGy6UIIjwo023wZaV7BsP5?= =?us-ascii?Q?XthsnTXxVyLBVDRx/U5i/H/CoUW0Vd/f7fZeRt1uGkZqCx0mUPIe6bmAm/Ln?= =?us-ascii?Q?Dchd5UAnZs458dUg3Mlxmb240RDd4ZtM7IjYC5bB/k5g5PnJCQq3IZ7N7ekl?= =?us-ascii?Q?WUz8EPuzjfdKQaUGpyFC2ioT2P6pafVyoPtTZf6Vt0ejO5ZZ3Uqm4ybWIM6i?= =?us-ascii?Q?AhUGgtAuCr4G1YNNYCcdz7q5LmO4YvDCumZKTsIXqu2MD5F4yhLlKimqGCBW?= =?us-ascii?Q?u28TIOHeTUUZQV/aFX7ILBTxrEQ3KXp5iDlNNtRchgZFT2JJO7pFMXVrWPV5?= =?us-ascii?Q?Hod0bWrNvCF+USLaZVbnXGntrdZNuNkm9gbiZrEuoMprvmFvdso7YDGLO24B?= =?us-ascii?Q?GQFaNaSKxSB+JUrLIfi07tjn?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5064.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: edd27b96-4e43-4098-47fa-08d97270897e X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Sep 2021 02:29:51.7159 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: MLzCqF6JiIq2s5TnjWO7+3dlZU1nStzTcrDvRCfBT3EEbQxhUO5A3sWPcXiGQuvLb+QVaUum5EnxgCCruiSZPQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5127 Return-Path: min.m.xu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable On September 7, 2021 10:37 AM, Jiewen Yao wrote: >=20 > 0008-UefiCpuPkg-Define-the-SEV-SNP-specific-dynamic-PCDs > I really don't like the idea to use BOOL PcdSevEsIsEnabled and > PcdSevSnpIsEnabled. > Can we define *one* PCD - such as PcdConfidentialComputingCategory? > We can assign range 0x0000~0xFFFF to AMD SEV, 0x10000~0x1FFFF to Intel TD= X. > Then SEV=3D0x0000, SEV-ES=3D0x0001, SEV-SNP=3D0x0002, and TDX=3D0x10000 l= ater. > I really don't want to keep adding PCD endlessly in the future, like > PcdSevXXXIsEnabled, PcdSevYYYIsEnabled, PcdTdxIsEnabled, PcdTdx20Enabled, > PcdTdx30Enabled, ...... >=20 We have CONFIDENTIAL_COMPUTING_WORK_AREA_HEADER definition in OvmfPkg\Inclu= de\WorkArea.h like below: typedef struct _CONFIDENTIAL_COMPUTING_WORK_AREA_HEADER { UINT8 GuestType; // 0 - legacy guest, 1 - SEV guest, = 2 - tdx guest UINT8 Reserved1[3]; } CONFIDENTIAL_COMPUTING_WORK_AREA_HEADER; Can we define the PcdConfidentialComputingCategory like below: ## This dynamic PCD indicates the Confidential Computing Category # [7:0] Confidential Computing Category (0 - Non-Cc, 1 - AmdSev, 2 = - IntelTdx) # [15:8] Sub-Category (defined by each vendor, SEV-ES, SEV-SNP, or TDX= -1.0, TDX-2.0, etc) # [31:16] Reserved # @Prompt Confidential Computing Category gUefiCpuPkgTokenSpaceGuid.PcdConfidentialComputingCategory|0|UINT32|0x600= 00018 Thanks! Min