Re: [edk2-devel] [PATCH] MdeModulePkg/PciBusDxe: Add feedback status for PciIoMap

["Min Xu" <min.m.xu@intel.com>]

On Saturday, January 27, 2024 1:56 AM, Tom Lendacky wrote:
> On 1/26/24 11:38, Tom Lendacky wrote:
> > +Min
> >
> > Adding Min to see if TDX is also experiencing issues around this
> > recent change.
It impacts TDX as well.
> >
> > On 1/26/24 11:21, Tom Lendacky wrote:
> >> On 1/22/24 00:47, Sheng Wei via groups.io wrote:
> >>> PciIoMap () need to feedback the status of
> >>> mIoMmuProtocol->SetAttribute () return value.
> >>>
> >>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4652
> >>
> >> I'm still investigating, but this commit breaks booting all types of
> >> SEV guests. Without this patch, there is a boot device mapping and
> >> the Grub menu is displayed. But with this patch, I receive:
> >>
> >> map: No mapping found.
> >> Press ESC in 1 seconds to skip startup.nsh or any other key to continue.
> >>
> >> and then drop to the shell prompt.
> 
> The IOMMU protocol is installed under OVMF when either SEV or TDX is
> active. The SetAttribute() function of this implementation has always
> returned EFI_UNSUPPORTED, which is now being passed pack to the caller of
> PciIoMap() and thus causing a failure.
> 
> Should the SetAttribute() function in OvmfPkg/IoMmuDxe/CcIoMmu.c return
> success by default?
I am good to return success in SetAttribute() function.

Thanks
Min


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114675): https://edk2.groups.io/g/devel/message/114675
Mute This Topic: https://groups.io/mt/103881889/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-