From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web11.8642.1644308424446283571 for ; Tue, 08 Feb 2022 00:20:24 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=NSlTeykS; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: min.m.xu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644308424; x=1675844424; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=LMvdm8+yFJ7gqA2V+JMpwOKmWbHOfDtZHKR2d4ov/Uw=; b=NSlTeykS1Gqo18+fbZG18SrwBFbSoqM9sI0EnYC6deB7zgtJNG6Us4vm gNVuLxY9F8XdM8wW7W4dpsSIp4nH6mcAGaHz2o1zLpej+n3bS9/HRUPe2 BtxAHOG2sS36rmqkJ67SGva0HaNkVpAK7KTKVdIpx0vZoMYYJxPKdK4f9 X9Rjwuj6d3phLI1NHt8m63p5H+d5qYl5KlZFGcmnzRCNBJFKUCoixBLYw kDsEpjJwpGJURA/X18NmFdwyTeCBOSBcr+ZgIBDWixs+68NgH7e4qvB6B s1zpBOhIyvXp1GXE1zHCcffIXAcnOV/v0FzfdH+EJ3AqeqXmADGk83fW+ w==; X-IronPort-AV: E=McAfee;i="6200,9189,10251"; a="309643634" X-IronPort-AV: E=Sophos;i="5.88,352,1635231600"; d="scan'208";a="309643634" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Feb 2022 00:20:23 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,352,1635231600"; d="scan'208";a="601170150" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by fmsmga004.fm.intel.com with ESMTP; 08 Feb 2022 00:20:23 -0800 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 8 Feb 2022 00:20:22 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 8 Feb 2022 00:20:22 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Tue, 8 Feb 2022 00:20:22 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.168) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 8 Feb 2022 00:20:22 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QcNtJ82DX+HsHowCCb6nIcbLMViL+7Ynt5x5/0PCsjpwZTgGlJ4Cnsbo3aVkn7r92TZ4LHU1hMpylHOWSfbDaXfVdMExi3dgZehP81WZ/aZ4p1qQGAFNVKCaXacZiJtovkISenQipYI0a0qAaa6PIROxnaadnGsKsc/cZEeD2KbKiAz47YFWyMYQlOW/277A+3ct2e5wdODm2Dgpi92OGrhOYhyFqGRpN8QEQuUNUJeWsLoMBEH+Cm+Ce6eFz2t7yWPn7NIqzZY0GMXjjmLVp1ABpTMHsTy4C9Y6sQYgeDPc5q9VZB1NPCYZ/XgE+J+kpxaD0DgWLXzbfI6EIgX5Pw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=h4VX97KDH8nTKjZj31NHS4hg5/lmROaB4dsv3tbYlfc=; b=YwlE3fROJt+TfdpjprH1mbTuG422OKzSGRTDOKoyuT5OKS9ZP4Tuz1GH7IZwSv5/viD/BvQKwsZq34iPM7i6XfuM+QiBOPGPM573gnMQJIL5GGrml7cAA2p6vC9YUOJRpnEC9QdfKBizUYns2EAm8YELaLQLmj8/owRznOCqUcYPqeV6K1MzZEx/8gKr/QHwmf1gCKkKj2YOoLKmWvp0cdqglK+0qbfdUwhWpd2lV1iFoO+DbfBh5LnLST1EmMZFFRLbbtyRfzUZk2vmNbHtWdaSZOXQMqB6T+mpQGTM2vOWqWD8t+Dn5+o683IrnyvXNpx/sG9sPWr0OsBxsfOXgQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from PH0PR11MB5064.namprd11.prod.outlook.com (2603:10b6:510:3b::15) by BN8PR11MB3617.namprd11.prod.outlook.com (2603:10b6:408:82::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.17; Tue, 8 Feb 2022 08:20:20 +0000 Received: from PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::98f5:edb6:aee6:6886]) by PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::98f5:edb6:aee6:6886%5]) with mapi id 15.20.4951.019; Tue, 8 Feb 2022 08:20:20 +0000 From: "Min Xu" To: Gerd Hoffmann CC: "devel@edk2.groups.io" , "Kinney, Michael D" , Brijesh Singh , "Aktas, Erdem" , James Bottomley , "Yao, Jiewen" , Tom Lendacky Subject: Re: [PATCH V2 09/10] OvmfPkg: Update DxeAcpiTimerLib to read HostBridgeDevId in PlatformInfoHob Thread-Topic: [PATCH V2 09/10] OvmfPkg: Update DxeAcpiTimerLib to read HostBridgeDevId in PlatformInfoHob Thread-Index: AQHYEbXXDF+Qh8cRTUSNSApL4sys3Kx25c4AgBJ+frA= Date: Tue, 8 Feb 2022 08:20:20 +0000 Message-ID: References: <20220125063318.862-1-min.m.xu@intel.com> <20220125063318.862-10-min.m.xu@intel.com> <20220127134850.q5rrxeefqyh3yrru@sirius.home.kraxel.org> In-Reply-To: <20220127134850.q5rrxeefqyh3yrru@sirius.home.kraxel.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7fcc5e7e-5335-4381-dee8-08d9eadbd8d3 x-ms-traffictypediagnostic: BN8PR11MB3617:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: bediPscO5FP5VYMe/02yLaJ690IZE8PLcC/KKOYVCa3Pl3mRII3NcpxutuIonqmcjLFHXOBYwUT/8Fn5nyVaG2MBxtQzPVziF79fKCelTK08nIbQ1wWsoP08pbV/7DH/3Ugvo1PR6nZ/pQmnZwU+5RRHcwKsF+wUjyQr2+76ZGszx5xaPgDV869U7Ff0obJf0iuBzz5xEcg82ICzTMuK0aDFZqIlOCWWzG2tUd9oC0G2I1DXXqDt2L0QunV3H3/V7LJ/rn0Q2qxTEz8oXqeYcJnb38ew9a6SzsV80j5GjgpBM42cjLuYs/eckXED/T+wdbcUE2l0L7aAWZaHnxu6YAOCzgX2tp5/8o/7hNFzr6EcoDCpQ72lFjgDD+gTs0f1WZE+FU6XdzFXRKvVnJ5UbVbYdwX3JotsgBhAsUsgewMvxQtYWjuTL7fJE/kIY3gTBNWkTV51kaiizXyobzS2JWNLqRlLRrejTJIyp+2U/grzUzWmENYz37at0UsCigemJl03Y5grAijlT8OJe5pDHbKf7kzgweH8v7peEK2eswARPPMoiYdeSpLfO++ubjbWf20Q391TBLdAXEo91hC3MiWIsUNoddjnOWhSvO7t2mRc4bNfZeGxzMAJyQLdXmoyRw8CTi/cYH6ZkStSxgXbQo6GAAnbHgyHXR75YB9u0kJePJRUyWr+nVOsFjC808B1ggDqCxMlbDK8sjFNmivuWQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5064.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(38100700002)(66476007)(82960400001)(33656002)(5660300002)(52536014)(26005)(4326008)(122000001)(38070700005)(8676002)(8936002)(76116006)(2906002)(66446008)(64756008)(55016003)(66556008)(66946007)(508600001)(316002)(71200400001)(6506007)(9686003)(7696005)(6916009)(86362001)(186003)(54906003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?0Z7/XfwdGevmeZBXdH4xiT9awnl2XuNCD0aHX6+McaoOPpNs3osUFTOJIDqI?= =?us-ascii?Q?SVaVogG7lyghWLfw3W9Bm0+T5SBC+YG7PeG3yzagNI+NCTsPPsTMFZ7a/3b1?= =?us-ascii?Q?h/cL3qPI3Jdgh11IM2QXKjR1f325BozLA/boJYOtocROGbsyOnNCEJZqiHzD?= =?us-ascii?Q?fDasG9rl9vUE7pVk+4RXTld1fIS0VnLlKOoHI5gHN4GjKQwvBrpy7xfF0sc3?= =?us-ascii?Q?ct8LrGLmyiEoVRPkHmZaq7x25ugAr8v35TXoibdzjDoA6mLxtKXnetz+u2pc?= =?us-ascii?Q?bogrJdxb+6aPYHqZCKKrTHHH5v39xvQDyf1saW8SbsHQcfbLjXMZ5rHp7n94?= =?us-ascii?Q?gr64ZqMOpgUZY+5R0yWeWGc0L6rDgV5ezdEOGWRLafcLmO3gbbe9ZNu0wH8Z?= =?us-ascii?Q?FvV+dbC3hwH//LV1CzcRYRWE6QIusG6iwKxOeWuQWoacS4YidtWDFP5Fn7xN?= =?us-ascii?Q?4NaRs06aO81yRqpzRZgpiIXjn6hoZhbpR/RbS4Cf7pt1EEu7JttM8hLv3KkQ?= =?us-ascii?Q?tnmqp5x97tmF6vOWMqJfHC8ifnPxeGMOIRwXyZDFePtWO1Jm+PNYTKCP/dl2?= =?us-ascii?Q?AQxJZljIW184hRE2bc/aMeqTK3JnN2R7zydHIMMClrN6O47CXn8se/dmjegI?= =?us-ascii?Q?jT/MRoEVS/OGko62bheTfFxOckzHlrqVqGsaFSG5X7fqIbsnGcOz8/kMcypR?= =?us-ascii?Q?9xzWzE9kEiYlvw02ZiB1YJMrctnsK96RhqkU6Bk2nTqNiy+RbqQeAIIYWQnw?= =?us-ascii?Q?KynWkvW/ePWp6GDvCvB7BTfL6a6HqqvpDPQUotZilftNXIBp8ACi89Q59AI2?= =?us-ascii?Q?GG4uPcMWyEIecj+fv065R055OiSnVuVZ+AIokkYT2R90w/i0qIR4etBu4X8C?= =?us-ascii?Q?26y3u47F1VV0L6q11LhICCT5daJ1tcJ9zUxhvosyyCb7G9nUm5eiMWPpOnnk?= =?us-ascii?Q?9+QNNhygield9qPgMbVFDo11CvJ81qx71/x6irTVKxtFXzjr5vClj+hh2A1/?= =?us-ascii?Q?6xZnnm8zrjdhPt/RM962itMPOw0/tU2MGzDc+VIqoPMuuyu14/fAezzDHSQ9?= =?us-ascii?Q?ku1jJcwE18RA1lPFCq+mqWwVtQuzrpkK+F1kf9whNKt3HD0Korui1U4tu9zH?= =?us-ascii?Q?+xz4MW/Npc9Dg69Kg68kyo3H1ieGc0da0AGCPqbXezgw8VvNPcchIPuiknPf?= =?us-ascii?Q?Z6Wc+tBCsCVwdTh0ioRHeh498FrSo0FPNM9VkmGUuazl0DgtIsIye1K4n1m3?= =?us-ascii?Q?hxFyWNBrH6W2MGGQf90qVMHoQk1we1idbhoOw63VUwVw2Y5UTaDdXjsZncfA?= =?us-ascii?Q?x39E4EHExNXs2zZAmK8yW5MFV5DoENC8FAOvdU9DSQR7NfgjjFCEhLaqAg5g?= =?us-ascii?Q?W/I7CGXnzn9qDRDvda1ypw7xnADXTrWZVtDbPTOZdPFbMft5RILIiQLX5fx5?= =?us-ascii?Q?9T3XuaL5Y1uRXnlJ+V4YHeWeL3SmTXVDD8Nm4ZqjOP5DiCPMnTrlk9bnGB3q?= =?us-ascii?Q?Tt6oBiU6DjvNI1BXx1yShlZSNsSLgh/LEF7puPA2cj6k2Pp2uYWZwtWvS7eF?= =?us-ascii?Q?CSTZGktW6XhOxuf8YqXimocZmjMIiGHsjjlY8YOzntnwsNNllzSJ7d4h/2Kl?= =?us-ascii?Q?55bofXvFI78i5iDQDiRRjgQ=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5064.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7fcc5e7e-5335-4381-dee8-08d9eadbd8d3 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Feb 2022 08:20:20.5355 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1eVZWqcvnxzPi0WybGIPjM30VFBqL7/0HgTlNpQpLYKj6/WpRpxcgSddqQQasqcxcVBKr3hDPa9LfLD2Rlljuw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR11MB3617 Return-Path: min.m.xu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable On January 27, 2022 9:49 PM, Gerd Hoffmann wrote: > > + EFI_HOB_GUID_TYPE *GuidHob; > > + EFI_HOB_PLATFORM_INFO *PlatformInfo =3D NULL; >=20 > > // Query Host Bridge DID to determine platform type > > + // Tdx guest stores the HostBridgePciDevId in a GuidHob. > > + // So we first check if this HOB exists >=20 > Hmm, wouldn't it be better to create and use the PlatformInfo for both PE= I- > based and PEI-less boot? >=20 > > - HostBridgeDevId =3D PcdGet16 (PcdOvmfHostBridgePciDevId); > > + GuidHob =3D GetFirstGuidHob (&gUefiOvmfPkgTdxPlatformGuid); if > > + (GuidHob !=3D NULL) { > > + PlatformInfo =3D (EFI_HOB_PLATFORM_INFO *)GET_GUID_HOB_DATA > (GuidHob); > > + HostBridgeDevId =3D PlatformInfo->HostBridgePciDevId; } else { > > + HostBridgeDevId =3D PcdGet16 (PcdOvmfHostBridgePciDevId); } >=20 > We would not need that kind of checks in the first place then. >=20 As we agreed at the first stage, only OvmfPkg/PlatformPei will be refactore= d with PlatformInitLib.=20 OvmfPkg/Bhyve/PlatformPei and OvmfPkg/XenPlatformPei will be refactored in = the future. HostBridgeDevId is set to PcdOvmfHostBridgePciDevId in these 2 = platforms. So we have to check both EFI_HOB_PLATFORM_INFO and PcdOvmfHostBridgePciDevI= d. Thanks Min