From: "Min Xu" <min.m.xu@intel.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Aktas, Erdem" <erdemaktas@google.com>,
James Bottomley <jejb@linux.ibm.com>,
"Yao, Jiewen" <jiewen.yao@intel.com>,
Tom Lendacky <thomas.lendacky@amd.com>,
Michael Roth <michael.roth@amd.com>
Subject: Re: [PATCH V1 0/7] Enable Tdx measurement in OvmfPkgX64
Date: Tue, 17 Jan 2023 13:09:05 +0000 [thread overview]
Message-ID: <PH0PR11MB50641EC367D8FEE81D86F711C5C69@PH0PR11MB5064.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20230117112206.duovcai6sar3djkc@sirius.home.kraxel.org>
On January 17, 2023 7:22 PM, Gerd Hoffmann wrote:
>
> > Patch #2:
> > Introduce TdxHelperLib which provides helper functions for td-guest.
>
> > Patch #6:
> > ProcessTdxHobList is moved to TdxHelperLib and is renamed as
> > TdxHelperProcessTdHob(). So the duplicated codes are deleted in this
> > patch.
>
> This is a unreview-able mess. Please create a separate patch which moves the
> code to TdxHelperLib, without any code modifications.
> Should code changes be needed do them incrementally on top if this.
Thanks for the comments. I will re-org the patches in the next version.
Thanks
Min
prev parent reply other threads:[~2023-01-17 13:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 7:40 [PATCH V1 0/7] Enable Tdx measurement in OvmfPkgX64 Min Xu
2023-01-17 7:40 ` [PATCH V1 1/7] OvmfPkg: Add Tdx measurement data structure in WorkArea Min Xu
2023-01-17 11:25 ` Gerd Hoffmann
2023-01-18 1:41 ` [edk2-devel] " Min Xu
2023-01-18 8:04 ` Gerd Hoffmann
2023-01-18 8:09 ` Min Xu
2023-01-17 7:40 ` [PATCH V1 2/7] OvmfPkg/IntelTdx: Add TdxHelperLib Min Xu
2023-01-17 7:40 ` [PATCH V1 3/7] OvmfPkg/PeilessStartupLib: Build GuidHob for Tdx measurements Min Xu
2023-01-17 7:40 ` [PATCH V1 4/7] OvmfPkg/IntelTdx: Update tdx measurement in SEC phase Min Xu
2023-01-17 7:40 ` [PATCH V1 5/7] OvmfPkg: Enable Tdx measurement in OvmfPkgX64 Min Xu
2023-01-17 11:28 ` Gerd Hoffmann
2023-01-17 7:40 ` [PATCH V1 6/7] OvmfPkg/PlatformInitLib: Delete the ProcessTdxHobList() Min Xu
2023-01-17 7:40 ` [PATCH V1 7/7] OvmfPkg/PlatformPei: Build GuidHob for Tdx measurement Min Xu
2023-01-17 11:22 ` [PATCH V1 0/7] Enable Tdx measurement in OvmfPkgX64 Gerd Hoffmann
2023-01-17 13:09 ` Min Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR11MB50641EC367D8FEE81D86F711C5C69@PH0PR11MB5064.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox