From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web11.195609.1673960950104216197 for ; Tue, 17 Jan 2023 05:09:10 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=oKudVbF6; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: min.m.xu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673960950; x=1705496950; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=ldkt0YuM2VODeZICPqxgXZlWPdq0ayhLC+92bqgv/e8=; b=oKudVbF68WYw0Nl9hy+hqNHqS6eguJrvKQmYSmVbECDnUlrKmL7p2ET4 hJkG4LvlrOvlp2BoufoPWAIFezTa6mRXIb8gsDLJUBnLmVVnjGc3btfpP B10I3jH0yazGkUaLBQJzX360g9rk3R937RcDeRqcOW4GyGzPgMehjPH3x CEn9NpGP51Bc5bCHdf048PtVZe5dLi9lxIz4Xw8v3AEtVlio4yd3slATu Gk/pnXiOYfOVizszoKsLvyrkwVvLiCTLrS6ROUwJpAKODuvrVnAHWOWgT aWN00X1mzoQ6JgVx+xB/jIfzcBmykddAfparrJpa0A4gvczr8iV74gxBR w==; X-IronPort-AV: E=McAfee;i="6500,9779,10592"; a="308251224" X-IronPort-AV: E=Sophos;i="5.97,224,1669104000"; d="scan'208";a="308251224" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jan 2023 05:09:09 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10592"; a="748040681" X-IronPort-AV: E=Sophos;i="5.97,222,1669104000"; d="scan'208";a="748040681" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by FMSMGA003.fm.intel.com with ESMTP; 17 Jan 2023 05:09:09 -0800 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 17 Jan 2023 05:09:08 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Tue, 17 Jan 2023 05:09:08 -0800 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.41) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Tue, 17 Jan 2023 05:09:08 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bOcuiUVHmK1h4cVNJ6JUvjp/juT9cyPTw/G0fPcg8huS+S5MOYtBgHgZ9qb70Yg8mrFHz+Ia9yzG8ZMecbaRAIms9aBXMzZD+txO91BKOHo7wvmPqxzy+ib7M7OekrS0d90EdCkikdbi2q1cw9Asifja65Mvxgf6j7bTeA8LmSpwhVFkFpVgfG7MNSKKVGDfjq8m1Q6TtUoqX1nZg6bB8FKADaYlPK3t0RmZCF+g03pGIWIYgDojEk55i/svp+rq40OQCIHK2LQHUr3x7+PBJSNRVSiviNC/PY6l7CqY0GMb1wTHiwHKa1I1LMmXxlMo90yuKhvFNqF7KiVKaU0tQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BaKfg6FiOG39jV8UeEd8o4ltVQ8sbuLn+PJbE6oHVCo=; b=EORshzD2cKtbIPI/Ve7tZsPIe75rHOurhyp9AmaHd1na5ScMlX5IDl1/DI+hkjlgyFc4DzIeFUHPAkpJCeqhMSrKfoF9ccrJhgiQBgAvTPkGSUcuPBUwTQdJvkjVQHO7/LDVOqol6Fd2G3dqrP+v4WFOqXRHt6mgZuiFHnOubEfNZbSI31gQnSEtP7U3CjDod/KI8F16nPGoDRm3iq9Zj3hzGX7Nvm8feGkFcrOU36iyXmt4r+g9LKOgxT1Dsq7QBT9YAJHQabkhc9aibsFP1h8Pq4x9ydr9moB1IlhyOFNSS9TbtdT1n30rhoW6GEq/XoYUPU2ZxLUc2rg70o987Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5064.namprd11.prod.outlook.com (2603:10b6:510:3b::15) by DS0PR11MB7261.namprd11.prod.outlook.com (2603:10b6:8:13d::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.19; Tue, 17 Jan 2023 13:09:05 +0000 Received: from PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::d87:9f99:2db2:43d1]) by PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::d87:9f99:2db2:43d1%6]) with mapi id 15.20.6002.012; Tue, 17 Jan 2023 13:09:05 +0000 From: "Min Xu" To: Gerd Hoffmann CC: "devel@edk2.groups.io" , "Aktas, Erdem" , James Bottomley , "Yao, Jiewen" , Tom Lendacky , Michael Roth Subject: Re: [PATCH V1 0/7] Enable Tdx measurement in OvmfPkgX64 Thread-Topic: [PATCH V1 0/7] Enable Tdx measurement in OvmfPkgX64 Thread-Index: AQHZKkcCC4Z6676TNkqcZ4ca+s7rI66id04AgAAdmGA= Date: Tue, 17 Jan 2023 13:09:05 +0000 Message-ID: References: <20230117074016.1056-1-min.m.xu@intel.com> <20230117112206.duovcai6sar3djkc@sirius.home.kraxel.org> In-Reply-To: <20230117112206.duovcai6sar3djkc@sirius.home.kraxel.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR11MB5064:EE_|DS0PR11MB7261:EE_ x-ms-office365-filtering-correlation-id: 47b46d60-ee52-49fb-fc6d-08daf88c02e6 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: okwAUQtCOot+IOTlwBzT6W04ZW9+RMAIF8Z3ys4Za0nncWCG1Y8o2+8wxmN8AaRpJW7/jAszg2FrVO3gHb+OdH8uYL0juWqrZzyH0wNZKZ4YZey7XR/Crgy/J/GhO/FMBB/5aHgEcEWLOT8oC7BAmy2sUroMebMI2b+pVHaCWccRn0f7B5JXvfEkYfqDUo92wKv09/Hu7/9FoY8bkRtiUo5JSHTdt8lWDfOFJExNSipqqh5aMGO2Zbb19sTowr704qK90CdCdt2HevzxtTEq4IMNWCv5a61KG7im79oiziOfhqIWKvTGzCUk3+UAfpdIO7E/jHiLYws4lYgJuJTi970NO/FHamWDovBHKh1BB6T1fjQPRHKwigw/JsAwskvrmiS1qTU+7Tk28kUnLGwpp3a25P0TGw4vVmF4xpGA2ZDxLGjBmj7i2/nRAHuQNZuULkJItNFOMMQCrPDKdYphQB2imiYNEgNNmuK+zu8loX/U0vOZeXcKqvQAAIJRG7fKPC5MVr8vROHvLS74z3UONmSB2jUwXNBBA9nE46cqYRiZZT60HV4nzHTvwfnYb6Yy9aNNVxKstPH741wmKZDXWUh9ICqRj8lpckzugksUB9fNE+1/34g4v+Ss+ZYd9ISeFoehdWjXwSw4bT0MwaEnGoyBx0fKjsBexI0jJc3zZ0YvaubcPDRXZQuAR3ovcU4KzvD0dezD0uXXG3I471IE/Q== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5064.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(136003)(366004)(396003)(346002)(376002)(451199015)(82960400001)(2906002)(122000001)(38100700002)(86362001)(55016003)(33656002)(7696005)(316002)(54906003)(6916009)(71200400001)(38070700005)(76116006)(66476007)(4744005)(6506007)(66946007)(41300700001)(64756008)(4326008)(8676002)(66556008)(66446008)(5660300002)(83380400001)(8936002)(478600001)(52536014)(26005)(186003)(9686003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Ea1m0OdR4Fw3wI1fDMcyHKhT26Wqrok2lEfhdVraNpj2UckG9EH2oJC1wnpd?= =?us-ascii?Q?pRQCmScjSobep11iweiQnt/dwebj0XCybNgh48ly8ntoB8Ttcm8K/6wsUMIv?= =?us-ascii?Q?v2tH+/yOjkcNc/5Kq/cpUHpvUW6R26eIhMn4CFnX6iERWc4wUtQw/Rd6HV0m?= =?us-ascii?Q?kwGVge9lHjfZgAtdvsv/0qTyA1T7/aK1WZYr2a2ALlRp9tKlqOILiP1OGYND?= =?us-ascii?Q?cDgBMGDOgsJl3yx8hwgSX74GM+fg8hEpNYgYnG8p1QV147AfOkoNPC+RsNbf?= =?us-ascii?Q?VqN5yPN/IqmoLImG9sS+MkO5kDROomIkz0w4w5TgQY+z8EqFCblIjjBQjuqn?= =?us-ascii?Q?FrCIc9VHXu25kcDjzsKaROJZLDOTtHfg7zo+06XwoOX4BYIOsofqs7Gu+v6u?= =?us-ascii?Q?M09KfDXfHGTJnzxKPrR9sIRAXubaTyv2QmAH89P81W+KTUmJVOpebq91r8Eh?= =?us-ascii?Q?+ib9EQY1oXOrnj0CZv8pOO8V+M71BYR+joWSZp2wjfPfaVS/1mhx5Fq5/Ry7?= =?us-ascii?Q?Rwdk4TEKy8DMkrrFscYSnV3V766mRtK10uYthOGsCzN3oFBKuds7URK/Z5Ll?= =?us-ascii?Q?WDsUQOCls70xCG/42uU8Nb6bNpBTSU6Bauja8Y4mhSwfqCXuj1t3ipSfn3Ha?= =?us-ascii?Q?LHhOlW35oOEik3wIB1mz9gx1NVyWpM5WQUxfL0oVqln8QjFQwMrLOe+wL9FR?= =?us-ascii?Q?7rl060psjrprYhrfwfKlShv93hAu1s3NGrpJ0WGZhZBdcnX6OiHB2+R87Tqt?= =?us-ascii?Q?MyDpJZHND32P3Mx05dofXOC2BFnuULv3uVa9e8QvHsGz1agNYEQaVXHmlS+a?= =?us-ascii?Q?ljT70hpLAzXnVfHNcVv/0CS7WPaKV+qUQgrwga6YP/3fdvarCGeeSCuKxkmL?= =?us-ascii?Q?7XrRZqvm0ohJ5672pYNGIoAK6h/kFQJx2VSAOcJgrcVzFpovM2llKFOOnZu3?= =?us-ascii?Q?45lf4VDkNmGySXw5vPdJjWWaLT1wFfHNqqdL44vTuhdQ0sUJDmf1ufIrn8TQ?= =?us-ascii?Q?cmxXU7Orh4IXJpT4o4jmq80JBO0aYKswiD5bEpdLfzmW7ieEgV884Ujrk8Hz?= =?us-ascii?Q?BvNE5iQ3kiTP286KJ4d25ij2YeSMD05VGLPMLxVW1EhT7loieEDmz5Xp9Qrq?= =?us-ascii?Q?pfxxUTl5R//vU/X+wQgA2No2/+qUJX0xSAArVmLpKdbHHF5lR4ooa0KPKMZc?= =?us-ascii?Q?nEfgO3QRPBx8OV/DUd4KDwuNSBuy+y0idEjndh4lvJRezr5WcM4U0dfpPZnl?= =?us-ascii?Q?6qzwPA1mhmKKAttorqiUUmpvXiVVtiHQls/K3AhLxtXYQ3IKebiaF69sQmyy?= =?us-ascii?Q?KI7+Yf748MQOb09auAymPf/MPxeyN1Ye4wLcq1dtjDOb4AftBhm+CCalnvsx?= =?us-ascii?Q?hu11V1w1RzkrteQJkevVMzuzBi3bnBhBF7i1UpQcfJNfN/AtU+UimrTo3O19?= =?us-ascii?Q?XznZHwvTuqNp2Idg1JFdLQ7C+wJzhVSPF2cqv9weUcOHmIGXmyvNAvDAg8D8?= =?us-ascii?Q?lMClNNLMdvB5Y7VFWRJo3QYkcjiSMJZMFDLols5GpGPWAEoEtg41bhN0LLMs?= =?us-ascii?Q?q16097vrdRhgW0bpGISFdBlMmhPQmr4H0wDMGstQ?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5064.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 47b46d60-ee52-49fb-fc6d-08daf88c02e6 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jan 2023 13:09:05.3523 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: KPSeqnXK//DTLXcPQv1x/2nJ6IWtDdzL7q2p4Yh7xjObhfazh6V0RU9pwDNuC4myk1Ek86xbGVW/RfMl2u/eYA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7261 Return-Path: min.m.xu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable On January 17, 2023 7:22 PM, Gerd Hoffmann wrote: >=20 > > Patch #2: > > Introduce TdxHelperLib which provides helper functions for td-guest. >=20 > > Patch #6: > > ProcessTdxHobList is moved to TdxHelperLib and is renamed as > > TdxHelperProcessTdHob(). So the duplicated codes are deleted in this > > patch. >=20 > This is a unreview-able mess. Please create a separate patch which moves= the > code to TdxHelperLib, without any code modifications. > Should code changes be needed do them incrementally on top if this. Thanks for the comments. I will re-org the patches in the next version. Thanks Min