From: "Min Xu" <min.m.xu@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"kraxel@redhat.com" <kraxel@redhat.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>,
"Justen, Jordan L" <jordan.l.justen@intel.com>,
Brijesh Singh <brijesh.singh@amd.com>,
"Aktas, Erdem" <erdemaktas@google.com>,
James Bottomley <jejb@linux.ibm.com>,
"Yao, Jiewen" <jiewen.yao@intel.com>,
Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [edk2-devel] [PATCH V5 22/33] OvmfPkg: Add PlatformInitLib
Date: Fri, 28 Jan 2022 07:14:13 +0000 [thread overview]
Message-ID: <PH0PR11MB50641FA8256BED1E38D9BF7DC5229@PH0PR11MB5064.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20220126130403.ygra7qoqnl5r3vav@sirius.home.kraxel.org>
On January 26, 2022 9:04 PM, Gerd Hoffmann wrote:
> On Sun, Jan 23, 2022 at 09:36:53AM +0800, Min Xu wrote:
> > RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
> >
> > There are multi-variants of PlatformPei in OvmfPkg, for example,
> > - OvmfPkg/PlatformPei
> > - OvmfPkg/Bhyve/PlatformPei
> > - OvmfPkg/XenPlatformPei
> > These PlatformPeis share a lot of duplicated codes. It makes
> > difficulty for reviwers and maintainers.
> >
> > The goal of PlatformInitLib is to wrap the common functions in these
> > PlatformPei. As the first stage, below functions are included:
> > - Cmos functions
> > - System memory related functions
> > - Platform initialization functions
> > - Hob functions
> >
> > PlatformInitLib is designed for SEC and PEIM. So global variables
> > cannot be used to pass information between different functions.
> > Dynamic PCDs are not available either.
>
> Can we please reorganize and split this and the next patch into smaller,
> review-able pieces instead of two 50k monster patches? Possibly it makes
> sense to split this into a separate series.
>
> Specifically changing code and moving code should be separate patches.
>
> I'd suggest to struct the patch series like this:
>
> (1) create an empty PlatformInitLib
> (2) apply code changes needed to make the code usable in sec
> phase (one patch per change).
> (3) move over the code (without modifications) to PlatformInitLib.
Thanks for the suggestion. I will create a separate patch series which including PlatformInitLib and the refactoring of OvmfPkg/PlatformPei.
Thanks
Min
next prev parent reply other threads:[~2022-01-28 7:14 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-23 1:36 [PATCH V5 00/33] Enable Intel TDX in OvmfPkg (Config-A) Min Xu
2022-01-23 1:36 ` [PATCH V5 01/33] MdePkg: Add Tdx.h Min Xu
2022-01-23 1:36 ` [PATCH V5 02/33] MdePkg: Introduce basic Tdx functions in BaseLib Min Xu
2022-01-23 1:36 ` [PATCH V5 03/33] MdePkg: Add TdxLib to wrap Tdx operations Min Xu
2022-01-23 1:36 ` [PATCH V5 04/33] UefiCpuPkg: Extend VmgExitLibNull to handle #VE exception Min Xu
2022-01-23 1:36 ` [PATCH V5 05/33] OvmfPkg: Extend VmgExitLib " Min Xu
2022-01-26 11:24 ` Gerd Hoffmann
2022-01-23 1:36 ` [PATCH V5 06/33] UefiCpuPkg/CpuExceptionHandler: Add base support for the " Min Xu
2022-01-23 1:36 ` [PATCH V5 07/33] MdePkg: Add helper functions for Tdx guest in BaseIoLibIntrinsic Min Xu
2022-01-23 1:36 ` [PATCH V5 08/33] MdePkg: Support mmio " Min Xu
2022-01-23 1:36 ` [PATCH V5 09/33] MdePkg: Support IoFifo " Min Xu
2022-01-23 1:36 ` [PATCH V5 10/33] MdePkg: Support IoRead/IoWrite " Min Xu
2022-01-23 1:36 ` [PATCH V5 11/33] UefiCpuPkg: Support TDX in BaseXApicX2ApicLib Min Xu
2022-01-23 1:36 ` [PATCH V5 12/33] MdePkg: Add macro to check SEV / TDX guest Min Xu
2022-01-23 1:36 ` [PATCH V5 13/33] UefiCpuPkg: Enable Tdx support in MpInitLib Min Xu
2022-01-23 1:36 ` [PATCH V5 14/33] OvmfPkg: Add IntelTdx.h in OvmfPkg/Include/IndustryStandard Min Xu
2022-01-26 11:26 ` Gerd Hoffmann
2022-01-23 1:36 ` [PATCH V5 15/33] OvmfPkg: Add TdxMailboxLib Min Xu
2022-01-23 1:36 ` [PATCH V5 16/33] MdePkg: Add EFI_RESOURCE_ATTRIBUTE_ENCRYPTED in PiHob.h Min Xu
2022-01-23 1:36 ` [PATCH V5 17/33] OvmfPkg: Update Sec to support Tdx Min Xu
2022-01-26 11:53 ` Gerd Hoffmann
2022-01-28 6:20 ` [edk2-devel] " Min Xu
2022-01-23 1:36 ` [PATCH V5 18/33] OvmfPkg: Check Tdx in QemuFwCfgPei to avoid DMA operation Min Xu
2022-01-26 12:06 ` Gerd Hoffmann
2022-01-28 6:45 ` Min Xu
2022-01-23 1:36 ` [PATCH V5 19/33] MdeModulePkg: EFER should not be changed in TDX Min Xu
2022-01-23 1:36 ` [PATCH V5 20/33] MdeModulePkg: Add PcdTdxSharedBitMask Min Xu
2022-01-23 1:36 ` [PATCH V5 21/33] UefiCpuPkg: Update AddressEncMask in CpuPageTable Min Xu
2022-01-23 1:36 ` [PATCH V5 22/33] OvmfPkg: Add PlatformInitLib Min Xu
2022-01-26 13:04 ` Gerd Hoffmann
2022-01-28 7:14 ` Min Xu [this message]
2022-01-23 1:36 ` [PATCH V5 23/33] OvmfPkg: Refactor PlatformPei with PlatformInitLib Min Xu
2022-01-23 1:36 ` [PATCH V5 24/33] OvmfPkg: Update PlatformInitLib to support Tdx guest Min Xu
2022-01-27 10:11 ` Gerd Hoffmann
2022-01-23 1:36 ` [PATCH V5 25/33] OvmfPkg: Update PlatformPei " Min Xu
2022-01-27 10:16 ` Gerd Hoffmann
2022-02-17 8:43 ` Min Xu
2022-01-23 1:36 ` [PATCH V5 26/33] OvmfPkg: Update AcpiPlatformDxe to alter MADT table Min Xu
2022-01-23 1:36 ` [PATCH V5 27/33] OvmfPkg/BaseMemEncryptTdxLib: Add TDX helper library Min Xu
2022-01-27 10:18 ` Gerd Hoffmann
2022-01-23 1:36 ` [PATCH V5 28/33] OvmfPkg: Add TdxDxe driver Min Xu
2022-01-23 1:37 ` [PATCH V5 29/33] OvmfPkg/QemuFwCfgLib: Support Tdx in QemuFwCfgDxe Min Xu
2022-01-23 1:37 ` [PATCH V5 30/33] OvmfPkg: Update IoMmuDxe to support TDX Min Xu
2022-01-23 1:37 ` [PATCH V5 31/33] OvmfPkg: Rename XenTimerDxe to LocalApicTimerDxe Min Xu
2022-01-23 1:37 ` [PATCH V5 32/33] UefiCpuPkg: Setting initial-count register as the last step Min Xu
2022-01-23 1:37 ` [PATCH V5 33/33] OvmfPkg: Switch timer in build time for OvmfPkg Min Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR11MB50641FA8256BED1E38D9BF7DC5229@PH0PR11MB5064.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox