From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web10.4231.1643354059115995615 for ; Thu, 27 Jan 2022 23:14:20 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=LXFSF6Up; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: min.m.xu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1643354059; x=1674890059; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=VBDUNkghJQAMQDdvbuIcw6FOOSVTot2jntS/5OuXrL0=; b=LXFSF6Up/j5/vWQlq7buDOK7LRrPzMHUS0gyelFj71/qKcDTiHLx80I+ Bo56XWSMYXtn6/K4X5tyLR6gRbWwhW6Z4DtvAifHvM32kL/H5PL9ql7Mr 4Fvvv/+fP5gUWu0vEk5xKNyZomFp94iYrmgCnOTtyXtxUMG1b+9+GPy9J Pbt750LJHhKc+f+mnfyRSDSM7IYCIQ+hvwy30NwbLERmSVpK3MQ/+n4UC xUvhJ/iZ1s35kOjU+P5bd+wfKbePxRubISYrAUNNwJixmShMGFmA9hTT2 G0MPaGFXBbZkkAuXQOAKmJwgAtzkcWpjAnKccSYRSVh1x/r289NbcS367 Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10240"; a="247011532" X-IronPort-AV: E=Sophos;i="5.88,322,1635231600"; d="scan'208";a="247011532" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jan 2022 23:14:17 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,322,1635231600"; d="scan'208";a="496042534" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by orsmga002.jf.intel.com with ESMTP; 27 Jan 2022 23:14:17 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 27 Jan 2022 23:14:17 -0800 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 27 Jan 2022 23:14:16 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Thu, 27 Jan 2022 23:14:16 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.46) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Thu, 27 Jan 2022 23:14:16 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XyXzdW4C+juIpWUTxsOBowLrsT22XcbGsaJry8tuDMZs4BOTxTcapM57UYsvyTJbIJPlYCJzk6t7qPc86kxIBL86XkNbVtZy/MqWqLxhVSWsoos/XD7BBfhtXlL5r1p/aBF0THpxkIdo9IrEciGFjsgTyNmKayA1DGJnTPu6hCAHPtPvmez1FZGoQH+ozQR/BofhD16LPhyfZnmoHczGtDQdcfTmvFAHeCXO7noK739YqJ1yDUDJZcN7ABrlrq7titUo20WqurV6T4LZReebWPLqoT+1FsxOqLQjyxO7tUKsZzD358gyyWmhfxCiKze7HZ5wb+qDpyAtYkc1kijC4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fKSyh9TLoJen8E8ggyokHnVBIEHd1p8I8b8u60M1T24=; b=M5lAexOwaEt4jOB2J8OpSsuXR7/WsY62p4tgz97SKIeZY5VfMAgo3ABLFdejoi5MUSS/9CTcIURYVDceWFRUvb+YHYtwgZx8XUKRPzZev5CNBuKVQhqQHQ16v2AgW0SImWl6MsUg3Hb96zlXyNfAokzCvMjJUtEEo8hqQFNKUDAlAU7xZinindnPSNFunE5IzZ0EdOfdDWpSDiq4b2mO5vI1YultirWjCCAKREkAFGG0PxbvTzoF6TLUebIAYHTIML9msR5a35pXC1vEJdJPPoGhu8aYwvCWZFl+/vTlfnASXahaKsIrM1Xf79seivPb3isS0Vt4lun/tKsZyRzkxg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from PH0PR11MB5064.namprd11.prod.outlook.com (2603:10b6:510:3b::15) by DM5PR11MB2043.namprd11.prod.outlook.com (2603:10b6:3:e::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4909.13; Fri, 28 Jan 2022 07:14:13 +0000 Received: from PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::ed65:b010:fc2c:f48c]) by PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::ed65:b010:fc2c:f48c%7]) with mapi id 15.20.4909.019; Fri, 28 Jan 2022 07:14:13 +0000 From: "Min Xu" To: "devel@edk2.groups.io" , "kraxel@redhat.com" CC: Ard Biesheuvel , "Justen, Jordan L" , Brijesh Singh , "Aktas, Erdem" , James Bottomley , "Yao, Jiewen" , Tom Lendacky Subject: Re: [edk2-devel] [PATCH V5 22/33] OvmfPkg: Add PlatformInitLib Thread-Topic: [edk2-devel] [PATCH V5 22/33] OvmfPkg: Add PlatformInitLib Thread-Index: AQHYD/oPlv1Ic8k420usY6V+5ctfJKx1Sm6AgALCO1A= Date: Fri, 28 Jan 2022 07:14:13 +0000 Message-ID: References: <20220126130403.ygra7qoqnl5r3vav@sirius.home.kraxel.org> In-Reply-To: <20220126130403.ygra7qoqnl5r3vav@sirius.home.kraxel.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: dcc3e64f-03d4-40bc-d512-08d9e22dc9de x-ms-traffictypediagnostic: DM5PR11MB2043:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: n6DEf2yvJoiTG3KEUyIoGpYTPW36vXdOUP13eMabEqDNARg2Smar9ThvfJe3FFG3HbyR+ZP3iy0jcaLI75QkobmLyrEOxSmq3QB3ZUdYFL4MhvFwFNFzUCbyczGWYbQEeUS3QDjiKIg9GpLgGKip/sB1NVmJmiplxBLnaGMU5qEWHuQz1IunsMH9NBadjYGAHHZTqyGriaj9kiiUk41bas4RO4iVlbhHWocHdP2ViXEiTXBx92pL554n0BoFOZPcW6yNXx50s09SXYUmFX/tSOgmPCVyhu8aaNntLZVJaxozvH5JSd4KqOjG/gWRNkJuFN2U7TvzlT2Tz/XrJ7YHsjic387DooJwhdCAJ/wXmtRnmf94alYJTQXPH6RTiC6WqakkYuttny6s7MSCLiWHOPXnHP57YEaI0YfQ4TKQerKt9fqcmpR/qazv/g2yTgwNy5xLCKZ+7suBLuNAoom/ycKepx/+VRD/jSFtQDLKIrFFAeS9esVOm7BhVmtRkOTQKcCFI1pTfiqK3fqLNrRrLmlgOCczlwMqP/Lny7uzOuIMvT1EvArFPxL4O67Z8i9ro2y7NpIDwPM1tzijfbqHsEC23m0XE8MlYNr2/lj+xzl2g4rEgc8A+jiHu9vZreHFDnLdsiFZWSiHIiQd/YjAPuR72y30AmPxUYoQwll14ot/Oc3I514UGFP3cV5v1DrZ5SENO8YLrTwmrCwYzuT8L7sJuiNTJJNmYAvpzkzNGuAqWqi1O3KJ89NAd6jQN4cg7UuaWAONTNIYsTplaMEjJtw/evFPGOsCScCEtLLSo+4= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5064.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(316002)(76116006)(7696005)(8936002)(508600001)(33656002)(66556008)(66476007)(71200400001)(66446008)(64756008)(55016003)(26005)(38070700005)(9686003)(6506007)(52536014)(86362001)(110136005)(5660300002)(2906002)(38100700002)(122000001)(54906003)(82960400001)(966005)(8676002)(186003)(66946007)(4326008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?WHg3Z05lmMIMr6L6+Cy+D5pxs9zlLicxFiMOkYUKDOuH/7GsebOH8bMZZ+hv?= =?us-ascii?Q?moibwlH3cbZWOyZpPFbHil9NMR/mNZbU7IISVMVXZh7+me2LiJxd3hE6b5MO?= =?us-ascii?Q?KMlsSBYis1G70/sYqkIsojAigbgRiC+2ghb/y11/2qn7pXShxW0nSwHifwmZ?= =?us-ascii?Q?wIE4Xz1LQKwvgiC8e74T4NVl1/oSORP06PVtsKXIvi/m4HnzINwhWJBqGQS1?= =?us-ascii?Q?+I+UKNq+0xtNDx9uCG4rMwgr5tqavY2lluCbYABjjd7JQpScvUCpnqwsOXD3?= =?us-ascii?Q?qnxGjb9rtxQOPss5m0h13WODyjzSL0IMNwUvb+d7kqoi519LcJXBmslrOH/D?= =?us-ascii?Q?EwHvO9Nc2++QQioR58bAis2YHdyxrlyOO1eVCVyAAP5WBDthgmkXefB4nAWq?= =?us-ascii?Q?ASpSeuQQL9ro3/Crm1QKofUrELGs4gdwqvI9y3kwg7+4inAjqcp+85szJrwT?= =?us-ascii?Q?GWIW9nNVDDG+eiJP24yrevVfg2sRAkOK/GBIQ/y0EYGkNNxQW+B57Fw5gNoY?= =?us-ascii?Q?MSlaFNHYnyt69iAlNqMiwkPRjdnxPypOe3gqR2ZNMxoayiUlaAs/5ALumslV?= =?us-ascii?Q?CdHzpHsv2UWrAMlhZ55rdHNibsDxxhIwUyeTn6yNPHOTFFu/bNGMaPiaReBk?= =?us-ascii?Q?LOA+ojXtYj6OXt+bPtmfc0ZUbMRe9XQihubwxFA/zaZopOvDj6MsGvn/IokS?= =?us-ascii?Q?sRys1OI+D3Uo9UREtnaDd+BqyqSsMwVcJXOyCoG7zSWG2Lt0x23MiRALZw4g?= =?us-ascii?Q?j/d9T83eSQ6TWZ+qpyjbqcl+rCFVVAebwPc8vDgGY4p1jIHiwnJOsTRprMDP?= =?us-ascii?Q?gNlBRB8CT6I3Q3Eirf6guBaSkAFzDfpMjk77L8Rb4xWgdEwU4QldE8kfh2P1?= =?us-ascii?Q?q83qHTHzV0mZmnoTnFLMQFXBDXw/RD6A8FdHEY5NpmS9G0Wrv5NLX7R57UhU?= =?us-ascii?Q?6ZQrkVIw/gRWNaQvk3rXn2WIMAimmw2W1T0nTpKBUu/LkX1NvN2WrgleUuWU?= =?us-ascii?Q?fWO3ExNNzrSgg/VdzNe0HChpJrfSZntMocL0GCoJ7ju3bigumQxMkrpb2dfR?= =?us-ascii?Q?0PkWwbaXnBgDtUKyQ1YH0jyWaSUrEvwKbdBLjcwAP4e5WJCTREqyP9BPPBZF?= =?us-ascii?Q?EyrPQ67tdmK/df1OdymTPUQwzSNQV9I5RqNuGz58IqDAOKL7cKfSXZV3P67B?= =?us-ascii?Q?4e/MfrvgXJ2VefNasJTbu6l7WggzOoapkyH1zS/bGcLid7iqSponck45DZ96?= =?us-ascii?Q?BZcBFAGz89pl7kxueo2E2hni9KrCGqPC48blmUHcYLWFZRlgwx7eK0TBTTdP?= =?us-ascii?Q?O3PgzcsDs+Soq+N718hXFkhKLmRfVU5tIDMOLxSF8fRjn2LeJBD5Ehai0+ik?= =?us-ascii?Q?tb7H1/bpLvfKM1WPUppVUPwh+Z1k7Dz0vDf22KV96IbjncV1SZq8gMBH75z9?= =?us-ascii?Q?BxCvdayHGLax3TCSDp+fGeMZ/GwUxxx0hzHct2Z6eP4IkVYTDa34tjPjvbsc?= =?us-ascii?Q?afVbBXK6PvbNVuvlHELJ0SP2skHnapgdls4fKBElm5T2gwrEluGr32reRf0q?= =?us-ascii?Q?xdyGd8Jh/WoRR+C9+aE9qoTNUga8GKBhdVTGvKZgKd1iXFvtrp8Yxu3TpHJV?= =?us-ascii?Q?+k2FJ1+WV0uXfhnz/PPn2Zk=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5064.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: dcc3e64f-03d4-40bc-d512-08d9e22dc9de X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jan 2022 07:14:13.6928 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: VtlAiDuQQcGvCmzXehW8Kb0fzd3RwnvhIiHo8cYxyXPOZg1+3aajJvPGVyht6+YNT/gCFG74id31lNqwdlaFVA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB2043 Return-Path: min.m.xu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable On January 26, 2022 9:04 PM, Gerd Hoffmann wrote: > On Sun, Jan 23, 2022 at 09:36:53AM +0800, Min Xu wrote: > > RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3429 > > > > There are multi-variants of PlatformPei in OvmfPkg, for example, > > - OvmfPkg/PlatformPei > > - OvmfPkg/Bhyve/PlatformPei > > - OvmfPkg/XenPlatformPei > > These PlatformPeis share a lot of duplicated codes. It makes > > difficulty for reviwers and maintainers. > > > > The goal of PlatformInitLib is to wrap the common functions in these > > PlatformPei. As the first stage, below functions are included: > > - Cmos functions > > - System memory related functions > > - Platform initialization functions > > - Hob functions > > > > PlatformInitLib is designed for SEC and PEIM. So global variables > > cannot be used to pass information between different functions. > > Dynamic PCDs are not available either. >=20 > Can we please reorganize and split this and the next patch into smaller, > review-able pieces instead of two 50k monster patches? Possibly it makes > sense to split this into a separate series. >=20 > Specifically changing code and moving code should be separate patches. >=20 > I'd suggest to struct the patch series like this: >=20 > (1) create an empty PlatformInitLib > (2) apply code changes needed to make the code usable in sec > phase (one patch per change). > (3) move over the code (without modifications) to PlatformInitLib. Thanks for the suggestion. I will create a separate patch series which incl= uding PlatformInitLib and the refactoring of OvmfPkg/PlatformPei. Thanks Min