From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web11.32600.1634538365876232566 for ; Sun, 17 Oct 2021 23:26:06 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=DqehQ6xy; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: min.m.xu@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10140"; a="251633926" X-IronPort-AV: E=Sophos;i="5.85,381,1624345200"; d="scan'208";a="251633926" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Oct 2021 23:26:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,381,1624345200"; d="scan'208";a="717402497" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga006.fm.intel.com with ESMTP; 17 Oct 2021 23:26:02 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Sun, 17 Oct 2021 23:26:02 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Sun, 17 Oct 2021 23:26:02 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Sun, 17 Oct 2021 23:26:02 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.42) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Sun, 17 Oct 2021 23:26:01 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dTrklubul2s7nQy/NqpRVUeX+VYpya784khNsOnl2WH4Odh1C0D9rMEai/4V58iOILTt+N645O9GPbgSNsESv0bY/Ru8iBiJ8X2sZj9VJOVOjl8jkIoPTzMgSXsNO3Ezn4AQ+lLFHVcXjbZpJ7zt3/eqsOUkcwZ1y+V/j/YKwWZG8DEDtQlgsEd/Yhb0cDfDyNYrF/Y74A9Zt1CTRYiouo2nEagJaSuFEmKf+dMU0vNOaWmL5Y6ppeqywk9VRqeFRivVGxdBa9qVVFq6EF+yKBg5X/36GsDxwdgzqM1h6MmPpHS0QTzGt9DV1N09iRd4F8fSLSZv778NYoatLZq9fg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=o/d2D3fMbPNkcVGANSoVDoDLNyAxI45Mj8+qtFjheM8=; b=gMksBCLN2IAjvz6sG4U0Jxs3bPRvRg+MBD3whzEyAh4z3U2oYsF2qw9dJ4DdcYmJ5CB74uSfhaT63Fc1jSdhFb0oNDRfEWnWjJorgSQft7P1tKqlhNxj5HAVBVwaWQ8SQbua66sMk03sQXNWv0SyJxar4NdlV+RxoROFnveRQB3OKP8w07hkwGhSojxDgachUqoRiww//iUHRAQC0ic3zZyL/5JaKrkg/m4B9IiC3gc7PVF8wX1naeSzhVTXZnDdWE/dd1epA3FpjSsskylYLIt3HaOIQm/AQdYXlUlmg061KDtR9VFQ5VenHraAXJAZ3q9jG3+JF1zAunLrELNlZQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=o/d2D3fMbPNkcVGANSoVDoDLNyAxI45Mj8+qtFjheM8=; b=DqehQ6xyfBxdg09tlJENi4rxhU4SpMKKyol2n08+sYZtqgw/qrw7kiSS5blFjE2IY+EVxooKoYMKLiDMKuE18ainiVq35wKSEumsUaQnAviVUmx9fwkGW5E9V5ZbrZOxdp4feS1Tc3iTuXP+fpMJjXImmj5V8h4tpsrLUv59MAM= Received: from PH0PR11MB5064.namprd11.prod.outlook.com (2603:10b6:510:3b::15) by PH0PR11MB4934.namprd11.prod.outlook.com (2603:10b6:510:30::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Mon, 18 Oct 2021 06:25:59 +0000 Received: from PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::7deb:6c36:73c2:f0d4]) by PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::7deb:6c36:73c2:f0d4%3]) with mapi id 15.20.4608.018; Mon, 18 Oct 2021 06:25:59 +0000 From: "Min Xu" To: "devel@edk2.groups.io" , "brijesh.singh@amd.com" CC: James Bottomley , "Yao, Jiewen" , Tom Lendacky , "Justen, Jordan L" , Ard Biesheuvel , Erdem Aktas , "Michael Roth" , Gerd Hoffmann , Dov Murik Subject: Re: [edk2-devel] [PATCH 2/2] OvmfPkg/AmdSev: update the fdf to use new workarea PCD Thread-Topic: [edk2-devel] [PATCH 2/2] OvmfPkg/AmdSev: update the fdf to use new workarea PCD Thread-Index: AQHXwSfUieA4Wcy120eKDuKfsTuXiavYT15A Date: Mon, 18 Oct 2021 06:25:58 +0000 Message-ID: References: <20211014181711.784074-1-brijesh.singh@amd.com> <20211014181711.784074-3-brijesh.singh@amd.com> In-Reply-To: <20211014181711.784074-3-brijesh.singh@amd.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c400feea-8285-4eb4-4d1e-08d99200265b x-ms-traffictypediagnostic: PH0PR11MB4934: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:262; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: iWVCRdA4QqYYAns8V7TJSl9zMHtYPcOrXufSNauTUcbymgizB20VnU3KxXtGIFcFDljHfg6kDw7U1zWPRmyhFx9qHvYDiA1ylPywgaNkdcecqlQxqe6l7jQUUqMHrOXD9Mv3tQ4wYcARBN64mUYkvN3/tjs8bfEKqmGRsPI3tyWoc5t9iZ7Iv+dPhqmSsg8gVzWm0osYe1IFNvGGMrasjc2D4afUMJwY4b0EWtZhwBUSvk8HP0FPz25tcobTA+cGanlsEgfiorkewVBrWBiFY5oNT5yqraIUfuRklBIkgT0/wA3H/FNNFrRiswk2OtRCBzAgdr5X4pyvwXjSHCf36ZUTvDq81otI69Ib8/tW+0rK7BVhyr5xtoZbnyEpPrgixB61yd+A873moj3ZpQYDERWtBD6cMXj/vGJ+ib0rZWkV0ETTw8CJIMUcf6KHd7C5iR3jYnrqU9UckN8EXJZ0FTV3zDSnVP3vggmFQdnoUvStvUQ3nVF125+hHXkZcWRnsJ6E4Gug5KKnRuuGls0jZ7zIXSbEJwLBKgEpNnz84JyqRuEWN/Wxrv6ABgi+ckPeJplJMpDogOJu62sBEXHYC0CU8RbXSHrNsg4QZ0nmYgyXWzgwUpVjVaKmUNe3bwmu/I480K57ATSTKkh7NEC6dadVYOf7z8mfZ64vrB0W7gnI8DhV0Yra1hRexVJA1knlqyH6kwwGCaaesGjceAS6eA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5064.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66556008)(66476007)(64756008)(76116006)(83380400001)(66446008)(8676002)(71200400001)(15650500001)(122000001)(6506007)(5660300002)(55016002)(26005)(8936002)(2906002)(38100700002)(66946007)(110136005)(508600001)(52536014)(186003)(9686003)(54906003)(86362001)(4326008)(38070700005)(7696005)(82960400001)(33656002)(316002)(19627235002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?WGL0MddjctTDmnYpIIZ+2LnlhjwkLHX2CeucsH4GqZmoyqxvzzMzYgP2sRAT?= =?us-ascii?Q?EBCfr63DjhGHO6jU6xc3NDMPK2tUjKkNMgkCKItFIuUlB8S5vldKEdZr4z2m?= =?us-ascii?Q?1wpFu093WqhYEl9OfbS0swQCzGvPsfKGrv6+UxCSF3TrXX1D8msJV/VH/Ck1?= =?us-ascii?Q?bFyAVfHVuWvt+SZvkiskRlAiFK9sqxUzUfKu9hIFJUs0etjrz6aPDi2JmPpd?= =?us-ascii?Q?9LHOW0Jqfzb6IW78lW24hC/Lw0x030ALy/Bo42wXHNZVCz2Jqsvgm/1e3CnE?= =?us-ascii?Q?gz7OCJ1EYJ8/vZ+mLskQyk9B8iv/AvZ5OcZUEHyyb3s3XrMYtRttZpvN23k4?= =?us-ascii?Q?wzwS3q5aPo2o+kGm64h13OXbhHinE2f5fNwRc6Dcxve9zHDrlVKEh03pL2f+?= =?us-ascii?Q?p90brlo5YC/P3ewu+zre+QQbIusSoR0U7UZJPtZ7V7HAqpsTVn45oZoDUjRU?= =?us-ascii?Q?DUykjdmYiW6o5i2Y2q+mslV7xDMZ9yLUPmnFFLYjONsZPTWbTUXVqnu1Qc+Z?= =?us-ascii?Q?7utIizkimCaGxHjaiyiy4WAsxNajTbhIo9eybvGrwvhVToTnzR6/VF/cfG/6?= =?us-ascii?Q?D9hFIQN6sPfR2jM4urpdFz5LT3rVkWDyaStaFtH8mEU3nyVmzvlrFD6HgbDE?= =?us-ascii?Q?wu1c5i9fNKPHatv2PPLHYZg4inH7GDY/fQ1DD3REGTftbmwduil9qDhsEGey?= =?us-ascii?Q?5YYWuHxS4cbV7ONPP3PV/OTiC69GzGmbqfKE7RZkKNxjq/j/tNRMO1Hd06eW?= =?us-ascii?Q?75IZJN4QulE1Tye8m4RUGr9ng8pMiqMzXXJjCrcRODAh8xIa+QDtQ3rs5kZm?= =?us-ascii?Q?YobzF/STeWtXMynV9kaGoksxpg7Gzk5ZB0au3lnM+0UTrKb3RUHVwtbZMeEH?= =?us-ascii?Q?3jaQliBpGZ2t2BwiU1WmrAijd6cH8m26phjz9Hfi8vDTKUfCPYdLgpP693jN?= =?us-ascii?Q?ZWaMg0R9izZ5dmjGnSY2T3NTqaKcF8X0vFmw8pU04z3Mug/t33hLZyT7lU0+?= =?us-ascii?Q?4B7bcoZWWHSg89hrFl5+aojljNJxrpBnn3r82TaeiKyBcotDB+r4u+jghLEm?= =?us-ascii?Q?62QdpYLwx8ybdgX5uppOMkBNUw3nnvNBV7XZu0cFdEwzt9a4wYte/iLcEuNC?= =?us-ascii?Q?cCv9HNuUknRhtu3I5abI0+x6vgLwh6IUGL82vLru7wGYvkFZ6v9H5UA9Hp8B?= =?us-ascii?Q?32RjJTh71Px0AUdc9vBAwNEbroNUaJWThTqGzR0X6cSQuxEVM7jiB1jamGLC?= =?us-ascii?Q?7gUkAcmKitfFMnHqUWi2Kp3hG4Sy+DIcl+AA/FnyS5BYSrZ9uBcwGFpwjD5X?= =?us-ascii?Q?jqTYlLjdHjfGD3k//zBgO3ez?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5064.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c400feea-8285-4eb4-4d1e-08d99200265b X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Oct 2021 06:25:58.9514 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Hyl9+y5l+/b2hzkZB9Jb69TReC/4M+fk7yix6Sv4kCRSPdWZSgNKLZHDoo/musGt2eUllWKMH63Wh65Tt8R8sA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4934 Return-Path: min.m.xu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable On October 15, 2021 2:17 AM, Brijesh Singh wrote: > The commit 80e67af9afca added support for the generic work area concept > used mainly by the encrypted VMs but missed update the AmdSev package. >=20 > Fixes: 80e67af9afca ("OvmfPkg: introduce a common work area") > Cc: James Bottomley > Cc: Min Xu > Cc: Jiewen Yao > Cc: Tom Lendacky > Cc: Jordan Justen > Cc: Ard Biesheuvel > Cc: Erdem Aktas > Cc: Gerd Hoffmann > Reported-by: Dov Murik > Signed-off-by: Brijesh Singh > --- > OvmfPkg/AmdSev/AmdSevX64.fdf | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) >=20 > diff --git a/OvmfPkg/AmdSev/AmdSevX64.fdf > b/OvmfPkg/AmdSev/AmdSevX64.fdf index 542722ac6b37..56626098862c > 100644 > --- a/OvmfPkg/AmdSev/AmdSevX64.fdf > +++ b/OvmfPkg/AmdSev/AmdSevX64.fdf > @@ -57,7 +57,7 @@ [FD.MEMFD] >=20 > gUefiOvmfPkgTokenSpaceGuid.PcdOvmfSecGhcbBase|gUefiOvmfPkgTokenSpac > eGuid.PcdOvmfSecGhcbSize >=20 > 0x00B000|0x001000 > - > gUefiCpuPkgTokenSpaceGuid.PcdSevEsWorkAreaBase|gUefiCpuPkgTokenSpace > Guid.PcdSevEsWorkAreaSize > +gUefiOvmfPkgTokenSpaceGuid.PcdOvmfWorkAreaBase|gUefiOvmfPkgTokenS > paceGu > +id.PcdOvmfWorkAreaSize >=20 > 0x00C000|0x000C00 >=20 > gUefiOvmfPkgTokenSpaceGuid.PcdSevLaunchSecretBase|gUefiOvmfPkgTokenS > paceGuid.PcdSevLaunchSecretSize > @@ -79,6 +79,13 @@ [FD.MEMFD] >=20 > gUefiOvmfPkgTokenSpaceGuid.PcdOvmfDxeMemFvBase|gUefiOvmfPkgTokenS > paceGuid.PcdOvmfDxeMemFvSize > FV =3D DXEFV >=20 > +################################################################ > ####### > +################### # Set the SEV-ES specific work area PCDs # SET > +gUefiCpuPkgTokenSpaceGuid.PcdSevEsWorkAreaBase =3D > $(MEMFD_BASE_ADDRESS) > ++ gUefiOvmfPkgTokenSpaceGuid.PcdOvmfWorkAreaBase + > +gUefiOvmfPkgTokenSpaceGuid.PcdOvmfConfidentialComputingWorkAreaHead > er > +SET gUefiCpuPkgTokenSpaceGuid.PcdSevEsWorkAreaSize =3D > +gUefiOvmfPkgTokenSpaceGuid.PcdOvmfWorkAreaSize - > +gUefiOvmfPkgTokenSpaceGuid.PcdOvmfConfidentialComputingWorkAreaHead > er > +################################################################ > ####### > +################### > + >=20 > ################################################################# > ############### >=20 > [FV.SECFV] > -- > 2.25.1 >=20 Reviewed-by: Min Xu Thanks. Min