From: "Min Xu" <min.m.xu@intel.com>
To: "Yao, Jiewen" <jiewen.yao@intel.com>, Gerd Hoffmann <kraxel@redhat.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Aktas, Erdem" <erdemaktas@google.com>,
James Bottomley <jejb@linux.ibm.com>,
Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [edk2-devel] [PATCH 1/1] OvmfPkg: Store PageTablePool in TdxWorkArea
Date: Tue, 27 Sep 2022 03:02:33 +0000 [thread overview]
Message-ID: <PH0PR11MB506421861B8214BD0CF8534BC5559@PH0PR11MB5064.namprd11.prod.outlook.com> (raw)
In-Reply-To: <MW4PR11MB587203E21FD5F2E0208157558C559@MW4PR11MB5872.namprd11.prod.outlook.com>
On September 27, 2022 11:01 AM, Jiewen Yao wrote:
>
> My feeling is that this mPageTablePool is an driver *internal* data.
> It is not the best idea to expose an internal data structure to *public* space.
>
> Can we have a way to move mPageTablePool to stack instead of global data
> area? such as input as function parameter?
>
Yes, we can do in that way. I will submit a new version of the patch so that the community can have a review.
Thanks
Min
prev parent reply other threads:[~2022-09-27 3:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1712727D109677C5.26635@groups.io>
2022-09-22 4:43 ` [edk2-devel] [PATCH 1/1] OvmfPkg: Store PageTablePool in TdxWorkArea Min Xu
2022-09-23 5:43 ` Gerd Hoffmann
2022-09-27 3:00 ` Yao, Jiewen
2022-09-27 3:02 ` Min Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR11MB506421861B8214BD0CF8534BC5559@PH0PR11MB5064.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox