From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web11.6730.1664247769949028508 for ; Mon, 26 Sep 2022 20:02:50 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=Y8EXBbCJ; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: min.m.xu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1664247770; x=1695783770; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=SyhnQ8AOXhQNABTVNf/BBMQ0JCEQgZR7PpZFsA2WVxo=; b=Y8EXBbCJCnSQanCj4RLKTy4+DBwDLoctUt22VCPFnV3Jjm/GD7aUDDE9 OfJmR4ZKrUsKi4eGTnJHuei/vMb6Ac0P+yiE5E2AKSE3LO5lbYqNflW06 5SKcmxTvBq3t3NXQz79ee6iVEiWOfCxSSQfapHHPadGXBLV2iV6UtJfen jnStQi8vn1biCRzZmNfcoFiQ6gOQoseHe4rxM+qRTewYc702wN2EmgVBW 5CGaiCtu7gZGCSOfkeRLjZkmkpXObh9fuHrklUseNmwItpC74ESy+i4nU whPxvq7Hgtsj6qOV52RCZlC5zVEAEKs42/lr0YoG09+LBFnWu7CgE0NQe w==; X-IronPort-AV: E=McAfee;i="6500,9779,10482"; a="302106647" X-IronPort-AV: E=Sophos;i="5.93,348,1654585200"; d="scan'208";a="302106647" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Sep 2022 20:02:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10482"; a="616661810" X-IronPort-AV: E=Sophos;i="5.93,348,1654585200"; d="scan'208";a="616661810" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga007.jf.intel.com with ESMTP; 26 Sep 2022 20:02:39 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 26 Sep 2022 20:02:39 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 26 Sep 2022 20:02:39 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Mon, 26 Sep 2022 20:02:39 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.169) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Mon, 26 Sep 2022 20:02:38 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KHkMu1lqQgixXjr5kTqVRANqFy91JB6Z1u/GlTnMBUD1PLqrCgkKXruVnfq21Jfshorb5Mu7hcdv4KjASXDZqVmzfiHqgv64Hv17VKP8Yw/bZFkm89w6u8Rbs4p9of8xltrracdr2XKJ91EKGETcLyif9r8JHQ6DWpK7BdBRKAf55TolQjSBsOJ/uLgtaosbNIU3Mp70QLsBB4AuPySOJfNjPyXQyhrs6gUBA052c5OH+qSfo1uiIcYn2AOJT/VmjbbShbMIK0zW0GDgHlO1ZV1V/FZO9ym9ox+rEM8AoD6xZ4WyCVtJ6swaoFCNOY/aZvJSvSNLVDKpHr69a2Z1dA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SyhnQ8AOXhQNABTVNf/BBMQ0JCEQgZR7PpZFsA2WVxo=; b=j6KEdQp/U3f2cprqxfGfsipzXwZ8PlzrFpEPOg9eLaqPx/ZhDJXqbzxz7qklKSLiObQcsnvAVfmq/V8/yMLa2MbFpAIESzRrX13/kNy5AqBuanJG/cyxXZWOHVAuX9D87Iy06DOSmU9Pgafk5bHNvhMnn/sp+MukLr/h0UqcpDYWLWeDO89IK4u5xNGGcKo0gBzkwPRulMZL1iAbLA6OlNLeBKMC4fKDA1zqer2ADgBTAyW1X5Po/AG53rH7WYB18M7WNOWUK/swYB7cEMbjnHgXrk4kIPS7T187h6Xpi43YLbdcB5qqhEyeZDSQE4FyNIKYZVHtY8DLOLYIQl0i3Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5064.namprd11.prod.outlook.com (2603:10b6:510:3b::15) by SJ0PR11MB4878.namprd11.prod.outlook.com (2603:10b6:a03:2d8::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.26; Tue, 27 Sep 2022 03:02:33 +0000 Received: from PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::ec3f:8428:41d6:3284]) by PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::ec3f:8428:41d6:3284%5]) with mapi id 15.20.5654.026; Tue, 27 Sep 2022 03:02:33 +0000 From: "Min Xu" To: "Yao, Jiewen" , Gerd Hoffmann CC: "devel@edk2.groups.io" , "Aktas, Erdem" , James Bottomley , Tom Lendacky Subject: Re: [edk2-devel] [PATCH 1/1] OvmfPkg: Store PageTablePool in TdxWorkArea Thread-Topic: [edk2-devel] [PATCH 1/1] OvmfPkg: Store PageTablePool in TdxWorkArea Thread-Index: AQHYwmAfAYrKTBs41EOjLRAjuKpiO63q9pIAgAGjhACABhtEgIAAAKOQ Date: Tue, 27 Sep 2022 03:02:33 +0000 Message-ID: References: <1712727D109677C5.26635@groups.io> <20220923054334.lra4csta2haobx7y@sirius.home.kraxel.org> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.500.17 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR11MB5064:EE_|SJ0PR11MB4878:EE_ x-ms-office365-filtering-correlation-id: 161651b1-d8c0-46a0-37b8-08daa034b968 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: qYxW4xM2vTECUk90C4hJezmPjKfEkPZROQOZuDeKuDHWvGXyNQmBHQxiV24jrxCx+Cw8oHfL0lhPxW0aBbGHmZii1LIU+QLGEbuE9Elsc9GgvATD1rl21bSMUDelD56/Qzi8f4D4dXGLoClq+vtsgdV3i2gXdPhNGnBrj0Wog7rlcgcOd7zIZiF/F5djDNL6J/rY+g4/X3YGLX5ujn6DdJ6HmJNmUo+KHS2QpyjbbNwDIxJMCrwM9K/FoGJoHp2LEFNMR4quZg7L2YA2KjQGInh1ldL2ji3glTshvPHK2TQkUK/vNeg6TLRK8bCH1WW2DTgIMiLF0rFBypn83sNbM8SSt326RjtpDyLyyNhYsOxV7ovxdTCdhOYN06f7sbanbt3au+j8yrD9hSoj7Y9mhO58eJeW2HmI43a5M+xykkS3rOYAU5cmDPuQOYNKMoAck8rhfcnTa/ObyFljuWXHX9Fo3c2PaGMDQCT5D/oDJ1IvwaUD01qxH+29OKAhK8lNyuFU8jE/dJUGm4f0I3aWJRI022EvTyPITm1ag7lUlQgn8HAOmtG4RYI49DzMzlghEYkyiwjumXeD+YPan07IceKyE4/Wu/Wv6B45b8K3zIivT8xTYaxLNGDiBzcxu7t/qIbpd/7r/QSXtU8tTmhD93Gtljd78Qe3TnDKPLFvaFrbfEHptZCKNH81JDRSgh7xmB6H806k6y0t2BMss1RUs7rGNfln5xMNUVcR1LUS1QRHWyFWT5RNQmLPW0monKEaXxoMyBkVA7drxHSKtz1JCw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5064.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(346002)(39860400002)(396003)(376002)(136003)(451199015)(186003)(2906002)(122000001)(38100700002)(86362001)(9686003)(4744005)(66946007)(33656002)(76116006)(66556008)(66476007)(64756008)(8676002)(66446008)(316002)(54906003)(7696005)(4326008)(26005)(52536014)(38070700005)(71200400001)(6506007)(82960400001)(8936002)(55016003)(41300700001)(478600001)(5660300002)(110136005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?7FmA0Wda3GCY3fg1wIRyU23pENxZ8M0FbMjeFoXYxc3x0o82zk29MV3KH8bG?= =?us-ascii?Q?NK5nr4K6xWyVxfwjpbya5tGkkGfEnCvitCCE0TW49uySJMT8t44+yWwnZjtb?= =?us-ascii?Q?+9FOPPGEp76ETvsiT6re/Se4FP7gK4UUy1SC5IeejISDm7F/tIbo71i0XBZ5?= =?us-ascii?Q?tf4DNuIfPLQxUIgMKfh0WGHCF/wIeKp5tqu4ZHVuieswakJVXAWvV8gVKGf8?= =?us-ascii?Q?/2+Zw4gKqIhbTs5x3sdFdnh8Sdbi/A4phwhHCMdHgXCXJMEvCcfiL9Cs1uja?= =?us-ascii?Q?sNDQPAR2nilvjMRgy5ABHBBuVXnTxBsUAA0FpjopE8W1wwVieR9sEjJSEdF7?= =?us-ascii?Q?eIndsAiB8g5P6czAzhY4gTGdojn69w24OAl6HHtNYHuXCh/g5pqMpeTFs/mK?= =?us-ascii?Q?DPSa0QjUfC6wiBnnyb87h467HeWx1pmdNvZJpECd/Kb8/zr4nxa1eOZ7IHR6?= =?us-ascii?Q?dmdkMmxTH3G9QCyLZEGSqtPvZNc4BOvQGMW+3+hOa9sAGh6yncDogLmjHF2u?= =?us-ascii?Q?ACJMF0rPAJ0rOkZ+4lHfhMX6M3Qn5Kgwwq2zRT6ai3Iuhu9oLLyPDN4txQQf?= =?us-ascii?Q?gvan0y0OtaQ3wUQWjH1QL8XuhDIaAxHgAkvego8cFzdG236lFBmlML+FfYlh?= =?us-ascii?Q?OX6CECWRUOb2um5FUS/GuSY7wGTMsTlGtdpWipP1yKmgUJp0Lcd0Y/tpZILo?= =?us-ascii?Q?zRjXOlglQ5bwdFIw1bC6Vxha/gzit42KcyIuWHdRHfQjQJQ2Od440ucrap4X?= =?us-ascii?Q?WCe97aK8eJRHnHMnkm+EICY/qIoYGWe1GXLDT8RbfcGror05904Fo5TiJPHH?= =?us-ascii?Q?LJXr5eJepEZAT51lT7ryIfrrTeLq5tfD8OGTLRmHxRxxbFV3cIjelM/iaCwO?= =?us-ascii?Q?PqQlK/Zl6iNO6H3tTxLq/kiSn35ZI/Ioohb826heRSVf3Jacpw4AvAunnWNc?= =?us-ascii?Q?qfq9LRbnxtG24oKivH5uR0POAZLB18f8QbXrbGivftMboxwuCYlM7l6CJqHI?= =?us-ascii?Q?HlLvIrdXw/5nu9jl8AeLzbphs024crmchm6i9LE5jT3QZmfCKwJLa9x2vwm2?= =?us-ascii?Q?+dJg3Z8SP4GzPAFK9RpfV7Z82d1jOKDrlaw/2jvTBPrE38nQMlAEbZ3pdKuZ?= =?us-ascii?Q?f2tYUe0W+nnT7FJMfKVm2GYDg6kzjWi1M/Q742Y+CeUIh4XQ8cSxYarOcTx6?= =?us-ascii?Q?iXQ2a49mPoKERqQ98+ZA0MrMuHt7kOeXZ0yeQ1sCEUyAPWnjdQQlEzHWhLPo?= =?us-ascii?Q?vKieoHM3pQfPYxM12xswx59Y5O8ZsvlmtjKflXpA2dly8f6EOhn6I4t1KcH7?= =?us-ascii?Q?DKgv6v1gT3zBNGysnTaw4vA/graPnbHo42ptguusTpuDnPZ5i4jWLlREzZPM?= =?us-ascii?Q?jsMokxm/1XokMDZ3sfjaG4ZEeND2k/amhj0DQsr2NyRk6RIjPgVbiCFJ1AQe?= =?us-ascii?Q?QEbpSNnhSy1pNatfRodO7VTJcGPk4l/Nb+6RkAa83ZXPNynbaeafVRivqaLw?= =?us-ascii?Q?WixHvmZ08VQxGh3OmLGGpx8GaX0U0JLNf76ZQmjt+SVwD4mFSPSPwAhsQ8xL?= =?us-ascii?Q?qTgvkR4/1wz8SQtW23M6wcwoV8py2P+WMN8MVMes?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5064.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 161651b1-d8c0-46a0-37b8-08daa034b968 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Sep 2022 03:02:33.5079 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: IcW9d8T/6qZyp261wyoY91yhr7UvUKXDFv7l3S/1uDGWsyxpA1iMEeRI6WT7ir7T4wOfZly+N0HqjRGwkKv85g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4878 Return-Path: min.m.xu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable On September 27, 2022 11:01 AM, Jiewen Yao wrote: >=20 > My feeling is that this mPageTablePool is an driver *internal* data. > It is not the best idea to expose an internal data structure to *public* = space. >=20 > Can we have a way to move mPageTablePool to stack instead of global data > area? such as input as function parameter? >=20 Yes, we can do in that way. I will submit a new version of the patch so tha= t the community can have a review. Thanks Min