From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web11.7965.1648035031056060476 for ; Wed, 23 Mar 2022 04:30:32 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=bkXSaK5B; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: min.m.xu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1648035031; x=1679571031; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=ntBEZD2FN3eojIzdAKI1s79oYTrzePcQParLVZHBooY=; b=bkXSaK5B72vMDLPRl2rZaB3t1LNEm2KRAxvHx2YfMicnKH0TrWrpDzMw PF+RH07K4R15gwVTMS0sbgcWYhis1nROBDO41u/xDiW43J9ixur4iMUnV mh/sq46nM4MN8L0BljhuGVUE2DW4v+6iq9BmxiACX8UHOc6yKGxaeXwl3 eOP0tg5iHAZsYo01X4YKaMwzNJfKXunBVQylbPHKPUK9+1Z9geffNVFaK dp6X/CPA9zDS7PnjF2vQfBbp2JYVGUQKW4BkXaC1e/7+DvQF90OXx3Q+p rsz9ooAl7KC9lWa79aSnb55yUrldjPDdo3hChDFoF3q2TIjXfZa2UJs5V g==; X-IronPort-AV: E=McAfee;i="6200,9189,10294"; a="318796812" X-IronPort-AV: E=Sophos;i="5.90,204,1643702400"; d="scan'208";a="318796812" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Mar 2022 04:30:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,204,1643702400"; d="scan'208";a="717360499" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga005.jf.intel.com with ESMTP; 23 Mar 2022 04:30:29 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 23 Mar 2022 04:30:29 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 23 Mar 2022 04:30:28 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21 via Frontend Transport; Wed, 23 Mar 2022 04:30:28 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.170) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.21; Wed, 23 Mar 2022 04:30:28 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L3eR5kKiS7JT2hYD2w0zJcjqJCWt7c1hOENguzQCnzLyI7IUnk8xTR5pgmOHYCo6Gujwf+O4PeZidSN5LKWVN3mTAikbSiaiCAOsucOCTlS41yjDOkvvurTh+TEby609Dle4LIfgSBM18DU/equtc462CQSNdLYnIt5xCQOsQCE47uUpAkImyHT4dztoL4BVaUxnYmNiom6CmPrTMDPsh7+wRf/Z9IIy61bEhUZ1yu9RH2PynwcJCmdpLhk/CPtc1PYG/YmHPnXkXjUvf4D7HMsRZcXEdtt5YGkPdUQ4NsRuxy9055dEURww6ZArk5it5HsYsLwpyxHL2AdexTCZ7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ntBEZD2FN3eojIzdAKI1s79oYTrzePcQParLVZHBooY=; b=L78Wb+mPEJ7tV2kKadTr7t+jZS2CxUISgFMamlG2wUFb1JDR3ymwaYabWNeM17oXTYWBgxMZau9Sd8g9Tl+Ez3DC89EfhtwWu2lQHe/77E9SIue7phUKu/NZuEexLZxRkNTMPLzKnMOw9ufDlBJFq7n77a8h5vQXu/NNCSWjWYRIPk268+OT5KSramTKK07KJEKQQDu+40Ts0/BZho9HIDkvskH2UwEVPndN6YhRrOLr2UlkhwITHgrGT309TUHcN8/rtrWU071A4IYZQ13WgBMXuq0Z/vnHnZ/a9qP/HI1fBwnzX5EHcwYt3L9rPW/QkB/AGqhWWoLDPQj+Ylk2JQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5064.namprd11.prod.outlook.com (2603:10b6:510:3b::15) by DM5PR1101MB2362.namprd11.prod.outlook.com (2603:10b6:3:9d::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5081.15; Wed, 23 Mar 2022 11:30:25 +0000 Received: from PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::ece5:6170:a99a:480a]) by PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::ece5:6170:a99a:480a%7]) with mapi id 15.20.5081.023; Wed, 23 Mar 2022 11:30:25 +0000 From: "Min Xu" To: "Ni, Ray" , "devel@edk2.groups.io" CC: Brijesh Singh , "Aktas, Erdem" , James Bottomley , "Yao, Jiewen" , Tom Lendacky , "Dong, Eric" , "Kumar, Rahul1" , "Gerd Hoffmann" Subject: Re: [PATCH V9 14/47] UefiCpuPkg: Enable Tdx support in MpInitLib Thread-Topic: [PATCH V9 14/47] UefiCpuPkg: Enable Tdx support in MpInitLib Thread-Index: AQHYOmG2N1WQoiYALEuY5uqJVojXFqzMmAAAgAAD/GA= Date: Wed, 23 Mar 2022 11:30:25 +0000 Message-ID: References: <2b5c26f8bbc272abfa39521175c85cf46b0fbeda.1647523953.git.min.m.xu@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.401.20 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 78a7afa6-7f09-4f82-993b-08da0cc0868a x-ms-traffictypediagnostic: DM5PR1101MB2362:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 747BN73PjZOYNjHRWW6owFL5U23y0zGHF/ourZSPdabQpyUW5I26tO6yFqYuZlBNBcic3tq7VGqplO8mK0YDTaLcQQUfNErt0at2sZsHDknTD/fQtXxdtzvrg8oW93Lu6AHfzfza+blQ3Uv7krzJ8Zmc4KOd+P3ZhT2bk1Fn7Et0gGR0y3VX7zvlfYLH2UID86/37DBs2Eo1lFKN4eaHOQN+1wAelimzx2ZL5twry9n+JA1IxdwX5MsDuQ5HRb8EYMtTp6pmoF2feocu74IvX42CKDatBYvEBvbSeY6PtvYusbcerHsheibCxSBRmq/2sO5+nNmaa6xHYI+kz1q+Ipa9Lp/xE5yOJKhry1VXnOLRza6W1KxzlxxxP4Ak9gOb6gUEiAduNThZE6VL9IRXDrG3TJQ21b4LQqG5cZg0Nm45ZPyLE+6AIATTvBZma7yFrHT2dM1oRB5zLgP9K1XOiYyPSM+Ri2jyKU5OacLmTspi+4VT/GoFy0rZ2b419NVVjFKV9+DVRPQR5HjMBkqYa1TrGWe+RYMRtOPr0D5WA7gkVzxKtwV/FywAiQ1NkP/IMsnERvPUJEB7Q2rQLDpWn0tAPgQERwgjQKwQbxgOxDxWBrFDmic75vm+g5eoFwPKBJQ7/pY8aa1CUK0lO2iXwrtiYkLA305B5uy9J9koeXLa1nZWaXEIpxE3kJ3x21H9wyRUz64VZtbCu5CjBtxsBg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5064.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(6029001)(366004)(71200400001)(4326008)(66946007)(8676002)(508600001)(86362001)(33656002)(6506007)(7696005)(76116006)(9686003)(52536014)(110136005)(54906003)(8936002)(186003)(66446008)(316002)(64756008)(26005)(66476007)(66556008)(5660300002)(122000001)(82960400001)(38100700002)(83380400001)(38070700005)(55016003)(2906002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?lSSaNbUR7EHZwey+rxXa6fj3qzweNqJCqZIYPn9Ggtc1K8VY9+dFJCt2ySpY?= =?us-ascii?Q?tgxc1KhpfBMvA9l7/CO2GNu3SF2qykuCIYQD47KRo/tenACOV9lyhMK4he8/?= =?us-ascii?Q?w9vofmMRLqtPyTkZTaaq8ChLbMLBP3XX8SiQzDKDP89tIIaWXxf/tXMuUwrV?= =?us-ascii?Q?caWQyXw5JV0KkiTqEvc8TGZLFGEjcraqXTbclndjvYZmLoG9t2nFwXBMsgdU?= =?us-ascii?Q?E6UtpAWhaln7MqSVSpXHIQHKnUec28qTBWRZjkRGb0E0HVFrjx1dZeHOclro?= =?us-ascii?Q?bxLWFUWJFnMul3auUtxVOtJqMWD4icGK9dMhwsKQipZwshfApNcJ6eFUifsy?= =?us-ascii?Q?yshGdWg7tEdk31x8cc5FTYlN/LY4D5cKyXlpSvMyx9Brn7lafhii3nxeuI1O?= =?us-ascii?Q?pUQc3RmfBonHHTDan6muYmuG8fnfB1FIwbg9Hy/iXrsDpZNtTMIcNqCWF79i?= =?us-ascii?Q?ofExo3wwQVG1Rvw+E/uuajkK2t7dtN8NftbrlB1Q0wF+8TmeiCd3LlRuEIIH?= =?us-ascii?Q?k7JTtb/T2drOevrowMM2pcJggDxn0+pOqYlMos7p4jwhXRjZEDQNk+aO7BkA?= =?us-ascii?Q?s3PLQRjy9IJhTR57GsOp6LrT1HxvbxnO22VpCx9znqy8DGB+c6RZDgb7DCAp?= =?us-ascii?Q?+B84G3PSM14K4u2EfeMOfQTtZWY4ItCUzJXtTGKY+beqoWyZaTDNeFC4mNlF?= =?us-ascii?Q?CiU3hs3ETY450piJgbKvBaSuslExesBi8kaSNGZxWmRH9YsNA7dYuQkAi147?= =?us-ascii?Q?//PaQjnCmeGGNSO0owXxQN5oJ1qnUkiRhc6aq51dKG9neuhoAnnjhmRxME0Z?= =?us-ascii?Q?g++BRm4OcqWN0TjsxzOcS3mCClwG72ADvsRCto/NJN3VkRLG2F/fQO2h3Ud2?= =?us-ascii?Q?j/xeXb8nZTAk9dejDyb/bWT8HTNoFiqTzRF4PYarAkg911EGR+zbISgFQeEM?= =?us-ascii?Q?FCtUrYMLXr/5ABOx2/NLQsiuJFObHCUNbfKXl7D+wx6B4embSN2TMSMiRKyp?= =?us-ascii?Q?a4CdBifjIT9BGYVPX2DZoPNKUSWk8JwbsDa+72UlB58/xZ3eloDCt5Cz7e5T?= =?us-ascii?Q?Z6pBYTXyJezaQavgjjk0Y163HL6mAnMaaHUbl/WXimTcy1d4RKjPEHxVuxcB?= =?us-ascii?Q?S6AvxkpY2FgTN1ipJNQJWh1KvQ2FW//y4hXnS9q3DUjt8ewzq0+/fkswHL4K?= =?us-ascii?Q?Y2O7GGprkYErZvHZGjLinWL5RnI14ztzVnegMbevZUzV/lBR/4r/DJIjUE8O?= =?us-ascii?Q?hZzwYeXPtz0/zUAyJmReA9rLc8R+IuS34YJH4F+GcIXws6gjIXvVxPoZQTOk?= =?us-ascii?Q?7g3FTvhyOOZRDXiytYMRoY1kWIFiBRSBHSdNBY/eQBCTywNss9LFtIY6xbmF?= =?us-ascii?Q?TqljsjGorqogUryvhrFMCFTGx3d2mZ8w7aJTMZHi5wJBqk6d9KGh6rBQUKm7?= =?us-ascii?Q?apm2Uyk1GnaeaDN+mBK95PTlBffDpdXh?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5064.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 78a7afa6-7f09-4f82-993b-08da0cc0868a X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Mar 2022 11:30:25.6361 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: CJttFp77yAMVlXvywls6z8FttEpRuG1R6TsKmn3GPn3KK4YKeo828VwBLvCWn8J6V172ehPBInj4ioPNX0Ws5w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1101MB2362 Return-Path: min.m.xu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable On March 23, 2022 3:20 PM, Ni Ray wrote: > Min, > MpInitLib contains following APIs. Let's discuss one by one. >=20 > MpInitLibInitialize: Directly return. Looks good to me. > MpInitLibGetNumberOfProcessors : Call TdxMpInitLibGetNumberOfProcessors()= . > Why call a subfunction here but directly return in above API? Not quite > consistent to me. By the way, can you re-use the parameter check logic? My consideration is that if the complexity of code change is small, then it= will return directly. Otherwise a sub-function will be called.=20 As to the parameter check logic, it will be reused. Thanks for reminder. > MpInitLibGetProcessorInfo : Call TdxMpInitLibGetProcessorInfo (). Consist= ency > concern. Same as above. > MpInitLibStartupAllAPs : Directly return in DXE version. But > StartupAllCPUsWorker() directly returns AGAIN! My guess that's for PEI ve= rsion. > Can you remove the changes in DXE version? I double checked the code of MpInitLibStartupAllAPs (both DXE and PEI versi= on). It calls StartupAllCPUsWorker which returns directly in Td guest. > MpInitLibStartupThisAP : Directly return in DXE version. How is the PEI v= ersion > handled? It is missed in PEI version. StartupThisAPWorker will be updated to return = directly in Td guest. > MpInitLibSwitchBSP : Directly return in DXE version. How is the PEI versi= on > handled? Sorry it is missed in PEI version. It will be added in the next version. > MpInitLibEnableDisableAP : Directly return in DXE version. But > EnableDisableApWorker () directly returns AGAIN! My guess that's for PEI > version. Can you remove the changes in DXE version? Thanks for reminder. The changes in DXE version will be removed. > MpInitLibWhoAmI : Directly return. Looks good to me. > MpInitLibStartupAllCPUs : Not handled. Missed? It is not missed. MpInitLibStartupAllCPUs call StartupAllCPUsWorker which r= eturns directly in Td guest.=20 Thanks Min