From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web12.4246.1646707154376930911 for ; Mon, 07 Mar 2022 18:39:14 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=gXF5+l8C; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: min.m.xu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1646707154; x=1678243154; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=vPOCUFH7is9CESkHqCy7Ts6kMAaa3Nk/ba3j8lE+ZUE=; b=gXF5+l8CNuarIquqLfdHtQ7aO+IqRzzvI5mZwX1H9ouVF0mZ74dM4Z+K qIJoWN7lrmzvPsbljP5bSy1kccVE4ZNRbvYWs9uB/yhDbl5IiOQ6kxrxT BqzX66hShPVeRFNqgkUlgZaNKhsvqpKaOD5tRg62rR/8hx1nlHBeYIFJZ If+DGq5Z2W1Ke/SShV7QtLGIt55zYXD9bht/9tFYXK0zASzVr2emmdFs2 8JYjBE3pog2hWw9nJKiiKDMWvbWo0jmnKEEN6QeMVHt6GdCNITIgzGZS+ Q82D9GOLL5dfj3goWuvXExoe9ORJw1OcL4yDfJ5ojkyT0lLWHU0r2ZcmQ Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10279"; a="254760961" X-IronPort-AV: E=Sophos;i="5.90,163,1643702400"; d="scan'208";a="254760961" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Mar 2022 18:39:14 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,163,1643702400"; d="scan'208";a="711361051" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by orsmga005.jf.intel.com with ESMTP; 07 Mar 2022 18:39:13 -0800 Received: from orsmsx605.amr.corp.intel.com (10.22.229.18) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Mon, 7 Mar 2022 18:39:13 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21 via Frontend Transport; Mon, 7 Mar 2022 18:39:13 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.21; Mon, 7 Mar 2022 18:39:13 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LEoTewwiIJ6U6rWCeGuP4ZJA3G6nwrEVStPO4kO6CN+jkMSsAJ6oQoy6enDHGUPvT9/0m/YT6jLT7Irv7K4Z4rR2WEyoYJLWIeBnGzuW8czELaT8TEnvjZdz7duYh704vshRjqYalGAk9eNPUHHqOppcTkB83M/jgLS69a4s2oEgLN4ugLl0SD7ikPl5yzO9gwaoL/RUQvzD9rpSHj3IOeWEr/dHCH/HoeKmT937Ygt5g5+OC9dAImcldLz6A/7poL7UrIMjRWDuIqqx6fQGpU/CDHA9LfohdN6U9Ofh+qqdwwQNMvQngrHVmI+zPEPxSnM9TIPMX9B4o6SjgDRtag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wmNMR4uiTVEkqKHUjV74K63XSbbT2MpfcLLaA0nBHVg=; b=BJQanwOTmz6cQMt+4OLq7+ePRJVNUj815FBVexJII4rqwf9MCPIFQJBtO1qOV19D/CXAB1RRvNRKhZXIzzh0wF1hctsarn0HxOprgfVte3KwNvaCvCsKHswUvEGaLH5FdAqwZ1FgxDcNsH/SQ99SXJgzsUIaGNsMimKXSNxfn7VdoDryYqk9+Ycfg/6crVT6wwGamdFsC7kPrJqgsNgumb/x4VREZ0FDNBD1Y8W0UvpZkmimsSPyn/w6jkWgGjmg+g9I+HzbZ9m3VNQ+W0JlxKpSbDGSn01rUrEka2I8E0l0ysoZpyLS2TwonhIahKEh82n7WDm7YEh0fZQMHjvXmw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5064.namprd11.prod.outlook.com (2603:10b6:510:3b::15) by DM5PR1101MB2250.namprd11.prod.outlook.com (2603:10b6:4:4d::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.19; Tue, 8 Mar 2022 02:39:07 +0000 Received: from PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::98f5:edb6:aee6:6886]) by PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::98f5:edb6:aee6:6886%7]) with mapi id 15.20.5038.027; Tue, 8 Mar 2022 02:39:07 +0000 From: "Min Xu" To: Gerd Hoffmann , "devel@edk2.groups.io" CC: Ard Biesheuvel , "Justen, Jordan L" , Brijesh Singh , "Aktas, Erdem" , James Bottomley , "Yao, Jiewen" , Tom Lendacky Subject: Re: [edk2-devel] [PATCH V7 19/37] OvmfPkg/PlatformInitLib: Add memory functions Thread-Topic: [edk2-devel] [PATCH V7 19/37] OvmfPkg/PlatformInitLib: Add memory functions Thread-Index: AQHYLHPwm2Ef7wesBUuvgjNVu4Z5SayqglGAgADDA/CAAGcngIAJJX5A Date: Tue, 8 Mar 2022 02:39:07 +0000 Message-ID: References: <46e0f662050779ec3ce3caf17196403266e73269.1646031164.git.min.m.xu@intel.com> <20220301130941.dw6cdc5nvh7c63u2@sirius.home.kraxel.org> <20220302065651.4ahbxeitxozrd5k7@sirius.home.kraxel.org> In-Reply-To: <20220302065651.4ahbxeitxozrd5k7@sirius.home.kraxel.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.401.20 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ede35937-0e05-4ced-c523-08da00acd188 x-ms-traffictypediagnostic: DM5PR1101MB2250:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ctsbsaMPZCL1RoteLeSdIu3/bPypnTs1RKf5GeRqqYGbECIwxMilA01AIUIbA8iYg/I8+b8JTW/WX+r5R35cafch7urxyZESqnf68+MAKNjbV8eT47ZXdmHSpqmclW9XBoNVABQFvbYFSduw+Q4UWGQkXSoaEjNbKvGIa+zU0ea50vvJInGPfVmMIYsUNo5VvGvt2uYaL0nzA+wd1YnY9nwK8+yT4mweiVIDVj9iFIqUC2AikYUUI/k84xu14EGMRt+lnlFXad0z9V6yNHxlHTf+p+cpc5mwuGLIYv+W3/MXcr025XWgO87LNry9AMlpM0eu2KHXWvUfYe5ckEn1RtR51aB8TqB9/lO2RutBsMDbHJgrgV7xAfAm68TbZZwoN/BjtzclkzTh/RQPaMycuu8LLYnnL77mHL6P2xvpzMPNP5+C29uOinmrgr73fwvGsDEt9INpuy5CsMYxZUvw34J8TNMs7PYLSbo31FDBWfuiZ3vXxrKFOvyoFL86BoxvauS6qUYi6gIRjM5nS28XHRm7kcx3hLDZzhKucnG1owOFoJRjG9W9MUPHB3jeXEnAOwqDnPPk7q5Rr2//yav6j8BU0dyfa3zy77uOblyZzNzAHcSXRiD1oABqzEF6xafUzv3Up990zfi8DJVuk7neTRsAQF7RQCIpqICtaFBUm3aRtG5YRVKWHD8MmIAcbc1q4RC04W+U7+hGH+GtNKDgymaZ6ekQ2e7j6YzSOcRuh5T6xoKNiTJYIfiZmananfOJf7CrvB8MkBlRoJKwi1L2kLWLRm8dK2+QgvoMZfhzpMl9O7/s+UqerWYst1wAufO39y4RjqomjejnkmCD2CNgLg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5064.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(122000001)(186003)(26005)(38100700002)(8676002)(66476007)(66446008)(64756008)(66946007)(66556008)(9686003)(110136005)(8936002)(38070700005)(316002)(54906003)(52536014)(4326008)(86362001)(76116006)(2906002)(55016003)(5660300002)(508600001)(83380400001)(82960400001)(966005)(71200400001)(7696005)(33656002)(6506007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?wrfwm6We1x0xSN7EsUUsjpcBokfCvgWyvTzt86KEAb2WrQvHgplgOCL0Qwe8?= =?us-ascii?Q?MWKIIYJlCnynxE8cV0bkW/wbmQcmztQSSOfi/0zXk/yOTnlkrpz5Ajs/kZgw?= =?us-ascii?Q?2Ju9TW0Rtc0++Fdv7pllBKnOF6AfOD9mdzXQ0bmX/xfQ43ex/AG6PagDlvig?= =?us-ascii?Q?haRVp4g2V41l/nbChrlTQbxHsphhNuv8msVqaQaShsaVNyFtUYcNURDuH3dv?= =?us-ascii?Q?UD3j3hi/jnaL5Ox9DoPkMyXTH+VMg8aqUGB/NpXjsiNPxsfp6Invl+XthGGO?= =?us-ascii?Q?wOh50GkdEpz6TC3R8yQdFuahMNuZOdB04mhqK6UE/n2HCkldI7qtLhNA5JJd?= =?us-ascii?Q?MB+JVgB/JXzUnkbaoGxEssrzgumNfjjETCrU4IRJfrMDH72GbQzY9ZEHMPIT?= =?us-ascii?Q?tCWYoLaVIzLYZekFKimWoMHbwBJ4+/JL2pSol66JpXbDEQAHACULu9zywu/x?= =?us-ascii?Q?YwPDWTj6jIVgenT1ni1gJvLwa5lUZG7AiIAaxIxEfw5n8ReL98SQXfHT7v9z?= =?us-ascii?Q?1kQe1mhkwpPkQ/L46u61DbrCk4302U8zVsKANSls09Rs47W9s5ZCtFX9Ve4S?= =?us-ascii?Q?uFTmcNI2lOXxGwTsGsw+nOV/qHW4ulIxeZhJoPnJ7q0ZjaFtYBZWl3fPLD1w?= =?us-ascii?Q?eMpuUQAse46icGXZqRBQmpTeNcCP2fQtzlnwOcYt4ylvo7vq45HqELFB6Qoo?= =?us-ascii?Q?h8L1dy4u0o0xrbsxPt0nxkNr7Y6IJ4eqTM1Vnjb2Nhrdqkgc+RH3x1GyAOwU?= =?us-ascii?Q?gtmioejcpatmOdhbW1gqCinzyzRSJEzq8txUuEJ8cUOfdM3JmpXxx/pyEFwX?= =?us-ascii?Q?37XLaL7p/znZR7IePXFxmunhHa5DbzLVHKh7h2UeVOkCV8Vfz2UYIKgPOj5b?= =?us-ascii?Q?tHB2lVjw/yebG74XAbAWF7ABPRLyZoON8c1IJ6HOWIDYguEtxVbpAozBUDy7?= =?us-ascii?Q?pFUj6yfLD4b2lQzK17/o3BLtjBy03TZ0gfGe3OZmv5Z6ye06WuWg+rSg0G2M?= =?us-ascii?Q?M5isZAN1sWN2ohCVDRbKNJzSQ7gkkswLHWN+m9tKVYok5TjUtTkd3xAfffxx?= =?us-ascii?Q?R/spSXSlXzFo5kc6QigOelnhmVuF2So+brltfdAmUzOdHZ7RiUxh9AaKGwOp?= =?us-ascii?Q?WPusklqvHYiT4KXgH9ZtyzSJA8LDCis8YJ0EjT6RwuGHKNTO3KRs9hdNsczF?= =?us-ascii?Q?xTctrsUvROZhhSAk31gl7owpIFGv3jhasfCvlcESv07BgEqlwgVaAT5gXw2a?= =?us-ascii?Q?uuVF88Lhz6OEVD7ZbrFc7uWXDec19/3FDzS2AUAaIMEz6PKH/vZHFT/1mZl8?= =?us-ascii?Q?Set+hJDo/xVg+NV53KYCQmak4mXzOE2VgBbNrWky6/nGCpOndY6Jvm0fSQWR?= =?us-ascii?Q?iYH9GktuUmy0Vq9qNjP/duIs9+mqPWFbQ5NQecH8IiYpBMPDNIzm4kfJhDmu?= =?us-ascii?Q?+K2bU5y2F2ir8NDXGvD0jFKUzUSKF/jey0xEENibHGwH8Kk35rJl+Eo2YLVf?= =?us-ascii?Q?1t9WUHGCVMpoTghZ85jnCidFFh3lDCzTg9g6rH0AMKprcIo3XzoL5O+HHGUI?= =?us-ascii?Q?0S5BPjCKI+66x4QM+7gBwioEmpzGDn8PqOPysBEuc2CAjqO3rKwkYEu06Gle?= =?us-ascii?Q?9//6DAV25CN/erKuBTBCqj4=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5064.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ede35937-0e05-4ced-c523-08da00acd188 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Mar 2022 02:39:07.5498 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 2CW+sCkcl50LJGejT1DWAZ5tm7mB6ynneBolGzSK6JinKv1YpXvFHQljBsQqjG5bcNrbjGU7VpPB610/TzVGTQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1101MB2250 Return-Path: min.m.xu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable On March 2, 2022 2:57 PM, Gerd Hoffmann wrote: > Hi, >=20 > > > Hmm. Unlike patches 17+18 which are pure code motion (except the > > > function renaming but that doesn't change the workflow) this patch > > > mixes code changes and code moving which makes it hard to review. > > > > > > It should be splitted into one (or more) patches changing the > > > functions as needed (and keeping the code in PlatformPei), and one > > > patch moving things over to PlatformInitLib without functional change= s. > > Ok. Looks like #21 & #22 in tdvf_wave2.v6? > > > https://github.com/mxu9/edk2/commit/ef0615ca5665b2058e4352a322dfa74 > d25 > > 8f9f31 > > > https://github.com/mxu9/edk2/commit/25f356a0bf7ee347be30e270aeffe6cb > d8 > > e0b464 >=20 > No. The idea is to changes to the code in PlatformPei with small & one-p= atch- > per-update patches, which allow easy review. Also helps debugging in cas= e > something go wrong, when bisecting found the broken patch it's *much* > easier to find the actual bug when the patch is small. >=20 > Rough plan: >=20 > (1) a patch allocating PLATFORM_INFO struct in PlatformPei. > (2) one or more patches moving global variables into PLATFORM_INFO > struct. > (3) one or more patches restructing functions. Stuff like like > splitting functions which set PCDs into two, one for > PlatformInitLib and one for PlatformPei. >=20 > Final step is a pure move from PlatformPei to PlatformInitLib without cha= nging > code. >=20 Thanks for the suggestion. I have created a separated patch-set for Platfor= mInitLib.=20 https://edk2.groups.io/g/devel/message/87327 Thanks Min