Re: [edk2-devel] [PATCH 1/1] SecurityPkg/DxeImageVerificationLib: Add AUTH_SIG_NOT_FOUND Action

["Min Xu" <min.m.xu@intel.com>]

It's good to me.
Reviewed-by: Min Xu <min.m.xu@intel.com>

Thanks

> -----Original Message-----
> From: Nhi Pham <nhi@amperemail.onmicrosoft.com>
> Sent: Thursday, April 20, 2023 11:49 AM
> To: Xu, Min M <min.m.xu@intel.com>; devel@edk2.groups.io;
> nhi@os.amperecomputing.com; Yao, Jiewen <jiewen.yao@intel.com>; Wang,
> Jian J <jian.j.wang@intel.com>
> Cc: patches@amperecomputing.com
> Subject: Re: [edk2-devel] [PATCH 1/1] SecurityPkg/DxeImageVerificationLib:
> Add AUTH_SIG_NOT_FOUND Action
> 
> Hi Min,
> 
> This SEI test passes:
> 
> SecureBoot - TestImage2.bin in Image Execution Info Table with
> SIG_NOT_FOUND. -- PASS
> 00C3C2F2-39D5-4D35-B7E7-587CA0F3CB75
> SctPkg/TestCase/UEFI/EFI/RuntimeServices/SecureBoot/BlackBoxTest/ImageLoa
> dingBBTest.c:1103:Status
> - Success
> 
> The test image binary is different to the one in the commit message due to some
> bug fixes in the SEI test suite. The right test case to catch this bug is 00C3C2F2-
> 39D5-4D35-B7E7-587CA0F3CB75
> 
> You can check the test code at
> https://github.com/ARM-software/bbr-acs/blob/main/bbsr/sct-
> tests/SecureBoot/BlackBoxTest/ImageLoadingBBTest.c
> 
> Thanks,
> 
> Nhi
> 
> On 4/19/2023 6:20 AM, Xu, Min M wrote:
> > On Friday, April 14, 2023 1:18 PM, Nhi Pham wrote:
> >> Hi,
> >>
> >> Ping for reviewing.
> >>
> >> Let me know if I need anything for this patch.
> > Do you test the change and what's the test result? Can you provide the
> validation result?
> >
> > Thanks
> > Min