From: "Min Xu" <min.m.xu@intel.com>
To: Laszlo Ersek <lersek@redhat.com>,
Tom Lendacky <thomas.lendacky@amd.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>,
"Aktas, Erdem" <erdemaktas@google.com>,
Gerd Hoffmann <kraxel@redhat.com>,
"Yao, Jiewen" <jiewen.yao@intel.com>,
Michael Roth <michael.roth@amd.com>
Subject: Re: [edk2-devel] [PATCH] OvmfPkg/IoMmuDxe: Provide an implementation for SetAttribute
Date: Wed, 31 Jan 2024 02:47:01 +0000 [thread overview]
Message-ID: <PH0PR11MB50643872B830CFD2DAD74D0AC57C2@PH0PR11MB5064.namprd11.prod.outlook.com> (raw)
In-Reply-To: <cc90ee7d-cbb7-728a-6499-446f29543d3b@redhat.com>
On Wednesday, January 31, 2024 5:33 AM, Laszlo Ersek wrote:
> On 1/30/24 18:15, Tom Lendacky wrote:
> > A recent change to the PciIoMap() function now propagates the return
> > code from the IoMmu protocol SetAttribute() operation. The
> > implementation of this operation in OvmfPkg/IoMmuDxe/CcIoMmu.c
> returns
> > EFI_UNSUPPORTED, resulting in a failure to boot the guest.
> >
> > Provide an implementation for SetAttribute() that validates the IoMmu
> > access method being requested against the IoMmu mapping operation.
> >
> > Suggested-by: Laszlo Ersek <lersek@redhat.com>
> > Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> > Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
> > ---
> > OvmfPkg/IoMmuDxe/CcIoMmu.c | 55 +++++++++++++++++++-
> > 1 file changed, 53 insertions(+), 2 deletions(-)
>
> Thanks -- I'd like Min or Jiewen to approve this, then I'm glad to merge it.
>
We have tested the patch in TDX and it works.
Thanks
Min
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114846): https://edk2.groups.io/g/devel/message/114846
Mute This Topic: https://groups.io/mt/104058148/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2024-01-31 2:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-30 17:15 [edk2-devel] [PATCH] OvmfPkg/IoMmuDxe: Provide an implementation for SetAttribute Lendacky, Thomas via groups.io
2024-01-30 21:32 ` Laszlo Ersek
2024-01-31 2:47 ` Min Xu [this message]
2024-01-31 2:48 ` Min Xu
2024-01-31 13:28 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR11MB50643872B830CFD2DAD74D0AC57C2@PH0PR11MB5064.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox