From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web12.10704.1632814553132567340 for ; Tue, 28 Sep 2021 00:35:53 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=MNnkbgzQ; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: min.m.xu@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10120"; a="222746797" X-IronPort-AV: E=Sophos;i="5.85,328,1624345200"; d="scan'208";a="222746797" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Sep 2021 00:35:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,328,1624345200"; d="scan'208";a="561917365" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by fmsmga002.fm.intel.com with ESMTP; 28 Sep 2021 00:35:49 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 28 Sep 2021 00:35:46 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 28 Sep 2021 00:35:46 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Tue, 28 Sep 2021 00:35:46 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.169) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Tue, 28 Sep 2021 00:35:46 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R9BivtduVqUfDb2xceANDIVmZheFUpkgBknBYH3fgLlcykzgklfsmegbzoudOznuZ7l0u2n16KeCRrkqfZKNRqVLDYfUAvWAvrEbWQ7pY3R0NigI0pBUe0i+nQY878K4frPVFcM0A61yd4G3lo35atPqsflx31p3T0ZzqL/iYpuZyGjiWmNRIoO7Zwzji5nsw1hXLEAnwtyt4G1BVqHM/suE5mAiAxCo7/ce9XTgnk6Xw9aer/oe0CK/+qNyGY905d1k2H8Wuc+hAshPLS1lUNLNylhdA2y+4EPDUgkOFKO4al9alnrLCFbQA4lbAhNC7FBAJPi+OnBxkiZa4t47Xw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=P4qCn12IZKvoxWHhGRDYXHmBE3O/llStiK2Vx8yo6As=; b=cyd3HBihY6UDzVu6xDktxvEeV6WKZ+og6UzPNbtQiGJQUO0u9A10mKmLvM9cHat3l2X9xsL55ZPvaOYVJLjvk2Hg9xWn1mMYmcAYw3bzg4l+K/8V/Fyfn/G6frjSoqbsF5L15ow72i/vv3ceLYCuQDRKM1B9VkswsWO6grGkDpqAqBoI3Rqg+lG8lgp1zkOEFLo4fARisqAvh8RvIEWLEzEL9gLKkOB/3K2SuDk3vDNeUSdhs+hx+mfBMYN7/sN0bIDNIdwWtzH/Uy43KdJ8TxPfq1KMqtucnimqGd7UEIr/hzeu9wg9JAkadc9uPqhCEz51B+sUNkpjGd9QaTtX1g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=P4qCn12IZKvoxWHhGRDYXHmBE3O/llStiK2Vx8yo6As=; b=MNnkbgzQpnK77osDYtTbw8xhetd5CfNW2CozvSqe+F4lWDuEaPTjwNoIqEkKQllXR/ENwfABaCa7u9C2rdKSOmpQvChk1luMvsZYvbJLar4O+Ok+vC/AW+g6tHmpPw9xHwhytbXUpxKVaH4LKU6lNFXHpQhnW9N34akgygG+5lM= Received: from PH0PR11MB5064.namprd11.prod.outlook.com (2603:10b6:510:3b::15) by PH0PR11MB4807.namprd11.prod.outlook.com (2603:10b6:510:3a::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.13; Tue, 28 Sep 2021 07:35:44 +0000 Received: from PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::c93:200e:5aeb:e11b]) by PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::c93:200e:5aeb:e11b%3]) with mapi id 15.20.4415.029; Tue, 28 Sep 2021 07:35:44 +0000 From: "Min Xu" To: "devel@edk2.groups.io" , "kraxel@redhat.com" CC: "Yao, Jiewen" , Ard Biesheuvel , "Justen, Jordan L" , Brijesh Singh , Erdem Aktas , James Bottomley , Tom Lendacky Subject: Re: [edk2-devel] [PATCH V8 3/3] OvmfPkg: Enable TDX in ResetVector Thread-Topic: [edk2-devel] [PATCH V8 3/3] OvmfPkg: Enable TDX in ResetVector Thread-Index: AQHXs0QwX8//s6Z2f0yRFpz23fm/qqu3kLSAgAEMVRCAAEMIAIAALc3Q Date: Tue, 28 Sep 2021 07:35:44 +0000 Message-ID: References: <729034c8d47013be1e87a68ba1b6c3a7b79a4b2a.1632707635.git.min.m.xu@intel.com> <20210927084235.pj7x2agzzzjqz7be@sirius.home.kraxel.org> <20210928044254.kdqpd76ltmcllqkr@sirius.home.kraxel.org> In-Reply-To: <20210928044254.kdqpd76ltmcllqkr@sirius.home.kraxel.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4c1170cf-a108-4470-b9cd-08d9825294bc x-ms-traffictypediagnostic: PH0PR11MB4807: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: USzRvw19POB0G3UHUj2UxfBNpVPV0dxNy96romRWZBkz9TK28sQa0G124rDsY4c4dDQhIoQ3qiFx0LrRcyua6ZtzYZuuZ4T2LgNIsm3cq6uqNLgDYCc2S+qUDSt09fdTaszpXSyknkNfGKga3HjmPoGiUZRqSgLI1l/uA9t7hRMZdr4TVGIMdrz79cwxCfTGK7/9l1bM9IAbA9mQUmPoOTB9Urcl6+H/p3n+CHux/qnfob4viE9p05OsuqUuOoFvsPJW5pHw1poyJ7U1T0x+qEnNN8p2eYc4MPKb6SRERHv10z39DPAmrEyZq4GnXRy205LGgaHzXQY4rkkEqFXEbQIXmE6dcWaK8Gg6y5WpQL5r3I69zRsdUvsCDFmjuglEH4o9bQ/7JmXtwbgZ7OlaAZM95EBmBxQ09/aTojIXmvrFcT72OurhW85u9cH+0OEb6q8bBUqWZPyqKXiUMKsBnwvBDY9axWbOOfjlw+FVnLiPYjzdBcAkTe6IQrER+lfHbity5R8DcUcGz4JNGX7/tI/cwRVxMKJAtj1aU0WWb8W6Ws4TMlU980WFIGIis3z+hPys8rcPJCAV/UbRDOoEV3EFucP4zmXhItmhZ87w74cwhgUZe4Pxs3Bx3i3tFsRtHsVrXyQjlQkJED9+rkpQCCINtqwrtIvKeA11NF8NMu1SJuQYZE60Qq7AHzX3ZDF7ERbpM829MJZasHnnrG8UKCoTasgFXvPbJ+tF7dos2AUvNMjZgzKYE12gunrHs6aHd4DKH48A/eHeGusALKTS/nUBwzOpptQl/2mtITpB6g1vOHodkKBV45esJVsVYTuwoLa0Yw5esaAoNYr/UtVFSA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5064.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(86362001)(83380400001)(122000001)(76116006)(38070700005)(54906003)(66476007)(66556008)(64756008)(66446008)(110136005)(7696005)(38100700002)(33656002)(8936002)(5660300002)(966005)(71200400001)(52536014)(186003)(2906002)(66946007)(316002)(26005)(6506007)(508600001)(8676002)(4326008)(55016002)(9686003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?MNU04tyM32zsBq9PWC+20rkrRyHjS2kKuhYYRRehjg8XyKYn/PsA//cijXwp?= =?us-ascii?Q?2WxTpVBinPt4d34zl4ipUS2zpvwJXuWVTtT40vzBrtVwSYebs0eKfcP7toO4?= =?us-ascii?Q?oR+hIVXPVCV84/IJbFDKomKNkHC1rzBsgKqno+PpEuGm1jXnva1tPgCf5KWl?= =?us-ascii?Q?hHIJGMSZIU7tkVfota7Mav5HUFNBGo45hchqD2wWxKYrEb8GuoGD0+5/gZ/P?= =?us-ascii?Q?jCJ2tFE2NJwMw5ed4XLR++fO8Ud2d34ZhGKHCbvm6zW5AWje+hXon3Gh2A2l?= =?us-ascii?Q?2gGSSvk6jsU/V9xLoHvcDAcQLCFYOwUC/PMoi10Ianz+aKJ2HWbx5s30rYiF?= =?us-ascii?Q?U7b+/sHScGhPULIiMmFqmIyoVvybeGJDCyz1Dbb/l4qD8zYVZgTBYPUtp7wT?= =?us-ascii?Q?jUnRtMDoIZRhf35r+XdVcCNZZzEM0kIVV1ZD+gvxsWj5MyxjwrZxE0Avxpgh?= =?us-ascii?Q?YIUZ2IKVxRdvGfQq30aTGhj8YcLexFkKdwXwD5wCgjQA6zFoQXBjxgFNf3xb?= =?us-ascii?Q?K1W4OmwByiBah8LcVU8bS6aFItt3g78LAB6OT+EtZGybDROOLOLo6zWkA6hv?= =?us-ascii?Q?ZMbJ05l9nXMxe5AsecOalzhIjHr6fbkT0dsTZilMtiOzG0prWnR08GEcw/2j?= =?us-ascii?Q?lhB7VEUtsyurylKQjIUeZP7BoJ2388zoL8+yQiwD1A1o0P+MBcGDfR1HBlNs?= =?us-ascii?Q?XeZmGFUEj9KFc8MqzZB98SSqPdCGTGtqPfN+DmVORNYubX5aWpZ0xVkzHYnA?= =?us-ascii?Q?umUC9uSIBUj7XUDQMmnNkMmYb1IwxpyJTT9mpMKqp6ILg2dItiL1jM5Sh7yv?= =?us-ascii?Q?BWGsSZPTQHaLZ30jNoP3D0JkDXSGIqJPnCEsy7LSvk0fHIOmBxYMxiVwTMP+?= =?us-ascii?Q?ieZpeF3UQTvg1f+TF5rUH7F++G9bkrbJmQdwju6WUxTvljYEMbVnZzhcbf6g?= =?us-ascii?Q?H4q+GXOyg/q3shi8LsBE86+d/jVoI1DuiDaB7OjJvHxzAgfvMsTkp8Cnudo/?= =?us-ascii?Q?8jlA6PCMHE6vYSHQKi7f+mrvVZvezs6B7wAOH/f7Ms8L+FBtNm6cCp4TN53U?= =?us-ascii?Q?9O62mbAoFfG387/igZBgWsODAtSBFoe1UMUyQQAZAIBBXYVdkM1xccys55E1?= =?us-ascii?Q?T3lpk+hsZZAa7/LYPGUa1d6+G71I/fazrQ6+58ZdxON+cR8rL0S99ipTJZR1?= =?us-ascii?Q?OE+UP925tPEvDndD6lJYl6zUnzTItzfrISKkvA5AwaYm28Jgr+7h5cqsSd0r?= =?us-ascii?Q?uTK5WBqrhCdaucZ7Mra/V44b1EIzE2N8nVIDHfAKmV6pS+yUix/Lxn4WyQrf?= =?us-ascii?Q?VwCprrNgo7mTg7pIIMmdT5bW?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5064.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4c1170cf-a108-4470-b9cd-08d9825294bc X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Sep 2021 07:35:44.2597 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: BjvyYiAeBWy2xupbukARAYqC9OUKZBGM23HsKZnnH+ZSL8O47ZP6FwhErCnYCY44q6f0SvwXr2Q0AdHkROKWkg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4807 Return-Path: min.m.xu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable On September 28, 2021 12:43 PM, Gerd Hoffmann wrote: > Hi, >=20 > > > Can you move the metadata changes to a separate patch please? > > Yes, the metadata changes will be in a separate patch in the next versi= on. >=20 > Can you also add a comment block documenting the format? Not only those > parts which are used for TDVF, but everything? The description in tdx-vi= rtual- > firmware-design-guide-rev-1.pdf seems to be incomplete, specifically the > option to use the table for TD memory allocation (as mentioned by Jiewen)= is > not covered. And possibly there is more which is missing ... Sure. I will add the comment in IntelTdxMetadata.asm to describe the format= of Tdx Metadata.=20 Here is the PR I would send as the next version. https://github.com/tianoco= re/edk2/pull/2018 You can have a preliminary review if you want. >=20 > thanks, > Gerd >=20 >=20 >=20 >=20 >=20