From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web12.5673.1648555438190448201 for ; Tue, 29 Mar 2022 05:03:58 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=m9mYaVfW; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: min.m.xu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1648555438; x=1680091438; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=+uvEO3sMe+qKExNgyPE3EPvKaPrho1nmwEDqfLyw/MA=; b=m9mYaVfWoKe7xSg8arNeMVaSIgVjI9ggo0OSJZR2muWhWaB0gasay8W3 HIE8Zeb0Wvwdiwpc2jyep8zfpR1vpzUATs+zUVLCIw0G9/vSDlOTiv6sP ThFFtXbBdAaSZqJ45wgduqTXBhnA09JUPy7Z3lUTUcHaK8zhH70E0JLR0 bW/d/GNj1GBHYY77UyUG8znjbvrET3w5e4P8AKd53MnpOH+WHk7jfn6r2 02322aS+A/wvefe+uc6wcFASbXE8g0xxmwX2Z1O6zVPXPbpaYFOYaOpUW V9RO9TJxZmLCWBk1FAXqiqt3gGoBQ6Piw1793fi9jJYPTxFficIjjezjY Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10300"; a="258062170" X-IronPort-AV: E=Sophos;i="5.90,220,1643702400"; d="scan'208";a="258062170" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Mar 2022 05:03:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,220,1643702400"; d="scan'208";a="564576316" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga008.jf.intel.com with ESMTP; 29 Mar 2022 05:03:55 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 29 Mar 2022 05:03:55 -0700 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 29 Mar 2022 05:03:55 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Tue, 29 Mar 2022 05:03:55 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.109) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.21; Tue, 29 Mar 2022 05:03:55 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IWTa2X5JGRVaJ0vieO984yHF25/a+BHPxkzcjCAxymdmRtjX83k5fSffJJjYVIEbXXL/FTGmrvy4IrFNyJVfTls/fcnGqWfbYT0IMF0PODZA1/x4sp6pqQQS3wkDDMrwiVPaSctdbwBP34knejYzEcIDz7Iuss7hkmRoLJY9VzXyFqzpIds0an1DbwKJFEEhL+xKZ6d8dIabbJwnFmXScKmpDU/jD+LzKvCrmgiaSkulG8YPs8+ArBg+glQwklyp2YnpctykP+cc0YPpFB9ubt99o0WGZkz9VYv8HNurKP38hAg8Lrkv42xVU62bfBbVpEXr/86wy+naAZZdvutPYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tvBOBzXN1Hl5laQmOatmz0K1AI/AFm6P2JsNgZ9ewJg=; b=Y/TQPc/oKbTvD6wq8GF5UlyMKbnb4hKhUkugYoLvbKMCPD0t24tdIPpirFg1XYgCxQ1607R2nkXlU1/l38GcPAVp/GJKDzzwdqoXqJ17Gv8f33eQEhiWLQq4AI37+5Eb+PG/E90orDNJkKwSFy3ogy87vQJ6mclnnOOQqubajDacX+uo5AGWi5Inutofs3oxNfnYwUqdaZrK+Z5uhnZvC2AiNPnh8P4aStdA1X7T8qE+A2Ah9qntB0nUkJo3hCKQ2O/6/yYnsa8lISlOI8Bwfe09tqtRqfB9my0FYPnrNRDqztsKFefgXcWXl0tflvF6nKtBP2Yi6SscgcxdG4a3Zw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5064.namprd11.prod.outlook.com (2603:10b6:510:3b::15) by CH0PR11MB5540.namprd11.prod.outlook.com (2603:10b6:610:d7::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.16; Tue, 29 Mar 2022 12:03:51 +0000 Received: from PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::ece5:6170:a99a:480a]) by PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::ece5:6170:a99a:480a%6]) with mapi id 15.20.5102.023; Tue, 29 Mar 2022 12:03:51 +0000 From: "Min Xu" To: "Ni, Ray" , "devel@edk2.groups.io" CC: Brijesh Singh , "Aktas, Erdem" , James Bottomley , "Yao, Jiewen" , Tom Lendacky , "Dong, Eric" , "Kumar, Rahul1" , "Gerd Hoffmann" Subject: Re: [PATCH V11 14/47] UefiCpuPkg: Enable Tdx support in MpInitLib Thread-Topic: [PATCH V11 14/47] UefiCpuPkg: Enable Tdx support in MpInitLib Thread-Index: AQHYQnsoyrTVjQnKo0SVjjHwWSW/4qzUdZoAgAHPPMA= Date: Tue, 29 Mar 2022 12:03:51 +0000 Message-ID: References: <6ae0bfcd1c819318d3745732950e4cfc88c373da.1648454440.git.min.m.xu@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.401.20 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b6fc680c-8dc5-420f-a43e-08da117c30bc x-ms-traffictypediagnostic: CH0PR11MB5540:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: hnbaaIQB0uTajAKPBQNOLPaNJ3kZ+9IN/SPqiHKgnliasEWUsDyUlMMGNA6q1m8sV+9+Y1YePwpIaHk2O21ccrHwq/5gp10EG/TlbqXxvuh1NFASwxzAoRZGVPK8aJjJ+0N3t+EQ1sYwsdVvCpZIHM45jEd4N704fPyT4yRf7HQ+0u+/cgZmh1P994EaSHh8Sfoq0gyMLYvnegLp5yvd9vDKS7MGlm6+fraM3ngS5CddOothilVK0q8qzR1HP7BNg4zWyP+ydzoIn3jplx6IIDwIfW+k4rGX7oG9x770mVQzSjDEWUXds8ytE2vC+wPvVBuG1YpBHQVyMApTY+syws+/7u2xLCdEsE1EHMUknEzv4kPyBzeN9yY7ZYVoDCYJeMD/u8Z+7cg0x4oZMzflasbxHuTWiCbdHfV9MS9GkutoIf1fsfWssLNQMhtD1CMl8+jAqSICkjQAEGulK7in3qfbnZvEuiS9/3/rDTTjhFvqK7HkTZY8OSZdHciCgMvJ9k4PZ/7ndzjcCUpz+zRGc05r9sE1l7k5hDLD4hOAVWGWd1MlCP6y5y/y5km+rtiCfOKmhtiniRp6ZjyHdXuQG5Dx7mub9ZomovmbCc0PZF8X0a+tm0xuZEm7BQk8YpclgXAAC2p2CHuYX8Vpofr8ktqxcvmNpVVCgOUHRml0wrckyIO2CKsNPVwr6E5dEBebj46gHfnanN3Tmv+N6KELWw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5064.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(6029001)(366004)(82960400001)(66556008)(76116006)(66946007)(122000001)(64756008)(5660300002)(66476007)(86362001)(66446008)(110136005)(8676002)(4326008)(186003)(33656002)(55016003)(38100700002)(52536014)(508600001)(8936002)(26005)(54906003)(71200400001)(9686003)(316002)(2906002)(38070700005)(6506007)(7696005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ypm+fLqGHO/aFjKdmFWucc2nSDBfSloujJVTcgbPz7RvIr3ox8557fWuc1LO?= =?us-ascii?Q?We7/17CnrI2G8o0/Asaw+YbKGPbGhC7eBTxhn7lUirX1U1PittpK6Irdd1ek?= =?us-ascii?Q?sruTQjMSj0BGnWcYkQI82tyQDRgGFZQpG24J16lyEK0zfpQ3tiyndACCQlzt?= =?us-ascii?Q?ehk6Bk/UQXOB55zAtBV5VdOPlb5WkGu+r0oByw/zMedGLl433bc2JfyQ2Jy6?= =?us-ascii?Q?hpyx3IG7KOphNzNkC3DUuCXLgKyQ+6Yqt3gzx6si+Kb+sQZEwjjK8LR/+5UT?= =?us-ascii?Q?kqGcP0JxvtNhE50TqYrqbEG0JRB4Hs6yXw88YSbP4RqnwvpGJMeXoCARO00h?= =?us-ascii?Q?qodFZTrQLSM70H/tSbPoIXNM5NFSQC6uf71Mi0lyHjVErXUQjQV3xsPoVTSg?= =?us-ascii?Q?mdGXfbtJzaVHPOFVHqYBBlgGM9S7ikqIYahrKq4XBwV00zoQtswgNI0H0qor?= =?us-ascii?Q?P7P13chHwnuX3MHqUkG/yxFOkTZhANff3m4gbhtHrWwZpuQL78umy/JHXPZs?= =?us-ascii?Q?aglUdL9uLgZq7V0sw9SylYI5PWYMVbbSiGfuEGI0K2hLndb0l7dShEdc2Vct?= =?us-ascii?Q?RL27nhlY1bHCfzgfMWvfW+I2DcBf9RXzJyy3FfgGPQVfN6PEY9S8pYvjqI5K?= =?us-ascii?Q?hZhOr5wXoZhWTmJJYmUheMGjqp3ug8sSS0tG43JcjR5TxUAr7M/1NLEwsXji?= =?us-ascii?Q?Pdr/vgLNibAq00PJBqzKD7a5nX7stbgZU2vqjGUtbbFH1d7k0JniI8y1iZh9?= =?us-ascii?Q?lfgZzSO9rsUVR+9bjoeYWC29Ehy20YJrrj5OYOXBOavCfDhtAsWr87T8pHDb?= =?us-ascii?Q?PtsD6ul94wuVsAIxr8GVEmK/gm2dz8R7vNMn3s6frizPqztxGnPCbf8ZQSX9?= =?us-ascii?Q?UwrluKDZO0SbnWYDdIYUACXLfJLdK29Q9cc4qWzYBS3XVTqFyUav3bHWRYWT?= =?us-ascii?Q?3f4JeQcETNPo/lnhqwRvOVU+AoIkmnXuNTxTUqmAbBio/MNsVFcw9Ywr893v?= =?us-ascii?Q?9JpNIt03PPhd6vHB0MPlSn5AYLmJBkWZKMcAAc00S7KXb5dw/WVeOEvmPu/P?= =?us-ascii?Q?TQfJ0ufcz8fFo0bqS/VxXOV515G88IIClNZYwFNeoTKIu4hVEfKiMZISiVoR?= =?us-ascii?Q?ZppeeJmKrM+FwYYmPJ0cZuV4C2dMPMETLQ3UU1B+fs9f0qUUrb8+Aq9BCsV0?= =?us-ascii?Q?JHAZiDZWa2EktBkXD2GYmGU8+KGKwv85oeQXSiMX6JfBb8cKLtZn4UzW6YHi?= =?us-ascii?Q?cbUIV1HW6dAf+TNIC+rUa43J4+SvGRRbJwv3tcpvJJ7DXvkDt+O5NJwhZ8Bk?= =?us-ascii?Q?n5sOv7i6X0HNcrnr+z6XBXsOKBTNCIPevwVFfQNe9IijvK7lzxhr0rROWtLr?= =?us-ascii?Q?O8qW5kk6ptPP8//XBpCxBrlzyjodZEB7oBtdyIFrmVgWWtgQs1HOSlRUHSAs?= =?us-ascii?Q?ZAY2zNIg9mhR7QSd9Q/px/g6GKWJ4zXknxxBTOi2sIB0NE1h1V8yvfR9NhRW?= =?us-ascii?Q?SdfG9pTHXRZwHhrifmbUSYkCz/uqA0HxYqY4/D3xk3PmA/LCRzLAD03U3eD7?= =?us-ascii?Q?fk3h5y1AEVRcKAl2UpdcMTi94/40lyAm5KeYWGrL2eGUPHdPHhbGS9asw+YD?= =?us-ascii?Q?5/Zjqhk57NpkzqPr2TfowDMIl2kUz+asIWtIVv/T0BQsfMaAtzCTeeIbZuin?= =?us-ascii?Q?r/Dj61T0QAvsPecEihoftyNTSmEHHqESTcMVPzUN5I8eMCMADrHAG87qarmz?= =?us-ascii?Q?voScsCeGkA=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5064.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b6fc680c-8dc5-420f-a43e-08da117c30bc X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Mar 2022 12:03:51.6070 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: bI2dCJN8loMl5gEete4/piIGeETm5uWpvygFs1PwDL1Ok4EnivTqF2KupvvZP8PPYoPNVA1IVzU0lqiOBemVCQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5540 Return-Path: min.m.xu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable On March 28, 2022 4:25 PM, Ni Ray wrote: >=20 > + CopyMem (ProcessorInfoBuffer, &gTdxProcessorInformation, sizeof > + (EFI_PROCESSOR_INFORMATION)); >=20 > Min, > You may not directly copy the whole structure to ProcessorInfoBuffer. >=20 > Because per the structure definition(below), ExtendedInformation is only = filled > when CPU_V2_EXTENDED_TOPOLOGY is set in ProcessorNumber. >=20 > This behavior is to be backward compatible with old caller that passes ol= d > structure (without ExtendedInformation) and support new caller that passe= s > new structure requiring ExtendedInformation. >=20 > So, the correct behavior is to only fill ExtendedInformation when > CPU_V2_EXTENDED_TOPOLOGY is set in ProcessorNumber. > The CPU_V2_EXTENDED_TOPOLOGY is a flag to tell callee that caller provide= s a > big enough buffer for ExtendedInformation. > Thanks much for the review comments. It will be fixed in the next version. >=20 > UINT32 StatusFlag; > /// > /// The physical location of the processor, including the physical pack= age > number > /// that identifies the cartridge, the physical core number within pack= age, and > /// logical thread number within core. > /// > EFI_CPU_PHYSICAL_LOCATION Location; > /// > /// The extended information of the processor. This field is filled onl= y when > /// CPU_V2_EXTENDED_TOPOLOGY is set in parameter ProcessorNumber. > EXTENDED_PROCESSOR_INFORMATION ExtendedInformation; > } EFI_PROCESSOR_INFORMATION; Thanks Min