From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web12.640.1654646537950415645 for ; Tue, 07 Jun 2022 17:02:20 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=DqbHcSul; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: min.m.xu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1654646538; x=1686182538; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=8PxYbLmJDz2WEeuR2c4zUqcYi0OwzdF9sE2csb7DG2I=; b=DqbHcSulZeZwLPZqC0YY1C8pU9+m51zdYn9aDCMfmiU2WZgyH2SZZofE PIeJKOqTNxZOzr6rX4qjtc5QAGz9b9s7hXXdPl1AtwkS61mFW2emkxyi3 zjIWOc8lYMyaxJMLBIyUL1qWGIKPhJ6f3FD73NVteH18A93pOmQXHWWHd aV8cidNxsAZhzxySVaJufIu6hg2vdM9JXFoYFQWlaT5VErx8InYX0W3H9 Qd7SSZ9ihxi8sEJmwtcKRLPz/cgByOEZFDLAGjMUeAIsE/bW9xbJ5qF0f WMVyXp5MmQUT9gGUfgSwInw806eDa4KXfajmFH+wly6jUJHl6k/MP0Ocn Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10371"; a="265455870" X-IronPort-AV: E=Sophos;i="5.91,284,1647327600"; d="scan'208";a="265455870" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jun 2022 17:02:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,284,1647327600"; d="scan'208";a="584481606" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by fmsmga007.fm.intel.com with ESMTP; 07 Jun 2022 17:02:15 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 7 Jun 2022 17:02:14 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Tue, 7 Jun 2022 17:02:14 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.173) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Tue, 7 Jun 2022 17:02:14 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jcu7s3hyasO1J+8/GwWoDtiE8QrpM5RGXA3eLoBZTqw3VzDiHOpExr79A+DrBp3d74ec1qFca1BJzDfJNTYFd5xtzba/mLyITkD1OJGwFdlhO8tqjZC2VuhcoQ8Yz5aE9tzWxbn5ZfXKYLia5MJCbb2rxD8tGDLOvTFYtE8UL9QWCiSNeMhewy6SLZxzpSybnY6g5m+Y3z7a/SuShv/9xbOk8chng4CuSxyNHMlExu/RngjlDiFJTosK0SBwXupmL5RcrvVIkXHp0u5GuB4YV2aZnQiub9W+ZX/JlQvqYuldI1p/tGJ0QLb1vCd5FPOj0M8ZsTllYAF9a51naeRY1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZHKeGlWDCkaRsT8oVR60sBrPICbo/Qihr0bKcjXmPMQ=; b=fyIWa5w7GmlYeSiU/dy/tepzcUVtrlelgR6ahLdbRYvkiJ9Rs8K4voFo/raitbGQNduxfwNOmvR7ub7Wa9x7oWStXfkimPYRqSOvC4vNYNos4sSvG+1uznbIk2hJMD/YntCimAEQ4Vdu3rUgBpLmJW/fJIPFEL9DHWDrWdn/hmu/rXNmurjVThbWvfGJow6dowfXy5cGorjxEcx6BtO/vxrIVNNrk4j/bA+OSuF3XkSWXfNJxKUHTr0uWHBppBiXQVUbj7zIHdalBP3wxWnmW6qLIrzFcaTIxmpbU5+Qajw9GOMpL+qCsKkqvo48CkVTL0/CunmfKAn9bFlBVBchuA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5064.namprd11.prod.outlook.com (2603:10b6:510:3b::15) by BN6PR11MB1442.namprd11.prod.outlook.com (2603:10b6:405:9::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5314.12; Wed, 8 Jun 2022 00:02:07 +0000 Received: from PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::1844:3fca:639e:7c56]) by PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::1844:3fca:639e:7c56%7]) with mapi id 15.20.5314.019; Wed, 8 Jun 2022 00:02:07 +0000 From: "Min Xu" To: "devel@edk2.groups.io" , "kraxel@redhat.com" , "Gao, Liming" CC: "Kinney, Michael D" , "Liu, Zhiguang" , "Aktas, Erdem" , "James Bottomley" , "Yao, Jiewen" , "Tom Lendacky" Subject: Re: [edk2-devel] [PATCH 02/14] MdePkg: Increase EFI_RESOURCE_MAX_MEMORY_TYPE Thread-Topic: [edk2-devel] [PATCH 02/14] MdePkg: Increase EFI_RESOURCE_MAX_MEMORY_TYPE Thread-Index: AQHYeVGgwvdf0M2hzUuOcbukwqlakK1DwxkAgADfnaA= Date: Wed, 8 Jun 2022 00:02:07 +0000 Message-ID: References: <13769f246c324cdd21c7e22e42fa3f92cbaa6a1d.1654420875.git.min.m.xu@intel.com> <20220607103930.nx3jcln56ttorv3d@sirius.home.kraxel.org> In-Reply-To: <20220607103930.nx3jcln56ttorv3d@sirius.home.kraxel.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.500.17 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e14a4dc8-8c57-4c2e-654c-08da48e22082 x-ms-traffictypediagnostic: BN6PR11MB1442:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: iZ9M+J4AtizhiaLICpZ6GS87vpdklFxqu0kgRYsXe8+0SZqCcvPeKGDDAT04t3b3y2tDiGsWUC+pMHpsn8W06MArIlMOr5+uP4iQufXYEIO6Rv8gAzCeTNqX/KFmKDlwmwshW8sF+sjATWRy/55vTu2wXm9KxLc8BDR8MdJMoNX8bNJd5atSI0WPgWIHXUr8AN+UmCS3T46lXe2FNW7tUza7Vg+O+Gqs5gfSMaaJs/uC4N2a7chmPwDfXAyAoCIpxBfIBiTL21PXGfB1NOxoa49aJH3iXCSa6FUVfi72UPouRB0NDSItSxL7VTrPzy9+uZVzuRF4WyuzolyTjkoR1+vZfbRagnEcoiJkR8m3hQdgw4qYqP+wTlj6mFe/fUpgZHVm2rAC7oaKIDDCGoNMVoj478JMiWK++UgRZNy4Va+54YPzPBCFwEYjxGyYfuq0qxFZj4Kd+I9mYJIHr2N7f5a89rqJQeuEg3jUvoBSmMCtLRQnca/Eb0bJ0JRew3NpZjJlgS0KazoYRnveJ89IIxUDefWaV6VkV69J8AA+NNEf4VVAViUE/7oiyZtG+lokXA0Ksz0FiCTkIWnzJyPziOs8pVLOgQVEQkyRxU+M9IkZcpX4jbkZ/4PAGwvTys+J6sa8nQnfalZ+tel+JJ5x4v1MqEKK6KQpjQlzjGVeECY+jUTvXyVArCuiDs8WurQfGHTgR8Isbr9YiodAFnXu5A== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5064.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(82960400001)(38100700002)(86362001)(71200400001)(54906003)(83380400001)(7696005)(52536014)(4326008)(5660300002)(64756008)(55016003)(6506007)(66446008)(122000001)(33656002)(316002)(8676002)(38070700005)(186003)(508600001)(8936002)(66476007)(66946007)(66556008)(76116006)(110136005)(26005)(9686003)(2906002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?r96+V4Es3SFWevzd4aSwMYDpxQKh2McGs7tlhJdOMjp/l1vSykJSzvqx9W3R?= =?us-ascii?Q?monWsy+64kUofoshmvk8ROj/1lVN9ToyU5Mn9eME1UB8ueruE5kn7uxUkJyN?= =?us-ascii?Q?IQp7ngqAL1w9YkkDRZFcfG1uUuuInSoIhW8DNZQTX2aqzsWNtXABg/DtQn3X?= =?us-ascii?Q?Q9XUTO1oDumBqzfCNLUzWAv7d5hXqHgOGOZQx81uaO4+14+CFWyTfQFfb4S4?= =?us-ascii?Q?8ZK243Pfep/PpSv948ZxJfkS3jHouXb8ZiQbqU7EWB2JOiA+cyWMKUsHzA2U?= =?us-ascii?Q?+Qz3A2U6WaE4uSxbYmhV6aur7SfILPrfDaxrO88bJy4vDrHvOhgZadYnxTH3?= =?us-ascii?Q?a5uc4FKS/+3gTPCN2NmOf+8QY1E//mZyPnBtCTANvMrexiEJHY/P6gdbWCJT?= =?us-ascii?Q?KTdgD94E2ojVRYNK8zZ7Sb6daKx3nPzTbQkbGpseyH1dnljrLaXoPO7P2sqQ?= =?us-ascii?Q?1O1Uueyyrch8D3UhA0wMGHFK/+R/oiycoxqVhvpkrVxla0zMc9xUQpNRfk1G?= =?us-ascii?Q?sKm6GP2nqgbLqanI7rSejSYiy3TdOwy5u4GZE+l1pIwr0HwA9xf8CatzJcAR?= =?us-ascii?Q?rP7qWVHiO2pn1f3md5VxiaiSjW8XjimCvwoOrySQSJSg++hqJs+Gtr95zTZN?= =?us-ascii?Q?3HweAmo6OTjUYMpwZjv+xu0bC8TWL6xneGXCLML63INdiZ6zPT/YSsWPvv8N?= =?us-ascii?Q?wywyKpE/VCVry9hTbWN/yOLpF4vCNghv26alxTY9HHNTD8hVq5ggBxo5x4o3?= =?us-ascii?Q?e6TI1WUGznDXwMo/imViXYGTsIJ4w8cS7mYUuViy8QFDxbfuYMSc1vVSe5l2?= =?us-ascii?Q?EaQab1vWzlM3I0PMDr99AahPHHy3yJEj8Juiump4c0AKDqwv0zg1UpkpIq97?= =?us-ascii?Q?oOwcrtO8GpTefSLEnhTQjPvnyj8H2ZfVYynfy3gzVlyyUtgj1bpt55oOAyKp?= =?us-ascii?Q?UXMnRUkco5m6RDwjnZOXJFsIwDlgNNoCBXj0+57YFdL7enHlxLsDH7B/RZFd?= =?us-ascii?Q?TUIT8NeO6akH5d3JjTBQNLfVz4I+f2T0ZAI+liB+hp0WGDgJp60ermT8grHT?= =?us-ascii?Q?VXRhZIEFItP3SFWFvo6Ay9Shi8+yUkmyhGq2f4jc37wGvkO36od/klOZNzKN?= =?us-ascii?Q?+rdtPmTWPnuLr/LqKo69kQVQoN2CMo3tXyiiAgNO7CDof2MCddPenP9LJpR1?= =?us-ascii?Q?5MZlKO/v5wZKRvlh66enZeusIQcATazqgHT1DTmr4BdKeOsDI7Gsx5KY4xU+?= =?us-ascii?Q?IFj/qCCEnC2Bx7mhLbH/oqKsD31IYrpb3AK0aEf0fynca4Vyg0a3FLk8M7st?= =?us-ascii?Q?I+A+U7soLzXoXR8KnlmE9xAqEiXV+Cu+uLgfNWo6GdU10RmKJ+awTpRCx9f8?= =?us-ascii?Q?y68B7W9AVRzuDOTNH12zFzVUheAK5MK/xqAgaGTdBXckwmSgjro+SYDgvbjU?= =?us-ascii?Q?Fp4s9ihmHdZkcpRiQ3G+5fij156/s9ka1lTlRx0ATfMQD9bBDqvXE671/Erb?= =?us-ascii?Q?3adY1HGf9XoxBbqP8LF0KwsxZrb763oPSNPXtacUmu43/EkIKJM7ql1zVJK2?= =?us-ascii?Q?S6ElGzoi7F7/zcTAc3C6/gw24hzHnPOwy0T8wuUya34cEVTggi7gVYZx4sNh?= =?us-ascii?Q?QRxahgLe5RS9b7XZmBWSBG9jDScJ2GL2gZrTw5ph1er3d5neehWwNYFjgeoA?= =?us-ascii?Q?QW7mWzZgNdIS7HW7ttPO1Fo2q4yMYlYxoOZOWgKyg34aGkI1dDbig9KjSnuh?= =?us-ascii?Q?h/0UxQNeeA=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5064.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e14a4dc8-8c57-4c2e-654c-08da48e22082 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jun 2022 00:02:07.1259 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Vn1p+nEaZwkqvW3RXxoHRe3aKHBIFg2DWZDvuiXWNYhvtNEPpVedn6JYjGhleNpbV7tIGO4lDX8gWQ00P43Efg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1442 Return-Path: min.m.xu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable On June 7, 2022 6:40 PM, Gerd Hoffmann wrote: > On Mon, Jun 06, 2022 at 10:59:50AM +0800, Min Xu wrote: > > --- a/MdePkg/Include/Pi/PiHob.h > > +++ b/MdePkg/Include/Pi/PiHob.h > > @@ -232,7 +232,16 @@ typedef UINT32 EFI_RESOURCE_TYPE; #define > > EFI_RESOURCE_MEMORY_MAPPED_IO_PORT 0x00000004 > > #define EFI_RESOURCE_MEMORY_RESERVED 0x00000005 > > #define EFI_RESOURCE_IO_RESERVED 0x00000006 > > -#define EFI_RESOURCE_MAX_MEMORY_TYPE 0x00000007 > > +// > > +// EFI_RESOURCE_MEMORY_UNACCEPTED is defined for unaccepted > memory. > > +// But this defitinion has not been officially in the PI spec. Base > > +// on the code-first we define EFI_RESOURCE_MEMORY_UNACCEPTED at > // > > +MdeModulePkg/Include/Pi/PrePiHob.h and update > > +EFI_RESOURCE_MAX_MEMORY_TYPE // to 8. After > > +EFI_RESOURCE_MEMORY_UNACCEPTED is officially published // in PI > spec, we will re-visit here. > > +// > > +// #define EFI_RESOURCE_MEMORY_UNACCEPTED 0x00000007 > > +#define EFI_RESOURCE_MAX_MEMORY_TYPE 0x00000008 >=20 > Shouldn't this be handled in PrePiHob.h too? > i.e. update EFI_RESOURCE_MAX_MEMORY_TYPE with #undef + #define > there? >=20 @Gao, Liming is the MdePkg maintainer. What's your thought, Liming? Thanks Min