From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web11.12146.1679314122136717444 for ; Mon, 20 Mar 2023 05:08:42 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=Tmkcvb1g; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: min.m.xu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1679314122; x=1710850122; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=8TlDPfoP4f3YVegj0KvX6YQ6bEAMIjR4cLEJKcMKtZw=; b=Tmkcvb1gxXb7iJc7MmoqEvTsWpr2sz8H4PGVKq5STyZcnvDgl4IRVRyE E0oolXyOOnzrX9Yt2L3+4uZcWAAIbV0ARmlmeiFA5m3IZiA01c0eEwGWi n4dBiTq6jimBaPzOJQFmMLtforBY92L3vpXPplgepP+iGVjgeuXOfz0Ao 91WuMsWn8bUYURnrg4HjMDtC0HE20iiL4zqiPJ0kaTv//aXLmpFksiRAn Y6R0z3KpHakIwQ31fvSvSVRf1vHLfwjcdd0sGQ0Ii6irlm/j5y12KbuU4 CP7+LOpc3MryVg48ViHyYshjL5lSzrnuhK504Kw2FyuLwLhvzi4fEkPAC w==; X-IronPort-AV: E=McAfee;i="6600,9927,10654"; a="401217615" X-IronPort-AV: E=Sophos;i="5.98,274,1673942400"; d="scan'208";a="401217615" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Mar 2023 05:08:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10654"; a="711338699" X-IronPort-AV: E=Sophos;i="5.98,274,1673942400"; d="scan'208";a="711338699" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga008.jf.intel.com with ESMTP; 20 Mar 2023 05:08:41 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Mon, 20 Mar 2023 05:08:40 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Mon, 20 Mar 2023 05:08:40 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.169) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.21; Mon, 20 Mar 2023 05:08:40 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P3uFeJ4I/yigvelXEeit0PPGHqxM7LAMixSGdivBmBwBDltHGNVDavjujmh52lLziANl7IhW1v3l3bjFSCPq0H5IgoLTdJOFfbp/9NfcOYmO3kzy15zVRf8ZQ8O0W/SnoNBFhNgG8X+kh6koDAD9ia1RfcizODDvPi8LN/sV0bkap9I23OHDQXb1iejG7ItFlwCVc1ql9Bo/qvZJsCetEir36MRk7vuA8NSrEC5d0ZJtwP6G2Ws/rRZkRBenTj1sZJcm6w4kbKc5I7Ap7k31lFovyWys9qd5c37xRiBbOrtljKeil9mUO3tNU3CxW/FS5gz0q4ErgS7UtGpbxOTBLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2LPKQij/xy4wKYxLEG5jfbttoTBrA2JJ00q7vCY9GVg=; b=eY4OzlaG99kbN9QAWX50wHh4jmvChJzusFEyZemL2rI5r6chPPti5qWPztxFaqUebHTdAZzje+RLpGvL0lMTa/qeKvWRUqvcWJtEpMuv4I8ljgMScD03yMxdPSDaykdFNPoQUCK04Z3r93sutKSc+fEArXOuBm/tIASSt1UZHaZzH2d4lC5pWJ21CqEIJx2mShlMjAKCqUCquggebGRCsiX2TogEXSCjV9oJVjsCd+yG6kjABs1QJUR4zvb14bP1mMlg2+jV1VHmB+SDHte4ZgbG7WvlKZdSSC/yaOScjSSnk8zABy9Whqana7oWWn3CGUTK7wSpPM8ZhE3c01hnEQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5064.namprd11.prod.outlook.com (2603:10b6:510:3b::15) by SJ0PR11MB5918.namprd11.prod.outlook.com (2603:10b6:a03:42c::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.37; Mon, 20 Mar 2023 12:08:39 +0000 Received: from PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::6364:feb3:108:a5ee]) by PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::6364:feb3:108:a5ee%4]) with mapi id 15.20.6178.037; Mon, 20 Mar 2023 12:08:39 +0000 From: "Min Xu" To: Gerd Hoffmann , "devel@edk2.groups.io" CC: Pawel Polawski , "Wang, Jian J" , Oliver Steffen , =?iso-8859-1?Q?Marvin_H=E4user?= , "Yao, Jiewen" , "jmaloy@redhat.com" Subject: Re: [PATCH v2 1/1] SecurityPkg/DxeImageVerificationLib: Check result of GetEfiGlobalVariable2 Thread-Topic: [PATCH v2 1/1] SecurityPkg/DxeImageVerificationLib: Check result of GetEfiGlobalVariable2 Thread-Index: AQHZTbv2wsrgr2Od/0+ubrbVUf+FIq8DipcAgAAixhA= Date: Mon, 20 Mar 2023 12:08:38 +0000 Message-ID: References: <20230303103553.804781-1-kraxel@redhat.com> <20230320100208.xhoz7smo5fkhal26@sirius.home.kraxel.org> In-Reply-To: <20230320100208.xhoz7smo5fkhal26@sirius.home.kraxel.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR11MB5064:EE_|SJ0PR11MB5918:EE_ x-ms-office365-filtering-correlation-id: 61fcc9c0-c0e8-44cd-245f-08db293bd6fb x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: uofEZZMXjk+kvp/5ce6+vnxl8UQuGMpcaRT2ROOPHcdeo1DtiGeE55LJUItKqxIsxVkfL9EbyURkLT/aOrkG+5S9uAj6U9109y3kG7RAVBbgk5y5I+97/BAkByrWVk9qIfH14OQclt5XlWI5O+D+qMIwnUcmN8UmJhx3SYrALXydVFT6QNmY3tT+BoEw897fEne8/4O/ZTuVrZCM6GPqMgF0jHVonCVykDhKxlX0Jx5mIXKnuOsCtCm0i3s+rzxCCa4K5AIX2t7Dv0It2Mz+vxZ343+y7lBzuI9WlVt1yOYWEeJb4JqGhsJ+fMoiH+FW0oh6TJxwn/IzrNstC8orqR59C70Xi8lvUa1REOHJZbgnEsUPk6S8zDCpuPzASmyg4dyIj/nnCI/ec5shXKwzf66bzHsjfmubHgUnwJFd+er+5NOHpiVH+u6qFVDn+t7y3vXNVByiZlVovss2X6xEZJm1Dwfwx986UUS0o5CyQVKWc41Y9m1ooa+r1dxXD57NKkEjTKrfWHn1fOK3MwagPb8PJQ3llR2pnV8s6Mn8ryz8s48wCbadTyGAj9dL6o4Ut1vHvKWFdgMC/UgYwGQxLvfPv0igUzHLalb4YhgrpXqR2ycwz39UrUSKT3jSv9QPVP4kkbniM00V0tNOa9c4dIITPW4zx+UJp7O8xKIRH1OK9IXzRj7uxPF1x6BJzAo/ x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5064.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(346002)(136003)(396003)(376002)(366004)(39860400002)(451199018)(38070700005)(41300700001)(19627235002)(76116006)(66946007)(66556008)(66446008)(66476007)(8676002)(64756008)(4326008)(82960400001)(15650500001)(38100700002)(2906002)(122000001)(55016003)(52536014)(8936002)(5660300002)(86362001)(6506007)(26005)(53546011)(7696005)(71200400001)(966005)(33656002)(9686003)(186003)(54906003)(110136005)(83380400001)(478600001)(316002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?QNdPdmBjRlHwO65riLwiCj23MhfAj3XJ6WF4dUAFDEHY66ZvxCeNndZkci?= =?iso-8859-1?Q?QZjNamx3mz9IuFV5rvj3dfJM9BgE6JTw5udhG0oFzTMoxrnYnuPUZseOa6?= =?iso-8859-1?Q?fgPnyadTGxUbSYOls8Y1aQjfd+t5oM7Wz26BFPi3b9wXuZmD5G6o1jaLwx?= =?iso-8859-1?Q?+BeyYo+I5EY3yhVDBGCO1n1h0MhJP9DQzI7Om5aGS9h2vz5u8KuOxtpoOd?= =?iso-8859-1?Q?BP/BWI2bR7XvlT1zy3SjhZk6vrydozLduaQcR8RX7QHH0bfZPBirTJcsAN?= =?iso-8859-1?Q?wgak1HQXc/Mhi41xrjJMrvl+bocXcc4IetgF0M27Ht2yp8CAMIqfgR0R1Z?= =?iso-8859-1?Q?4XtgEzTZ8IR0C3kxL9lPXu1P2n516jHtOHCVhOeriBjgxoIQC0yPAhQAkJ?= =?iso-8859-1?Q?1E9IQPgbzvNlRNB/FXZo2k0jigRlCeOlExdk4XWtH3/nMn0g5tJVid3hu1?= =?iso-8859-1?Q?cUDy8tu6vWACi4cAfxLMcGr0WeGRCVVwo+iMm7eEfzza8xBf8bjEk4/dDG?= =?iso-8859-1?Q?Wy+uM/6DT5R+F+pMudZLUxFSR6yqUF7ZLm5eCvPaBUXcBQ1gd+j1tEkw7G?= =?iso-8859-1?Q?gOaCURFfzlSh4eibrMws3OLMmAFt1ePRgKB8XwUoQoLXJLw2WnI4qYqgmc?= =?iso-8859-1?Q?d3b6lwWWA98Op9gYzTQbSDGHbeFtSdpnI4mO7c+qXAPUrWfxr93upQRyN5?= =?iso-8859-1?Q?+g516gNCu7JGgTVzwOiJfZOGDYtTfHM7Nj/mIi0uM/aejjblMHWhaEZs1G?= =?iso-8859-1?Q?JhBh2EfTpSgKg++aXgBK/ah9wB4tx7NKDyu1hZFGP3U0+I1YZoAHY6Kvdi?= =?iso-8859-1?Q?+3/M3QaYCNhM079eWDeHIUTQTH3LicAL5Tx5J0g/aa5QTyjrJLp8vELZAp?= =?iso-8859-1?Q?VAsOGNA2trZgR7k2xFL8fenyN7cychn7pop/wf2nLFkiLyBxO5OxdAtwx+?= =?iso-8859-1?Q?U7RLZtztXFRxZKisB0o89Zv/zc84gsXBfvvQ6W46fcYVJY640TkIvGZUwH?= =?iso-8859-1?Q?GPdzaPKP4rLrjj5RnogceBV0ZlWn2KQMVG1CVnwd8GDjWTkUAyHqKkuOGs?= =?iso-8859-1?Q?DobJbqm35IvnMj79Uy92WvcKfu9Heq9nCvlQX4YrdU9rG6D+dw2AFJqPUF?= =?iso-8859-1?Q?5HuqFkw4fiIcLgXNzLiUYIr91zUHfeyNy8F2VWDLXx+HUAzhQRxFhfx/Tl?= =?iso-8859-1?Q?CGVKq43X/ewwo3ZN6naLsNwNXM+Fsx+hJDnSdnXA6fmtJvXvkmRATZsKRk?= =?iso-8859-1?Q?RxQVtsLZYaEl7hidwiI8IW4wStO5t1HeuTvpJR0/5jtmQVyzeHDDFvjvuP?= =?iso-8859-1?Q?HD3Yp5JtBCxsBHVF32IdKBzaQMdJgXM1AWI/EiwzxHmAad5o6oNMoeFFsx?= =?iso-8859-1?Q?h3J+nbyO7bdzE8Q/Uwity8WkUmB+GyFhUqvnLCdlkprb1ttPMoDLQk09kI?= =?iso-8859-1?Q?odeDgt4lPpLmj+RwU2H9b22URhfYWNc3/NV1UCRK3RMqOYTlGXHIQrpjQi?= =?iso-8859-1?Q?lpPZXD9sk0OLsubfS6mLZC3Q23FkLn+0oYvYv+wy2CJiPlSM/wybthwSrd?= =?iso-8859-1?Q?c749+LS922SX5gmz1WxygqJU/ebM1ipp6TRwU9e7ilKA7m7unfRyomACFU?= =?iso-8859-1?Q?ty86ScJlAn53irRz7zlN3d1QuzTar0vB4M?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5064.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 61fcc9c0-c0e8-44cd-245f-08db293bd6fb X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Mar 2023 12:08:38.9337 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: pS9bOPJPWjgcNNqxJK7l3tyKuJRyCfV7QmW7Madgy5qtYLgu53AKi6p66YOKj1id1eCjzPKWJM0Sxvz3j+inZg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5918 Return-Path: min.m.xu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable It's good to me. Reviewed-by: Min Xu Thanks > -----Original Message----- > From: Gerd Hoffmann > Sent: Monday, March 20, 2023 6:02 PM > To: devel@edk2.groups.io > Cc: Pawel Polawski ; Wang, Jian J > ; Oliver Steffen ; Xu, Min M > ; Marvin H=E4user ; Yao, Jiewen > ; jmaloy@redhat.com > Subject: Re: [PATCH v2 1/1] SecurityPkg/DxeImageVerificationLib: Check > result of GetEfiGlobalVariable2 >=20 > On Fri, Mar 03, 2023 at 11:35:53AM +0100, Gerd Hoffmann wrote: > > Call gRT->GetVariable() directly to read the SecureBoot variable. It > > is one byte in size so we can easily place it on the stack instead of > > having GetEfiGlobalVariable2() allocate it for us, which avoids a few > > possible error cases. > > > > Skip secure boot checks if (and only if): > > > > (a) the SecureBoot variable is not present (EFI_NOT_FOUND) according t= o > > the return value, or > > (b) the SecureBoot variable was read successfully and is set to > > SECURE_BOOT_MODE_DISABLE. > > > > Previously the code skipped the secure boot checks on *any* > > gRT->GetVariable() error (GetEfiGlobalVariable2 sets the variable > > value to NULL in that case) and also on memory allocation failures. > > > > Fixes: CVE-2019-14560 > > Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2167 > > Signed-off-by: Gerd Hoffmann >=20 > Ping. Any comments on this patch? >=20 > take care, > Gerd