public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Min Xu" <min.m.xu@intel.com>
To: "Yao, Jiewen" <jiewen.yao@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>,
	"brijesh.singh@amd.com" <brijesh.singh@amd.com>,
	Liming Gao <gaoliming@byosoft.com.cn>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>,
	"sean.brogan@microsoft.com" <sean.brogan@microsoft.com>
Cc: James Bottomley <jejb@linux.ibm.com>,
	Tom Lendacky <thomas.lendacky@amd.com>,
	"Justen, Jordan L" <jordan.l.justen@intel.com>,
	Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Erdem Aktas <erdemaktas@google.com>,
	Michael Roth <Michael.Roth@amd.com>,
	Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [edk2-devel] [PATCH 0/2] work area fixes
Date: Tue, 19 Oct 2021 00:21:34 +0000	[thread overview]
Message-ID: <PH0PR11MB50644565020C927661F20A97C5BD9@PH0PR11MB5064.namprd11.prod.outlook.com> (raw)
In-Reply-To: <PH0PR11MB4885F84F2EF3E2FE7768F66F8CBC9@PH0PR11MB4885.namprd11.prod.outlook.com>

Jiewen
I just create a new PR based on the latest commit (2108698346) for the patch-set of "work area fixes" and it seems all checks have passed. https://github.com/tianocore/edk2/pull/2078

I suspect the previous failure was caused by the un-stability of EDK2 CI system. Maybe you can create a new PR and try it again.

> -----Original Message-----
> From: Yao, Jiewen <jiewen.yao@intel.com>
> Sent: Monday, October 18, 2021 10:49 PM
> To: devel@edk2.groups.io; brijesh.singh@amd.com; Liming Gao
> <gaoliming@byosoft.com.cn>; Kinney, Michael D
> <michael.d.kinney@intel.com>; sean.brogan@microsoft.com
> Cc: James Bottomley <jejb@linux.ibm.com>; Xu, Min M <min.m.xu@intel.com>;
> Tom Lendacky <thomas.lendacky@amd.com>; Justen, Jordan L
> <jordan.l.justen@intel.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>;
> Erdem Aktas <erdemaktas@google.com>; Michael Roth
> <Michael.Roth@amd.com>; Gerd Hoffmann <kraxel@redhat.com>
> Subject: RE: [edk2-devel] [PATCH 0/2] work area fixes
> 
> That is weird. But I am not tool person.
> 
> HI Liming/Mike/Sean
> Would you please take a look and help us understand what's happening?
> 
> Thank you
> Yao Jiewen
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Brijesh
> > Singh via groups.io
> > Sent: Monday, October 18, 2021 10:45 PM
> > To: Yao, Jiewen <jiewen.yao@intel.com>; devel@edk2.groups.io
> > Cc: brijesh.singh@amd.com; James Bottomley <jejb@linux.ibm.com>; Xu,
> > Min M <min.m.xu@intel.com>; Tom Lendacky <thomas.lendacky@amd.com>;
> > Justen, Jordan L <jordan.l.justen@intel.com>; Ard Biesheuvel
> > <ardb+tianocore@kernel.org>; Erdem Aktas <erdemaktas@google.com>;
> > Michael Roth <Michael.Roth@amd.com>; Gerd Hoffmann
> <kraxel@redhat.com>
> > Subject: Re: [edk2-devel] [PATCH 0/2] work area fixes
> >
> >
> > On 10/18/21 8:14 AM, Yao, Jiewen wrote:
> > > Hi
> > > This patch failed in PR -
> > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith
> > ub.c
> >
> om%2Ftianocore%2Fedk2%2Fpull%2F2076&amp;data=04%7C01%7Cbrijesh.sing
> >
> h%40amd.com%7C20804cf7726f4528ee2608d9923950ba%7C3dd8961fe4884e6
> >
> 08e11a82d994e183d%7C0%7C0%7C637701597143373879%7CUnknown%7CTW
> >
> FpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI
> >
> 6Mn0%3D%7C1000&amp;sdata=S4RXWkQ5Hs4yr8FvEvKJSYGVPZS7mrBfvjRUKZF
> > dsZ8%3D&amp;reserved=0
> > >
> > > Please take a look.
> > >
> > > You are encouraged to try PR before submit next time.
> >
> > I did ran PR before the submission and it all passed. The error this
> > link is reports have something to do with the python script used for
> > running the PR itself. I am not sure what I can do to fix it. Sounds
> > like a bug in the tool ?
> >
> >
> >
> > >
> > > Thank you
> > > Yao Jiewen
> > >
> > >> -----Original Message-----
> > >> From: Yao, Jiewen
> > >> Sent: Monday, October 18, 2021 12:53 PM
> > >> To: devel@edk2.groups.io; brijesh.singh@amd.com
> > >> Cc: James Bottomley <jejb@linux.ibm.com>; Xu, Min M
> > <min.m.xu@intel.com>;
> > >> Tom Lendacky <thomas.lendacky@amd.com>; Justen, Jordan L
> > >> <jordan.l.justen@intel.com>; Ard Biesheuvel
> > >> <ardb+tianocore@kernel.org>; Erdem Aktas <erdemaktas@google.com>;
> > >> Michael Roth <Michael.Roth@amd.com>; Gerd Hoffmann
> > >> <kraxel@redhat.com>
> > >> Subject: RE: [edk2-devel] [PATCH 0/2] work area fixes
> > >>
> > >> Series: Acked-by: Jiewen Yao <Jiewen.yao@intel.com>
> > >>
> > >>> -----Original Message-----
> > >>> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> > >>> Brijesh Singh via groups.io
> > >>> Sent: Friday, October 15, 2021 2:17 AM
> > >>> To: devel@edk2.groups.io
> > >>> Cc: James Bottomley <jejb@linux.ibm.com>; Xu, Min M
> > >> <min.m.xu@intel.com>;
> > >>> Yao, Jiewen <jiewen.yao@intel.com>; Tom Lendacky
> > >>> <thomas.lendacky@amd.com>; Justen, Jordan L
> > <jordan.l.justen@intel.com>;
> > >>> Ard Biesheuvel <ardb+tianocore@kernel.org>; Erdem Aktas
> > >>> <erdemaktas@google.com>; Michael Roth <Michael.Roth@amd.com>;
> > Gerd
> > >>> Hoffmann <kraxel@redhat.com>; Brijesh Singh
> > >>> <brijesh.singh@amd.com>
> > >>> Subject: [edk2-devel] [PATCH 0/2] work area fixes
> > >>>
> > >>> We missed updating the AmdSev package and Ia32 buid to use new
> > >>> work
> > area.
> > >>>
> > >>> Brijesh Singh (2):
> > >>>   Ovmfpkg: update Ia32 build to use new work area
> > >>>   OvmfPkg/AmdSev: update the fdf to use new workarea PCD
> > >>>
> > >>>  OvmfPkg/AmdSev/AmdSevX64.fdf          | 9 ++++++++-
> > >>>  OvmfPkg/OvmfPkgIa32X64.fdf            | 3 +++
> > >>>  OvmfPkg/ResetVector/ResetVector.nasmb | 3 ++-
> > >>>  3 files changed, 13 insertions(+), 2 deletions(-)
> > >>>
> > >>> --
> > >>> 2.25.1
> > >>>
> > >>>
> > >>>
> > >>>
> > >>>
> >
> >
> > 
> >


  reply	other threads:[~2021-10-19  0:21 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-14 18:17 [PATCH 0/2] work area fixes Brijesh Singh
2021-10-14 18:17 ` [PATCH 1/2] Ovmfpkg: update Ia32 build to use new work area Brijesh Singh
2021-10-15  5:00   ` Gerd Hoffmann
2021-10-18  6:26   ` Min Xu
2021-10-14 18:17 ` [PATCH 2/2] OvmfPkg/AmdSev: update the fdf to use new workarea PCD Brijesh Singh
2021-10-15  5:01   ` Gerd Hoffmann
2021-10-16 18:38   ` Dov Murik
2021-10-16 22:32     ` Brijesh Singh
2021-10-17 17:36       ` Dov Murik
2021-10-18  6:25   ` [edk2-devel] " Min Xu
2021-10-18  4:53 ` [edk2-devel] [PATCH 0/2] work area fixes Yao, Jiewen
2021-10-18 13:14   ` Yao, Jiewen
2021-10-18 14:45     ` Brijesh Singh
2021-10-18 14:48       ` Yao, Jiewen
2021-10-19  0:21         ` Min Xu [this message]
2021-10-19  2:31           ` Yao, Jiewen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=PH0PR11MB50644565020C927661F20A97C5BD9@PH0PR11MB5064.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox