From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web09.2407.1646181731957079610 for ; Tue, 01 Mar 2022 16:42:12 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=TGI54hdS; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: min.m.xu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1646181732; x=1677717732; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=feDRWBDyTepEyKVBOUfPmPbXXCH5EWACbyckh0jPnnc=; b=TGI54hdSGWQWggPRtwSXL3gmqdkExW7HjULVfBGyLdwIHXu//O3KU3yM 9IYoOljMJX0m+3Aoe4eApJ1ZZVVwgsw3X+5ILaKK3yJgz3O6d12ZwoEoO puA1FDNhr9/PpHd58hX0sA2EjaMZFgv9V/p3jxU3goBmX91lwc0TRdmwW RQ/uC+OUsWa/NWZTurqgoh/ajR01jV8vS/3hdQdcollxvDYC0qlLVx6fo 0xtydxqR4np+YINS7omScDnG9HPygooeAyTUfH1t30S+YRXHw7NDselQ+ ASXh7V9ZRn/YC7irQSg33MdVLqFXMZDExYRjpgt6qqJg2c3EM8Ouhv8Vt g==; X-IronPort-AV: E=McAfee;i="6200,9189,10273"; a="252108328" X-IronPort-AV: E=Sophos;i="5.90,146,1643702400"; d="scan'208";a="252108328" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Mar 2022 16:42:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,146,1643702400"; d="scan'208";a="545307121" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga007.fm.intel.com with ESMTP; 01 Mar 2022 16:42:11 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Tue, 1 Mar 2022 16:42:10 -0800 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Tue, 1 Mar 2022 16:42:10 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21 via Frontend Transport; Tue, 1 Mar 2022 16:42:10 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.101) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 1 Mar 2022 16:42:10 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IS23xup95fVISD7roQCh1yRVi+kTkXIIPBl0p7UgKxOHzIC4ZpXajtxhHm8IS3laR7ZgjVutj1EjLw2g0hWKvt1ZEmFlY4Rpp31jqzaemQOQOsJTnfbmgJ0dNAMxF4ezeRBwIqKj5IiYIzPKthnHdey+ErCD+lAT8hvk1VKtz5xCk1lD0zwku8tUF/HqKLtJaWRyUVIrB1YI3DVLBX50HzCCTZzHauoRvMrOBwLIkg/9gJD1XNfE16uo2gPEGP8CUFftMSSPLl1AATHqs6ZffVtCLYBdF/YQDHO4yQAjHzurLz6l+uQgqYTKE36EsMwVa+Ig26WavjL8oyvICxMOJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ykpiNB8iry2lt6SbJU9gijwNeOGlltcZ0bDW3Q4KK4I=; b=BgWrShwcsKqeVxeFgrQZhPKb1oAcu2ejdwnFgFwNcvEVeeTVSLGwupG575YANSha7oS9OX+ZejDf9kaiH6uIOijX96u5cerJn1opANEKdGrWJmhvgALxrAcQRwMwwKz/9tf+W4Iu3MyhaYCovytJahaNwseXPwozweeYlWRiP9uERy5Gc+JZUJnk8fS9GogGueE4o9eViSs6JfKwpdP1Tdkf5aEGpuukbvQFkNkDLA2PV1hGg+WdGcd3H96HGwkiaYcJ0HllAAQPEV7xHurLwOHl9xDjvrQBTkuvVOSjd33qR+8Mk8vol8WLEjiPPI2stVb2Xe+B0utXHGyVvriDTw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5064.namprd11.prod.outlook.com (2603:10b6:510:3b::15) by BL1PR11MB5336.namprd11.prod.outlook.com (2603:10b6:208:316::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.14; Wed, 2 Mar 2022 00:42:07 +0000 Received: from PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::98f5:edb6:aee6:6886]) by PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::98f5:edb6:aee6:6886%7]) with mapi id 15.20.5038.014; Wed, 2 Mar 2022 00:42:07 +0000 From: "Min Xu" To: "devel@edk2.groups.io" , "kraxel@redhat.com" CC: "Kinney, Michael D" , Brijesh Singh , "Aktas, Erdem" , "James Bottomley" , "Yao, Jiewen" , "Tom Lendacky" Subject: Re: [edk2-devel] [PATCH V4 03/10] OvmfPkg: Update EFI_HOB_PLATFORM_INFO with more platform settings Thread-Topic: [edk2-devel] [PATCH V4 03/10] OvmfPkg: Update EFI_HOB_PLATFORM_INFO with more platform settings Thread-Index: AQHYLHucfy84zjISXkiwxtQpb9UFj6yqhw8AgAC24PA= Date: Wed, 2 Mar 2022 00:42:07 +0000 Message-ID: References: <20220228081631.681-1-min.m.xu@intel.com> <20220228081631.681-4-min.m.xu@intel.com> <20220301132652.mfdms3yevnnhpvp6@sirius.home.kraxel.org> In-Reply-To: <20220301132652.mfdms3yevnnhpvp6@sirius.home.kraxel.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.401.20 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: fed4aedb-966a-4124-f3c0-08d9fbe57ad4 x-ms-traffictypediagnostic: BL1PR11MB5336:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 0nueCGg7Z5pvPtLI/3RlQtRDdbJ+QN48iemwk//EA5sKSzzHn8YHu2g++EmXqRXtBs5kh3obllazGqk6X5+vqqBhqNyRy/4PyMl3BUhsQrDX/QcgO0dCZA6mclRG0AolhScWc6RM3hX+CAnbJgzPyIh/Z083hbVFWDU99b4/oviKNy5/ej9V9EKiV/Ven2LK10dWX37pfXhWmuRniHlZ/Iyovo5l9YvH5HZox5yJg+Z7yRmJ8cLcQOX5Jj0elAecwey7x2lMjNHjvog7ozSbxoStb/ucl05s/EF4S4/aPkjkB0bnjkfpYLK7U8xW/c1bUyP3vDvgmnkcO6zdxl2rVw8QKd411ByeS8oQ/vbel5p7C1N89FwuEDkuB4EsQGTv4zcnJZfYT2AjEMerRcpgG1Y8Cg4TtEM09XrQ3k7ecdTz+B2muY4suo7IlX/EdJGuIWrA0VQnovpf8lkNd25yQKPWcXVDbyszbxN+3QFNzf9rBxYXIp2MoUuR56k6zANrZkXMxH0YM0ap6ujCnglRvmI+tD1tPKISCIiVZk0Cscfo9PyVtHNt9DZgnWG23bQwKJzmVSfkafpWDrpKikp0WWiPhC/uynBpV1M3jxZqlF8VJrb58WF4U3UqRYLDUqhQvPky7ghvN+K6iMPbdbuQKr3kXbG8FUzqzAx7vLT9PRUv3CJH5LOSwFRqeaLOkL1qiqy4hlEJXv15HYHhxytKE39uuqUA4vq60Ycd7jDWHZzMs2TllquHLyTGEIfSNrX+vcRNPPyY4Z9Fb4RT6NFIAoMBjU467vTJoEL8w4vysh9EM95isS3yRUj7XFCKkJOD x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5064.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(110136005)(54906003)(316002)(8936002)(64756008)(966005)(66446008)(66476007)(66556008)(52536014)(4326008)(8676002)(2906002)(71200400001)(26005)(86362001)(38070700005)(508600001)(66946007)(76116006)(55016003)(9686003)(7696005)(82960400001)(122000001)(6506007)(38100700002)(33656002)(186003)(5660300002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?1RrU2eiKpI+rXvcKtfob2FWuVCUwRkCqocthCbROOybaTkGAepZTQD6o9wux?= =?us-ascii?Q?4J4YZhfrnjCSCPGHP6zJ/mht73HEp4x+AsfN/3J3tjT+JL4HxtOBx39LR/kP?= =?us-ascii?Q?Ck1iJ/KFiV9xUyPjmsX+RFLBTJrVEX6sWrQtVd5PbiPt5BWOiUQS9DyutQwD?= =?us-ascii?Q?FlFUPj90uX3uXsRIUoO3HAN7lpi/s8TH0ijcK1ZnSumyeUS4Nq8Z3DMAeFZG?= =?us-ascii?Q?HlBpPewOM9DAEs/Q8a6d14+N6kHmK0JGivRC25gEsi3VOmB8w3iyZvHqMYXZ?= =?us-ascii?Q?NmqBfd4pYruxBONnW7qf7Y5FYAkRKsxvIr4HB18CdxkULGG3/luwrGkgNHvg?= =?us-ascii?Q?kS6ljfm0LnFk5nCy2eIpxTvrFK7Xr0EYeQSW2i6rjMYOzHQwEzdK17VmvpSO?= =?us-ascii?Q?RAeWoqpEEtOcqStG7CEAY5mRXZMeXcpdPfsGRuU61GmP4yHDtIlEU0n19bg7?= =?us-ascii?Q?iDSH8bzBoXrxvRsY9+QQDrA8Qw3oywcjTBaioMELT3q5oyY9EZSaqDI74nfC?= =?us-ascii?Q?/ns1N2SDYflR9XDxrGPPulsyxRssx0OQ+r1farLKU60GC6zWYM17/oSzXsrv?= =?us-ascii?Q?U7YPq8YrNDRibMcNZbWNS4WOs90gc3yfQf8LFErIclXdyZ4JQxOZ8MUEkQ1r?= =?us-ascii?Q?rZ6hZlGTho9YQ2wkW3ym4DyWBXEvsZQbQMYvRGXJc4lXDXh6b9a2bxNeeX5f?= =?us-ascii?Q?aRFCZn095Ti2Ob+Ba2WmrIFApA3jGL+jiBfVh5g23ljTMFNHBnWdFM4SEkAr?= =?us-ascii?Q?lMBbr0I6/t8SbZ7+B9UEM2fFTt2m346zmm0XcEWGeIVvMyU0cxTElgiWKjPu?= =?us-ascii?Q?P0oYgsAagIb0eaE8SeU+Z1qG749BdOZv1YV0PbU4DR3Nl5bS0rielX5hHzU+?= =?us-ascii?Q?UQddit7mkYS7ink6kC0xC/zVvuk2LnoO3MlBKZwfoZwxIcbiGDYftxniDL54?= =?us-ascii?Q?kiojKBxA5XzhyyQUnoEDe8WoE9vwOT5f0GiQqnP6Dgm1Kem3PozQkBY8v58p?= =?us-ascii?Q?NY3xkQbvcjsUQnN44l+jFgpSrj0l9tqqOTH1ukbDW5paX456ZeYWUezULVRO?= =?us-ascii?Q?HeaZ4+v/U1m93ANGWovbZPLvH/5DwZBF+/lPXBEaXpbEBb5g005wORpZtFFr?= =?us-ascii?Q?0VD/SefGjIHEHCt6MOr+2yc3UGtrLZC7I/ZFWxsSb+/ibgRQRc5U51j7w2au?= =?us-ascii?Q?KjC0XfizeaDdP8Xai7qWMQbh4B7aQGYyciRxmcYVyP/AeV/b5pNv5ghMb+Pr?= =?us-ascii?Q?b4UFMquuSXqlA8805IKo7gofRPqLW8YV9GH5t0+Bczw2Iw2umgr5Sye3QTHa?= =?us-ascii?Q?2cgAt6qLW09Ex/YCjHQW07E258WU/3p4I3+yPpt+QxJZ2aW+6eY/HCYuY7Ru?= =?us-ascii?Q?qsogQP5Zi8aG+SxGe2HKgbfwWGJU8pw4YzPIY3Yur+rWMcRuyo4zkipLPzwY?= =?us-ascii?Q?rbHb9e37q8BPDCqsgw0Mo1/033IwWAORzOZzLJbeEvyeFYXQa9zso3a6/AD/?= =?us-ascii?Q?ESTzp0LQ3cor6hzvZW+q3nYJzuqNEgpZqMB5RjZlsoLTd2vayPm//VcuxpEt?= =?us-ascii?Q?rmXIcaL/T/KttQaeae/BzqMMc6mz7DpPUudzUbxDt/cdVr5/5hckLa+0MDwy?= =?us-ascii?Q?otJ5WiXA9KszFkSuddxbVCg=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5064.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fed4aedb-966a-4124-f3c0-08d9fbe57ad4 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Mar 2022 00:42:07.5557 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: BPaj1MYKj7baMpCkNyYx9RQthOCheSv1EZeUg0LO6qYtoTYnlaeYZE1S3fWL5NOAtlbAR/Hy6xgY8S6n6T9yBg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5336 Return-Path: min.m.xu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable On March 1, 2022 9:27 PM, Gerd Hoffmann wrote: >=20 > > @@ -15,6 +15,22 @@ > > typedef struct { > > EFI_HOB_GUID_TYPE GuidHeader; > > UINT16 HostBridgePciDevId; > > + BOOLEAN PcdSetNxForStack; > > + > > + UINT64 PcdConfidentialComputingGuestAttr; > > + BOOLEAN PcdIa32EferChangeAllowed; > > + UINT64 PcdTdxSharedBitMask; > > + > > + UINT64 PcdPciMmio64Base; > > + UINT64 PcdPciMmio64Size; > > + UINT32 PcdPciMmio32Base; > > + UINT32 PcdPciMmio32Size; > > + UINT64 PcdPciIoBase; > > + UINT64 PcdPciIoSize; >=20 > Ah, here you add some of them to PLATFORM_INFO already ... >=20 Actually there are 2 stages of EFI_HOB_PLATFORM_INFO.=20 The first stage is in Config-A (see https://github.com/mxu9/edk2/commit/30b= dad7da340cb390c4a3ce0f49fc4324b72e60f). In this patch the EFI_HOB_PLATFORM_= INFO is very simple. There are only 2 fields (GuidHeader + HostBridgePciDev= Id). Because Config-A boots with PEI and PCDs are set in OvmfPkg/PlatformPe= i. So we don't need to ask EFI_HOB_PLATFORM_INFO to carry other information= . Then we come to Config-B (the Pei-less boot). PCDs cannot be set in SEC pha= se. So we have to make EFI_HOB_PLATFORM_INFO to carry more information. See= https://github.com/mxu9/edk2/commit/a1779386899369eb9c27517d72cc49870fd78b= 45 Since you're asking to simply pass around a EFI_HOB_PLATFORM_INFO pointer t= o the functions in PlatformInitLib, I am ok to define the complete EFI_HOB_= PLATFORM_INFO structure in one patch. Thanks Min