From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web11.9957.1639658204005950643 for ; Thu, 16 Dec 2021 04:36:44 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=g11FkDDh; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: min.m.xu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1639658204; x=1671194204; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=3pyrDFhJj9mG1skAIYsDYT7OBcg3CEf5CRMevG5NJi8=; b=g11FkDDhELwU8408KHZ8U38Jg8AKduCGsLl9K+cjV0IsBqQJfuseXoOA a7GpqXbxnvLqBssvxaiGwE+a+QNcRPzdkId0S3DVObUGzJG/1xJGEip+F B4YJCEzOAMnBH4ptQiUC24LPGwyGVPAfBlBruZRJpnm5LEN8YQ71njdWb nCr3EELWQoRw3Jq4nK5ITl5uL1HDIVY2OPpP1OcLPhaERerLXiCbapnit Xei7/KuyTV0ggrEfn3y+Y5ExAz5hb1npMrXw2LtiXPecBHGwgNhI9Qxrq 1xjSxbNl57oOfxZzGFMlqbqFDymyzeja0fo0F2z14K7cl2vad2BsKF87J w==; X-IronPort-AV: E=McAfee;i="6200,9189,10199"; a="239288785" X-IronPort-AV: E=Sophos;i="5.88,211,1635231600"; d="scan'208";a="239288785" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Dec 2021 04:36:42 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,211,1635231600"; d="scan'208";a="506261135" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by orsmga007.jf.intel.com with ESMTP; 16 Dec 2021 04:36:42 -0800 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 16 Dec 2021 04:36:42 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Thu, 16 Dec 2021 04:36:42 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.47) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Thu, 16 Dec 2021 04:36:41 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ett7E38y8Hr5+Lf56MmEUpi2T1enuTs6xJ978sjrtuiSOwgvrQLN0hjOh4TxZ7MeV0LGm27jbBlCluTwRdcPOEIjdmbmKLIkt9rlh35PzbWxHEPRQatFVKSXQ4DpYx5uKV67ZUdzIGe/QQ7Opehl6Zpidf2PPkuL+pR1N4LK2x1n3Eu8g6ys7SlPw8Ikco4c8Q3N87wiqqU+EA2DkBv7kb+/UvvYGxsLkIcRqRp4UKRmFQAvAtzCMLn3myviCQNtRTDjERSpZYdPVrMgJg3Va6j6UQ430NYW5k2PPH1PcfL5JR2nn7lPLtYPanrD45ufGtDmZ8BU/MaylgPu7Bw1eA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4Sj/IDTi3VCqvErWHMiaq8rgjGYebjBi323P0VuWS08=; b=WyxxzBAaAkgoUDO3f+I2zElGw6GNXUEVvJtmTfWIErvkhYnXGlSg+W90yPKhkl4LcSPzx6GNA1WQBJRW/hwPPbA2T+9qgmbWHOaKOQtFL97zybDtH2NG9WfcYrUTwn9iNN1+Apjnf7uzbF413rlg6bv/7+TKtiTDk1qwRQw2HT8XqcduGvKIzdLo0Ax0WvUqjqJe77CJ36R+ZYeBbai8nN0yZA/RKUEfX/irCTRcr3yizDmKd5zZNd7N4jqrT5H8icy4zpvkxw1wtYtkEMRtK5oDzqgYEpGYT+KJiKCYay91S5We9aJ/JQR6gWr+/tnHg4UDVjxEUgPh/cosEuV0HQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5064.namprd11.prod.outlook.com (2603:10b6:510:3b::15) by PH0PR11MB4950.namprd11.prod.outlook.com (2603:10b6:510:33::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14; Thu, 16 Dec 2021 12:36:40 +0000 Received: from PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::fd42:b334:5030:af8d]) by PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::fd42:b334:5030:af8d%6]) with mapi id 15.20.4778.018; Thu, 16 Dec 2021 12:36:40 +0000 From: "Min Xu" To: Gerd Hoffmann CC: "devel@edk2.groups.io" , "Kinney, Michael D" , Brijesh Singh , "Aktas, Erdem" , James Bottomley , "Yao, Jiewen" , Tom Lendacky , "Leif Lindholm" , Ard Biesheuvel , "Chang, Abner" , "Schaefer, Daniel" Subject: Re: [PATCH 00/10] Introduce TDVF Config-B (basic) in OvmfPkg Thread-Topic: [PATCH 00/10] Introduce TDVF Config-B (basic) in OvmfPkg Thread-Index: AQHX8PBYVCcb5mRpjk2ZpLzYe0Lw7KwzXtMAgAGuVcA= Date: Thu, 16 Dec 2021 12:36:40 +0000 Message-ID: References: <20211214134126.869-1-min.m.xu@intel.com> <20211215104144.xlyh3xizpnigpk25@sirius.home.kraxel.org> In-Reply-To: <20211215104144.xlyh3xizpnigpk25@sirius.home.kraxel.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6afb6c81-4f40-4c70-2456-08d9c090b5e5 x-ms-traffictypediagnostic: PH0PR11MB4950:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: MrFuAO8sP77veDYe2CtaG6afpKjjLehhLpdpJFoJ54rI6iOyRWsb54pZ+fC3QgkoNujTlCOi6U+iGetVEue5q7SlJRf3xgCtF9cPpW4HNuyfLPCcqUWf9qO9ULzaJLyraOvKUePNwfL5j8K6efUgIPOSSoPwnOpdui1ay6QbweUU50Zl7tZ9ajALdIqtOqnMTLIFn3xGtfJWyrRhwqyY52kZbaCaBdVrFKwTdVX2HigB4DNFsb3ItTEQO9tFKNJizdt3duJRrLP2+J/lMdK7uxsoJ0L/IppMqX7JpspO0By4Ca/9+cQ/pkD37AwgXfdr3c8bswx3tf10YdTJ0lvL8jrGSiqnqRCs+NUI4pQrpLvcVPKWJ0KgfPZQ1l8dpkIQ3uYIvCYqafylk0GvrF4a2x9rNKqDDNd6UV2IBwRIk4hAU9Vc2RtbSCpU1RmcT6WjDt0Wxet4f8HoO0aVbDttY3WtQqPiMo36ymDKpDPpdPK/zlhgoiGMhHjNg7XuUQaJVlP/0/TDO2RvhGyHWdRKM9ocprNomksu0tCwgcExQ4rtPieMUbYWGXeRsxhTp923DuuR77xVsxorZ/HYH0+VUi1wugAaJzYQVT/SdatOQwvklprUV9h5kMxcmGIhN53gJb15ymVg9V5IKdzlMzBsCc1/5ki5oNxZE4X2o1EjVrpRG+ROA+W8/G67rTcPvLVV4Y/HPGb8/uaiYaRzqb7TmqF8DljdTqXHAe5vE3trrmA= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5064.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(82960400001)(86362001)(9686003)(71200400001)(122000001)(38100700002)(33656002)(8936002)(8676002)(4326008)(5660300002)(38070700005)(7416002)(54906003)(186003)(7696005)(6916009)(2906002)(316002)(508600001)(26005)(66556008)(55016003)(66946007)(66446008)(76116006)(66476007)(6506007)(52536014)(64756008)(156123004);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?IOAi6f0BQn/PAPWDWjVg4QhrsmZvgI6dy2WE9T4q7OslmUisz8k1YaI3DZJ4?= =?us-ascii?Q?is+yFGUfp/CqG7WaLBH9Qjja0fwAwU98bP8bC8GfGaoTZK8bsvNqLiLDS7A5?= =?us-ascii?Q?M/rz4F4b8FX22EeFJbmxqOxO0872P/a7anidDuEZAWqPBTJ17XwWWM6VkQj6?= =?us-ascii?Q?C1EnkPxGxbUonx9NGgCMwcUHpcUFyPKYgTKGnLpw9fnB9rF2Z7XxysFEeRDM?= =?us-ascii?Q?1vFXcn4u2CpffiJqAxXN+Fy77G/VyqVKqjS3Zqw5NI8gzB26lBxaAfI5farq?= =?us-ascii?Q?orcNEUYr0p+SOksdzCSHwSrxiWQ4EijJZqU8KVEXOmnE7Nz1FOZVihTY2fsF?= =?us-ascii?Q?BC7nv4DCZgpU6g2EhaaCuXq/9rXYriEdtjIR8/fQIap4y1ZHTfvEP6H/N+b1?= =?us-ascii?Q?pZwoHmGGPQ4FeVeRtCAVkw64B+H+5Qan4qD9DeuUfu1TvLr3Ap5TVMZvp0ny?= =?us-ascii?Q?H12nZHi+vC0g75e12wOUoncNwZ4wrMV/CgyQSScRrUjoJ6W0NDtDcMLloa7l?= =?us-ascii?Q?b+ov0pWtOqV5YBti/1J/7evT//Et91QqGvZzeC1tgc4uyRKCsQRk64SRDXcC?= =?us-ascii?Q?Iqvsi/jGgoiNjtNIKBFgKK7xwFP0Af30qY8goJ/7voOXUzfXnCmXq2gbAaxK?= =?us-ascii?Q?K2sNH44A8sYvXYPLB+Ueb6g98RI9XUf/t75GeUrumCrPpqYUZD+kSAj4omUK?= =?us-ascii?Q?iVIk9s8MdQp3Bq35Ey6TwK3XqfDTbFDOdzqV5N9n/aRIEkTyB/+Cnq2TXbMM?= =?us-ascii?Q?MH2Io8fUII6DgaO9voyMs5Yjujq2eKFauyHC6hGOxrDcKSrW5Wz5oaHAO4XQ?= =?us-ascii?Q?+Q0z15rLFJO/xxlgBvk479S9EuTIB6NMj3jMoGbMgvnN64IvAeqhGkrPyP8Z?= =?us-ascii?Q?qV5iap1/J2AkhoowlDhOt9BOmMrCiWBedq1YkfDZRMIeltN9rADxzmPCCHC1?= =?us-ascii?Q?rw1WCh/rfPDp2qadD1K70MPAq4MyasH53Z1Fh8YUKQmuE2sy7ZPVGSygvU0P?= =?us-ascii?Q?vzqppi7oVn+7TJh20nn6zUm8d9ReNZQNwOd7sAwQWfRs9oNinaXdjj1Ax3c4?= =?us-ascii?Q?MuRY/SdWz526tcfa9iBuRj9P1S94OJgjOCixBxvovEVkZiO0FFjinXCqPYuP?= =?us-ascii?Q?418zA8Uk2fDi2Gsx31NY2inbkigNr4lWcyZJyUAIGqkIq6kXF/RhH6g4mCPw?= =?us-ascii?Q?cIBqydRxz0LMNmH2U5fO2b80U98llSqcNrPCOSiXzLnTeizTCttRDa0OPwSM?= =?us-ascii?Q?R0FoPIt9Jyg+0JQDF5H6lI4GW9PpRlzi+0Zh5Djw4boDqMzASSvr4fuxBs9i?= =?us-ascii?Q?lBTNJI7I4cC+vuLxqnRqx4TEMreEOAgaN4LeD7sjUKsp4cMS8VtdNRvdV9wF?= =?us-ascii?Q?uRK4Ri45xhvNqfTh2czw01clpJitBCWkjHRbB2NKY9vyXxd7VzZPdfQuhFJF?= =?us-ascii?Q?S5IJinbQRhpnIny45f0ntohJJGlH3XydM14uuoZn3rFvISUN+mj1WQfvf1e0?= =?us-ascii?Q?1w57Nu5W/L3+L/y5gntVKT6oo78AxRlHAfkOTXH3PoSDW5VBtsKp6tTAFew6?= =?us-ascii?Q?psKEbU2KDhxgJnRLGwVmhSep4b0VN8iMbzov8yf5U0UtKdqg/x35iGN+CIcb?= =?us-ascii?Q?BOJuR2jTEm0GmvkFl0S6+lQ=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5064.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6afb6c81-4f40-4c70-2456-08d9c090b5e5 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Dec 2021 12:36:40.7828 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: fS3fNjwzMJJ43GlpB178HVBT8wn4xyqLVWk+kKguB+ogF/chCR0pa/Js0shvvBU4FBjQ/JRMwdCgZb+hN734Qg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4950 Return-Path: min.m.xu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable On December 15, 2021 6:42 PM, Gerd Hoffmann wrote: > > Patch 2/3: > > This patch-set leverage the PrePiLib and MemoryAllocationLib in > > EmbeddedPkg. Some new funtions are added to meet the Tdvf Config-B > > requirement. >=20 > Care to explain why this is needed? How is tdvf different from other pei= -less > platforms? Could we just place DXEFV directly in the firmware image, wit= hout > wrapping it into FVMAIN_COMPACT for compression? PrePiLib and MemoryAllocationLib in EmbeddedPkg can meet most of the requir= ement of TDVF Config-B, for example, the hob list functions, fw volume rela= ted functions, memory allocation functions, etc.=20 But there are still TDVF specific function missed. For Example, EmbeddedPkg= assumes the compressed section contains only one FV (DXE FV), so FfsProces= sFvFile () can only handle this situation. But in TDVF's image, the compres= sed section contains 2 FV (PeiFV and DxeFV, this is because of *ONE BINARY*= requirement). So FfsProcessFvFileEx () is added to handle this case. I have to say, *ONE BINARY* requirement restricts us from changing the OVMF= image layout, otherwise the current code (legacy guest, SEV guest, etc) wi= ll break. Thanks Min