public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Min Xu" <min.m.xu@intel.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>,
	Brijesh Singh <brijesh.singh@amd.com>,
	"Aktas, Erdem" <erdemaktas@google.com>,
	James Bottomley <jejb@linux.ibm.com>,
	"Yao, Jiewen" <jiewen.yao@intel.com>,
	Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [PATCH V4 08/10] OvmfPkg/IncompatiblePciDeviceSupportDxe: Ignore OptionRom in Td guest
Date: Wed, 2 Mar 2022 01:21:47 +0000	[thread overview]
Message-ID: <PH0PR11MB50644D0AED596074E90C892EC5039@PH0PR11MB5064.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20220301134458.4ipmt3rto5euc3o5@sirius.home.kraxel.org>

On March 1, 2022 9:45 PM, Gerd Hoffmann wrote:
> On Mon, Feb 28, 2022 at 04:16:29PM +0800, Min Xu wrote:
> > RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
> >
> > Host VMM may inject OptionRom which is untrusted in Td guest. So PCI
> > OptionRom needs to be ignored if it is of Td guest. According to
> > "Table 20. ACPI 2.0 & 3.0 QWORD Address Space Descriptor Usage"
> > PI spec 1.7, type-specific flags can be set to 0 when Address
> > Translation Offset == 6 to skip device option ROM.
> 
> Can you split the reformating of the existing code and adding the new code
> into two patches?  This is rather messy ...
Sure. It will be updated in the next version.

Thanks
Min

  reply	other threads:[~2022-03-02  1:21 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-28  8:16 [PATCH V4 00/10] Introduce TDVF Config-B (basic) in OvmfPkg Min Xu
2022-02-28  8:16 ` [PATCH V4 01/10] OvmfPkg: Add TdxWorkArea definition Min Xu
2022-02-28  8:16 ` [PATCH V4 02/10] OvmfPkg: Add PrePiHobListPointerLibTdx Min Xu
2022-02-28  8:16 ` [PATCH V4 03/10] OvmfPkg: Update EFI_HOB_PLATFORM_INFO with more platform settings Min Xu
2022-03-01 13:26   ` Gerd Hoffmann
2022-03-02  0:42     ` [edk2-devel] " Min Xu
2022-02-28  8:16 ` [PATCH V4 04/10] OvmfPkg: Add PeilessStartupLib Min Xu
2022-03-01 13:31   ` Gerd Hoffmann
2022-03-02  1:20     ` Min Xu
2022-02-28  8:16 ` [PATCH V4 05/10] OvmfPkg/IntelTdx: Add Sec to bring up both Legacy and Tdx guest Min Xu
2022-02-28  8:16 ` [PATCH V4 06/10] OvmfPkg: Update TdxDxe to set TDX PCDs Min Xu
2022-02-28  8:16 ` [PATCH V4 07/10] OvmfPkg: Update DxeAcpiTimerLib to read HostBridgeDevId in PlatformInfoHob Min Xu
2022-02-28  8:16 ` [PATCH V4 08/10] OvmfPkg/IncompatiblePciDeviceSupportDxe: Ignore OptionRom in Td guest Min Xu
2022-03-01 13:44   ` Gerd Hoffmann
2022-03-02  1:21     ` Min Xu [this message]
2022-02-28  8:16 ` [PATCH V4 09/10] MdeModulePkg: Update PciEnumeratorSupport to ignore OptionRom if needed Min Xu
2022-03-18 13:41   ` Ni, Ray
2022-02-28  8:16 ` [PATCH V4 10/10] OvmfPkg: Introduce IntelTdxX64 for TDVF Config-B Min Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=PH0PR11MB50644D0AED596074E90C892EC5039@PH0PR11MB5064.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox