From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web12.2871.1646184111546490491 for ; Tue, 01 Mar 2022 17:21:51 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=QSA6Uk1/; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: min.m.xu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1646184111; x=1677720111; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=fNuJWu8MupQ07K17rxGznP6PT3902T+E105cqAcASD8=; b=QSA6Uk1/HfAjr8ScVeXz7wi+02XC04uQTzHeke13yZPW9NpiD7d7vSaW qaVTWizrb/tTryuHmqqV0qcmHxyqfP5eCQ+07n4UqRCq45oXLwXmF2CB9 ApzUDOrhXAtK5bCy0VGlsMMxX5sB9u6IBTMpNnWAcQnXJoNuiuPaMyy9Y nYAhlkfpcRHQFsNpQwiwbBdn8MbOKs5WM038RUpkbWIb9co6nZHxhSR+1 POwS6W5YqaYXRnqdU43JgpyltvjGEl6Lf0GngEUiy6EQt3offdo4N0qHd dgPgdvkpErIycSXzs6bT46x2Kc/SDiL4VXn9Io47MyoR+r5KTDV7j1Ypo g==; X-IronPort-AV: E=McAfee;i="6200,9189,10273"; a="316497181" X-IronPort-AV: E=Sophos;i="5.90,146,1643702400"; d="scan'208";a="316497181" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Mar 2022 17:21:50 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,146,1643702400"; d="scan'208";a="545326727" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by fmsmga007.fm.intel.com with ESMTP; 01 Mar 2022 17:21:50 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Tue, 1 Mar 2022 17:21:50 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21 via Frontend Transport; Tue, 1 Mar 2022 17:21:50 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.176) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 1 Mar 2022 17:21:49 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f8JqkYSSr7AknVXsaQ/jFtu4kQ328t5qfrEf3exJsENQaq8kMA7F+k9W34/ovIrPa7ImMGNQd1Z1Vwl7/QsJiP8h5qRo+TbIqOUXD6wR8udvZaaqZdn41SV3VugEK0OL/NnZJIdXbIT0jXQz1vkpOcxFf5gqUul4VxaNO8E/dOk3rohP+Z5bxlIGr2PBKYL68fhxIt63FzEQr+FvrsvDYt8Y603OReUcs8tPqj8IaWWIqpl6PWDtpmn2qwWnQ6/53hsP1oWixCGYPkbVPdwKKJrkS8zOoDqL48MQdH+wwzG+gQZlPk4OulZhnDKQQZsfphEErpzpG26Dzlv8JzdMIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=94XcsGii/eVKwqkWf+m7poPqy61Bmwix9gI5UuVjyTo=; b=G3pDwfTTO4YFiU8jBTZOuPHsLlrlDKM2tbOpY5QWQl9JFPUIpy1+hR4ghe08wJ93wfVyB4vJJo3kYkshiqGJXV95HClYL2BMmk/DcpIWerq7/BFdOUUmAicW4qAfthU88ZGQerz/AMwuih6O4sGoRApt/UuLiFKmiF6XzfemobSZe59xfOgQFyuyGY2Ke3cDBOy11aYrtSCHutlKkknlXX5LInHjFRNeskcA0pSWzWEc8LvoE+mwun54rFzVFWe5PCIyYKLW/DFWYniaLSuTt66fA90QDg1v0vHTL5SiMtORvxgC71Q017viQjQ7Ctl24yJDP6YdycVPMXj1ss7Gkg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5064.namprd11.prod.outlook.com (2603:10b6:510:3b::15) by DM6PR11MB3899.namprd11.prod.outlook.com (2603:10b6:5:19c::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22; Wed, 2 Mar 2022 01:21:47 +0000 Received: from PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::98f5:edb6:aee6:6886]) by PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::98f5:edb6:aee6:6886%7]) with mapi id 15.20.5038.014; Wed, 2 Mar 2022 01:21:47 +0000 From: "Min Xu" To: Gerd Hoffmann CC: "devel@edk2.groups.io" , "Kinney, Michael D" , Brijesh Singh , "Aktas, Erdem" , James Bottomley , "Yao, Jiewen" , Tom Lendacky Subject: Re: [PATCH V4 08/10] OvmfPkg/IncompatiblePciDeviceSupportDxe: Ignore OptionRom in Td guest Thread-Topic: [PATCH V4 08/10] OvmfPkg/IncompatiblePciDeviceSupportDxe: Ignore OptionRom in Td guest Thread-Index: AQHYLHun520UqIVODECmqgtYQxPmN6yqjB0AgADCdxA= Date: Wed, 2 Mar 2022 01:21:47 +0000 Message-ID: References: <20220228081631.681-1-min.m.xu@intel.com> <20220228081631.681-9-min.m.xu@intel.com> <20220301134458.4ipmt3rto5euc3o5@sirius.home.kraxel.org> In-Reply-To: <20220301134458.4ipmt3rto5euc3o5@sirius.home.kraxel.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.401.20 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8df83836-0d71-4917-fc1c-08d9fbeb0523 x-ms-traffictypediagnostic: DM6PR11MB3899:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 7b3qiLpVi1kDGIwIxMGR80nHvEcG1lTPUr/3JJNRjUOS2EnKxfNB1jBlA8KudHYaMjpRv6wz4KjPOOg8PE/PKPB8IxPG/IvwNQZcGM2qu3WOXuA8kQ8trZfPViWVOrpiASET4K4AS0GkZAG1jnVE2kGwua8rDJ7HcGTcPJVF0Yo7SDLl6d8EivIIajOFUUhCmQbTKNupaMc/e98+GsoS9AJha9lhJWjDjWpCr7Ki0ktWeLxdQomrgZA1JWczbaeVntJWYazB3ruoi60hQqdb0TvsTdOtXKGGdFINEbVsgiY/AxhYJ36ORret0ejIozvaqd3NaM354PysN3qxlylzMnjCIQay/Gp08xqxxF9VcwJ2HvkqTpUFtEYGf4/QimkIfuTRhGyKcVUOCQIH4CjWFoc3z9NJEFFrqR2zEsvo41Fj3xZhmd/Mdn0yTY5ZLtlhi9kHSrPbHnQR3GuYU4ceDP6B3pfoYD+kCtU8IsFO8ud1uN65SoDisdbolHEluCYd1gGjHmwHY4by+sc1C/EVZK+2WxGRO0IOMkVmA5qBjrxHgr/DjB/hEL7d4o6Pkizfc7hioUDwl5RPEY2Zra9LVatEdSYb04NWgpaG+oqm9Ph1dJITgUTKrYRyzXABiCCAABjWc3ZmufR0y3igzm0C6Z/2xR18SqcB3DbaJj0BHCn03SDkPknlDaB4S7Icza4KfYf/9w1G6QWaUnRyWnUL0xLKKLHSji33lTypqIYYv2pXdZEj+FRMLmkminWDKrrUXNucB3Mv1a/X51ZBS2LlT+Zovvs1DOquUhTUE80y2oTbkm5KUQ3UZSsBTEsNRj/c x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5064.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(55016003)(52536014)(4744005)(9686003)(5660300002)(82960400001)(38070700005)(8936002)(6506007)(7696005)(2906002)(316002)(86362001)(54906003)(6916009)(38100700002)(508600001)(26005)(66476007)(966005)(66556008)(66946007)(186003)(66446008)(64756008)(71200400001)(33656002)(4326008)(122000001)(8676002)(83380400001)(76116006)(213903007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?6ypCTIb4GZCbavr905MageI0/qzXFzJodOOzX5V8dXzLtEcj4scU/vafvMym?= =?us-ascii?Q?jS4stl1uNmm34clJ0KUnDlMQQEwBRZJULH4ZcccATdICxWeJv/ABawDd7bgi?= =?us-ascii?Q?zA5Hxfds3nvd+AHc3519oFQxBUwilQCVSuScwGRcSp9eh/ZLOyAwuOLEVmKc?= =?us-ascii?Q?ATpjZu9t9b95KRiydTA2QE7LJcgVmyYvsBKikAnJeI52pmrP5nkaj9FViiPU?= =?us-ascii?Q?R58svsf67RrpdRAI8WGNNrW5LoqGgO6ay39+9wKXhMRHNy+R0DoDX+yRPiHY?= =?us-ascii?Q?NXncfV+rELUqaP/RJsOHxwjAV1x8rW0Im3BSZ4uqAr1r8moRo6bRZpC0z9Cp?= =?us-ascii?Q?XI6BDRj+R4k0zo1/dPKyFIvZP2akJEvRkiFR7p/FLe0kCTvMOk4gRVO64nlS?= =?us-ascii?Q?oQUiEUxa2nB5/B/zF9cWUIY38VTZVPZIQRBomMlSS4zGBBkAuN/CXxUdGDIg?= =?us-ascii?Q?Zs0C0ypXyIqrl2AOtq0nFc+N2ahx9ATgrmcLC4OoUOI+3y/kxidpc4vmRzgf?= =?us-ascii?Q?2OllbymTwZeQsmz9ubfd/HyGM82T204O07lCjwPnlw2UErzR2dRAUIg5CF+b?= =?us-ascii?Q?WN1TU3r6wzqL9O6RaJlnptg7VWxuh2reKqoQNN82hQauvf7hhqgrZgf2Qo3c?= =?us-ascii?Q?Bch/OOW3SoMuFK4EKgyD2VqRy8xL9r1R20Yt3ZC4X11ZDTHS/PQ2jSOJEAWi?= =?us-ascii?Q?Jn4Hc6YoE2Q/WrTvN1QK253PUCep3b7trjcvYdgE4g8G2P+NxNpz6i5/i0JL?= =?us-ascii?Q?R3Nxw7JtPpeXyhjEKSTONTT+3Ssoov7r1xvJHTHMLJpFN8x58T1AQqvZIyV2?= =?us-ascii?Q?xoqOcrNz8WyrrJHzFsGt2SSRjjWmByTlSilUYdcT3iGTQnjH62QbL4U1vVVv?= =?us-ascii?Q?CdQ+h7Q+mdU43l0wO/tL4FqReNG72vUgncC0hEKbY7GLTsvvNJVlcWxtEGf6?= =?us-ascii?Q?UYa6Hg77n8fPBPu/wGwuZuxkAzz31G82o6fzmeVOh1hBQUsbIH3kr9aKILN6?= =?us-ascii?Q?hB/40SUKV0w/dO2oHBv2pDTeJJli4gQdgfc6YYT4KKUd/bPzn+25t0yq3h5e?= =?us-ascii?Q?xFABK1ZH5xmpaYlv+mI/N2X5RcW0lTH9JBKRCf1BYVCKa0sCIhsjBujxpKyv?= =?us-ascii?Q?uO0+ocBtXNHVRsHXYU58Vo1+KYqes7CccH/bId+oPCBRLmNJiaNd/pDfNX70?= =?us-ascii?Q?iyoF3NLgaw2XdfWpKk0mt/7w0MkcHLNL7ym7rLVRKZcW+6/LKMAooPeeFjXf?= =?us-ascii?Q?g0vMnP5zAIn6novR/xnYc2vMLLxHJZuD6RDQF6Qx2y5NpfizpE96np+RP/MR?= =?us-ascii?Q?KZqPWdArTCYZuH6zh6sAQdZSX4K6PoSe8gY8Z6BmpFMw8bf4a/QlyFssd84G?= =?us-ascii?Q?LEvIRQ2UQaetkwLpisI+v+9EYcLe8pu347PrdLX/jekMo88r9dYXq/yyjeoF?= =?us-ascii?Q?MrDBF4IbDF56LgjRj1Us+Ixox19OhxeqmYf7GHTQy2YkzdaeeGI40YWAAjYY?= =?us-ascii?Q?BShpWWS1NdcHNEd8YgG7G5gCkCbM43oAEuifL+a/+EUsO93Hv/31C09ssaHN?= =?us-ascii?Q?CrWvoY8P5pp3eRBk7nZ+d9T6tgpyE0xWtV2tVjQh+ztv0/kVjOTJsy2SFOG1?= =?us-ascii?Q?KpGuLPiBZtpVGmjxyXyeBjY=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5064.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8df83836-0d71-4917-fc1c-08d9fbeb0523 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Mar 2022 01:21:47.1454 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: hwRl5yNB0r7kxuZvrgC6aIOBlxwT2xhDEr+39/xNyrBZY0PbcFo7oiSt6ifLEHS3ZPp6HrL4d9gsQDhC58DtWg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3899 Return-Path: min.m.xu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable On March 1, 2022 9:45 PM, Gerd Hoffmann wrote: > On Mon, Feb 28, 2022 at 04:16:29PM +0800, Min Xu wrote: > > RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3429 > > > > Host VMM may inject OptionRom which is untrusted in Td guest. So PCI > > OptionRom needs to be ignored if it is of Td guest. According to > > "Table 20. ACPI 2.0 & 3.0 QWORD Address Space Descriptor Usage" > > PI spec 1.7, type-specific flags can be set to 0 when Address > > Translation Offset =3D=3D 6 to skip device option ROM. >=20 > Can you split the reformating of the existing code and adding the new cod= e > into two patches? This is rather messy ... Sure. It will be updated in the next version. Thanks Min