From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web11.5930.1634192712907182896 for ; Wed, 13 Oct 2021 23:25:13 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=L8xN15p1; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: min.m.xu@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10136"; a="214549432" X-IronPort-AV: E=Sophos;i="5.85,371,1624345200"; d="scan'208";a="214549432" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2021 23:25:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,371,1624345200"; d="scan'208";a="442609963" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga003.jf.intel.com with ESMTP; 13 Oct 2021 23:24:47 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 13 Oct 2021 23:24:46 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 13 Oct 2021 23:24:46 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 13 Oct 2021 23:24:46 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.171) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 13 Oct 2021 23:24:46 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fbOBf+eb+wuhcmnl+Y86ZtAynoq91MF5B6zitZpInl8e+61IOfHXVURWpC/WKhHz9WiLc4RLDcCtJUq/S5oswVqwbl+1LiQyCWliZVUrWaXB19Q1UwyFibOXQYE4RUwmfaJC+s7um0SMHtpXJN/po43lJG04pFzN9BIZBHVaRlGw1Ud4YMFcyRoEfP33dX2qtMirsmXcI9KbZ4Obpk7VSzQ2wEy3txUWFuOGilOt/GnaP1ru7Hy2MklpQwaZUM7Jq8mXDQgIbpedIK4syUfYm6pTG4/+2r+Gf5vzKp4LOGg3qd1FkDuSEn3EwITdxQBeCCnO0bywKIvs+/bSKR3xNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xFbHnI2YCTL4Hy4aWSTXB6IggvskCy2ghP4zlVvxxyY=; b=TAjrOreJ1yYKko9WiSaxNO0btAq531tD1UpdsX0vmkiA0JhwAn0+QhkWbxud7BRHL+IsgK6EpMDcpp4SA006X6YSo8RALdzaQ8v6Eq02TuQj2CClI9a/h/lQ4PeTNoFDueGg7us8pmnR1gyADtiQDSLiVN6Pgn3qXL0CiX6uuz9cQsYEYpF+BJxGzK22Nel4q4cPkvQkXFxSHW05N1GuLnG1T/ohXovMnLycF0287M746pYX5yaq1Zqd/vl0zCDJMbDlb4Z2ro9vUl3STWafVK30XMo2Tu2tsfSD2Tb95uvYk6pj2EqaYmplePcxHcvEWF3cfWAU7JgRtwBO2ynATg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xFbHnI2YCTL4Hy4aWSTXB6IggvskCy2ghP4zlVvxxyY=; b=L8xN15p1H/WgiZS651WZscxkgw8/d9HYF58J3UtlKoa2L6cXsoTQrLgHSHCAeihZTdWZpb9fAFQRh+Jbsie181q4skEYwIVBCuO3KrZ1PAcRl7YorZVXYmO7Y0laPrT6YKILPg0Q2vrAf8raTna48KMW92Cnkz6JPN7IeiENqvo= Received: from PH0PR11MB5064.namprd11.prod.outlook.com (2603:10b6:510:3b::15) by PH7PR11MB5916.namprd11.prod.outlook.com (2603:10b6:510:13d::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Thu, 14 Oct 2021 06:24:45 +0000 Received: from PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::7deb:6c36:73c2:f0d4]) by PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::7deb:6c36:73c2:f0d4%3]) with mapi id 15.20.4608.016; Thu, 14 Oct 2021 06:24:45 +0000 From: "Min Xu" To: Gerd Hoffmann CC: "devel@edk2.groups.io" , "Kinney, Michael D" , Liming Gao , "Liu, Zhiguang" , Brijesh Singh , Erdem Aktas , James Bottomley , "Yao, Jiewen" , Tom Lendacky Subject: Re: [edk2-devel] [PATCH V2 06/28] MdePkg: Update BaseIoLibIntrinsicSev to support Tdx Thread-Topic: [edk2-devel] [PATCH V2 06/28] MdePkg: Update BaseIoLibIntrinsicSev to support Tdx Thread-Index: AQHXuZq9J2lnNAejJ0OJzWlcSukajavPLkiAgAG44dCAASDXgIAADDug Date: Thu, 14 Oct 2021 06:24:45 +0000 Message-ID: References: <78bc0164be0e6adb1edf4454bdc3aaf1d55a2771.1633401643.git.min.m.xu@intel.com> <20211012100555.4sykhkinx3fc6gak@sirius.home.kraxel.org> <20211014053741.ev2wd7hrzkrdatln@sirius.home.kraxel.org> In-Reply-To: <20211014053741.ev2wd7hrzkrdatln@sirius.home.kraxel.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 76a0dd4f-520a-40d2-ae57-08d98edb50aa x-ms-traffictypediagnostic: PH7PR11MB5916: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: It6GkPt0CIGiYCz//KrlXA+r8nQAO8VhdI3f00gMh94iYOayaUMgXc0YHAFjktjmABVguBYJ/RICtoJhhn8lyUHOkFc06AG4bCw/fIrL4ImA2FyPWvsJEF3+G/zlcDKBTx3fayN1u1pUhnXciJ2AJjQ7RkTnp8cF4cRJP9qKIvf1awi2Tzi79Vu4yITDFH9gYFICJVz1uOZZOoJevbKSNXPGzuENguKMMoGkY/FOsMMLXxpiSkNL8uFrKO9dmnZF0B8YgJ2axnIzvvePXX3iqOmMx07V2CVqCYq3gUUxE59hC1OXhUU0rGt3zIb5Z/EqREY+AoilRfvm2IzY/Tfd3vGP1KhnNinQebpPAO41qQd2lgzeQLRxDTnN1aznIaWXpWYygUGUfaCahUFYJZbk4N/5U5MgOB3FNipvUgNB+kvWMnWu0iL5yHjONAkvvI0km/bdDpyBtJA/iXODf0Z4ukkDXbXVDCbRJ9YWSXPKQqHKny46ASiwfMXO0sPNri9jaMWL8ge/q7ZIPI8Gxru/xosdDwwrYRyMl/vRlL6OlanEdZUx1bkMz3Dt6LwqecJ2LRP9dmAU0AguLqMMzzXwEHY27KhgyqRABeUZsva3TZ6qV6wizZGML6wQZU8ZuujPGPofJr8USTXbYVB24C1C53cceXhOJozR56CAGIr6lpgPDnCg7l+bhWerJ9cy8GtdYMc+SIwKOa6piYe4HRtvGQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5064.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(6029001)(366004)(54906003)(316002)(5660300002)(38070700005)(82960400001)(508600001)(52536014)(122000001)(83380400001)(8936002)(64756008)(66476007)(8676002)(6506007)(38100700002)(7696005)(66556008)(55016002)(76116006)(86362001)(66946007)(4326008)(26005)(6916009)(33656002)(9686003)(186003)(71200400001)(2906002)(66446008)(15650500001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?NxKmNTjbXmdXakgKL8eyIZByaOke5uSe0BDmOTqRJRQBmHEN2Ao4TQJ6WW31?= =?us-ascii?Q?94tvUHi1nNzLxhmc7KpE9XCFjr1SjXdu4/Mdbtues22NksiNmvNlX70WYlQS?= =?us-ascii?Q?iUQcYUpMbjBl6h7C8WTkha7UGso8YKynVJgMIfbMA+4xPMluIu6QvNm/ITBZ?= =?us-ascii?Q?lDnLRbS/z2sNENR/oKTSv/jcJisi7hTS8Ye7SSFsp43SwmNxAYcFVTz5PaD/?= =?us-ascii?Q?ENu1Wl9quVgz2YI6AfUbIgGr8V5nuogG3Dyok7DTKrDLGLQzkIIgHlcAwSd/?= =?us-ascii?Q?AdS/KA/T3UPX1gVOeDmMht5y1MoTzefi4CNGBw+kgkjkrqcAk89IzFB6YZU0?= =?us-ascii?Q?wCj1OolR/bAHHqAw66R84o4PvxpE9CuYDgXVs/cmOLuy4XrOzI1XR3CeUrfb?= =?us-ascii?Q?Q9f52HbKqtHavK97ltCiTtp9QXIYXNRB0ow7P9PAPxfFiugQfLqeH9Ii6Hz4?= =?us-ascii?Q?eRimjZ9uGB7nXWVntmr/UzYjsUTJF8yYiSngnCMh6WOEroh6DBlV8GUD62ku?= =?us-ascii?Q?rvuZ10lcR9tXQFtvbMTHyYn8dOxaB/gCj20pU34x7LARxpySng5BsHGmglx8?= =?us-ascii?Q?b9GpzRis3QvBtMx9JXACDb+aWJ6V8C4rRxTrUoS+tNtdiAhBoqi/a7XrqoSl?= =?us-ascii?Q?SPEnWyXW8DAna/4Xm7KKxLfdB2vnl2nbtkvSPVHiY7byrcyE3c3nzPN/CjPt?= =?us-ascii?Q?NTIM6yUgUl7GJ19rLAeBr5VxsvglSYRm8cy9OsYNzR3rYkWR5oKHTcAXnOWA?= =?us-ascii?Q?7gBG2JbQvtorgkInvM0DTeS60K+9/IhHQb9s027q1mgtWQLtXuINj50NNwr6?= =?us-ascii?Q?ORZcfXErUuxexA+fuMvqtlFUfDTrXU7O44CBJHd9fO1+z2N5lXftdQL/QnKC?= =?us-ascii?Q?3ZDhkzE5yNZEGas6BgZM0URcB4tYtqvnUkhVS9adONsIB4lrkvu/LjdqoSCc?= =?us-ascii?Q?Nd6TSLKzvdI9GhppJlmhHX/wqP/cHyKT1S2w9B0tWJBalwF8a0fqYUv0lsCY?= =?us-ascii?Q?UOkQdtR2PdQibTGg3RkLw0EzYZPET9db0iOvtwIO60sYso4jvp0v38283zDT?= =?us-ascii?Q?I44QG6EkL0HHekK/7QdO0/NrNH8HnqKtZ2iyOhRFflIMlhM6L1R1nHNVDD4V?= =?us-ascii?Q?6H0+95GT3pzd85H0UiVhHYuar+LiGfsFbxuIQBBDC6BGtn7BPYpE9rcOaxiZ?= =?us-ascii?Q?1MAHphJ6w1JRn1MHsBm9wlYZ86IcudS+jtFfAhQ1NYC4ZMTx1HSdp4WvpXCY?= =?us-ascii?Q?SKu9beGEa3hhiOHVpEWwXyF1crOpM8q4kNN5w2n0YzAGsZ/WoHGfd5AEbyOk?= =?us-ascii?Q?zeJyqV4SW9sV2T8YhUbiX6Z3?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5064.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 76a0dd4f-520a-40d2-ae57-08d98edb50aa X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Oct 2021 06:24:45.0915 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: gKN9RpmZ/I5Y35yfnW3gxmf1QMPXsnCK0fDfzjvu21OkiaKJUBkCa49o5ejMfH9dV3c2YhsEJbrUwAZmw5dR5A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB5916 Return-Path: min.m.xu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable On October 14, 2021 1:38 PM, Gerd Hoffmann wrote: > Hi, >=20 > > > Calling CPUID should not be needed, we have a new fancy > > > ConfidentialComputing PCD for that now. > > The gUefiCpuPkgTokenSpaceGuid.PcdConfidentialComputingGuestAttr is > defined in UefiCpuPkg. While BaseIoLibIntrinsicSev is in MdePkg. > > If the ConfidentialComputing PCD is used, then UefiCpuPkg has to be inc= luded > in BaseIoLibIntrinsicSev.inf. > > I check all the *.inf under MdePkg but no one *.inf include UefiCpuPkg. > > I am not sure if UefiCpuPkg can be included in BaseIoLibIntrinsicSev.in= f. >=20 > Hmm, I guess we should move the pcd then so it cam be used more widely. > Confidential computing has an impact beyond just cpu, it's also memory, i= o and > more. How about define ConfidentialComputingAttr PCD in MdePkg.dec? >=20 > > > Maybe that's something to cleanup for amd (Brijesh?) beforehand, so > > > the structure is there already and the tdx patches just need to add t= he "case > tdx:" > > > bits. > > Tdx patches can first use above structure. AMD can update it later. Eit= her way > is ok. >=20 > That'll work too, I don't care much about the ordering. >=20 It will be updated in the next version. Thanks. Min