From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web08.5224.1645668780628146095 for ; Wed, 23 Feb 2022 18:13:00 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=I5loD+7s; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: min.m.xu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645668780; x=1677204780; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=2Of29zM9eatuYNy9f90EjE+fMKLrNGzw7FayEv5sztU=; b=I5loD+7sQ9Nh3AzBmnO8C5u8coeTrrt4RH7qO33ZUBQnySZdzm4GiZNZ uK0PJAa4E8rgMp/sBdUWy+ZzdbwhWkeGpZyGdVkCtt/gSL7G2Ul6aYjRM TrE3883CZPJgIFcIl5SDvBBP2LR/rQt7KQOaqgCpIbcmI0zShMdcnEy26 bP1FCFVZR4uND8CRTEEj0cXP0wKJFbEIwmawasp6dx2G8cW94yr3Vch7R M9CFCpXyfZKDYqU5VgzAb/RyK+ySK2vS7Var973xSFh0FK8SZ6Yz5mHKh M/A2g15KrAR5P2EbvWhtoCvtSjAhQdQ4vm7KI28pskT9fJXAEhN0un8St A==; X-IronPort-AV: E=McAfee;i="6200,9189,10267"; a="239525975" X-IronPort-AV: E=Sophos;i="5.88,392,1635231600"; d="scan'208";a="239525975" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2022 18:12:59 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,392,1635231600"; d="scan'208";a="637661533" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by fmsmga002.fm.intel.com with ESMTP; 23 Feb 2022 18:12:58 -0800 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Wed, 23 Feb 2022 18:12:58 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 23 Feb 2022 18:12:57 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Wed, 23 Feb 2022 18:12:57 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.172) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Wed, 23 Feb 2022 18:12:57 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K3QchY4N+6A8UN+K3jpK8BibrH7xLVAYUo9176hCqWbj1jyZaFVqapnsVPXUl8AQbw93f39+LZUUdvTvE4hk3GQdZXCv1yMalTb2akaZC1Nh6YYxWljzEAxMSpo/YnWYOloP89VK/w+30gLG36ang/5cDhh221JHVZ9sOkvo4+NioLZxz/lLUktueOaCCszYdO+Kl3oBRxMM+NOVwKFf7osr/Xx7IpcG17bQLLFBFC5NrImIalJ5jbaInwrLzmB7mmGIvIj6OC7/imOD4+afmn2HSqT3wiMdneEUXzoTeZaqO5az6tXNznb7f2Znepft6NpCMj+Awf7aXk28ZCfC/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pQMoY8KEaSkrh2fugguKivoG9o6sk4+/AX3lCYfo8W8=; b=aySEgeBJjonW5AHSYbHEwnK98qgiZCLNTK2X49O18QOCDXciW1vNktKgQAqBNQJ3GhSzdwGlr9wQw0NE5mPyTuaW11FDeTbQS6dQCnSgjFCYBKN+D2gLMJF3Ffc6HBv1Z7VwV/mHkeTXcvPMjTFsCN0NrqI4Q9ZPZ8l7JmdoivYhi1a0K1t4U6uowCdiYdfNHzUB1NZhGid+3VFg0RKbf1Dr6DkqmINe2FkwmbjamQntnpNNGH8ViB6OzOccV+0glqa8PUXTTt9SpyCHL3d3kZctYOaIc1yATMbuN7C71maA9d4G4LK3UpA6Fj5DAzioaf/AGHe7M3Q+KNghCNVscg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5064.namprd11.prod.outlook.com (2603:10b6:510:3b::15) by BYAPR11MB2680.namprd11.prod.outlook.com (2603:10b6:a02:c9::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.24; Thu, 24 Feb 2022 02:12:54 +0000 Received: from PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::98f5:edb6:aee6:6886]) by PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::98f5:edb6:aee6:6886%8]) with mapi id 15.20.4995.026; Thu, 24 Feb 2022 02:12:54 +0000 From: "Min Xu" To: Gerd Hoffmann CC: "devel@edk2.groups.io" , "Kinney, Michael D" , Brijesh Singh , "Aktas, Erdem" , James Bottomley , "Yao, Jiewen" , Tom Lendacky Subject: Re: [PATCH V3 7/8] OvmfPkg: Update DxeAcpiTimerLib to read HostBridgeDevId in PlatformInfoHob Thread-Topic: [PATCH V3 7/8] OvmfPkg: Update DxeAcpiTimerLib to read HostBridgeDevId in PlatformInfoHob Thread-Index: AQHYJgJZiR6RZUrtIUmfDIWxyIrq/6yg/fyAgADtCbA= Date: Thu, 24 Feb 2022 02:12:54 +0000 Message-ID: References: <20220220023319.1495-1-min.m.xu@intel.com> <20220220023319.1495-8-min.m.xu@intel.com> <20220223110335.pevax5cklskydbqc@sirius.home.kraxel.org> In-Reply-To: <20220223110335.pevax5cklskydbqc@sirius.home.kraxel.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e3bb2257-0ab1-4313-6930-08d9f73b2adc x-ms-traffictypediagnostic: BYAPR11MB2680:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: JPZWxaX4ej86Z0emRqIu4z+DOJvQsRNZNT354UGDMFNUM1JkanXLGc42De+xB+UfMX+GvSGjqEwI1f8pkYjr0scd9BV7cMOIk/RgQu6jsQPfe8mVlfRGmbzgqP4TRS9eCCvkNeK85+fgXdXafOuFERGQMil2G2ZF83XMsODNheto3F5lhfsAvB2LAi8LEIf8lI+c75wp5ufaEKaZCycudHU2cWVKEak1JM4/gUxaMCvhjxagCpPkOO1YZm12KyZwhO5F8ZHZvfj2mWkEMmeyt9QLj49M/a/mSbGihJcMJxbfzwGFuthgQ73xdpJBVTKQ9oeIahdnqGMMpREG9ENRShKHnMrYTwCErOkt34VTzlEB3GHzy/PibzTWjQTcqiLK/n6SLyyqDQXWw7F7oYrv1GF5aVncryMBsF/BreVIHmzlQBxQ+3V49KvMI7xupSLBioFhnbmTWjgMtIXy5SpsMqFgJB/16csXT6klTYQppwCWIc0Gea5sycpWzJ1q03H7ioPH/wIhdU0+sAVwu0+9et26zPhOqEU5oTl3Ijpct6Zotsk0mPc7x4VVykQkFcsNaTZ1N8RdBy1qgxMhgl1qnyBbB16RRiNd8i9HyMx2NldYSW8h/c/6ZYcM+dcw6YGdlsMzk976hlzJP02tYRIOUiows34FUyh14w8wHmD8nE3w/rCbW1nLJpUUb+0ANTlzEJdw3USDlcKnJnlKDYxpMQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5064.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(508600001)(52536014)(4744005)(5660300002)(71200400001)(8936002)(33656002)(122000001)(82960400001)(8676002)(55016003)(9686003)(26005)(186003)(4326008)(64756008)(6916009)(54906003)(76116006)(7696005)(38100700002)(66446008)(6506007)(38070700005)(2906002)(66476007)(316002)(66556008)(86362001)(66946007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?tM9225RFcWomz3uTmNFZZdJHn78Myc8JWlSA6WLeGYu71MfpREkDiH0WYEtq?= =?us-ascii?Q?zocJUe1fiAUMt1AOyAn/pEv/KE+5YwKc+5CFvqecDmBMx4Btl0/gwDGSr0Wt?= =?us-ascii?Q?RbaxA0NOW803ySELgUq2xVBCb23YtVS49xTjxCM5fjt1vm/6Xvuq8GLNMYP1?= =?us-ascii?Q?SLMatrX3SaK1Sz+VUdIeJWcarINkNiNy0VuYLkqdk39TSIA8Zp2/zCQc3mwI?= =?us-ascii?Q?KG2zSlJI0QTy4krVlK7oAjvD719yeP/Q/EU0uIBKbJtxVGq5dkzIkBbxCSai?= =?us-ascii?Q?mA938HmRCzqJuAwJUYckZH5ceX7/WQsYca3lRJHsT6+FWulHxLbPW/UpnTNE?= =?us-ascii?Q?paN2wiPYQubHZhxTgf3gY2ALzXWT4WP+z/GkVp8oypuG61HTHUZ8ionGuxjY?= =?us-ascii?Q?CjOZL6bCqy05Ggu5noy711CX6H+MBTQwA+QGF/7OIb53pawkCmtry6omVdXb?= =?us-ascii?Q?6hW9v8oaGxZmZfcgCrGsYfGzuJAKiFHmcsMhVypH/tbB/ebhlMmsd6ZKePCP?= =?us-ascii?Q?Fj2UNldewXsDKRWvEA06wycHxl+Bz+bsDG5AQiTlgmExK40lQvJCJN4v+FWX?= =?us-ascii?Q?0GJsP0/FXLMlUxn1c7hTafIlkg2O43oSc+dVCM7oXCSAfFM6pej4DmzCyg4J?= =?us-ascii?Q?QtehidP/JT4sdcG8ydzwSksCSMxdUR7w01IrUP0DnwB4Dpa4czLGRd1rpkLA?= =?us-ascii?Q?0d0/h2YYMvCvvAgUXTqgRlQD5VJiz7iPyoGBdEAyHXOBMUYxdAT80OmBjkkm?= =?us-ascii?Q?XVWbvcI6Eh+0QArYdjGFCOBS7V7aeM77jEoVCZFlh5r2UBqYj5zEjUM4nA0s?= =?us-ascii?Q?gBdP/mrlgFQ0W7ojcqaJfNnz3RniRSq8f3f7+/OWC+LdwJ9rb3RmxFSKEoRD?= =?us-ascii?Q?dmNoIlpVpaIAWmwQwND8+KxLHZbxeXt6Tykhc81uxHbT1exH6CfbLgRSWdNK?= =?us-ascii?Q?c+7tGnbFYLaSeo+RWvDArmcua0H37kCKIg5L4XzsAtghJr3W3GqhVuJyWoCd?= =?us-ascii?Q?GI/9hWM20QwaTH3L7tqF6eu5I0jq2dTWkpmiwhZ3AhMb1FKxpnZ/7IJ5uQcH?= =?us-ascii?Q?nc+h1lrNo5Okk2iREBxMg82EcwQsJabIo2b+I3qgBWM6tg59HtuLEEVGccQV?= =?us-ascii?Q?z3o8pjqSVv1Pd5ZMo0ppw5/JPLInNeULYMynO8PPptr18l4X14nnCzE41BIT?= =?us-ascii?Q?4PNP3xzst2rX5b9Mi2YKvq2bFukJvriYt3DCzKpgBIS6i9SzGoPWvhywZwcu?= =?us-ascii?Q?q+Jg0bBNxvzfW2GYJBU66XxMrdHcQrKIzFHY8fvtEAA3nmmIakQhDHr6Kw5s?= =?us-ascii?Q?ChWVmhyubKEFnEIifMSQftdZR7q9CLP8Id+wL8sVq1ydIN/p7B4d1Eta7bEr?= =?us-ascii?Q?8xcZtVqrwkBdg6WVzaGv2X+i7VF41dVKIzNwu4osDNmpijXGVpQ9/VFQzZCf?= =?us-ascii?Q?Xu8qPkBolD0P2z9ZCc17vTZLA2lGzrqwfm2v4O2kgHUJi5k7KAZMpL6Ycmr+?= =?us-ascii?Q?VsijwxYkgkv0PL0S4iqAzd8jfP0zhcUgCLqVI+1gITkfzjA4ITQio4aLfEM/?= =?us-ascii?Q?av7cMN5DfWXcHPw2SmFRJvpemK1a2KRjyJmazgbGIvBPoCRcD8PEcx4Zut+0?= =?us-ascii?Q?96TFkF4LCYdMchhDQwOmk0Y=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5064.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e3bb2257-0ab1-4313-6930-08d9f73b2adc X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Feb 2022 02:12:54.2605 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: V9e33Lgu8K/ilOkTm28+vNHJ2cYwCbS3vCD9Qt0KyHctEtfkf6HhkewWvAaE8D4ATjbj9skmJqIge29YS9EODg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB2680 Return-Path: min.m.xu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable On February 23, 2022 7:04 PM, Gerd Hoffmann wrote: >=20 > > // > > // Query Host Bridge DID to determine platform type > > + // Tdx guest stores the HostBridgePciDevId in a GuidHob. > > + // So we first check if this HOB exists > > // > > - HostBridgeDevId =3D PcdGet16 (PcdOvmfHostBridgePciDevId); > > + GuidHob =3D GetFirstGuidHob (&gUefiOvmfPkgTdxPlatformGuid); if > > + (GuidHob !=3D NULL) { > > + PlatformInfo =3D (EFI_HOB_PLATFORM_INFO *)GET_GUID_HOB_DATA > (GuidHob); > > + HostBridgeDevId =3D PlatformInfo->HostBridgePciDevId; } else { > > + HostBridgeDevId =3D PcdGet16 (PcdOvmfHostBridgePciDevId); } >=20 > Another thing we can probably simplify when we use a PlatformInfoHob in > both PEi and PEI-less mode. Agree. >=20 > > +[Guids] > > + gUefiOvmfPkgTdxPlatformGuid ## CONSUMES >=20 > name this UefiOvmfPkgPlatformInfoGuid ? Sure. Thanks for the suggestion. It will be renamed in the next version. Thanks Min