From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web10.64752.1674698290702945616 for ; Wed, 25 Jan 2023 17:58:10 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=SkHJS5Px; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: min.m.xu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1674698290; x=1706234290; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=2MNVUmd3+TYE+nNO/iXn0Wfv8wsE3G/UP+o5XHWj/ig=; b=SkHJS5PxVnS4glIKv5zW2nYAR8rWvagCRMnEVGxS7MfQ3qpEdx1AyWXK WoDqZ6jdcmrIw44gbrwOVxWeTuKc0M0KEF9QS4ruvlcDyT9thuuGM2A7R 8yFUGc4lWuHqc1dnKZY3onm02dp/Uc+Va+gM7kc4ts/yiCaCCw9W1FJTt hnwh+JQlACo4O7uNnHCUZLXTScEKMSCn0Fa3x5ZffuVfc2LrrXI1dMoS9 fuzZqDNbvuXhpdeX92jdE9bCTzHp7DP9VzutWQw6KApp/sbrlRwquduaI E73TGu+Rh6WFnbvIYC3/dteSY7xNfFhgb3q9IWg9kuOCmJMkeaRoRYa5z Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10601"; a="314634597" X-IronPort-AV: E=Sophos;i="5.97,247,1669104000"; d="scan'208";a="314634597" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jan 2023 17:58:10 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10601"; a="664677995" X-IronPort-AV: E=Sophos;i="5.97,247,1669104000"; d="scan'208";a="664677995" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga007.fm.intel.com with ESMTP; 25 Jan 2023 17:58:09 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 25 Jan 2023 17:58:09 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Wed, 25 Jan 2023 17:58:09 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.174) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Wed, 25 Jan 2023 17:58:09 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DsRGt8u9QIlETky0wMRR2aLOjdFuHYhmTbS7g6gTr1UZ+y/h8s55aeDI6jBYzFHJ1zmqifoPZ/TJJ98GfyHmzg6K+khYCnlIKbTovjjYhj7p2s9ORu6OXbj8GipySc/4Eus86PiZPDXNMw6pxjo9wj2KFawRVaHdYL1qj0MfZqRfk5YzXLsWnpqnbwBBlTT1Zcltn+bHUymQmlygQWJJj4Xk488bMMHoJRy8QxZzpSW00gy18PdD/rKv+RJ/omnKwBpEw3BlttDqNBVe+8jxhOyTMP7AUFex2RAJj8nXl8riUJ7WmxF/NPUZXjPwLoCC3D6c2qzgmp7Gol9MxJ3INg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lo0tw5/ptPy49ftWQhXFvD7itDSBg3JA/uN5ZvcbFU8=; b=AuNtJ2F2TE//8xbcD2DhOaWtMtzlXw+TvZmJfiyKb4lrWL+RhPjfe/9Ii8bAyrlHvHVx9etKADJEpB8qmj30sd0BPPNEHTsP1LAIqf2aFkjAuWhMM02vggnG+QKAgjmFpW0gmTfyekcwGn5vdnE1SMPX+jPLGBNjQd9T4577QtHEJqCZqbJ/GKfrWsD4uLNKcDh7VOjqT0TAFQ6zmgGOxOCGTrjHR4q2hrDF1ZIPjRIVjK8pwUepONgycho66UybO1Ji6Igp3nvqo3HNQKsRvY9s5PhVxmPTLn9fn86KqTqB6G4ND14Ahr8GnSphDL2ojpfDd6bKP6NZfrtmHNQkow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5064.namprd11.prod.outlook.com (2603:10b6:510:3b::15) by MN0PR11MB6256.namprd11.prod.outlook.com (2603:10b6:208:3c3::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.33; Thu, 26 Jan 2023 01:58:06 +0000 Received: from PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::d87:9f99:2db2:43d1]) by PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::d87:9f99:2db2:43d1%8]) with mapi id 15.20.6043.022; Thu, 26 Jan 2023 01:58:06 +0000 From: "Min Xu" To: Gerd Hoffmann CC: "devel@edk2.groups.io" , "Aktas, Erdem" , James Bottomley , "Yao, Jiewen" , Tom Lendacky , Michael Roth Subject: Re: [PATCH V3 5/9] OvmfPkg/TdxHelperLib: Implement TdxHelperBuildGuidHobForTdxMeasurement Thread-Topic: [PATCH V3 5/9] OvmfPkg/TdxHelperLib: Implement TdxHelperBuildGuidHobForTdxMeasurement Thread-Index: AQHZMGQ9iootqGkOR0SoQpxNl7Osza6vDpKAgADjuRA= Date: Thu, 26 Jan 2023 01:58:06 +0000 Message-ID: References: <20230125022359.1645-1-min.m.xu@intel.com> <20230125022359.1645-6-min.m.xu@intel.com> <20230125122223.xsc2kwwpcajn53bi@sirius.home.kraxel.org> In-Reply-To: <20230125122223.xsc2kwwpcajn53bi@sirius.home.kraxel.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR11MB5064:EE_|MN0PR11MB6256:EE_ x-ms-office365-filtering-correlation-id: 2ef34684-717d-4c13-cdf3-08daff40c460 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: MJg9JgAMMPZjQ0TukrlYGohiyLqG8Q5QOhkOwwwyLpHaXZPGtcBhEqKhqwFUo5fDT5lYnMgMNZZkbChRiCpVVr0wtAXMtbgLCfGLpc+wSryTuRx08+NAh5HXYBQDtxUzkWOhCCnzcKICbBKnDMp9mBasPqL5vzOl8prH8SncOCu7rtpm/iZZYBeeZhAZCS7XzX61DibY99IW7gqZXH0JuTV7DvTU1sHkKz8Nf8eidJYbgTd6nYhAhrJlzUi8N9LJcXnS9jgdP0Zkf/BsN3Ngz0jB1gNlYmUHDGMZmZj9fbZP6JxSFUkp064AmU894x96tj9uwxswmZkpeAI/bv1B6h8MpqYXnmh6IIZGoCn3a2LEL7SBUbLb1h6K67q3p7/ZQdlwFFXa8rmdwA+KJ/o9bVfx2iQM/TcRSjiRVrHUkbvvHlgeS5FFalE3GyxSC2bxpv5llIeEhE+mnsUjPHFt+R09c/af2YeSCBpyymOjOA6NZOStOKxyb5Wc4jL/5VbPiLqEl2oiqF6UiT7SQr2nJ3J4POjPDgHJYPXwNBD1mjcP3SPTKtLYrdZDwhydWg1VfxY7O2HMLsZSWjacVy62ynlo++0fbn1jI0q8OCsn2HLiF+D8JQZKCDsJQ7m95UHCce36JazqG5MOSe4zO+hwsijOhf09ptDRZOBFrSS0DQdLWGko0kwfsEy8ESZ/xf98sNFx2q9RDzOypv9xEGxdTxspM59Uv7coQbup/qTnHzs= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5064.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(39860400002)(376002)(346002)(396003)(136003)(366004)(451199018)(83380400001)(33656002)(86362001)(66946007)(66556008)(38070700005)(38100700002)(64756008)(82960400001)(66446008)(122000001)(4326008)(8676002)(52536014)(6506007)(2906002)(26005)(66476007)(4744005)(8936002)(41300700001)(478600001)(76116006)(5660300002)(6916009)(7696005)(9686003)(54906003)(186003)(316002)(71200400001)(55016003)(213903007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?2UPMeSkeO82MUcKLtpWoSO/r2WSg227s87McvjNb56RZBgozL68eSi6GEj1J?= =?us-ascii?Q?ivUvHGPtKSOlP0LFFqwAltw2MrznFQLeoq+JuN4WJXTvQna1DjfpokdFXgx7?= =?us-ascii?Q?lQY5EX9JrKWWwJ1sPn3U9PefE9ZuwfaPsbU99LyMUdIhK1WmnuKzd4u/LRQd?= =?us-ascii?Q?Qr1DJE5COXOolDI/Zf4R7PAIYwv6jCMr1UdaQBfowlIpTA89cYO+TUcde4wl?= =?us-ascii?Q?WUB39hkgHbgncKrPWmka0E419Fuc2lq9h5xEBtkphljsURJQmfvcKkg4Wyr6?= =?us-ascii?Q?oRVDdkxlExIk3KbiaGNvIFMcPINZT5Zck+VgVWfw5LbLq4AxEzeVTisi9kDd?= =?us-ascii?Q?aKbvyjJQmvGweV1QSe9K/FpWBCA/Fj/3Xo03+r25SplIqWyAMlywMpAsR/MD?= =?us-ascii?Q?R6t/hSjAOziE32Fi9L0hYplS8ZsxUzoxy4Q2rLXnTDdfndJp2u5iVXUhABbX?= =?us-ascii?Q?0T5OjYX1/Z4pouPnPG7SIisCY2JQy4sAcl3VzoKF44QRhU0Rg9aWPJQ+KOm0?= =?us-ascii?Q?bWKrsGjKrLXBoebrjPMUVULgqe2ff+hBQyMpjtUybXOCJQqfE5Z24EirW4Rz?= =?us-ascii?Q?uJN2Sm1t2/EPilP9Q03EPGL6faqgmIKgW7kflyvmAKkEMj0MVawxkxDvvNWo?= =?us-ascii?Q?E9wcEkTqK7kuDX0o8P50sj6XVBLmgOEm4eKXUa/OQnWdXXaTtQJoiBWXSv5L?= =?us-ascii?Q?zFNl7UbQAci7qzXfrRCVF1tMAMUH//uu4G93dMC8drTQLr14VscHFjbidX31?= =?us-ascii?Q?cZ1R6uDSE3wiv4oN9eruQ0Ekt2N3OISt78idt90xJ9VASBiET3wngod4h6yl?= =?us-ascii?Q?zHIUwkNiaKNiefb+tl7rkXfDuX82vjuIRGYZ5XYULycUcwLLnyEkfntnfdeE?= =?us-ascii?Q?wCd/+UgLwuQovOuqQ8UhHPj+TxlgAczqZIBj+BLoBGbHc9B1rQAnz2XWWCMl?= =?us-ascii?Q?8otQaVkJZW0o6tQDy6WmqfK8CT/9Z4oiQBH+ny0ltbkHP4ryC0eKhtoqoHMm?= =?us-ascii?Q?Z3MDQEf75bEBGpbTeXFw6RK5vmiTjFWzBwFW2n6Ydb3fNVwrZSisV9mZ6kbO?= =?us-ascii?Q?iTHKbkhTTMu6dACNNRUMMA/QmEwfUSKjB7tyQp+/gFb8iVuQr4D2RBw2CAoC?= =?us-ascii?Q?LwEVrXoCBkOpdxsD8Nu3iWyRKKTyzmaA9JOK/W79BihBh2TeF9w1T4CbTTmj?= =?us-ascii?Q?D30ZZ+QWT2dDT8TDstJnmrSNUydbH14AGIa7FehjlR3v3Gev3HvQ36FTQzgA?= =?us-ascii?Q?ovEwXbIDtvIECxqDHnsjJRcerRn7mu5o6mQdGqoL4jlTHzhPRLUiiPtjoRVy?= =?us-ascii?Q?PFFjX7mkT/3wHRUmlr3ewXr+0j5P3epm6+pT187qsblSHIckj+ECH/qtWOug?= =?us-ascii?Q?47ngGseo6D2uJ6egWCK5JLc0yMQxJPKZkh/LrVqcPA0RnPN8zwgjzAHt/I9A?= =?us-ascii?Q?JFGq40ITenE6LQ9KEfHGskqi2pJ21IB+/8d3QJkXKH7k/9eS8b4HImO7PYgQ?= =?us-ascii?Q?7yLZVfx6/RSrIGTiNwX9+rj+N8hkn1BZs6V/YbKI05OYZnAqLGFhTYyeFyTk?= =?us-ascii?Q?7mPKMUMM5y0xDQI0u0wLCfTuZrsE3Aixsr2N4DLD?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5064.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2ef34684-717d-4c13-cdf3-08daff40c460 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Jan 2023 01:58:06.3546 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: O6vgAICXpAXgrGZX2WywekZFjGMCqtmK6/08AuitlqbZ/9eXj/wM2CazlLWZ0j13ESuweF9B0xYpKqAw9Pug+A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR11MB6256 Return-Path: min.m.xu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable On January 25, 2023 8:22 PM, Gerd Hoffmann wrote: > > +#define FV_HANDOFF_TABLE_DESC "Fv(XXXXXXXX-XXXX-XXXX-XXXX- > XXXXXXXXXXXX)" > > +typedef PLATFORM_FIRMWARE_BLOB2_STRUCT > CFV_HANDOFF_TABLE_POINTERS2; >=20 > > -#define FV_HANDOFF_TABLE_DESC "Fv(XXXXXXXX-XXXX-XXXX-XXXX- > XXXXXXXXXXXX)" > > -typedef struct { > > - UINT8 BlobDescriptionSize; > > - UINT8 BlobDescription[sizeof (FV_HANDOFF_TABLE_DES= C)]; > > - EFI_PHYSICAL_ADDRESS BlobBase; > > - UINT64 BlobLength; > > -} FV_HANDOFF_TABLE_POINTERS2; >=20 > That update makes sense, but can you please split this (and possibly > other) code changes to a separate patch so this patch does nothing but > moving code and the absolute necessary changes needed to make it work > (update library references, function renames). >=20 Yes, it will be updated in the next version. Thanks Min