public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Min Xu" <min.m.xu@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"nhi@os.amperecomputing.com" <nhi@os.amperecomputing.com>,
	"Yao, Jiewen" <jiewen.yao@intel.com>,
	"Wang, Jian J" <jian.j.wang@intel.com>,
	"Gao, Liming" <gaoliming@byosoft.com.cn>
Cc: "patches@amperecomputing.com" <patches@amperecomputing.com>
Subject: Re: [edk2-devel] [PATCH 1/1] SecurityPkg/DxeImageVerificationLib: Add AUTH_SIG_NOT_FOUND Action
Date: Thu, 27 Apr 2023 05:46:16 +0000	[thread overview]
Message-ID: <PH0PR11MB5064566865F2B231207274B7C56A9@PH0PR11MB5064.namprd11.prod.outlook.com> (raw)
In-Reply-To: <6cdc4e11-bda6-976d-e18a-45c734fef2b2@amperemail.onmicrosoft.com>

Hi, Nhi Pham
Yao, Jiewen and Wang, Jian are the maintainers of SecurityPkg.

They can help to merge the patch if they have no concerns about the patch.

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Nhi Pham
> via groups.io
> Sent: Thursday, April 27, 2023 1:38 PM
> To: Xu, Min M <min.m.xu@intel.com>; devel@edk2.groups.io;
> nhi@os.amperecomputing.com; Yao, Jiewen <jiewen.yao@intel.com>; Wang,
> Jian J <jian.j.wang@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>
> Cc: patches@amperecomputing.com
> Subject: Re: [edk2-devel] [PATCH 1/1] SecurityPkg/DxeImageVerificationLib:
> Add AUTH_SIG_NOT_FOUND Action
> 
> Thanks Min.
> 
> Could you help merge this patch to edk2?
> 
> Regards,
> 
> Nhi
> 
> On 4/26/2023 2:54 PM, Xu, Min M wrote:
> > It's good to me.
> > Reviewed-by: Min Xu <min.m.xu@intel.com>
> >
> > Thanks
> >
> >> -----Original Message-----
> >> From: Nhi Pham <nhi@amperemail.onmicrosoft.com>
> >> Sent: Thursday, April 20, 2023 11:49 AM
> >> To: Xu, Min M <min.m.xu@intel.com>; devel@edk2.groups.io;
> >> nhi@os.amperecomputing.com; Yao, Jiewen <jiewen.yao@intel.com>;
> Wang,
> >> Jian J <jian.j.wang@intel.com>
> >> Cc: patches@amperecomputing.com
> >> Subject: Re: [edk2-devel] [PATCH 1/1] SecurityPkg/DxeImageVerificationLib:
> >> Add AUTH_SIG_NOT_FOUND Action
> >>
> >> Hi Min,
> >>
> >> This SEI test passes:
> >>
> >> SecureBoot - TestImage2.bin in Image Execution Info Table with
> >> SIG_NOT_FOUND. -- PASS
> >> 00C3C2F2-39D5-4D35-B7E7-587CA0F3CB75
> >>
> SctPkg/TestCase/UEFI/EFI/RuntimeServices/SecureBoot/BlackBoxTest/Imag
> >> eLoa
> >> dingBBTest.c:1103:Status
> >> - Success
> >>
> >> The test image binary is different to the one in the commit message
> >> due to some bug fixes in the SEI test suite. The right test case to
> >> catch this bug is 00C3C2F2-
> >> 39D5-4D35-B7E7-587CA0F3CB75
> >>
> >> You can check the test code at
> >> https://github.com/ARM-software/bbr-acs/blob/main/bbsr/sct-
> >> tests/SecureBoot/BlackBoxTest/ImageLoadingBBTest.c
> >>
> >> Thanks,
> >>
> >> Nhi
> >>
> >> On 4/19/2023 6:20 AM, Xu, Min M wrote:
> >>> On Friday, April 14, 2023 1:18 PM, Nhi Pham wrote:
> >>>> Hi,
> >>>>
> >>>> Ping for reviewing.
> >>>>
> >>>> Let me know if I need anything for this patch.
> >>> Do you test the change and what's the test result? Can you provide
> >>> the
> >> validation result?
> >>> Thanks
> >>> Min
> 
> 
> 
> 


  reply	other threads:[~2023-04-27  5:46 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-12  9:21 [PATCH 1/1] SecurityPkg/DxeImageVerificationLib: Add AUTH_SIG_NOT_FOUND Action Nhi Pham
2023-04-14  5:18 ` Nhi Pham
2023-04-18 23:20   ` [edk2-devel] " Min Xu
2023-04-20  3:48     ` Nhi Pham
2023-04-26  7:54       ` Min Xu
2023-04-27  5:38         ` Nhi Pham
2023-04-27  5:46           ` Min Xu [this message]
2023-04-27  8:19 ` Yao, Jiewen
2023-04-28  3:14   ` Nhi Pham
2023-04-28 11:08     ` [edk2-devel] " Yao, Jiewen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=PH0PR11MB5064566865F2B231207274B7C56A9@PH0PR11MB5064.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox