From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web12.31499.1652100303146868981 for ; Mon, 09 May 2022 05:45:04 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=ZHd+VVNV; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: min.m.xu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652100303; x=1683636303; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=Zw5Fe1Wr2B1TbKkBT2NU+sequp7reSZ8pu9C7QnQabE=; b=ZHd+VVNVxjp4hdjimDakFhsQr0Ehr8ovUAFUAbM6j9qmmGjsUwexAe4c 12lPUWpEXWPtRDmPUqW5c+9wHB10bOtr8aSQk0jUhrWuCU9DHIgfikECJ K8l5KqkLnjc/IFX0UZwKtvK01j0oPjax2C1l0YkTb7P6vvcO988aIL1YH Xg4rpKzP6IS8HI4Dqvw4G1QQjgChM29jqlrvYSXyWcSdNg37LN0m3FPwd QZV8ZPJ4hZbpa2cL9yZJ0HHuRU2O74QLbZyg7VZhUXerL+QGlXVePhGnG fN+yQrAhKh+uXbGMbYbRp4se6sfnTJP+ZF2R+RunmOI/RDNcTdWlj6/Cb A==; X-IronPort-AV: E=McAfee;i="6400,9594,10341"; a="267877581" X-IronPort-AV: E=Sophos;i="5.91,211,1647327600"; d="scan'208";a="267877581" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 May 2022 05:45:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,211,1647327600"; d="scan'208";a="738147842" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by orsmga005.jf.intel.com with ESMTP; 09 May 2022 05:45:02 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 9 May 2022 05:45:02 -0700 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 9 May 2022 05:45:01 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Mon, 9 May 2022 05:45:01 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.168) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Mon, 9 May 2022 05:45:01 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BW9gKW7Ya7exMunhGfDQsKNPghYURudp8ch4pr34WRxNBUGF6Z4B8ehZJlRfDmWL5QG9xA3Mh9breGjG4fq65u0KC+eIsNIZZYIIfjwfISZOI6xbBxZho/UGXO3X40YQY/2DMw6u0Fav4GXq+h/V+efcQXaeA/YAGR0Mk5aUHaDXOKw2a2dywNWiyj8kIk60o41s7o3Cl2F9Yd+KV9XKxMjSwaCycd+rUirCTL1Q6Jnvg9icbf8zKYfxF/UU4rmND+6I1rgnGOyomCfK1efjxKN/JMB280rrG8ZdIQvpAlqKAASmEipTu3QW7UK1uSdAt/2FeZsT46pG2EumJ2VbQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=O6N4JJvwW8i37EZQ2Ch40E5pfQKiqprL6rz6bAOz+1s=; b=FSdoWC4Mhz7zXJlBSXAgAOVZR+gcb1UjwZAiV1Yz4AMICeywH8t90CPhcwykBQziIH+muvkYx9gZSaZBTdfHsE9E0tP3E3I7/TPZrtz6stvdF4rjdBGfJNjo4Qh8M1PYv1Ie6EHE3Sk33dW2VT1e8oOcZRgAMVNyOyY7p7oIC7oobeN0Zm7TCHRAvCWaQQdQEReeb7wqCRO7M09yFymrjHuRIiNYUqUt3akyuHMyjk8TD4KUQ2fx3zxzNW+B8DnllWz4CU3VHiroGxzxhyPhir+tJujPfm/EwxWGtFX4NQWS8KICp0uwMAwJ0LhF/tONZhRoTRmVtQphrApq/T80AQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5064.namprd11.prod.outlook.com (2603:10b6:510:3b::15) by DM5PR1101MB2347.namprd11.prod.outlook.com (2603:10b6:3:a2::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.21; Mon, 9 May 2022 12:44:59 +0000 Received: from PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::1844:3fca:639e:7c56]) by PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::1844:3fca:639e:7c56%6]) with mapi id 15.20.5227.023; Mon, 9 May 2022 12:44:58 +0000 From: "Min Xu" To: "devel@edk2.groups.io" CC: "Dong, Eric" , "Ni, Ray" , "Brijesh Singh" , "Aktas, Erdem" , "James Bottomley" , "Yao, Jiewen" , "Tom Lendacky" , Gerd Hoffmann Subject: Re: [PATCH V2 0/6] Support 2 CpuMpPei/CpuDxe in One image Thread-Topic: [PATCH V2 0/6] Support 2 CpuMpPei/CpuDxe in One image Thread-Index: AQHYYbLq0fqgSDJ1NkuEWpAX8sNYC60WgXYw Date: Mon, 9 May 2022 12:44:58 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.401.20 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1a28f1ad-a879-45ec-074c-08da31b9ba2f x-ms-traffictypediagnostic: DM5PR1101MB2347:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: k9NDpzfGchOj75ljETsSwjLcV8jC98oWB9BfuwL1TxT8RbMSdltFm9ptpLjtmN+4tYuiUuHRCUjYXgDG+PPySBH8Mylb+bHGCfH7qAK5XsIQEb9tuFRQ3SOlvKMmALmT+yJY/QYR46R/9SKdcZIcwENjl0DPXwRlhTG/cexqhCd2iMp4tULyvKo2Q7QJxBmDEhJq3FJ5cTEX7DXiqIBwncJQu06clQhHsT/VcrtGQVJXIzk8sINjT9UKkShs/SIPEuBKQh9A9+8SEj3HTlyv+F5qSlgy2cYnGMh9lqIdeoQKUzt8o3ny2rfRnJJRJwHJgVRISDJtifafss8wWt8RB5C7Q0e7und/GcjIpR/gd0oLO5sFMkGdxi5quh93aEkBWume2QcXhsBLCkduWVxEhBYUCMgLkT77EMrIacZdUAazKUPlCwdMIUxJ4tYXR/AyUoRvVyLVLR59g1k4HyDu5CnMF6klB7blmKecazQmuUXb0v39b9TB7DpR++0GfFAa9NM9oI+FrHqdEheKw3tpiCEoSLPXFrpGeFoF+Qji/pkr024I/R9nQixeBUHdbnFhAMOvsp3DHupHeNioVHExosCkckEbo0YzBHXP5TY6YaLVCtCiScQ62etFk7+BeVPqHMY7Pn+JrWmrTgEwxPYmUdorpxCKcgTOKeBbnvxR5eIBC0Jhr1Kw5yAzIg1SSb46kSaegGSieH9nZvq3z+CETaNvFtW4+izrGWtt/BChYfSpM43QbVhdNKOkpsdvy50rGukQcSWBMYIhDickThMb9XdS2jNEp1iW47HKuP/7atNl+zvviL/OYiUcIcGJiDLghj4RsHlLihkbXRSWaPgpoA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5064.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(6029001)(366004)(86362001)(2906002)(4326008)(66446008)(66476007)(76116006)(66556008)(66946007)(33656002)(64756008)(5660300002)(8676002)(8936002)(52536014)(38070700005)(82960400001)(38100700002)(122000001)(55016003)(26005)(6506007)(186003)(7696005)(53546011)(83380400001)(6916009)(9686003)(316002)(19627235002)(54906003)(966005)(508600001)(71200400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?mwpQ3uq4Xi9Vc5eq5D/TTLAzw5LC4mnYmuaUu1egAYSoKW0ZRnKZjp6YNLdP?= =?us-ascii?Q?izSYzEwPD1GJ3oJpOj53HiF7S9BcyXCj5UOhQAs0s7kUxg4gnkeNSCsZ5I+b?= =?us-ascii?Q?yeoGkly/7BJ1xqeCXRLOwdx6dCxFwATldEk8KzhKeSwuVXyhGIVD5ab3sFU3?= =?us-ascii?Q?Xfik8cjZy80P6z3hjVkql8tOPFJ7rk71fgsrQkSMpLEe05McOfjdN70YezOY?= =?us-ascii?Q?Lm6bTA30nOjoF3ZLk8Z9p35rqumwEZ32zGaP7iuZQlKKWDm2ryhn+S1qsD0O?= =?us-ascii?Q?hQQZuDev81R2RJP1rvzRkTVuW3yrGSXozhJ6dxHgwfk/ofmIhBGZHLWmgYwv?= =?us-ascii?Q?0EvOkimYClrU6WUyJFEtpmrY6bLbtWb7r405WQ5Hj8KiOAjHYIzEBwLH6BDg?= =?us-ascii?Q?+1SJl1V69b846Di2Pt9R8miOC19Ko0xlokyDtGG63JxkbxcPuJPTd7V3gRAa?= =?us-ascii?Q?7JcPPNSPernze/IfHE48PgZnjJr+pbp5rU5ixe4SwWF9i2qZMbao+JoclrGZ?= =?us-ascii?Q?fSx4ybthyZFGsIxl5uMIKw01O1ZTuQ1fQabNwpqChh+Srx4A1imdFsinVtR4?= =?us-ascii?Q?KqWv47/k9KxtQcxzg3hRAbGzhc5t7yLnCLYFHk+i/LyXEjO4sTR5RshNIUw4?= =?us-ascii?Q?rZCnjCldTIxmAfkoK/CRnhMWb8rh41HgCIz/BqmdczRLiAPtXyvQtUvGRFJW?= =?us-ascii?Q?TwMee0I+krwcO4adTtkh7klLKmRv+i3zgWr+lOb1tvBVIHrAFoMYF8uTSq/p?= =?us-ascii?Q?cE9uKJN3Jkuv4lv7Ruhjk+UZchGSzzD2C5bX3tBQPMPn5sj2pRqHaW88Ig7e?= =?us-ascii?Q?Ltz9q/lbZ8M5HLydmVF8Bdscw0f/fSSg58enIwQss5bnQ28XCCyTqHsB9eNl?= =?us-ascii?Q?YReZfarg6fvHEQHG1lFrqwIHzwgJCRtYlFVwYVm2+2MMqyDdVUPmYzchC0px?= =?us-ascii?Q?mp2IWmFhZvIi0Es24uVK+0Jjdu/vfJrDW+lyvlwtZOx7vMrALtotHd0UAe5m?= =?us-ascii?Q?xYE5DuFAMLHP+1iEywxhkeQInkl80vMJCXZDjIccWD1rZmi+fCl5CZ81hB8j?= =?us-ascii?Q?NBVcqPkMojIIlCB05ur+lJz6HWOak+9uB4QeHy2W0pOpD02nn99UhSaMGGYE?= =?us-ascii?Q?Pzq7MavSF+EDvpq+ryB7qzMLld6/JcIkaszsW9tiIKn1wkD+2cWBDpM/513J?= =?us-ascii?Q?gKW/znDxOB2t++gptsP6hccHb5ExuNppd0gof+/sXOt17NHHwMCy1WssdOoI?= =?us-ascii?Q?vnqqKJXREo0ThVBDE+t7qTYUDt2QOCQ+1l/Q2JTVLnQJk9QitUSLzeKSpXZB?= =?us-ascii?Q?8HTCeSBRrPtGvWghyLyGTq7hTcyfGDLyJXB0/URHQrxANdutNOigyy7rAP6F?= =?us-ascii?Q?IqlxMcSBo4dcIL4eRxKy/AbG0DR8Uq+LxBbqCNU8JkaQFk4A7t9fDzH1qYFx?= =?us-ascii?Q?SFciv/CeOBBVNTgHNF0niHg3Tq2hp5bU+IB9RhVu92Uy0qtF2MVAwrHMEwVo?= =?us-ascii?Q?UvTdVOCH/uVP94+F+n9cqaAb98xXSt+uJ/0uRkR7ek1v/1/hD8rk8p/7MvHC?= =?us-ascii?Q?2Twc2lX+i7kWlk7rfKKxBxYXj59Hs5XLO/Ynw1/MACRvxVSYIuVZUVEyNZlM?= =?us-ascii?Q?c+QkZATuMPTfqrDlhHYRNzeDqZdGV9RQ6I1NtFfaJfZZalQ+3dI2/7lrAiui?= =?us-ascii?Q?iVpWMIKQrwtDoMZmlxH5O8k8wN1naCkQEai23D7arjsTDwQDJMoJ4UptU71H?= =?us-ascii?Q?hATrio4NmA=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5064.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1a28f1ad-a879-45ec-074c-08da31b9ba2f X-MS-Exchange-CrossTenant-originalarrivaltime: 09 May 2022 12:44:58.8389 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: V8y0WXwCPRM2xyPkhAxSwZuvh03stUglish6U4JGQ3/HxjqkFCqT9dVyfJUSkdYJDnhjhaD1fjV+iXZrDTxqXw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1101MB2347 Return-Path: min.m.xu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Gerd & Tom What are your comments about this patch-set? > -----Original Message----- > From: Xu, Min M > Sent: Saturday, May 7, 2022 9:36 AM > To: devel@edk2.groups.io > Cc: Xu, Min M ; Dong, Eric ; Ni, > Ray ; Brijesh Singh ; Aktas, > Erdem ; James Bottomley ; > Yao, Jiewen ; Tom Lendacky > ; Gerd Hoffmann > Subject: [PATCH V2 0/6] Support 2 CpuMpPei/CpuDxe in One image >=20 > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3918 >=20 > Above BZ reports an issue that commit 88da06ca triggers ASSERT in some > scenario. This patch-set is to fix this issue. >=20 > As commit 88da06ca describes TDVF BSP and APs are simplied and it can > simply use MpInitLibUp instead of MpInitLib. To achieve this goal, we > include 2 CpuMpPei/CpuDxe drivers in OvmfPkgX64 and IntelTdxX64. This is > done by setting different FILE_GUID to these drivers (of the same name). = In > the other hand, we import a set of MpInitLibDepLib. These libs simply > depend on the PPI/Protocols. While these PPI/Protocols are installed > according to the guest type. >=20 > This patch-set is a replacement of > https://edk2.groups.io/g/devel/message/89381. Please see the dicussion in > - https://edk2.groups.io/g/devel/message/89382 > - https://edk2.groups.io/g/devel/message/89455 > - https://edk2.groups.io/g/devel/message/89522 > - https://edk2.groups.io/g/devel/message/89535 >=20 > The code is at: https://github.com/mxu9/edk2/tree/Rework-MpInitLib.v2 >=20 > v2 changes: > - Remove the un-used FILE_GUID definitions. > - Delete un-used EFI_PEI_PPI_DESCRIPTOR_TERMINATE_LIST in > DispatchTable. > - Add more comments. >=20 > Cc: Eric Dong > Cc: Ray Ni > Cc: Brijesh Singh > Cc: Erdem Aktas > Cc: James Bottomley > Cc: Jiewen Yao > Cc: Tom Lendacky > Cc: Gerd Hoffmann > Signed-off-by: Min Xu >=20 > Min M Xu (4): > UefiCpuPkg: Revert "UefiCpuPkg: Enable Tdx support in MpInitLib" > OvmfPkg/Sec: Install MpInitLibDepLib PPIs in SecMain.c > OvmfPkg/TdxDxe: Install MpInitLibDepLib protocols > OvmfPkg: Enable 2 different CpuMpPei and CpuDxe drivers >=20 > Min Xu (2): > OvmfPkg: Add MpInitLibDepLib related PPI/Protocol definitions > OvmfPkg: Add MpInitLibDepLib >=20 > OvmfPkg/Include/Ppi/MpInitLibDep.h | 28 +++++ > .../Include/Protocol/MpInitLibDepProtocols.h | 28 +++++ > OvmfPkg/IntelTdx/IntelTdxX64.dsc | 30 ++++- > OvmfPkg/IntelTdx/IntelTdxX64.fdf | 3 + > .../MpInitLibDepLib/DxeMpInitLibMpDepLib.inf | 27 > +++++ .../MpInitLibDepLib/DxeMpInitLibUpDepLib.inf | 27 > +++++ .../Library/MpInitLibDepLib/MpInitLibDepLib.c | 23 > ++++ .../MpInitLibDepLib/PeiMpInitLibMpDepLib.inf | 27 > +++++ .../MpInitLibDepLib/PeiMpInitLibUpDepLib.inf | 27 +++++ > OvmfPkg/OvmfPkg.dec | 5 + > OvmfPkg/OvmfPkgX64.dsc | 55 ++++++++- > OvmfPkg/OvmfPkgX64.fdf | 4 + > OvmfPkg/Sec/SecMain.c | 34 +++++- > OvmfPkg/Sec/SecMain.inf | 2 + > OvmfPkg/TdxDxe/TdxDxe.c | 22 +++- > OvmfPkg/TdxDxe/TdxDxe.inf | 2 + > UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf | 3 - > UefiCpuPkg/Library/MpInitLib/MpIntelTdx.h | 69 ------------ > UefiCpuPkg/Library/MpInitLib/MpLib.c | 63 +---------- > UefiCpuPkg/Library/MpInitLib/MpLibTdx.c | 106 ------------------ > UefiCpuPkg/Library/MpInitLib/MpLibTdxNull.c | 69 ------------ > UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf | 3 - > 22 files changed, 343 insertions(+), 314 deletions(-) create mode 10064= 4 > OvmfPkg/Include/Ppi/MpInitLibDep.h > create mode 100644 OvmfPkg/Include/Protocol/MpInitLibDepProtocols.h > create mode 100644 > OvmfPkg/Library/MpInitLibDepLib/DxeMpInitLibMpDepLib.inf > create mode 100644 > OvmfPkg/Library/MpInitLibDepLib/DxeMpInitLibUpDepLib.inf > create mode 100644 OvmfPkg/Library/MpInitLibDepLib/MpInitLibDepLib.c > create mode 100644 > OvmfPkg/Library/MpInitLibDepLib/PeiMpInitLibMpDepLib.inf > create mode 100644 > OvmfPkg/Library/MpInitLibDepLib/PeiMpInitLibUpDepLib.inf > delete mode 100644 UefiCpuPkg/Library/MpInitLib/MpIntelTdx.h > delete mode 100644 UefiCpuPkg/Library/MpInitLib/MpLibTdx.c > delete mode 100644 UefiCpuPkg/Library/MpInitLib/MpLibTdxNull.c >=20 > -- > 2.29.2.windows.2