From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web12.4583.1643356905752698846 for ; Fri, 28 Jan 2022 00:01:45 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=BWuIlVFQ; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: min.m.xu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1643356905; x=1674892905; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=i1GuErwDHq1kuL5IAzP7D8CLGOQ6sDugGaX/CNCLrfU=; b=BWuIlVFQb/yBBor7t3Kl4jVpu4IU8ftXUFP3GUg9d9kMROmtNeUVItJe GLeE2iY5ncHf3J7abbJWcUV4aSEeheM9776dpNYpV8N1eT5Ntma3rgxUw nZ8lwNh1iGz54sqNt7w3pvFIOktuFKOEm+Jpxe7+rAf+oyY18As0etb0N +/yj0etf4pm/Teq44+hZ4pPKQT9OPc7UndWmDKbBzKpbHPJYRcNTLpyL9 e7r9oWgtD9ajdPvE1ihKxkIAgy9ZLmYLPPvj6+4FgNQh4RJrlkStYzLoK kZalSZjFzCYMo3CqgiW8lwa1aPCdA7Rh/VEOpPA8SKP7L3MgOwbCHhv3q g==; X-IronPort-AV: E=McAfee;i="6200,9189,10240"; a="333425451" X-IronPort-AV: E=Sophos;i="5.88,323,1635231600"; d="scan'208";a="333425451" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jan 2022 00:01:45 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,322,1635231600"; d="scan'208";a="480655152" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga006.jf.intel.com with ESMTP; 28 Jan 2022 00:01:44 -0800 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Fri, 28 Jan 2022 00:01:44 -0800 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Fri, 28 Jan 2022 00:01:43 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Fri, 28 Jan 2022 00:01:43 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.171) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Fri, 28 Jan 2022 00:01:43 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RVKRwYknBlgDMrHuWCb6WtCwaosjEXZbsnmMW1NC3bi1B0qb7qapZBbIPp5XudGLwFj+qQnFNTnQsA0v1lMGRUpcQdcDvaCCMqHxBqRdYhy7O5OnfM8E1otRRHLHuCe/pNj+JYLdyxuK6mtY73PItRmMJJQH9U2s8X0U6QYavc1dzErVYtMxLtvA2GJO4XadjC1nANqh6h4nnry120tgCKuWNlShGAvHS7Og4EIgMQidQcYcnnWvjDISp2hoBhlYG8rB3GvNYWFdag8cJrp+MrIVq7m9qe70MJZis5ZQJWCN2t+MDszFT1Y4jUxcuRgbYRgxeizUhJMY+yp3zPBZ7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UMxcRKCVDwCFo6qLpJpvNQvyqky6wa3069AG9QMUTd0=; b=i1rIpWBJa4vui5yy7hK3b1WtGDUFPk/43F+mdGxNTPoNMwpo2Iy68ZZIDBTfcjIz9fbTE+7VCg5DD6tKwJuqI3RHCyv/gb4YnXAtBpurzAzIHorFmBgxMD+a7JCinaqgqYMB4F3sDPjvnGJyw4UKD8fifjPO7qYkCDhU0UnMOmmP+O9jacH2QSVdfpPJMXNxjuNzvt6HFRmyU7kY47AS+onZZ5+MYInYcfokGnjlTJdCFJlv9OcmpDULiSxi5UHwPAbnPRUTNnc7GJ7CBm42k++F3HhNaySufQP6zKyYnMGAIjIgvPHzH8r4/B784ToBDtJ6OZVC4Go1D5aFQgRdMw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from PH0PR11MB5064.namprd11.prod.outlook.com (2603:10b6:510:3b::15) by BN6PR11MB1988.namprd11.prod.outlook.com (2603:10b6:404:48::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.17; Fri, 28 Jan 2022 08:01:32 +0000 Received: from PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::ed65:b010:fc2c:f48c]) by PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::ed65:b010:fc2c:f48c%7]) with mapi id 15.20.4909.019; Fri, 28 Jan 2022 08:01:32 +0000 From: "Min Xu" To: Gerd Hoffmann CC: "devel@edk2.groups.io" , "Kinney, Michael D" , Brijesh Singh , "Aktas, Erdem" , James Bottomley , "Yao, Jiewen" , Tom Lendacky Subject: Re: [PATCH V2 03/10] OvmfPkg: Add TdxWorkArea definition Thread-Topic: [PATCH V2 03/10] OvmfPkg: Add TdxWorkArea definition Thread-Index: AQHYEbXL0aB5aOFZu0abaCyGNGg6a6x232MAgAE283A= Date: Fri, 28 Jan 2022 08:01:32 +0000 Message-ID: References: <20220125063318.862-1-min.m.xu@intel.com> <20220125063318.862-4-min.m.xu@intel.com> <20220127132552.trn5bwlouxhoda3y@sirius.home.kraxel.org> In-Reply-To: <20220127132552.trn5bwlouxhoda3y@sirius.home.kraxel.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5f5fc577-251b-4779-e020-08d9e23465d4 x-ms-traffictypediagnostic: BN6PR11MB1988:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2887; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: VT7V4G5HnrWr/P/iWKgSM87gweAQ4RddKj2aJ2fEThCpdbVRbP1mREUaD42zl33qOoLbuqWMegDKOcIZvUcGzqwF2ufSB59PgasZu1wiYGgRQ24D/sZ+2zLiwXEGMSNXf4NqrJmcEG+mx+xDCAGjlmz69vCpid539Uek5sxBc3MK6LalkwkuBm/2RTWS9n8IXQaXbefm/3nPdvNCkdgy2KRUZ2/A/qjZJj5feh1p5FFih7vGpkSgW90UIXsEi7PQb5wjL5qTD4eCeuMVzZfHA+y2r3AxElp3BduNHJJ4hrI5BF3kvyAgQT/Z2WezYSnMKvg8/SFGb8kNxzQhsqjniyX6a25cgfx78bjRtk+9AXDy2fvU8QKNF2VLhvqdg8LUNcm1gMS6dtA6R2ijtz0tnwa9xJLFC+u1YlxzMxPU7OzU/3+XOLyYXMNUxZafkJDb9FYZlU52w6pPLyoev6B7b45VAX1JpepbdoJBXUvajpJRWWc1YW3N1g+y3CRz6/vuKVCFFqWxDdLWqg5VeZpFxGJ5XkuiCuLf3wgsiDRYHatJDVKCleJxD00odCsLlmnrm15lAY0WkNwETHOGvoO/nLAHedfyH9ywYMeCQ7L7R1GgarwXZJ/9QmLv/PmGS0xMSqrMgJ1T6Epq/ZkQlQewD1MJzoNjOZJAo1Bcxe/HB7J2sW+RcF+V7T4PeVGLzqIgUHZXY58fIaubioyYXJk/CA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5064.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(38070700005)(83380400001)(52536014)(55016003)(4326008)(508600001)(4744005)(122000001)(38100700002)(9686003)(5660300002)(6506007)(7696005)(2906002)(82960400001)(86362001)(316002)(186003)(71200400001)(26005)(66556008)(76116006)(64756008)(6916009)(66946007)(66476007)(54906003)(8676002)(8936002)(33656002)(66446008)(20210929001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?TbAMBpS6GiqO6aeGGrm2BIlec9gH4XwzS+moJwsxyU2or00Fk1eJysKS/aVK?= =?us-ascii?Q?DSf4qM8WHtFJ3Sixwgs+e80UkD8zmQxQwkweKwYfvpX6H/941i2USQ32BYsJ?= =?us-ascii?Q?F9PMFk+bA1CVUgT3Uf4xoWskJMs95CU/h+h1zpZvRawKx9Nvd8QROGTXBkxk?= =?us-ascii?Q?3gYa5pG2pGoC567XIUalyI5y+baPrhwG8Znehs03BPhb8j+Sr1RdG2CiiXNx?= =?us-ascii?Q?rdd6yeEpQaKSePvAU0Yrf62nhYoKTvYoGpW2Olsx3OsEN/3A23iRqYKSG1fg?= =?us-ascii?Q?/gtUgMd1znUCkazW7jkiiWRlBqmBHVbPgf4zGZp70ftvfTQ3w/lfBgVCu/Yi?= =?us-ascii?Q?hNVPeEzWFJpdf+kRwY5udXMia1xaJDYoTiCg6hjuPNKoRkUUZG3rusDwWMCM?= =?us-ascii?Q?Ai88ULdKDqVzzNphqg5gkpWFn/KWhsc6tvW2DrMnytDrSkRerDKj6tZT4frU?= =?us-ascii?Q?2OJ96kdqfRDaNO1XM3cos6fWYfScjyDtH3NLX0cBvBQE7kIux2SVrizMxLmT?= =?us-ascii?Q?wXxotiBCGVMqlU8pGRZ0gkpbgfor3fwbkAHatHEqGGKpHtNCIH0W74vmfo/+?= =?us-ascii?Q?o68hiG+LJGgWlT1PikqXtem8dtqZCwk4miXsNYWaw5no5yhStrgXm5a6yuBG?= =?us-ascii?Q?JPtZg58HLLkxwTJe9/eb96R/s0VQlnOWAeNHk0VnMA0pVxiOrSaMR5AezE4E?= =?us-ascii?Q?l19zpQzkwkFbQivu2zPZjAGzv58vIdn8HEnU4IiIOSb5RW1HomteB8dd06qO?= =?us-ascii?Q?VR6sgfXlm7AMwP51K4TC6+jj068htAn59aQjpCo0iCcg+dDe40QwQybYL7v/?= =?us-ascii?Q?LA+M8PEaUfuYJxuIL4Cw7tl6Raa4Y6vxHCRDdcbE5ZQu2aOJ9Dzh5ofyqriY?= =?us-ascii?Q?UP7BXcON4+pfBtu94Vz0NNYbG0gJbIXd8Xg0+NqpiwF4ZdJKtxWAuz89zugU?= =?us-ascii?Q?XPRY1pbcgJ1pHwztvGpR7UW8IpV+hvad9nJzWIYNYz78V4SteNWzLFY0PTOz?= =?us-ascii?Q?S5jWuQ9iO0OYQwB/Gi3Zs3fONf0m+ew9E9gu8ZVLbgeaSPJDtStt4aA7ozt1?= =?us-ascii?Q?QjwRr1aFV8xizV/wlnShCcmShAXbeqgBW0bMXhjTmtwkrgdyEEgZ57H15Lky?= =?us-ascii?Q?Z+EaOB+DYRX/qWOf7oaqjkWs3FeeJONeiFQDgcoX6RsxNuHVSSyyqjfHUuBs?= =?us-ascii?Q?9sYo1k2uPkO2jz5WMOUphjNOH5z4HTRsTdQ+eyy5Vfw5pdsXlPT55F3RWTXj?= =?us-ascii?Q?aoGX7ouKnkaX3lZsDJrcRYQBIOmb3ys3k3/qFg5/PM5+RfwZT2K6r6IVyrAj?= =?us-ascii?Q?z9F70BOz79VYJqn7oSq1cqZ/yHrgV5BwHB43jihc3ERadeOW65OE1x4r/8sB?= =?us-ascii?Q?qmgxE4KFUkD9h7q0eV7YSB54fgY7ePK8AwD3tt+KWq5M5lBLTQN8BpBzvRwS?= =?us-ascii?Q?2uFP0WT6J917b7zib7tRQPW1Mz5HWwTkgragYbOXgJtVebPpd+IOtmrCalCp?= =?us-ascii?Q?xrf2fufg7D0ytQ4dyh5+Q/p87f9dkjcmXGarMXrfr77xBljKU8eK9W3lXcue?= =?us-ascii?Q?rUNFOn2rHk5XForBjN2Ssp+xiUcObewlp7C+OfTVIdbp5lGfIgkwYzeyRIyD?= =?us-ascii?Q?MU3Z74pg0QUfk8tRM2oirHU=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5064.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5f5fc577-251b-4779-e020-08d9e23465d4 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jan 2022 08:01:32.3481 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: OYl8yLyVsk+rB0o48O8t7uKnkFZRwS9N2bcCoVtVxVDSNw4u2n5fVMNTKSHGG/Go+oJkcT6PcXbzAw+qKm4mCg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1988 Return-Path: min.m.xu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable On January 27, 2022 9:26 PM, Gerd Hoffmann wrote: > > +// > > +// The TDX work area definition > > +// > > +typedef struct _SEC_TDX_WORK_AREA { > > + UINT32 PageTableReady; > > + UINT32 Gpaw; > > + UINT64 HobList; > > +} SEC_TDX_WORK_AREA; > > + > > +typedef struct _TDX_WORK_AREA { > > + CONFIDENTIAL_COMPUTING_WORK_AREA_HEADER Header; > > + SEC_TDX_WORK_AREA SecTdxWorkArea; > > +} TDX_WORK_AREA; > > + > > typedef union { > > CONFIDENTIAL_COMPUTING_WORK_AREA_HEADER Header; > > SEV_WORK_AREA SevWorkArea; > > + TDX_WORK_AREA TdxWorkArea; > > } OVMF_WORK_AREA; >=20 > Now you have the CONFIDENTIAL_COMPUTING_WORK_AREA_HEADER > twice ... OVMF_WORK_AREA is an union. TDX_WORK_AREA is a struct. So there is one CONF= IDENTIAL_COMPUTING_WORK_AREA_HEADER. Thanks Min