From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web10.888.1674259333292667536 for ; Fri, 20 Jan 2023 16:02:13 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=KMttRTuA; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: min.m.xu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1674259333; x=1705795333; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=hSMIlLvkn5XfFmAX5envrGUH1ZHtN/UFnUVnzNyOUbE=; b=KMttRTuAvpVHoDoVk1oaHZMYSv8CBLULVdLQL3U6KDbzFf48SVcAlAS4 0YwhFYyJjTP0M4TKOeRxNDxJtTWc1FnsYJUyUcSnMjyljX/HfOe/aHkpS tUq+sjD9kzaCrw6VUP0GUN9f0z/oOVmwJgLWDtfcjeQs+x8vHW0XLvUzg T+598Uv7Buu0z0hi56hu+DK/NtnrwNzMhN9JhTe6TtUnzdmd8Z6qkJT32 KSmL9/Ll8V74i0npFqdPPs7I+r2kvr2QMTmo8pnQLBkgC19oBR5OxjpYo aDDuTja3c9W947Kh/uSlgBp7T5c4+8iDJYNSZwa0eyE0rXgzVcwi5fYTU g==; X-IronPort-AV: E=McAfee;i="6500,9779,10596"; a="327819576" X-IronPort-AV: E=Sophos;i="5.97,233,1669104000"; d="scan'208";a="327819576" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jan 2023 16:02:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10596"; a="803248279" X-IronPort-AV: E=Sophos;i="5.97,233,1669104000"; d="scan'208";a="803248279" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga001.fm.intel.com with ESMTP; 20 Jan 2023 16:02:12 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Fri, 20 Jan 2023 16:02:12 -0800 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Fri, 20 Jan 2023 16:02:11 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Fri, 20 Jan 2023 16:02:11 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.107) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Fri, 20 Jan 2023 16:02:09 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BK1Ny1+UbIqM1QpkXCwpcXeEJ0aPR0pdBSNICiOYRg2q3x1thJJVWE0BdUTmthbS4yxjXfdtB0/5+EqutW9Dhdsb+ex9tIt8dOwXIRDknR1qg61uWMWPlUyBjxrLl1ngmYvpd9bFgnmf08peir7BGwDO1fgB1p4gE/TMnwVI+VSl++ghPZ75pjAuB/EA5MjruUfsAn32AMOVsH/OBeNAmrmJShsTVawwVIy1IEHMDwRPkO6537uXceHv4aBUSjQ70VTKcnNgH47k0iB7GJ8hEToTMNEBpUXuAE4bSiVpoDD+0B5AKmmvo0NyKIO7sx2a0YD7dvtC3D/RG1Cjml/i0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RCCP5Y6gvTXZoiLkyr5qnaqsb3g9K3ikt4bc/3CNVQ0=; b=nA3YdfXypfRns3+hpcGYKWx2LhSpLDocrBJlel84jE1maAmuohLumo366TZPPtTtRPI63Fm1nIeMXbLkyiByvt+iEHHz/gubHZjsEJqRDXw62+nTxmiEJWEqVGi+dusA2k0WhCIirkHSDA08zUSv+wm8Mw6YSIqDTxuyoxNOpWKW6prv3LnM4M5aGoMJ04M4b8LksaQaBHrYHyf5FGzHBqpLQThFp81uGGcuZc59CjNwOBR3AFkyYa3TO1EgTc6DyweNuI5gaan3WBwVXDYP9UsiGHI+I++7U4S4Ysn42KRjdyf7Cq+uaRL5oLMn90vvPV4/rmJaJg33BC61GCmtaw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5064.namprd11.prod.outlook.com (2603:10b6:510:3b::15) by BL1PR11MB5285.namprd11.prod.outlook.com (2603:10b6:208:309::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.27; Sat, 21 Jan 2023 00:02:05 +0000 Received: from PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::d87:9f99:2db2:43d1]) by PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::d87:9f99:2db2:43d1%6]) with mapi id 15.20.6002.027; Sat, 21 Jan 2023 00:02:05 +0000 From: "Min Xu" To: Gerd Hoffmann CC: "Yao, Jiewen" , "devel@edk2.groups.io" , "Aktas, Erdem" , "James Bottomley" , Tom Lendacky , Michael Roth Subject: Re: [PATCH V2 04/10] OvmfPkg/IntelTdx: Implement other helper functions in SecTdxHelperLib Thread-Topic: [PATCH V2 04/10] OvmfPkg/IntelTdx: Implement other helper functions in SecTdxHelperLib Thread-Index: AQHZK7YrgVPaTkexhUe4Crhi5Ela4a6lgJYAgAFqSJCAAAsagIAAI68AgAASUbCAACkPgIAAqb1g Date: Sat, 21 Jan 2023 00:02:05 +0000 Message-ID: References: <20230119032822.1406-1-min.m.xu@intel.com> <20230119032822.1406-5-min.m.xu@intel.com> <20230119095422.ou5vbckdyn33hh5c@sirius.home.kraxel.org> <20230120101828.jf43j7ahxqossace@sirius.home.kraxel.org> <20230120135059.opht56zl4jbybg23@sirius.home.kraxel.org> In-Reply-To: <20230120135059.opht56zl4jbybg23@sirius.home.kraxel.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR11MB5064:EE_|BL1PR11MB5285:EE_ x-ms-office365-filtering-correlation-id: 0eeb6acc-e5a9-4136-c8e4-08dafb42bb52 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: B2lbum0cQ21M51LS72BuDM1A1veN8OXwMxvanGNeCOMfoQR0dAtKwzBMcjlXaxdMYjeHmCtybne/BK+RrAkdjhpfBZ+XSbSK9SaojCzRbAeWW1kziXlRJ4emx6kLQ9w35q1dpGYEN11CG0GTwCz2M9PUp5MOZ/HR7+diCLpq1ez1ghsMHFe+vFteQXnW8BXS0bu06XDv16eaCFU4W7LfYvXzOFOn7p/avJt6OiHJ77Kjbjo2u2bReBXve/3hoI/a4YylsLqkCASqB7Xp4ooNiYTE7E9lurwOXa5O0ukMte2wPCqLL8KA8BSYR8FnYkNSr9aJXS2BhVOGshQL4PWjMJpeVOQN3jzVSrnaCw7Tmw/b57kdPjpH3hmtQXUOQ7DQ4frzGrpI6QmsbjQWimG5RXa3UvzmS4eTOYOZidaZoGQYCKG10FVTjRPNxrbAzUnr4KNXy7qGJCPu3OQ8iTQve9elCfQNBvDvPaeTv36HRaRPDWQQ2/AJg424EcVbwTDUqkItcJJxdr7QKa+CnyRZGNORmkviHLp+9kIz5Dw9TIE6YXHYX1M6H+uGrT/sZIf/D4wNNu9UUCU+utxQZ+h8x86UmnWPzK6C1X0SXi4fPwDeGb3mXbmvA8M+23AqCPtKjvFv1em3JIGUvShX611lwFSsTjLZOg5PryHrTa7wf7Q26dcXdKPeLTy2IOh+CK7BJkWndJlT5DbuCiPtSmOQmxeF0lMpdFwRvKSU6kXTlG2uQJjFrpjJeqYQ4CjjmQ7c66FbCAPd10POvNv9Fctchw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5064.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(366004)(396003)(346002)(136003)(376002)(451199015)(83380400001)(33656002)(966005)(478600001)(71200400001)(7696005)(55016003)(26005)(38100700002)(82960400001)(86362001)(122000001)(186003)(38070700005)(6506007)(41300700001)(52536014)(2906002)(9686003)(66446008)(8936002)(64756008)(8676002)(66556008)(66476007)(4326008)(76116006)(66946007)(6916009)(54906003)(5660300002)(316002)(19627235002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?A6KCU50EW3o+D6QRjLeNdxyVUBYGh2tzac/2bb1DUOBDaUvFnRikEqPoobcR?= =?us-ascii?Q?CQ0SJAn51PvudBptulRi7+ZMku9ixI0bAFH4VpQaB4GR4hR5LWGpOirej6s2?= =?us-ascii?Q?f3Y9w0d2uxaAeKIyA3tUtu2m2jBpHkwgdfQy2GljxKj8LfxpsbGKlfyo3HjH?= =?us-ascii?Q?7CGiqXorQ0uxMuuSIg2XX4ltFghzsMUX4UBbBVBfyfWZ0K05T6hoiOCbKikF?= =?us-ascii?Q?3WcwKINXC//EuSsudxeUB5/AdW0gfGZstK1J0fASXO0m9pCTEQO7HsEvlogY?= =?us-ascii?Q?Y290qYQxdSyPtzVp/QLjpZav9Gd+gPzCINr6tsoEOCZFwhVMdxdJoKIz5zwY?= =?us-ascii?Q?6gb9mej+sXNA3MKD/G8KzrcP14JwTREcZjq2xtRsCvi66xkPny6BF8ltI8q2?= =?us-ascii?Q?Y9/qLZukv388JSq9Aoc+ig0we4xIwa8cTPTMtNx4REcqOVhW1cLlaMc8zb8i?= =?us-ascii?Q?ovVBnxTP2/qXyhSDvdfp9Wt7oRFqkgCgs3wNNOmS4QgF1hAxfvRRZEu/H1wD?= =?us-ascii?Q?zFGNm8XMeAUq85jypB0GuHy9o8itxMRyPn9Y5IZOOC3kVglxms8qcbGMBeRP?= =?us-ascii?Q?ORs33CNKDPXpGpVjdeNCehD39oXHPmpegH36W/QdkP9CC4c8KjVgqKlVu2iu?= =?us-ascii?Q?pkBwPoBaIrgH7sa4h9u64CjRXWXjDxLkvc9s1RLgvv/Xr5Yvj0cHJivduohy?= =?us-ascii?Q?sqy6GNxuYuBBh0foHMoPALVEMKlaNQ8G7fPLT7UzUGhdxMuczP6wehu9pW/0?= =?us-ascii?Q?fUtdkWjC+LKF5GbZo3ciBUu66PY67XUlBkUyWGfPLuZ+NfF/XeSbx9fiqmyP?= =?us-ascii?Q?Cy+wq3Q0N4VpYBf9r37o4m8u67fO1FjjgDeYyTQQ34ZgBuICGKEz6zmUC3L7?= =?us-ascii?Q?FwGMxH2XIpIyvQ1UsjP3n7ngxu/OWJ9Ob7Gi1PPpdGB1A0u00ce/qVV49HA6?= =?us-ascii?Q?NT7GG9hN6I0vNuxiJvftZC5ZYQq8MgXR7Avd34nPohlZMiSK1DKAvrbZklWX?= =?us-ascii?Q?MtUznwe8+uWbnaXWp7+/iPRa+NEK6YeN6+RilCjQ9YHF+NVgozOgiMhqQVTu?= =?us-ascii?Q?dC+zgRZQxAbvcgHpAJShNPGLl2snI9EQvmmPh1rutjQTaAqFFeJBltOZJBw/?= =?us-ascii?Q?aIQ1Azhuhox225QEfkmpW9/xuSOox3xmwBpwQNz/jzZQ9Ylf1nLIsO/peECp?= =?us-ascii?Q?eZkHYRfGTGur30ajdb7RRe5Ih4dYTNtB6Hd8Leir1oSQqYloxJVxs5irYAvh?= =?us-ascii?Q?tJhpu+zGzxFB7B5ifb0fDOM6FkDnlcUrXjVWinEscqad1NOPMD0CB6yPvK6C?= =?us-ascii?Q?vBUjKtWj/jP0rO7AJ2XOjpLmlJ11mBp49XrG5jdu/4r765YZFL6M+lrg6t4f?= =?us-ascii?Q?X0v49eaJrsUjYHLeiGJlFIIuVzRRabb2ZYAHzw/dFjb1YJqOnM4B2ONUB4NV?= =?us-ascii?Q?qgu6lk2F6AD20ekYtGvIdKdP5TJ0IWmsL6N3wJqW6LpuTVHsBvxnCINVnxTX?= =?us-ascii?Q?MMru28mANlnn/uhJtPqPl2mNmEq+iqAbtQojVdoTSj304d0fA9Ol7EMBOebO?= =?us-ascii?Q?+7/c09FOg/7SbC7urK4hjNlBhvWlSw2pR+ggByWQ?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5064.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0eeb6acc-e5a9-4136-c8e4-08dafb42bb52 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jan 2023 00:02:05.5055 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: wSJnhIWL6QiYOfwlHusv0hggn7mNw5EXWSDPErW9QCfBYy5JGw5DiAPyV3kQml6ub+K72XRiGdJS9h42kovT1A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5285 Return-Path: min.m.xu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable On January 20, 2023 9:51 PM, Gerd Hoffmann wrote: >=20 > > > > [Jiewen] No. We cannot move to MdePkg. > > > > TCG defines the field to be variable length. Something like below: > > > > > > > > typedef struct { > > > > UINT8 TableDescriptionSize; > > > > UINT8 TableDescription[TableDescriptionSize]= ; > > > > UINT64 NumberOfTables; > > > > EFI_CONFIGURATION_TABLE TableEntry[NumberOfTables]; > > > > } HANDOFF_TABLE_POINTERS2; > > > > > > > > typedef struct { > > > > UINT8 BlobDescriptionSize; > > > > UINT8 BlobDescription[BlobDescriptionSize]; > > > > EFI_PHYSICAL_ADDRESS BlobBase; > > > > UINT64 BlobLength; > > > > } HANDOFF_TABLE_POINTERS2; > > > > > > > > The implementation can choose its own length as they wish. > > > > > > Why doesn't follow TDX standard TCG practices here? > > > > > As Jiewen mentioned TCG defines the field to be variable length. The > implementation can choose its own length. Below are some examples. > > Tcg2Pei defines its FV_HANDOFF_TABLE_POINTERS2. > > (https://github.com/tianocore/edk2/blob/master/SecurityPkg/Tcg/Tcg2Pei > > /Tcg2Pei.c#L126-L136) SmbiosMeasurementDxe defines its > > SMBIOS_HANDOFF_TABLE_POINTERS2 > > > (https://github.com/tianocore/edk2/blob/master/MdeModulePkg/Universal/ > > SmbiosMeasurementDxe/SmbiosMeasurementDxe.c#L113-L123) > > TcgEventLogRecordLib defines the PLATFORM_FIRMWARE_BLOB2_STRUCT > and > > HANDOFF_TABLE_POINTERS2_STRUCT. > > https://github.com/tianocore/edk2/blob/master/SecurityPkg/Include/Libr > > ary/TcgEventLogRecordLib.h#L14-L32 >=20 > > I think TDX follow the same practice above to define its own > > TDX_HANDOFF_TABLE_POINTERS2 and FV_HANDOFF_TABLE_POINTERS2. > > (FV_HANDOFF_TABLE_POINTERS2 happens to be same as the one in > Tcg2Pei.) >=20 > Ok, that makes sense. The TdHob is tdx-specific, measuring a firmware > volume is not. I'm still wondering why the structs for standard events (= like > the firmware volume) are not in some shared header file ... >=20 Hi, Gerd Actually I tried to find some common header file to define the events (the = firmware volume). But it seems there is no such header file. Let me check t= he code again and see if there is such header file. Thanks Min