From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web08.9603.1638952655275952682 for ; Wed, 08 Dec 2021 00:37:35 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=Tm1Ofrpf; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: min.m.xu@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10191"; a="298579805" X-IronPort-AV: E=Sophos;i="5.87,297,1631602800"; d="scan'208";a="298579805" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Dec 2021 00:37:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,297,1631602800"; d="scan'208";a="606185257" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by fmsmga002.fm.intel.com with ESMTP; 08 Dec 2021 00:37:34 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 8 Dec 2021 00:37:33 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 8 Dec 2021 00:37:33 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Wed, 8 Dec 2021 00:37:33 -0800 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.48) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Wed, 8 Dec 2021 00:37:33 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nKf0CjOie21odvseaPdresBP+iOuoLa31FNcbfyafep6CQ72tyNImhty2X+7L7kXuWTZidk9yGkIB2JwTp6mjQqR5npjWmdRmnTD42o5jx3Q1ywoHxDd/8zRHyTqwvjZdmVj4VkE0qnnWC1nu5VftL6tNX46oZqbR7sBTcBdUK/wUhHXJphaOvLheUKKPNplV5gS3a2Au/F1WUwwzhylkI0GjRRj+nwEXaPRVdDY6GyZeKBKtABWN1zahGL6VVJn7f0tWtlOfGbnja72LlU1jLZUW8mJl0lUiZrWgD5b1NtMVYdwUNjIp8MFBEC5+OXqxy1BahVWp1s8MT7YtxLwMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fMtPYq9/BDzk3u/+NTtnXtH774vYY7rqm/RYa382lSs=; b=U0pf/9w3402MkteTraDRk45VoxJhZkRIGc8HLvH9SUDTjknjFkOp/dG/PfyzUT5d+Kp3kycgNKWJOn6BMcntkU8Cdrdi6wZSi3MCGrj7svB9qEwWoP5lNSLzGM3D9sgMQN/69chNEQ+fe2n03bhpm/PNaUTg3Moctu29rarA8XR5CjzC9Y2B0ggVPH5izALn2vL3GW3t5tvOGmzelEjHO/jnxY7kf2/hKxo8+euKDUhD8Ghq6cwTGQIUitD+7ep9kmU4J8YyGmmV8+bt/01TlU0W0zlOj0VsOKHkEC79G9DP0tgxwjQbGYneMCv3A6mhpki8iTBa5ZP5m964Eo0pLA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fMtPYq9/BDzk3u/+NTtnXtH774vYY7rqm/RYa382lSs=; b=Tm1OfrpfUftdK7SW2PDOLQKpiYFyvdm3W8b1usRjlkdRKPLhFaGK+qaQ1CQuAneq99gqbtziCpkD+Ku3khrAGXHUt85PH1/T1FUwTrTsPhDJ+HLzsTpGjbSC9nlV3nXvtA9gx+R8rIErQTob7D2jVuAoeclOgqK1iLeSuu0EZcc= Received: from PH0PR11MB5064.namprd11.prod.outlook.com (2603:10b6:510:3b::15) by PH0PR11MB4919.namprd11.prod.outlook.com (2603:10b6:510:34::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.20; Wed, 8 Dec 2021 08:37:31 +0000 Received: from PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::fd42:b334:5030:af8d]) by PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::fd42:b334:5030:af8d%6]) with mapi id 15.20.4755.022; Wed, 8 Dec 2021 08:37:31 +0000 From: "Min Xu" To: "devel@edk2.groups.io" , "kraxel@redhat.com" CC: Ard Biesheuvel , "Justen, Jordan L" , Brijesh Singh , "Erdem Aktas" , James Bottomley , "Yao, Jiewen" , Tom Lendacky Subject: Re: [edk2-devel] [PATCH V3 27/29] OvmfPkg/BaseMemEncryptTdxLib: Add TDX helper library Thread-Topic: [edk2-devel] [PATCH V3 27/29] OvmfPkg/BaseMemEncryptTdxLib: Add TDX helper library Thread-Index: AQHXzyMFzFfp5S/l80OLR6fx8CkqLqvxZW4AgDcVGLA= Date: Wed, 8 Dec 2021 08:37:31 +0000 Message-ID: References: <9ad859590b430fddb8ce9f0ebdecb8b06d9b7f4f.1635769996.git.min.m.xu@intel.com> <20211103071016.eyhqna3ydekf6egi@sirius.home.kraxel.org> In-Reply-To: <20211103071016.eyhqna3ydekf6egi@sirius.home.kraxel.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 640b01c9-e277-4825-4492-08d9ba25f996 x-ms-traffictypediagnostic: PH0PR11MB4919:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 2ot+9TE5aJonLXpc+6e53DWt4td9TFxhhsSTmNGy2+Pxwe0AkvKbCkC2vNki2/+mwP1zIEjy8CoRcHBNuEBNuR3iU2ld0GNsXm9uVvp5Kz6Nh/I0VkoRiQQFmDWCzZURH2utjVqAmOWycFgDlrmFxvtNE7ToEi8T2U6mWp2Ks+xBTB9+ZX4uX969yo553WRZcWF4KSayULk7RPseU0S5rK7u+A5X6ks3mltmkkICeHMYCj2gTlRD8WuM4ung0nDkB1IDNFVsOg+zqTSmKgaXkJCibbbb8FFkA+skdozHrHP5QYiY6dAjZo8Ala2t8X14E3T6mPq4Eps1YBQiZx63H52wATVtxoAQTOWMezxA2Y23jIk9AOcj0lOpdFH02M/nysyWlhqWXgGFfOXkdL3zcH02UWIHDguOAfxRPHfxOLUw5fLy9+PbYpz//xw1SNFqVlQZYAV/56Ao50RaL+LmeB3a+SYrI04+mPm2ogSoqyIfWcwZmHaliwhgZbKmA001W4quFVVgTLT91utL/lZQhXXHpNMFPdEb7vkgsKBE2wWsDvDAKhuJUt+ZJRTujh+/TGtXwy+JJ7JttbOpyFY9uYKgAI5Z8Qxw2whf/XKgJxAmxVI2VmB+BCrOIphOLEdx2tyt3O32TDCongL3B5kIkzEPULUbPN9mabAJgIdFQfvF6NCseWz/sBdT+wNb2h61gcuy9GHDsJGjd+AA312CBtWJeC6Y2aAIhKizooERm/8= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5064.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(83380400001)(4326008)(5660300002)(8676002)(86362001)(6506007)(8936002)(508600001)(55016003)(4744005)(9686003)(122000001)(66946007)(82960400001)(26005)(52536014)(38070700005)(71200400001)(2906002)(33656002)(66446008)(38100700002)(186003)(7696005)(66476007)(110136005)(76116006)(66556008)(64756008)(54906003)(316002)(213903007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?xgAYGR8+SoLWVHeWm93loTB/oPRdoLpsWAMgFe9/qP496wvLi3hlJAE8x1x4?= =?us-ascii?Q?4O+Xuso+Jj2XVUg4AhDqy1KbweyhLykrZIVTdn8h8VhPZq6rxVzn1z+vlvAy?= =?us-ascii?Q?+tovIpGJZpOIRqbdwlwbXh5qxNm3EpeCGvdMmaN9XHqmsczF7V9pi/5U/M9v?= =?us-ascii?Q?IdRSuRn1MYmxpTQ8799BOULbKuwJBxefpXhBwRWQI7QqJnePyvBHXszsTLSQ?= =?us-ascii?Q?2Il4YQYlIcfbzsURwkml/DZ3pWYZP826v/0KTO8hNedrp6nI1h2oVQ6Cv+GA?= =?us-ascii?Q?rZPBKse30tIbMkPtGdWC1mQQI4QJVNweLCjoS+9ivQdV+rHI7nhRw/iCI5pU?= =?us-ascii?Q?RU0rucrIRj2QytL/SDuVpIc3l8FE1eYex+ENwn43yJGLMMlYP6Dcxv3Sf6Yl?= =?us-ascii?Q?Pg1wQNNRJw30gYgZtJP8HPdAikAr+qyYtqoQ1iFql69Y+98V60/w+MOG95f8?= =?us-ascii?Q?SYhLHCtt+B6KZ1P0NuT1Dvyayj+Et/TqNa0KpkFxf31uvPb4UkpcY2+a9lpj?= =?us-ascii?Q?2IaR2aweTduRMKXBFSN33lC1loeBU5zrmaY+2etyo3MtOWYzSTwQJYCy6434?= =?us-ascii?Q?4eHpPTzgQkaMfIpLW2Z3uXSEoZ5WEQSp79FNI37gUKL0V+w16r0fOsLekVEh?= =?us-ascii?Q?8BSt9ILeGUQR0jn6a3gcz2UxKcVHPKsJqb01ELzXbozq2tzPRYN7qdF+f5Hl?= =?us-ascii?Q?e7qbNGHx64BaoFwZhMFcPYbXfsP/y0qvCm0HhiS4oX9Q7Ni1M8sav8PKZ7CM?= =?us-ascii?Q?B1nMVI8ccjtUI44mcsv6o/OYq8chFvlaHYvrqsR2+CZDw3rYCgOOp3h7pP0k?= =?us-ascii?Q?OBpwBdjW5pABjBO4Lk9C7IQpVm2NvnKonW1WyaPXsLSz+ULyQ6gfVqBInpYN?= =?us-ascii?Q?PzJ8FceMmZ0a/TPIa9JrJSDoyTAZS1d3bU+TDQQ4PMGeCXRPeIiBrgWIFN7D?= =?us-ascii?Q?51VHI8CtZp4Pnr3Hf1u93NtJoaFgTB+ZY/CN2JkyS0PTkgam7zvG+JvmmJQY?= =?us-ascii?Q?d5DRTJcczepchDGrLwc9Wf79gc07x2BkEq/BYN5vDn6rplTewav3s0UvTMoU?= =?us-ascii?Q?IKgItSVD9mhYH0P2PVIdhWJQ5kmg/s30oWHI0ivI+mPBWQo0RXn2toUUNH8u?= =?us-ascii?Q?w0l3F2kr2RamDIFUWqMOShanpxA0T8m+7LFOIGCUJVTvmgZjPcgWFdjjZPf4?= =?us-ascii?Q?ohFK+S2RV7ZLO9IsBLISDMBR0+XRcK7Q4ibHVuQDgkXvCtlzTktWu8DTipGu?= =?us-ascii?Q?OVELcQAJPu82d0ILFGFwGLSnIzHr3687YjLQoN+XdJOBnA4j54iOMJ3pX1dv?= =?us-ascii?Q?2lhpuDJRRSp0Xb9wW1yHskQAKP87UbkManI2e5A9pzS/HiCBBwZ++OO71hKm?= =?us-ascii?Q?J07TDo6e8FebpXiZZM5hVM6hxQFGM26CNNjrSFoniQCn0OOPUGvt2gTiFaSW?= =?us-ascii?Q?JlD604+r0WLZkgokwDmD1okMs1RMenJsIqxMAvv4iREHNRByWguN3RXTc6uw?= =?us-ascii?Q?stAWLgiWCgOy6I3IjHurSr67n4gffwK1AsrFGBLHW0rgotCvhi82z4oeABGG?= =?us-ascii?Q?R8QJpoqwNake+haHEqpsVsXkLkzmdvEnOmaDIIjSlu4+8KWSZMCTDFkgPDDl?= =?us-ascii?Q?/A=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5064.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 640b01c9-e277-4825-4492-08d9ba25f996 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Dec 2021 08:37:31.2421 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 3gGYDuy534yUYW5ppORrywCs6U/tsGIK3RtAqc+G4iYls7g3bFKphyqL5i6h2mHY70/ayn72zwPvF49IMVaJzw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4919 Return-Path: min.m.xu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi, > > > > Add Intel Tdx helper library. The library provides the routines to: > > - set or clear Shared bit for a given memory region. > > - query whether TDX is enabled. >=20 > Hmm, patch 22 adds functions to set the shared bit too. > Looks like duplicate functionality on a first glance. >=20 Ah yes, patch 22 (setting the shared bit) is duplicated with BaseMemEncrypt= TdxLib. And setting shared bit for Mmio space can be moved to TdxDxe driver= (It is more reasonable). Then MdeModulePkg/Core/DxeIplPeim can be un-touch= ed. To be honest I am a little nervous to touch the core code. Thanks much for the reminder. Min