From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web10.3036.1673999662168945765 for ; Tue, 17 Jan 2023 15:54:22 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=T/aOVMMP; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: min.m.xu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673999662; x=1705535662; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=tbc5XOs1q5pT0I1EUDHdEvNU0XTLy6ck3FdArINF56g=; b=T/aOVMMPqbp4/6XoLyBNSgF6aN55ps0Tn6qA/UimvNwzpGtsyBtZWVb9 +Ku+2/f8hZS9zRJeylVoJeYiQQckJL4WjKMwq34tzMovZLUYWNsmZlbaZ EJ3bkD+o4NUDyQg5N75sOI8bVCpbf4YVB3QqM3lNMkUcqUAdPpb+m0F4n JdvmrIa0RDO471drTYP085b1As4NSKWaqJV/MhWy81h/wAiix8rj+A0lB cTLHbmfZPfRqIc0nCGAcd1D6vfr7F1cn1VUwCLOjwvjiiV2wKYhQs0dnR u+MBZP3Se4uLKCrLnBsi0YnJuIy0uHw4ThAsInYVmvq0yi7bEzCTUhVAo g==; X-IronPort-AV: E=McAfee;i="6500,9779,10593"; a="326927988" X-IronPort-AV: E=Sophos;i="5.97,224,1669104000"; d="scan'208";a="326927988" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jan 2023 15:54:21 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10593"; a="904834634" X-IronPort-AV: E=Sophos;i="5.97,224,1669104000"; d="scan'208";a="904834634" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga006.fm.intel.com with ESMTP; 17 Jan 2023 15:54:21 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 17 Jan 2023 15:54:20 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Tue, 17 Jan 2023 15:54:20 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.173) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Tue, 17 Jan 2023 15:54:20 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fnsKFDzWjVqcN747iYjCOOJ3slqPdmOYsnejgMloRv47nwxiENHmcesxAVhR2ogbHKo/YBy68GmGxXb3/xYwHzF7dHDRqgpkd3sCckyYLjJQ0cLgPeln3HxW7iS5AXl/6j6Kp/HWCWBp9HNybm6d+FujXPSxOXdegw/yPiCC6q11en7A6pDbuNuvE+KalZZe4hS/fXiF21QF6RjgeX3jIEgXN5W8wuKlra8usRIJel2PtOEr+dliXlsxRlIGhsAZqV+7T+POiUp+JW3VBVJs1MlVshk26xBXImBw0m/Tu2pU66vs73QpZM6xkQVIvBGMq+P2CNtsC7h8v61UMyIWFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vNiHcJEsWPq/OL7WNoJbcdOMflD5ZxgDeo1hZW7VEjM=; b=DtEDeV/xVqzHjf/gS6/R6HDaMtaN4JaH0SXVkh+MmXtWG3eVkXpiAj0VF+jjuA4cS3kBS3ICotwUGAVAZfHFTNedAKoM7TJP0PL3mrtAHQwLQnvRKRVc0aU9dBwrmVsevCEDpCg0nbyC94o4MiXGyEHuOSKcbaZ7aeV/uwUs2pY2KaGF85w6gUAOPK+wwCc1RwoeOK9h2kmu7XXhivVBNvm/Ojn1kusSNgk3iu/Uut7izxHbgflOsUYQ0BE7jICdq+w/KR1i+r5Xi68v3CdTwWOQUXctlRJGrgeT7nSRy8i5QQzlVKNrVSubedxi6sLilJ+kM1fi+odk0X/oYY6qzQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5064.namprd11.prod.outlook.com (2603:10b6:510:3b::15) by SA2PR11MB5019.namprd11.prod.outlook.com (2603:10b6:806:f8::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.23; Tue, 17 Jan 2023 23:54:12 +0000 Received: from PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::d87:9f99:2db2:43d1]) by PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::d87:9f99:2db2:43d1%6]) with mapi id 15.20.6002.012; Tue, 17 Jan 2023 23:54:12 +0000 From: "Min Xu" To: "Yao, Jiewen" , "devel@edk2.groups.io" CC: "Wang, Jian J" , "Aktas, Erdem" , James Bottomley , Gerd Hoffmann , Tom Lendacky , Michael Roth Subject: Re: [PATCH V1 0/3] Fix TDVF issues Thread-Topic: [PATCH V1 0/3] Fix TDVF issues Thread-Index: AQHZKTkAy9b74OYMZEi4AaKivQS+966gNRIAgAMWXIA= Date: Tue, 17 Jan 2023 23:54:12 +0000 Message-ID: References: <20230115232739.415-1-min.m.xu@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR11MB5064:EE_|SA2PR11MB5019:EE_ x-ms-office365-filtering-correlation-id: 93117248-2c86-4fec-770a-08daf8e62247 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: g2EBQL5meDj5oD2aWnjQb3zbjj3x0KL7flcaJErtjXoe3pe8p+pvyB77QmuN5cgKSShGLPcemErKjA0VWLRMujvJpxp8i5lzZxZBLUCJBL+FW7wWt6b5jIRHx/GNisA1wGyGL4XxUnlq38GcUpWoI2rvW50L9lhzwQcC6O0ENmoRlIwoF6bLPEVAYoMeS/Wii8JWJrZBXY9SMjQIP7/OCx6HY1sJIDMI0R2tPphM5SNY+2kuLH9Npo57H8zkeFl7+h+6qh+nAvMYqejLhBLj8bd/nCTU1Dim7QNXEEaRfcnqpkF/Iw/6ct1wTjN12bmapOfpsReUNdFofFIsDTqRuSQ7S4y616LcafeEDprt7rV2F1SyABxtTqOmdvvZSyy7OJq5flFYsv3Ay3KTPU32yMwtsYjnJQTsMn43Zx/MPkZH7vrSEuiCksLfZhBY+t9OG60oSoPckkHVbdbUcNo7bMPVwMfIj0+BR+wofZJN6An3crPTu0oevLt007cxNQLj11zoNrcXx0z0Q1YMky8anxOfcpEz1gyiS7NOSGgv8IP5Eb1icyuSzifqYtQteLGMI19xAbHXyP6GdxnMzGikTFMh45vjEeycMECkgXJ1Mldnr+o7748d+hcvHUWdq0xwJog1ecAh8hbP+HBHoNoJ8tnAPkUIXY2tdxbvKKf5Rjin3UnbLCvAL0/CfM03H/9C1JE7QaXG64PaAaWEOlFKeg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5064.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(346002)(366004)(396003)(376002)(136003)(451199015)(71200400001)(54906003)(110136005)(33656002)(41300700001)(4326008)(66946007)(19627235002)(316002)(66556008)(76116006)(64756008)(86362001)(83380400001)(66446008)(66476007)(82960400001)(38100700002)(38070700005)(55016003)(122000001)(478600001)(8676002)(7696005)(6506007)(26005)(9686003)(186003)(53546011)(2906002)(8936002)(52536014)(5660300002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Nxhre5tlUuE6a47FMAGS2qrIyQN8RfaE7UmKqDz6DGr399y/cNfufV1/Lb0V?= =?us-ascii?Q?VelX6Xhr+YT30XxOMSdcp7IrmY2bvBXzwQHobFU2QhM0UJPn2xYF8yoCcNxO?= =?us-ascii?Q?sf26XGyVdNkYHOPaD9+uAcfS40K1EUpNgQIf+HNjVUwDtkatCNSV3dAjK4DC?= =?us-ascii?Q?w9uVOSGPE+poAAbfboSd3aJIlGnpjE9whDQFvn8NPpk03xxTalh0vIu7PQ84?= =?us-ascii?Q?c0/h2Ez9QaIJs76tTNuqE0paFpOwJ5fjybwf9LNIPYa5T7Xo4EemAMR9srnv?= =?us-ascii?Q?fBz31KWP/Y6bjGIcgEkZhvKxNRz4dWtq94mckpL+NWnFwQKbQ6yV2sdc/YAC?= =?us-ascii?Q?8yLbN6hHQQ9ucHYUu0xBl3YOBpeSqVlSU+3QDBMA0qBxhAm57T8UawGWoE20?= =?us-ascii?Q?A0bKT3+1BCS3MoeylkVHuDJX4g6Y6yjQn5sEqD98dUB/JSgJpYeoTCBhC/b9?= =?us-ascii?Q?pUUXgqgMyyjeDc9xusIBU/TCMMwC8hlaIAjRor78GF9ti9+VgxrqBQ2eUwfH?= =?us-ascii?Q?9OG/U1hupPobxVXA8MD3QH4QkojoaQi5QDdcgFxaHYWOMUpZWVxEsw31R90i?= =?us-ascii?Q?cWhX4Y3cvPhZTWjIL9wn/mhl0GPEOjMWSrF5fEipzedPNbuB/HesOzgJ02p2?= =?us-ascii?Q?FSif/QNQ7Af0Goa8fBsrddEG988uxhTKnpkyYd1Efh83x3AeWzCH/Ujt4CQ3?= =?us-ascii?Q?/ACRket2/1nWFylEyHLUANJpZet2l7VpadvetJ/DEc0RkVcX+CK/R0wzordI?= =?us-ascii?Q?MnlSl26Q9/EllLiFBJU63ykEAun0AlqOG1boikTpfLVUELI9wZuLvJDe6EYX?= =?us-ascii?Q?lhoxxskadJBXoRs7UMUtUtE7yYv0MymfngzFiUXAt4BLGCjlqmsq8xODw8Wt?= =?us-ascii?Q?DdxIBXXeHJucHxAoPnGpcxj/STLdmTihD0KVSALz7jOcjnywIr9DhGqo3Faw?= =?us-ascii?Q?ld4P9B3FeSZl5+HjKyZlev5DGDpAa6GQeNYYPzK1k93aBxwwyFvNR2r7+4Zf?= =?us-ascii?Q?ZsI4A5I6XVY/xtcsijxJAtbEOETO6nusT+obSYUsgKUmlKVZl8VSSRD1M+7o?= =?us-ascii?Q?FiAtzDEPxETZKkjclehSDB4J2i4xVjYudI3qrR7FZ0F56ovktBqPKjMpBTFZ?= =?us-ascii?Q?iWa1uuqvN+77ubMvge/cfVp03J9jBN/HdF6ynTglATVvwFhrVyAbH+scFf4/?= =?us-ascii?Q?vnzZy626K489Z/FDwaaHwi66fRE/Zl05FA4zjHyU+ROAXigQ1bXVncbIelsm?= =?us-ascii?Q?bVRZvbLduMMjU5rjxO8pQN2O8Tf/+qnhGJP/3ShpWGQmxH4Op1eDuXohbTSi?= =?us-ascii?Q?wc0p1BFGyZhIVCRH0HpjiXbvEYJOQFrR6LVwfdLWs1y+mFKpdQe7sjye580j?= =?us-ascii?Q?JN8ehouaY0i5xbF9jrwYZ90zVVefNF85lunxiD40/eEOrbacoHtDkntqj5II?= =?us-ascii?Q?GeT+60LtthT4+9DiOK/14aN+NT0S0EUYeBacELM9tJZ+nTAugMkA9ZP6Lcau?= =?us-ascii?Q?flXIbthAwqCSbhp+kYRuJdoEKZfWuiybaG3FX5sxrZz3oGNmzuXi2Mck5xhv?= =?us-ascii?Q?z9lQmxvA9Vc5LZLP2eo0FFoofqPPaM5JSL1CmAmt?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5064.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 93117248-2c86-4fec-770a-08daf8e62247 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jan 2023 23:54:12.7152 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: yv43WYgp9zUYeIOmHv7AMoqBPX/Lggh+14Sfmh07HiQSwXiJ4ZL+2p4mF3e27ec8X4+mklJbdT+QoGEPFt0pDQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5019 Return-Path: min.m.xu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks for the comments. They're will be sent for review in separate patche= s. > -----Original Message----- > From: Yao, Jiewen > Sent: Monday, January 16, 2023 8:45 AM > To: Xu, Min M ; devel@edk2.groups.io > Cc: Wang, Jian J ; Aktas, Erdem > ; James Bottomley ; Gerd > Hoffmann ; Tom Lendacky > ; Michael Roth ; Yao, > Jiewen > Subject: RE: [PATCH V1 0/3] Fix TDVF issues >=20 > From process perspective, I see no reason to combine them into one patch = set, > because each patch is individual, and they are handling different problem= . > Also, there is no reason to mix the fix in SecurityPkg with the fix in Ov= mfPkg, if > they are not related. >=20 > Please split them into 3 different patches. >=20 > With comment above, reviewed-by: Jiewen Yao >=20 > Thank you > Yao, Jiewen >=20 > > -----Original Message----- > > From: Xu, Min M > > Sent: Monday, January 16, 2023 7:28 AM > > To: devel@edk2.groups.io > > Cc: Xu, Min M ; Yao, Jiewen > > ; Wang, Jian J ; Aktas, > > Erdem ; James Bottomley > ; > > Gerd Hoffmann ; Tom Lendacky > > ; Michael Roth > > Subject: [PATCH V1 0/3] Fix TDVF issues > > > > This patch-set fix below TDVF issues: > > Patch#1: Initialize Status in IoExit > > Patch#2: Extend EFI boot variable to PCR[1] according to TCG PC Client > > PFP spec. > > Patch#3: Refactor error handle of SetOrClearSharedBit so that the calle= r > > can handle the returned error. > > > > Cc: Jiewen Yao > > Cc: Jian J Wang > > Cc: Erdem Aktas > > Cc: James Bottomley > > Cc: Jiewen Yao > > Cc: Gerd Hoffmann > > Cc: Tom Lendacky > > Cc: Michael Roth > > Signed-off-by: Min Xu > > > > Min M Xu (3): > > OvmfPkg/CcExitLib: Initialize Status in IoExit > > SecurityPkg/TdTcg2Dxe: Extend EFI boot variable to PCR[1] > > OvmfPkg/BaseMemEncryptTdxLib: Refactor error handle of > > SetOrClearSharedBit > > > > .../BaseMemEncryptTdxLib/MemoryEncryption.c | 48 +++++++++++++++--- > - > > OvmfPkg/Library/CcExitLib/CcExitVeHandler.c | 9 ++-- > > SecurityPkg/Tcg/TdTcg2Dxe/TdTcg2Dxe.c | 6 +-- > > 3 files changed, 46 insertions(+), 17 deletions(-) > > > > -- > > 2.29.2.windows.2