From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web10.4732.1652228028719512084 for ; Tue, 10 May 2022 17:13:49 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=g2inr9Wg; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: min.m.xu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652228028; x=1683764028; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=8cM3ZIWPpR9Ditl87/+Ao4EEYS2efs63KXmqiHpsBcE=; b=g2inr9Wg2hiUtA8fabQ/LMSdZez23HTr74xxU/xvmFsGyGQ2j30+ZDDF SWJuKOZ7/TI5ZOMYb49eoRR98iW2i3Uy1dFRwGXDjwUnbsYGOZrLjdQ3F CMG9H0POGBE2CedUT8uTNTggObb0twPXXrmUGiluoqi1MTJdYuTT9tiGB tlbn7E2HKMrEJSP+X3BdOsEDo8Q6ixw5EBwOTHyPB7d12p909iA4yQ8OT 7E7hl/IjvbVg5TqfaSfAfmmytM5DW7E1mHue6BBONRuFleVGMWsCxTbT0 olEg1EVa1rYMS5dtrpU2as6+XR1jcG8Eq3HJUDfvw99VnaGIyrwodJ2Fw w==; X-IronPort-AV: E=McAfee;i="6400,9594,10343"; a="251586575" X-IronPort-AV: E=Sophos;i="5.91,215,1647327600"; d="scan'208";a="251586575" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 May 2022 17:13:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,215,1647327600"; d="scan'208";a="593821394" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by orsmga008.jf.intel.com with ESMTP; 10 May 2022 17:13:46 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 10 May 2022 17:13:46 -0700 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 10 May 2022 17:13:45 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Tue, 10 May 2022 17:13:45 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.170) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Tue, 10 May 2022 17:13:44 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DrQTYWyE7gUTON2a2NZvfXEvpZAXtvqFfdb29NTWcV7uifbOCl3QdMdyym9VtZN9yc8DIT+6gOSHzOdEvJOX6y5Pjd94rr0uAWrTofh0S4ZJHu+aXxQ7HbE8pgEDrEbNHpW/hO/iOYWJbxCmKcpWA0CSVbn+qynkZn+c1f0769rBN/oZPFOcKvdMgCihajdospzC29zLDS5hh/49RirvwqGdn7LaiXJSLAlK7GlUukdVFOU5x5qYBb61aAlMT19BaE3d8RUk+nTzizOS5OQdrLlVpx94Fj8/kpv+XhlD/r7rnmbmEg4q4IVDexdqVRXrEouVF4OL3jJs0bIio7O9FQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hGVdmd2IQBGFTbsBjzUEE6wNfm5YxhtbHORp4MjRlZM=; b=X/WN/QbU3jmZQlPGb8fWRmjpsB0/NL9sc9n3w78pAc2jyVyo9oectDILfYihVj8NjpTKWKq5LxvsQpgTm9JgjKq2A/4zeMu/9+9kFAwuPtIXc+vx52MJ9MTu2xNT6YZJ3yPzvaHJjleUYe8I8ZwKNhWtw0/0pO4ju/FgSzGAZnAbf9Yhxqv1pvb2St/N0/i0fFVgK3D11/MPWjXf4c/C58GCaibMOV2yQUJwOW8njh9j2INeSi6wv3TPiPxA0u0qgPRtR6VZ6g5Ccsrlblgq/BpFlxyNOAM+ULjXnPi+x55umG3ceFSxIBmxogSphqZ0+kyZmv0q09vXWuC+4FCaog== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5064.namprd11.prod.outlook.com (2603:10b6:510:3b::15) by MWHPR1101MB2078.namprd11.prod.outlook.com (2603:10b6:301:4e::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.23; Wed, 11 May 2022 00:13:42 +0000 Received: from PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::1844:3fca:639e:7c56]) by PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::1844:3fca:639e:7c56%6]) with mapi id 15.20.5227.023; Wed, 11 May 2022 00:13:42 +0000 From: "Min Xu" To: Gerd Hoffmann CC: "devel@edk2.groups.io" , "Dong, Eric" , "Ni, Ray" , Brijesh Singh , "Aktas, Erdem" , "James Bottomley" , "Yao, Jiewen" , "Tom Lendacky" Subject: Re: [PATCH V2 0/6] Support 2 CpuMpPei/CpuDxe in One image Thread-Topic: [PATCH V2 0/6] Support 2 CpuMpPei/CpuDxe in One image Thread-Index: AQHYYbLq0fqgSDJ1NkuEWpAX8sNYC60WgXYwgAFbUYCAAPbNwA== Date: Wed, 11 May 2022 00:13:42 +0000 Message-ID: References: <20220510092655.re3wd3mu66toqor3@sirius.home.kraxel.org> In-Reply-To: <20220510092655.re3wd3mu66toqor3@sirius.home.kraxel.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.401.20 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: da80e8f8-d2cd-48de-a1ed-08da32e31b7b x-ms-traffictypediagnostic: MWHPR1101MB2078:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: PNXdKoic5YEYGuwr/vA4mbuDJqqvGlNPBmOPqNNaW8SSjGQTPR8XllfZXZrmd9r3gljt+vnlL+5wHErrsBMj4Tm/X11h4UtY4h/8fAEyMYgTFOvCPga3LI9OZhuPhbLal5fPF24zSCadjh+Ipzi6/uiB9IFYKVcTBM2XDFMkUgRKyoV1/BGzrFeeNI4mp8kicuLC2+0SiuI0MUAUGQf768MGKTN0i+ArmcdN4MH772+tX5Dk4XNIP24nLLBwBUcZpTYVeA87OGquU5/JCdi39wO7ScOnbqy0LnDjvihuv2FVxw0fyu4mKLL1/xS2GEemR25xbVj2oYnJhOs9QmwlgQ+xRim9MY835YPnJ1IQlEjSrKPLPI6tAOZE2BxqREYINzCQ6h6ozV4uCOJfQC2fQrTuOvWKXZFrdmNd//FnKKcDfVO/GSngWW7Dbk3x3ImaVgUauIE4pPKg9gadcPnB7Q31OQvvWEgek1qlWTq12Zvri91zAY8r1w55D00kSNy1qzoSARdEshvra0WoO/stOaNrTadLy5CjeFPlCG8NZ20TnVDQgHH6g3e1R/OeCzgiM6hyCCqQjSEuaWPlrG3FEk6FO7lSfmJ07wWrdFLIVHWVTr9S5ahoM/smyI8rh1jhhNztUyt5X1lhvk5fg3gFcQKdO/bCGHvSFQKduk425ZZua8H6FYlhFwaGk/n49E6UXNFya2P0OBZmxxgQ/jmOERqA5p0oZCt8sP0umYVxAhbXhhyTThB5k1PYMRDIdag++EZrDd23RV0o7eLjGEzzgp95PY9S1ZAchePFwySgaw8= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5064.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(6029001)(366004)(5660300002)(52536014)(508600001)(38100700002)(38070700005)(8936002)(33656002)(55016003)(316002)(6916009)(76116006)(66476007)(66556008)(66446008)(54906003)(64756008)(186003)(66946007)(82960400001)(9686003)(26005)(71200400001)(4326008)(86362001)(8676002)(966005)(2906002)(122000001)(6506007)(7696005)(53546011);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?utrwZ5jsxZqOfDT8uIkg/p6p6sP6i/e9hTH5jKNz+oZZv9RvxacBtndCdgPX?= =?us-ascii?Q?ODXnpFO90IUei5S9LOR+6KSO6sx6NJCwA8TRlcKutiSS6O2pPDm0+4yG1vZ3?= =?us-ascii?Q?NQbVp3vcZqDz3ySgTKg+HZXnvXaT9305hRG6Xl9AczAXZGVvXc5bHXBo+Lg4?= =?us-ascii?Q?looBlyLcsFws/GvmGjScMD/RVURMydNwoNzj9sJK3RBTwXLjhnYn9stBACwq?= =?us-ascii?Q?225asriVbP4FmxuBQEffVlUadhzHT6wy675KFtHU/7tBW2Q3RAmw7VQhFs69?= =?us-ascii?Q?uoZgc/C4WC9OxUEIJk/bGIt3+9JQURHplFiA54MK/qp4/7oFf5U3vHx4lcwa?= =?us-ascii?Q?dBLnqzQ658MQF07wKhZr0WNA9PFnqLAGqIUHzOUkxV58zOMlX++1foo+0ndM?= =?us-ascii?Q?S7vmCQLcQHcLpZPYHt2WrLWI3JaZA1d4KbtjnidUrq5gELIZ6l9BPT4eCiIY?= =?us-ascii?Q?uH+RRRRoZYLimGSHUbGaiFwoWBvu3UFb7GoiJ1MC6+CK0QjV/651YZZB+wWF?= =?us-ascii?Q?+Voq/N07CxSmFWd8pxOkuIaTBEb3FEgFZF2diW9B9/6y9hy4MckN/EGu2mox?= =?us-ascii?Q?xnc7YfKbXdhtqqPUYoAX02iXHWY91/TQr8pL+BzTPbVHE120id8UGSZZU/KT?= =?us-ascii?Q?5w8NU3yw4CXw/lfsezXuMp8jDCMES1uBPwdm/hfvdt7vcCIDTdBIipgBzik9?= =?us-ascii?Q?4zXOyJf/KmOP176zatNoUtaEdr4khS8qQwclbckhE5shknm6w0c3JQG2oiBo?= =?us-ascii?Q?+FfIBF7rkxkVu1Sm3UcJ6WsBFqvcuHWEssWMUcZ+PLREBjqNmxL+631NWjud?= =?us-ascii?Q?XTbkdVNZDxY4EagEs73z/me3zoir8FQs3rEnDbolM9ZlE/U+D4uJIfszdIpu?= =?us-ascii?Q?erLWVBUlqrxyH5ffrI917qAaji6m0Nu9mob+d0Mw+kh3N1djCQMjBHYiZE4b?= =?us-ascii?Q?zj2ooTGcAA7+hkJYufjnuj1o0Na6JuP8vSlZbXC82Bi6UnS3VuqGeDhB2yYt?= =?us-ascii?Q?hMvqWpqmM/cffTIm8hWQ+mrCfqhBFXuBjDSHvYYkkbyObGYjyVUsBMRajcXx?= =?us-ascii?Q?Cf35aEdG80CVp338huqKBb27OMuVytfbAaySvPPX11U243RGGVdvCHpMGUVW?= =?us-ascii?Q?OBezMZblQpT7X9vNJzf+n0dtZPK0TGrfd+tiV/EjD+alcZt/1UZDyxh9MxAA?= =?us-ascii?Q?QvK64405Q1riJLEo5uVfqeQy8fsXXRdvNFGf6QagbMe7z75//05OpomGED3M?= =?us-ascii?Q?lowPlEVMw1UAFS7p4HnixdGM/Pew/6/I7y4sK5grua+wTLaUo8xqj9cVBzf6?= =?us-ascii?Q?0sG+OqumvJrdH+Pq/8bBGGEAdw6jtVdk079A0nythQfugzaxhGBxQWUNCcRP?= =?us-ascii?Q?FQ3xyUZkMssxRdtyPI35iiHe3A4+fenWDmQEX4AkIYdJ0lzfqS1G38RgqOzz?= =?us-ascii?Q?EC0nPA036zjmUvSyiXW304cxYDzuw9okeWB9A6RdqCUGjOUzYcTjKJ/Qu3sJ?= =?us-ascii?Q?M+Glnzz/NoOQUV+H7oA+PBiEDS333AAQTP2/eRKBC+NnAx6WkYkd57oucZyB?= =?us-ascii?Q?oEIlAio2C0+ILOWf+YDv/LPVH1yNpaAh6P61sysH82u0zDe9TehQ10JPXkTN?= =?us-ascii?Q?dRHDym0VwWK3M4pNfkjC8phqcaHl0uKGnGYtEhGVz3CMQZbn0zpnbrr7h7BD?= =?us-ascii?Q?Tu50L8OLCtrwgNFMShRt/aApELvYts28TcLxZ8YSFWI4js6IRfLJZIwS8BaV?= =?us-ascii?Q?H5hbHWRcKA=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5064.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: da80e8f8-d2cd-48de-a1ed-08da32e31b7b X-MS-Exchange-CrossTenant-originalarrivaltime: 11 May 2022 00:13:42.6242 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8QCYYQUM9PM7j8zfx7UTtwknvz0pndNNtmBLTG3MQz24w6+Y7YxCBVyT9dI6yhxtB4P+PXQIRLUyVq5ot8yxgQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1101MB2078 Return-Path: min.m.xu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable On May 10, 2022 5:27 PM, Gerd Hoffmann wrote: > On Mon, May 09, 2022 at 12:44:58PM +0000, Xu, Min M wrote: > > Gerd & Tom > > What are your comments about this patch-set? > > > > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3918 > > > > > > Above BZ reports an issue that commit 88da06ca triggers ASSERT in > > > some scenario. This patch-set is to fix this issue. > > > > > > As commit 88da06ca describes TDVF BSP and APs are simplied and it > > > can simply use MpInitLibUp instead of MpInitLib. To achieve this > > > goal, we include 2 CpuMpPei/CpuDxe drivers in OvmfPkgX64 and > > > IntelTdxX64. This is done by setting different FILE_GUID to these > > > drivers (of the same name). In the other hand, we import a set of > > > MpInitLibDepLib. These libs simply depend on the PPI/Protocols. > > > While these PPI/Protocols are installed according to the guest type. >=20 > So the idea is to pick the one or the other implementations via guid and > depex dependencies? The approach looks sane to me. Yes, it is the idea. In this way we can decouple the Tdx guest from MpInitL= ib (multi-processor version) in current stage. =20 Thanks Min