From: "Min Xu" <min.m.xu@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"kraxel@redhat.com" <kraxel@redhat.com>
Cc: "Aktas, Erdem" <erdemaktas@google.com>,
James Bottomley <jejb@linux.ibm.com>,
"Yao, Jiewen" <jiewen.yao@intel.com>,
Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [edk2-devel] [PATCH V2 4/8] OvmfPkg/PlatformInitLib: Add functions for EmuVariableNvStore
Date: Wed, 29 Jun 2022 05:16:46 +0000 [thread overview]
Message-ID: <PH0PR11MB506471D7F60544B2E1A4DBB1C5BB9@PH0PR11MB5064.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20220627091006.gyih3pdwnjvkdgek@sirius.home.kraxel.org>
On June 27, 2022 5:10 PM, Gerd Hoffmann wrote:
> > +VOID *
> > +EFIAPI
> > +PlatformReserveEmuVariableNvStore (
> > + VOID
> > + )
>
> > + DEBUG ((
> > + DEBUG_INFO,
> > + "Reserved variable store memory: 0x%p; size: %dkb\n",
> > + VariableStore,
> > + VarStoreSize / 1024
> > + ));
>
> > +EFI_STATUS
> > +EFIAPI
> > +PlatformInitEmuVariableNvStore (
> > + IN VOID *EmuVariableNvStore
> > + )
> > +{
>
> I think it would be good to add a log message to this function too, to make it
> easier to check variable initialization actually works the way it is supposed
> to work.
>
Thanks for reminder. Log will be added.
Thanks
Min
next prev parent reply other threads:[~2022-06-29 5:16 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-26 3:05 [PATCH V2 0/8] Enable secure-boot when lauch OVMF with -bios parameter Min Xu
2022-06-26 3:05 ` [PATCH V2 1/8] OvmfPkg: Move TdxValidateCfv from PeilessStartupLib to PlatformInitLib Min Xu
2022-06-27 7:02 ` Gerd Hoffmann
2022-06-27 8:04 ` Min Xu
2022-06-27 8:41 ` [edk2-devel] " Gerd Hoffmann
2022-06-29 5:16 ` Min Xu
2022-06-26 3:05 ` [PATCH V2 2/8] OvmfPkg: Validate Cfv integrity in Tdx guest Min Xu
2022-06-26 3:05 ` [PATCH V2 3/8] EmbeddedPkg: Add AllocateRuntimePages in PrePiMemoryAllocationLib Min Xu
2022-07-20 8:49 ` Min Xu
2022-08-03 2:26 ` Min Xu
2022-08-03 6:22 ` [edk2-devel] " Ard Biesheuvel
2022-06-26 3:05 ` [PATCH V2 4/8] OvmfPkg/PlatformInitLib: Add functions for EmuVariableNvStore Min Xu
2022-06-27 9:10 ` Gerd Hoffmann
2022-06-29 5:16 ` Min Xu [this message]
2022-06-26 3:05 ` [PATCH V2 5/8] OvmfPkg/PlatformPei: Update ReserveEmuVariableNvStore Min Xu
2022-06-27 9:14 ` Gerd Hoffmann
2022-06-29 5:17 ` [edk2-devel] " Min Xu
2022-06-26 3:05 ` [PATCH V2 6/8] OvmfPkg: Reserve and init EmuVariableNvStore in Pei-less Startup Min Xu
2022-06-26 3:05 ` [PATCH V2 7/8] OvmfPkg/TdxDxe: Set PcdEmuVariableNvStoreReserved Min Xu
2022-06-26 3:05 ` [PATCH V2 8/8] OvmfPkg: Add build-flag SECURE_BOOT_FEATURE_ENABLED Min Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR11MB506471D7F60544B2E1A4DBB1C5BB9@PH0PR11MB5064.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox