From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web12.7899.1656479810760624763 for ; Tue, 28 Jun 2022 22:16:50 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=SfSF+vdw; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: min.m.xu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1656479810; x=1688015810; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=Jy0ngOisrBoXAuZMy5I4DdYbfoOHNdFwJXEiWqYveMw=; b=SfSF+vdwhvj8uwBp56UGgBAXaCPkjno44ckl9LQbfc7el8GLqfNcaZSP VgAuokA0TENSrgenFhQf/EKEynEqjRQV+r+DhziN3AN5GSmWcyIjNna8r jFWpRx0jetxdE1xFuP+11auUQ8dY/6Jo2HLthEZfbszXyYJe02efLgqgp dGTnu9h5N/98oz5Ferwz4NWPeEuAVz59CNrmkm9WmW188GJF74sZvpsDH DmOmm/OE054rtopIJXKvV4gdTSeTdJ/a06XY8DfSRS0yLNYT7YZvkIHCy 4cHBYFUKffqqcy/QgqwBsRE8o3Xp4PdWEB84KDIPYtcVxEU7CQ7oI/fG9 g==; X-IronPort-AV: E=McAfee;i="6400,9594,10392"; a="307415188" X-IronPort-AV: E=Sophos;i="5.92,230,1650956400"; d="scan'208";a="307415188" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jun 2022 22:16:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,230,1650956400"; d="scan'208";a="767438164" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga005.jf.intel.com with ESMTP; 28 Jun 2022 22:16:50 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 28 Jun 2022 22:16:49 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 28 Jun 2022 22:16:49 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Tue, 28 Jun 2022 22:16:49 -0700 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.46) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Tue, 28 Jun 2022 22:16:49 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HIm8vIKuxK2KXQ0Esz4NVPJ3HERIHfzYJRSKCKn2RD7+HAv/PTeceAXjpAiCYOv9R1AlsjAQ+qCWxu304Md4PjGEOLr3QcijuRBtLi6H9T8DmRILzyOem4nQ15yJWbRb6DlMcbI4pveDFYozgcsMl6Umaium/+6ZAHwMnkt/uUduW9PY0yF57SZ7cGXAInO7prJ1LxbxVoFuXh4j9NjCukR/BtZnEVlQNdtLJlu9nu7lZ6yW0ys6zjNbWmzILCrhnrEVnwxR9wGk6hgzut5waUnmZp63ymhYafhqMC9keM18wcX3Xpa5yfmKLWGOOYyg8oCE4gMSSbDpjp6YoFBCPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XF4YTFFZ+Sa/qGOxdlsxzHegcC0vC1CHw6P1XQAzDis=; b=RnkMOGA2cxQLTlOVdcUBE3EcZfKv98QWe2R/Sb9Xy5oW9p9Fn8hhCkbQIN3C3E+sw+k53a7b/DCV2b8zMqhlXwea3X3P3Km5NXGYwlvUYxDa+GnomVbZ5/7eyh+wX4C0hYNDTL9J3RLQl8HKVsg9uiCN/QSG4eVqj73f1z/5D5+ChYGpOJ9hugq4r6E+O+U9hpKLTo4YGFJwYxJzV2J79uqfEPJR2/nk6cXcGeOUCFadrV+XgKl0ZpRIGgNqSgg2uWJJSVn2YJrAuny0BqoDirJT/Nnwf6cVhVP8yqkJ/SVD5z0xHQ32xckm6ZNFIhmcZj5SZCLxqYXXcW+7sV7YaQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5064.namprd11.prod.outlook.com (2603:10b6:510:3b::15) by CY4PR1101MB2119.namprd11.prod.outlook.com (2603:10b6:910:20::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.18; Wed, 29 Jun 2022 05:16:47 +0000 Received: from PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::a0ea:2e53:9c0e:9148]) by PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::a0ea:2e53:9c0e:9148%4]) with mapi id 15.20.5395.014; Wed, 29 Jun 2022 05:16:46 +0000 From: "Min Xu" To: "devel@edk2.groups.io" , "kraxel@redhat.com" CC: "Aktas, Erdem" , James Bottomley , "Yao, Jiewen" , Tom Lendacky Subject: Re: [edk2-devel] [PATCH V2 4/8] OvmfPkg/PlatformInitLib: Add functions for EmuVariableNvStore Thread-Topic: [edk2-devel] [PATCH V2 4/8] OvmfPkg/PlatformInitLib: Add functions for EmuVariableNvStore Thread-Index: AQHYiQm7MJ8JYhTHZUSI0NM3Ui9IOq1i+U4AgALjQfA= Date: Wed, 29 Jun 2022 05:16:46 +0000 Message-ID: References: <20220627091006.gyih3pdwnjvkdgek@sirius.home.kraxel.org> In-Reply-To: <20220627091006.gyih3pdwnjvkdgek@sirius.home.kraxel.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.500.17 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: fc95580e-ef89-4d3c-b4ec-08da598e9060 x-ms-traffictypediagnostic: CY4PR1101MB2119:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: bcwXs/CGclzSxXt6T8fRmwUoMTPQ+oT0LSonfp65dK0UdEM3YosHw5e34ijDAxXbabV7Kj8ULGT1WitN6JeMCgOpM76IaZPEKvSfHSw0T+QIm8NpWE2zqyHE+jArf0l46MC3JMWiLVFpgxnCYlFeKCPYtkHkpEulHFM9yKg7Nq64EX91RuYac49HC6yNndD53cjgLFYLiJp9lwLcy305h8BFT4rHrjgjXsTe3yCovo5A/2dS5c14VruuLlSZ1jGqy5v/Lw1FKiLy9yMhF6aFMKiZhF3TjZUYWEDmse5Lbt0EizBBlFTkW+UYRHkpfZf4dWTLQ0ax6NDJwPP1/BQhG2BzhfEDs2YMwLKBlskn6IwnU2MvVtSeBwk4n7IR1I30z0GJIZzH9TZbMSQXC52zR92WW7SXOeyxqjAY6sJjVdwwRY4Lml7IbKzm705h++853RWxpkQxFYvsME5DvInny+SjDi4henk+Aea2SULLx2C+/rzvUhCpXcWusKG8cqOcmknQTZx92znf49+oIkukpK8ojp/aFxkUYR+gMBfNCoPiPTfxFSfjsu6TUz7eK4zKbQ6a0oe831yJx8lC3JkZ2fb0+1kCSzl+9ahoRtq3Z/z58SmQx5q49saaXW790C4+8y/B/eKyVq2RZfvA4eiYLHtZzptqL5Q6nvvXRt9vzC5/8GTX0TC64VsOWiDapS2A9MrEBDq/6IhyR9Q3YgNaXNf7b2I9jvPJdyoueQ1Bl9988qOIeI4HaUOLpo4L00UoEqzw7nRj4+pf/zzY24rb85hnxTm/nZXTi8MaIcQYd8U= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5064.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(6029001)(366004)(39860400002)(376002)(396003)(136003)(346002)(55016003)(33656002)(4326008)(54906003)(86362001)(110136005)(186003)(8936002)(26005)(2906002)(66446008)(478600001)(6506007)(9686003)(38070700005)(82960400001)(66476007)(52536014)(66946007)(7696005)(8676002)(71200400001)(64756008)(66556008)(41300700001)(83380400001)(122000001)(316002)(4744005)(5660300002)(38100700002)(76116006);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?dXWg2ZQWaxj7vjg8yN5FhPu/ssNZh8fRZHoJLDwiYBZHa8sSERQYauoKrokC?= =?us-ascii?Q?oGfX0O2iVzWu7cHc+WcRBqFxpNsGhdgzyTuncwxxlek7bJeQUK2XxxZaXafX?= =?us-ascii?Q?rSQuPzZL3tpLeldXmw0UlX/JkUjYjALT9F09iHJJ6cWxo/6B348aCOl1PfPB?= =?us-ascii?Q?2S2kMycjUYTcL9HGz7ho6j024i83mwJcWxGadiI0eo1YfEgtmcDT8cx8hBkD?= =?us-ascii?Q?yo/UKf8vif8PVGJIBqlvOTmAqD7Ts6p+Mq+0VonNFlzaqDxmInFoLIU4nAU6?= =?us-ascii?Q?1e75NHso/R0eOO9Ey1TYBf2WsRWs9Rv8hYcOJQ8QCebgUtUFUUcCxd2Tqo45?= =?us-ascii?Q?mljzHU2/cW6IXVSVBqB/SN47mmFdmYNBxhuFsVMQZRJsOB4ZoT/nRhKhso1k?= =?us-ascii?Q?VvJNuYScp7e59tkn+n8bxJsDNp8pVJyZ759ejskbI6jXA8zd4uLTM2+OJvPR?= =?us-ascii?Q?vQT2Ltnb56w74aFOMQUTmedeKtoBFBeo6KLi9tPOOqAaVRNVjmMFZ4+Lg7o2?= =?us-ascii?Q?zipSVZq57FhbUVaveVBW112KNjeXOpP3R/4JNlxybDUNXM7rFb4SF1KWXoxy?= =?us-ascii?Q?Swj2gKFY7jgR0JkCBkFElPtLqn8oN2EClcVA0WWO6c0jaQlGKu2YUDiEQBxY?= =?us-ascii?Q?tZcq3HSKXYMqvq30cb8nLk6U5Fyn5tiFeJreBwmW11GZMMKaPjruYa/LiKK4?= =?us-ascii?Q?97Z0gNcsKsbVbrtJBdNgDf/+mTvGzG8z4zHC8sT1DSy59y+L6nsgUZpB8ZQy?= =?us-ascii?Q?uepVn5s0jZLzmBDKDcBJZ7aDOfTf7PvrX7iVKN2LARvtoTxe6BBJArR8p/yr?= =?us-ascii?Q?JVV49e1XDizffuX2sycJkMugrFk5IeXftQz1qo0hXtVe/wllakbtDObz8fDn?= =?us-ascii?Q?rzx5Pd0aqkkprfcXaeac2d3lAUsXu13Z3sgIgdNe1W3Hnx9HNBO6ipZ2jVxw?= =?us-ascii?Q?Ea2+zkWgGymjEyBj6icR7iHebPbpNqU+TE65IDvZ1cd9u/NffT1bppSvAvPd?= =?us-ascii?Q?WeBLEoq7IJMv65uMUmp6S3embMPbk2AowFLjuQLuji1IPO37OPz+k3pzDaWf?= =?us-ascii?Q?bAKz3Al+fwxBtMOxSsueHeV4/jJtn2COnI5QLeb+MqwpmPLhiYshDJ1RnhbQ?= =?us-ascii?Q?W+HytHAkWi/+/oEyiG/HVFx5UAXesTwcbbH8sNBaGdzisZfSxqaq9RU6rRig?= =?us-ascii?Q?YIhnkfBg28Hxa1W/GOk7ZpRJLGJchXr0no5z+QmmVYrsCloN3CXkHRh+A/UB?= =?us-ascii?Q?CILE78DaNhdemKBZ3rtviYdVWyDz5mV1mTZtWhwroBpbyDyPxyj3oVnG5QbF?= =?us-ascii?Q?y/q2b9s2NHjfiKaTTfEsumlmXBu5T75BmHtCAGzFcioaiIgR9xkuh7iPtU6G?= =?us-ascii?Q?qTIXZ7ToPrukTLyKJvt/LgYYx0pZ6KViZmPl6pqBmCNWdU/OpMZytJZq3gw7?= =?us-ascii?Q?A9lsIyL3O+qi5DhkIdpJwhtaSO1IjgjgmJff5HH5m4fp5NJhJ5KolidmrLVS?= =?us-ascii?Q?g2GXxQmN4RQVvOm3nKVgCba4CdtvXj7VZUggegiNftFxSK052RWSRM6FC4vh?= =?us-ascii?Q?H8dc2tV1e+zkhaOjzFZH5b2Ga9JbXmNOVXSZM9wz?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5064.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fc95580e-ef89-4d3c-b4ec-08da598e9060 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Jun 2022 05:16:46.8361 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: yZ7x+ZpN5+GJkF3WZ79wXrHbgyOLGtwpJ3BwDu2V0NUXWI8PT/JqrxO/Etr9j5aFV29k8u6ZCY/4N1nLGjrYOQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1101MB2119 Return-Path: min.m.xu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable On June 27, 2022 5:10 PM, Gerd Hoffmann wrote: > > +VOID * > > +EFIAPI > > +PlatformReserveEmuVariableNvStore ( > > + VOID > > + ) >=20 > > + DEBUG (( > > + DEBUG_INFO, > > + "Reserved variable store memory: 0x%p; size: %dkb\n", > > + VariableStore, > > + VarStoreSize / 1024 > > + )); >=20 > > +EFI_STATUS > > +EFIAPI > > +PlatformInitEmuVariableNvStore ( > > + IN VOID *EmuVariableNvStore > > + ) > > +{ >=20 > I think it would be good to add a log message to this function too, to ma= ke it > easier to check variable initialization actually works the way it is supp= osed > to work. >=20 Thanks for reminder. Log will be added. Thanks Min