From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web11.2401.1624416263219599045 for ; Tue, 22 Jun 2021 19:44:23 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=LguPuTzV; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: min.m.xu@intel.com) IronPort-SDR: jUWHLQ26jpHcHebVg1+AvpqJQP/l5N6bNdRalSIU9NOK7gcyqkDT4vQkos2tdJrvVy5lPF8UvL YCVxOny8VbVQ== X-IronPort-AV: E=McAfee;i="6200,9189,10023"; a="186868782" X-IronPort-AV: E=Sophos;i="5.83,293,1616482800"; d="scan'208";a="186868782" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jun 2021 19:44:21 -0700 IronPort-SDR: Pthw0AQYhH3Zdj4pgSUP2QReezU+6eZXQUOT+LRun4qPM4gWbtgtDoeU5GY74ILp5IhLl4pJXL +b5Hr7r6T5Ig== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,293,1616482800"; d="scan'208";a="406538239" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga003.jf.intel.com with ESMTP; 22 Jun 2021 19:44:21 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Tue, 22 Jun 2021 19:44:20 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4 via Frontend Transport; Tue, 22 Jun 2021 19:44:20 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.109) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.4; Tue, 22 Jun 2021 19:44:20 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MmK+3hPRxgLTKN/nH0SiIUrPZLAB2/Fol0e6FApJg9gCXB3Q2bVRZWBUTTqKI2shYowOTrSO9g5UzdB6L+itwYt0rK4XwJVsvN6tbdmhF4HqZkcVKuBEz3+UclpoMMZBdBQ4bIwlmjfcyCjLBrdqLjnBZH+LMmHMnRks8C7zO2wcFxU+GI7LlEnic04dqHUv6Dg3IsVZO7lAgMI27WJDM48bKN2ejHJxQzXPfQFiIBd90vo6UaSM0UqMcAotXWuGVx26Fp76xhjzIm98OmqGdU7t5VgghCnE6eRG1Wt+2n00pgENRc+b9mGLOZWinxOfOfYl9ObGNMsAclhsU54DWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UcROKCX6JvTY0W//8SyszmlAuDiS7L+J4D6o9UlSY38=; b=JIQidGzd1Zq1dnw5Oj2QqnNz/RPWy9UIi33X1AV/R6eGa281gocfB5ssaRO9GvHcrRlwe2SnhuwULgSnxwd6X04ApdYqS2CqRgsAYCobyCl/qxxBuqoFxPSCcE7rGGu6+vGXT22Hjz1h/DHhhrM1nmzHHSfUdffffFpN6zUP7VARv+U4K/FmkYZLp2e0JoLQ7CrjD3TBVVK1JKQI7/6DAXja6Jgx26kHP+YzZ8Ay+n6zyX8SINi0AWgM3S/5NEBwfgw/8ULWI8ra3eDtvjRG2z93urLfs2onwrAfBHJf0YA0+DMjaZRmfzl8BuAZZYQS0vnmAXQeh+WNzpc/6UF0FA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UcROKCX6JvTY0W//8SyszmlAuDiS7L+J4D6o9UlSY38=; b=LguPuTzVG6nHEt26THLjXx7RRuB1jQa3sG0AIJ8JST22ZtRfChCPynkTIQomeLxdFDIyuWvJjwV0saVUxuzVE6C+sKt7BwcWT8Wc6tb8gjsMKnFQJqppMqdvThCVQuf182Pg9ORH9WfWpcF2m1iExGN5n0ZPIYFVBzd/qbUJD9g= Received: from PH0PR11MB5064.namprd11.prod.outlook.com (2603:10b6:510:3b::15) by PH0PR11MB4997.namprd11.prod.outlook.com (2603:10b6:510:31::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4242.21; Wed, 23 Jun 2021 02:44:19 +0000 Received: from PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::b4be:3994:dd4d:7b9d]) by PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::b4be:3994:dd4d:7b9d%7]) with mapi id 15.20.4242.023; Wed, 23 Jun 2021 02:44:19 +0000 From: "Min Xu" To: "devel@edk2.groups.io" , "lersek@redhat.com" , "Yao, Jiewen" , "rfc@edk2.groups.io" CC: "jejb@linux.ibm.com" , Brijesh Singh , Tom Lendacky , "erdemaktas@google.com" , "cho@microsoft.com" , "bret.barkelew@microsoft.com" , Jon Lange , Karen Noel , Paolo Bonzini , Nathaniel McCallum , "Dr. David Alan Gilbert" , Ademar de Souza Reis Jr. Subject: Re: [edk2-rfc] [edk2-devel] RFC: design review for TDVF in OVMF Thread-Topic: [edk2-rfc] [edk2-devel] RFC: design review for TDVF in OVMF Thread-Index: AddYf4DUPECuZ9ubQaOwhq0M0PgYbAFyHmpgABBrYkACOGvAgAAbO7wA Date: Wed, 23 Jun 2021 02:44:19 +0000 Message-ID: References: <168759329436FBCF.5845@groups.io> <4d0fc023-6520-43f6-0b0e-9db7bf15a85c@redhat.com> In-Reply-To: <4d0fc023-6520-43f6-0b0e-9db7bf15a85c@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.143.25] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 55d7ec72-34bd-4394-c4f9-08d935f0cd0c x-ms-traffictypediagnostic: PH0PR11MB4997: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: wUpAfZy+1b4ICyVrYcOivnVaeozfaqADcGj3gmRlfxSsDgVmN+93eL0yC3tfmG5bXEO4nURxFGCONwjuhD4aqYW+LYcsj94a//GKz6Wn1+bqxvbQZJyurujzo0oPuXN+ZKYHqYC3FuvY6OepOj4yq7Be314sWLdc67OesGMqqL7CTVZj/mjMDCx6f3VW9SGFwgZR0eAHi78GbAjcP2LJjMRkSn3Zd05gPuzsyeGRQ5UkQN4xYiJdcSGgPIbkGbpxrQj5adVqEwMfnIjHFn/DyfvvPYRnPknu+4dsYiPeIJBzLKXGmHDVYgwq98W5S70yMIw3/gUKbeKeixlcXqxC0gA6D0ue/xye6zg/2OhcFAV6rTkNxv8mkwP05JMgZI+jDZwNDvBF1bf+dTt6fqitIwFWgJcrY48f8A2Pa0wWhj+ls+vCdarbm21lNXAXlvBOykX204IR1ZZMxmNof/cVsXQl5ay9MnngZlljNByKWUqNUVbWXZZqQPKIXpG4XAyvI2TJzsPGjt4mNIhTwIaA6ZSoUUp30iXWyudWCG8ymnKL0hECdMY31N3UfjKyuvv7haugjbx34250sqq7uCRqtzL4/85DmY9asGQ1BDvClQKOTYwLF2hTVcxHIQqs8v3290hLRbVt+jFRxTEgfJ81YzolYnGmYvZNM0MNinFnAcNUa+8iruFWkIGqe52OhZK/Yu/r9bomTc+47bRepYJb8bKL8f5IwtYf7e/JqNqns9o= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5064.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(396003)(39850400004)(366004)(136003)(346002)(376002)(66946007)(110136005)(186003)(8676002)(52536014)(71200400001)(316002)(53546011)(966005)(54906003)(7696005)(26005)(6506007)(66556008)(86362001)(33656002)(66476007)(9686003)(76116006)(38100700002)(478600001)(2906002)(122000001)(5660300002)(66446008)(8936002)(4326008)(55016002)(64756008)(7416002)(83380400001)(4744005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?dWCbJpzcppGmo7TI0TPJNMwdCSc8PJJ1ORRBcfXeYg4G+CGnTonB0/Mq6z2i?= =?us-ascii?Q?uuwDBPYCBWvaByCsq8t5SqcvKHu4JgbUnQq4U5ODh47ScAdvfUzQQXva4sHE?= =?us-ascii?Q?A/HxWy3i4uj1/TmNYuypK5QfeV6VpUnd2F1CbJAf66lWbVQJPA8Dm51JHxHm?= =?us-ascii?Q?Y6gCqbY1DCO4YM32cIbijWs39sMAlOlmYi+uyPZ+0E+Bh1Ll42bPxNgAqY0V?= =?us-ascii?Q?3S9F4iCkTXwHeEDRZxaDswMD8iFn3wWO5FlIuYw0TszN112eVAFiBjBFHxCY?= =?us-ascii?Q?Fv/FD7YqesxvxHE/HwV859g9lJj8W0jUYC4f05sa7EcuGRtj0K61E1ZJImyf?= =?us-ascii?Q?k/hYmd27TljwnHuzjRbYPRwZkRxmjOiOw+of6Tvrbpm/QLz5Y2RdDORNxXPQ?= =?us-ascii?Q?Iz+EuNkIivb4WjyxeBqrUJ7fDff9D6T+Sh8Vkq6KLYUDj7WNgnX3HNirtUW6?= =?us-ascii?Q?sK1YlsgeJcr4HEpDVwfJ9ycTRkItF6g1MvVWFIrCNtxFfYb0c5ZM1nKk+468?= =?us-ascii?Q?UnOuA27n0SPrBLNQ7Wp6VsGUBgOCYz61vxXdUz9etWB5YNIaEWIYXhu9RZSg?= =?us-ascii?Q?25nU7kyxreuH3h6p8lgSzVUN5vE/1BjKU2yN5tRky7pFpCdaVlisDCWqi8jF?= =?us-ascii?Q?Pi9PscyHGycyooWU5+235ka30+Xel79tZAjVmSfdvxOcMisbShZ9iXDBKeyd?= =?us-ascii?Q?dwFG5YhaPeVvCQxwP0lMzmjUYEH+Yf4c9JJXrlUIsah3o7tTir4lJkZn3mdf?= =?us-ascii?Q?t7QGCWgXG3W+AprRvKrDLRFP6t+kcJQWcapOazckif6ZYIq3zsOt8RpQkT5p?= =?us-ascii?Q?2yksNxjJ+zWgTBKiwASu3jxDJzaArevwLVhiFcAPiAWi8WkcRoGPRLphmMZv?= =?us-ascii?Q?qvHfXneptmzmrQ3BNUhAjrnUKt8HNY/UBtJDDKeNuLDtIQVLSJASocZsO0Pb?= =?us-ascii?Q?UY1djwIFnCDZVbHNP/sWSkriP3OEnHvdDP0fiKWCcput0s7rSv1YOzOQ95oY?= =?us-ascii?Q?qoK+g9Auz0+EqNTYsbqDizUrvsQLUry2OddpJ4K1r4X8zHRCba/q2J7+CAFm?= =?us-ascii?Q?O/LM35H8UTNx29r0l2ECmtotCeQzLVNja2OomZZtTn17avY7aNp6zunQldNS?= =?us-ascii?Q?c4/tZe/gPnn72fMfIbO/+0BcE+ExSAvdRzZMtZF2WUX3FaNyP7kY1pyTZK5s?= =?us-ascii?Q?L5nna4iLbgGuyqw4cFkwfgCsCeyD/7EeY1/M4YN/lSZJ4zxNOc3E21+p0oT7?= =?us-ascii?Q?WaTjsn+9JuTrlY8VAX+CcOl4/lRCCDT1UGvy6ZqVjCo1qx6wqudIgPEznd7d?= =?us-ascii?Q?s+8hW8UB2Ex+oTDDqEsUpjJy?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5064.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 55d7ec72-34bd-4394-c4f9-08d935f0cd0c X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jun 2021 02:44:19.7129 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +AqE48u3pwc8G1JmiQdTYj4Xu7xv+XfIzxVVTNSiKMf4qxOmWyY3pKTJZoKUAqWBQ3Xv+krP5wHIDp0nDJNhpA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4997 Return-Path: min.m.xu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable On 06/22/2021 9:35 PM, Laszlo wrote:=20 >=20 > For example, as I stated earlier, "OvmfPkg/AcpiPlatformDxe" is a driver w= here > I'd like to see zero changes, for either SEV or TDX. If the TD Mailbox lo= cation has > to be reported to the OS via the MADT, and QEMU cannot (or must not) > populate that field in the MADT, then a separate, TDX-specific edk2 drive= r should > locate the MADT (installed technically by "OvmfPkg/AcpiPlatformDxe", earl= ier), > and update the field. >=20 We have updated the design of AcpiPlatformDxe. Please see the slides in bel= ow link. https://edk2.groups.io/g/devel/files/Designs/2021/0611/TDVF_Design_Review-A= cpiPlatformDxe.pptx Because MailboxAddress in MADT table is determined in runtime in Tdx, so we= =20 separate the update of the MADT table in TdxDxe driver and keep AcpiPlatfor= mDxe clean and shim. > > > Thanks, > Laszlo >=20 Thanks Min