From: "Min Xu" <min.m.xu@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"kraxel@redhat.com" <kraxel@redhat.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>,
"Justen, Jordan L" <jordan.l.justen@intel.com>,
Brijesh Singh <brijesh.singh@amd.com>,
"Aktas, Erdem" <erdemaktas@google.com>,
James Bottomley <jejb@linux.ibm.com>,
"Yao, Jiewen" <jiewen.yao@intel.com>,
Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [edk2-devel] [PATCH V4 17/31] OvmfPkg: Update Sec to support Tdx
Date: Thu, 16 Dec 2021 08:11:39 +0000 [thread overview]
Message-ID: <PH0PR11MB50647DA89FA4E4A3077978ADC5779@PH0PR11MB5064.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20211215081842.stsakfl3ub3thycu@sirius.home.kraxel.org>
Hi
> > +EFI_STATUS
> > +EFIAPI
> > +BspAcceptMemoryResourceRange (
> > + IN EFI_PHYSICAL_ADDRESS PhysicalAddress,
> > + IN EFI_PHYSICAL_ADDRESS PhysicalEnd
> > + )
> > +{
> > + EFI_STATUS Status;
> > + UINT32 AcceptPageSize;
> > + UINT64 StartAddress1;
> > + UINT64 StartAddress2;
> > + UINT64 StartAddress3;
> > + UINT64 TotalLength;
> > + UINT64 Length1;
> > + UINT64 Length2;
> > + UINT64 Length3;
> > + UINT64 Pages;
> > +
> > + AcceptPageSize = FixedPcdGet32 (PcdTdxAcceptPageSize);
> > + TotalLength = PhysicalEnd - PhysicalAddress;
> > + StartAddress1 = 0;
> > + StartAddress2 = 0;
> > + StartAddress3 = 0;
> > + Length1 = 0;
> > + Length2 = 0;
> > + Length3 = 0;
> > +
> > + if (TotalLength == 0) {
> > + return EFI_SUCCESS;
> > + }
> > +
> > + if ((AcceptPageSize == SIZE_4KB) || (TotalLength <= SIZE_2MB)) {
> > + //
> > + // if total length is less than 2M, then we accept pages in 4k
> > + //
> > + StartAddress1 = 0;
> > + Length1 = 0;
> > + StartAddress2 = PhysicalAddress;
> > + Length2 = PhysicalEnd - PhysicalAddress;
> > + StartAddress3 = 0;
> > + Length3 = 0;
> > + AcceptPageSize = SIZE_4KB;
>
> You've zero-initialized everything above, no need to do that again.
Thanks for reminder. It will be updated in the next version.
> You also can just use StartAddress1 + Length1 which uses 4k pages anyway.
In the origin design, StartAddress1+Length1 and StartAddress3+Length3 are for BSP, StartAddress2+Length2 is for BSP/APs. Now only BSP accepts memory. So you're right. We can just use StartAddress1+Length1 which uses 4k pages anyway.
>
> > + } else if (AcceptPageSize == SIZE_2MB) {
> > + //
> > + // Total length is bigger than 2M and Page Accept size 2M is supported.
> > + //
> > + if ((PhysicalAddress & ALIGNED_2MB_MASK) == 0) {
>
> The logic is rather messy. It should become much simpler if you update
> PhysicalAddress and TotalLength. You can also use the alignment macros.
>
> if (ALIGN_VALUE(PhysicalAddress, SIZE_2MB) != PhysicalAddress) {
> StartAddress1 = PhysicalAddress;
> Length1 = ALIGN_VALUE(PhysicalAddress, SIZE_2MB) - PhysicalAddress;
> PhysicalAddress += Length1;
> TotalLength -= Length1;
> }
> if (TotalLength > SIZE_2MB) {
> StartAddress2 = PhysicalAddress;
> Length2 = TotalLength & ~(UINT64)ALIGNED_2MB_MASK
> PhysicalAddress += Length2;
> TotalLength -= Length2;
> }
> if (TotalLength) {
> StartAddress3 = PhysicalAddress;
> Length3 = TotalLength;
> }
>
Thanks for the suggestion. It's better. It will be updated in the next version.
Thanks
Min
next prev parent reply other threads:[~2021-12-16 8:11 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-13 12:56 [PATCH V4 00/31] Enable Intel TDX in OvmfPkg (Config-A) Min Xu
2021-12-13 12:56 ` [PATCH V4 01/31] MdePkg: Add Tdx.h Min Xu
2021-12-13 12:56 ` [PATCH V4 02/31] MdePkg: Introduce basic Tdx functions in BaseLib Min Xu
2021-12-15 6:33 ` Gerd Hoffmann
2021-12-13 12:56 ` [PATCH V4 03/31] MdePkg: Add TdxLib to wrap Tdx operations Min Xu
2021-12-15 6:44 ` Gerd Hoffmann
2021-12-13 12:56 ` [PATCH V4 04/31] UefiCpuPkg: Extend VmgExitLibNull to handle #VE exception Min Xu
2021-12-13 12:56 ` [PATCH V4 05/31] OvmfPkg: Extend VmgExitLib " Min Xu
2021-12-15 6:56 ` [edk2-devel] " Gerd Hoffmann
2022-01-20 6:34 ` Min Xu
2021-12-13 12:56 ` [PATCH V4 06/31] UefiCpuPkg/CpuExceptionHandler: Add base support for the " Min Xu
2021-12-13 12:56 ` [PATCH V4 07/31] MdePkg: Add helper functions for Tdx guest in BaseIoLibIntrinsic Min Xu
2021-12-13 12:56 ` [PATCH V4 08/31] MdePkg: Support mmio " Min Xu
2021-12-15 7:02 ` Gerd Hoffmann
2021-12-13 12:56 ` [PATCH V4 09/31] MdePkg: Support IoFifo " Min Xu
2021-12-15 7:18 ` Gerd Hoffmann
2021-12-13 12:56 ` [PATCH V4 10/31] MdePkg: Support IoRead/IoWrite " Min Xu
2021-12-15 7:18 ` Gerd Hoffmann
2021-12-13 12:56 ` [PATCH V4 11/31] UefiCpuPkg: Support TDX in BaseXApicX2ApicLib Min Xu
2021-12-13 12:56 ` [PATCH V4 12/31] MdePkg: Add macro to check SEV / TDX guest Min Xu
2021-12-13 12:56 ` [PATCH V4 13/31] UefiCpuPkg: Enable Tdx support in MpInitLib Min Xu
2021-12-15 7:33 ` Gerd Hoffmann
2021-12-13 12:56 ` [PATCH V4 14/31] OvmfPkg: Add IntelTdx.h in OvmfPkg/Include/IndustryStandard Min Xu
2021-12-15 7:37 ` Gerd Hoffmann
2021-12-16 6:43 ` Min Xu
2021-12-13 12:56 ` [PATCH V4 15/31] OvmfPkg: Add TdxMailboxLib Min Xu
2021-12-15 7:47 ` Gerd Hoffmann
2021-12-13 12:56 ` [PATCH V4 16/31] MdePkg: Add EFI_RESOURCE_ATTRIBUTE_ENCRYPTED in PiHob.h Min Xu
2021-12-13 12:56 ` [PATCH V4 17/31] OvmfPkg: Update Sec to support Tdx Min Xu
2021-12-15 8:18 ` Gerd Hoffmann
2021-12-16 8:11 ` Min Xu [this message]
2021-12-13 12:56 ` [PATCH V4 18/31] OvmfPkg: Check Tdx in QemuFwCfgPei to avoid DMA operation Min Xu
2021-12-15 8:19 ` Gerd Hoffmann
2021-12-13 12:56 ` [PATCH V4 19/31] MdeModulePkg: EFER should not be changed in TDX Min Xu
2021-12-13 12:56 ` [PATCH V4 20/31] MdeModulePkg: Add PcdTdxSharedBitMask Min Xu
2021-12-15 8:22 ` Gerd Hoffmann
2021-12-13 12:56 ` [PATCH V4 21/31] UefiCpuPkg: Update AddressEncMask in CpuPageTable Min Xu
2021-12-15 8:38 ` Gerd Hoffmann
2021-12-16 8:23 ` Min Xu
2021-12-13 12:56 ` [PATCH V4 22/31] OvmfPkg: Update PlatformPei to support TDX Min Xu
2021-12-15 8:53 ` Gerd Hoffmann
2022-01-20 9:07 ` [edk2-devel] " Min Xu
2022-01-13 19:18 ` Vishal Annapurve
2022-01-14 2:23 ` Min Xu
2022-01-14 2:37 ` Vishal Annapurve
2022-01-14 2:40 ` Min Xu
2021-12-13 12:56 ` [PATCH V4 23/31] OvmfPkg: Update AcpiPlatformDxe to alter MADT table Min Xu
2021-12-15 8:54 ` Gerd Hoffmann
2021-12-13 12:56 ` [PATCH V4 24/31] OvmfPkg: Add TdxDxe driver Min Xu
2021-12-15 9:05 ` Gerd Hoffmann
2021-12-13 12:56 ` [PATCH V4 25/31] OvmfPkg/BaseMemEncryptTdxLib: Add TDX helper library Min Xu
2021-12-15 9:16 ` Gerd Hoffmann
2022-01-21 2:54 ` Min Xu
2022-01-21 8:04 ` Gerd Hoffmann
2022-01-21 8:31 ` [edk2-devel] " Min Xu
2021-12-13 12:56 ` [PATCH V4 26/31] OvmfPkg/QemuFwCfgLib: Support Tdx in QemuFwCfgDxe Min Xu
2021-12-15 9:16 ` Gerd Hoffmann
2021-12-13 12:56 ` [PATCH V4 27/31] OvmfPkg: Update IoMmuDxe to support TDX Min Xu
2021-12-15 9:18 ` Gerd Hoffmann
2021-12-13 12:56 ` [PATCH V4 28/31] OvmfPkg: Rename XenTimerDxe to LocalApicTimerDxe Min Xu
2021-12-15 9:19 ` Gerd Hoffmann
2021-12-13 12:57 ` [PATCH V4 29/31] UefiCpuPkg: Setting initial-count register as the last step Min Xu
2021-12-15 9:20 ` Gerd Hoffmann
2021-12-13 12:57 ` [PATCH V4 30/31] OvmfPkg: Switch timer in build time for OvmfPkg Min Xu
2021-12-15 9:21 ` Gerd Hoffmann
2021-12-13 12:57 ` [PATCH V4 31/31] OvmfPkg: Move LocalApicTimerDxe to UefiCpuPkg Min Xu
2021-12-15 9:26 ` Gerd Hoffmann
2021-12-16 8:29 ` [edk2-devel] " Min Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR11MB50647DA89FA4E4A3077978ADC5779@PH0PR11MB5064.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox