From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web09.7606.1639643395079545721 for ; Thu, 16 Dec 2021 00:29:55 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=PWgF6oze; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: min.m.xu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1639643395; x=1671179395; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=th1MfJ7AOVLOmLgLb9yVIidGoElACVmFpPHb4UB/hv8=; b=PWgF6ozef6nezlrMxMc7DAjNDOmzEySRKEe9BHoLMkn7SwSIa2WiT7Ac nrI5z5PVT/Nm4Ueo57VHRswZ20HuLWmPlvoEKr5a+kz0QqBTPw+cyXZxA DiMcXI/mXLcrtph/7mPmwqDRRDmSxUXPcVwZ5+0ajhGtMkygxTZNdVj74 YN8aq3Fo/ke6JS5jOH9o451WJSUNS4b80MKW6sWwMTw6wWAdaOZe2LOCj K1SJH28CNp+IDIsG8shUG9/eJ2jF4t/oNvsiI2RhsmrRFbWzz9MXAH6Br N2E22/IJ/BgqDcwam5+DDDGxdtGIpmP5G0ajstyiHzEwm4aQC8QKA7FT6 g==; X-IronPort-AV: E=McAfee;i="6200,9189,10199"; a="220116949" X-IronPort-AV: E=Sophos;i="5.88,211,1635231600"; d="scan'208";a="220116949" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Dec 2021 00:29:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,211,1635231600"; d="scan'208";a="506189356" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga007.jf.intel.com with ESMTP; 16 Dec 2021 00:29:53 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 16 Dec 2021 00:29:52 -0800 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 16 Dec 2021 00:29:52 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Thu, 16 Dec 2021 00:29:52 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.107) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Thu, 16 Dec 2021 00:29:52 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Eqg0UscL9CJQyLBTWKmz/oTBvE940r6YS8wDne/q6pUM2rYZiXFJi4YoCABFy/3Ojwd7hMEmSoYxXI8zK1Ix1YSapSmNz1QJE9ityknm+oCz5ApTJoEQDQt5CHkEkOPSXzaValY7Kts4xGHkKqfxqTuk9e53PTMGrFCi9d8hBpdE3O1ucMBmlItSbhOW0HcEJyhOcf8vJofDRMrpaPmQbija8X4FEHSjh/CSv2kpjE806UVwFzNNLxgNySLSjiBcKPRIp/LOYHB7QLa59IXN7VDTuh2r3OG69ik5DwkwLnQU5Mdpd5mmEQLXfToaP4GkeGHMwwK7zkdJdmvp5L2PWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ORsGj/9a9U/K+428VMo8mEZ9YnZ5/o6bT7fyk8tG0z0=; b=cfSz4S5Pk89aRqt2RN1ilAf7BAtljuRXKzmJttbZeI/OseXyF64Xw1m79jmOKDJt6ZBKCSago6R41/J86wWBExegz5WSvit8UyjERLlfj2FUCkJ07M9i3zYYBNUzLm86I/IrsU/ZYw8YNnp4rm6IUESCaDySuVYVEra8SHM5zV0qxXAUUOaPbO68VJxZSHtbm5MLADdF18kx52UvO4q4JDM/HYfeFwVEoB9eTt9kRQUSvoHcpwb3Tw5KoMo9knkng+s5B9cW/xb4O7LR0zqeM5AHRV0+DayvEfaZJMc/vruL7OzJE7bPTN+eYE4yslsLpFI2vdPHq0cXAGaIO2o0Gg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5064.namprd11.prod.outlook.com (2603:10b6:510:3b::15) by PH0PR11MB5928.namprd11.prod.outlook.com (2603:10b6:510:144::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.11; Thu, 16 Dec 2021 08:29:51 +0000 Received: from PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::fd42:b334:5030:af8d]) by PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::fd42:b334:5030:af8d%6]) with mapi id 15.20.4778.018; Thu, 16 Dec 2021 08:29:51 +0000 From: "Min Xu" To: "devel@edk2.groups.io" , "kraxel@redhat.com" CC: "Yao, Jiewen" , Anthony Perard , Julien Grall , "Dong, Eric" , "Ni, Ray" Subject: Re: [edk2-devel] [PATCH V4 31/31] OvmfPkg: Move LocalApicTimerDxe to UefiCpuPkg Thread-Topic: [edk2-devel] [PATCH V4 31/31] OvmfPkg: Move LocalApicTimerDxe to UefiCpuPkg Thread-Index: AQHX8CFbQt3KWC2AH0eoUooLkyoK8qwzS2UAgAGCF5A= Date: Thu, 16 Dec 2021 08:29:50 +0000 Message-ID: References: <20211215092624.ezdeswmn2gmn5fcc@sirius.home.kraxel.org> In-Reply-To: <20211215092624.ezdeswmn2gmn5fcc@sirius.home.kraxel.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8dfa515a-378f-442a-d40b-08d9c06e3a8c x-ms-traffictypediagnostic: PH0PR11MB5928:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6108; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 0/urn5YSIlqIUqEuO6jFaTWPiUzQXVpSkaJ+/coWDZXkGz+8+Jes3nk4b2mvD6dwVCwuka7c1nu8x2dGSzsL5qPs9dK+ATNYBtJvqTnNXyuQPJQHShPxQ+M/7cPYlpwNTgWVw/JZQ5vRHiTZ049tL3Ji/1z+0o1uccCOwB3vdK4tTxD93ttX9v2RllWDJXbjp1674t40CddqWwOubN4aXBJfg1pDJpfDr+NuVoV4Gp+B7e8VRwxgwZcM5wWduZH10XFplXAfXPv0Hu4MNC8eF+LgEAnI/zIXW3FREI/kv0n3AYohpK7YKNWC2f03aVGYGaFA/gFv6ZPxe7H+pqGS4nlHCe1nVUmwHW2F/oNTVV7udlVpCYWT+HR3dZTfU/qjMkjhlWvHVwbAj/kAqKcgSmTVWSrxvG/GXlV1UvzWLdhRzNolMD2rSzZSmjFwh2x0jdDQm7noKgtFmb86Be+OLPj+QQq1+UJtn3lTfSROe7mTJaa85pcSg1vKaGDTVFdx5C/wJzJ24dF4PTeBN2viD+LBMtQUJc1ZwUHCg6Glkt0YDUv5AkN8JdMq6fEhZpAkVXdwhvMQrwDa4LwOGHmLy16KYYBm18nKcvAFize98GSpKXUY8OyNKSbyFcXwEsV0MVAb+ihVUDNiFBCYZGkC4HpaoCliAExtu2to9atuNboKppF96BXyVsjbK8V4tWzSrXg10R2+gAZ7MkHo0VQ5rg1rY0yJn18e/89i1ToPnOWABdgyDSwKeZSVToZpsyjyRpgQozqsfoNrgX5jHK6uJt7+1CbQumjXL2t2KlfQA8c= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5064.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(7696005)(38070700005)(55016003)(5660300002)(316002)(9686003)(54906003)(8936002)(52536014)(82960400001)(107886003)(110136005)(8676002)(122000001)(38100700002)(33656002)(4744005)(26005)(66556008)(6506007)(66946007)(64756008)(186003)(66476007)(4326008)(508600001)(83380400001)(966005)(71200400001)(86362001)(76116006)(2906002)(66446008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?sTUApCwerGCNm807FfjxoDxpmFY6/fh4Pul5+die97CFlivujuO8u2IXaqdd?= =?us-ascii?Q?6fmXtFiHGGvUgKz2E9EqdG1MwaBHsxY/d0YZnvCskoiQpi7+9L2wRGJ3U3Pg?= =?us-ascii?Q?/bJqVGhjk9/0nXq2gmOR17LYiZAjxqDpjYhfB1gOrhv5Tr+igfLrjeNEpPaX?= =?us-ascii?Q?QlR1kYWHGbUKjL/X+xrRj5a8ViKhO38Azgq2i0QAnPXXWbGitGMg5VVvYzEL?= =?us-ascii?Q?ZWz/OTb2RMJGMD9yVPZEr3gOazQiMibLQEhx00aUPHPSV88Rs0/gN9oLbaM7?= =?us-ascii?Q?goPWaquAF+bBSGHz3pM0iBXmANvuFfd8vVF3tO/fQr31wmgaDpfRW9J7UBzb?= =?us-ascii?Q?aIUKiDCy53reaELtCbDlGo25hHKNLznZcqn/gkWD5v5D+vcbn5Z+dqjT1dCo?= =?us-ascii?Q?K0J7VblGWOIJsAlO8hqY9N8qnaa3MYekUx2y0yRnhVKp6PRD4nLnuptMfh4p?= =?us-ascii?Q?CzH1bTcbbh6wGlcGrZXptcosmkYLKP6lGWod7j9paqKcnpXN4O3M2UEvsP3j?= =?us-ascii?Q?vK16G63onnE0p/dsoXDg7S4bVTqSx5MXHc9M0MKn2zcTaXRgzXJRc8U/GZ5X?= =?us-ascii?Q?731WRvexcFOu86/b9XDUTDzCnyWs4xyCCIkh31yYTmu3wNJoQY+AMKX0Pf1s?= =?us-ascii?Q?DTApuL30+6P+UQIFBrUw+OeNqc47qthT+2g6DAxxiIn03J5oOPeogSMyw5/6?= =?us-ascii?Q?VzidyRhF+SSK2UNZonlevOJIw81sQH6dN4EHFE8eW1e7TCXhEJ0upS74fbh7?= =?us-ascii?Q?jVn2QsWsWXnDbr+A5gutXTOdbOhC7y5kWVH0augyI1rwxJkja+3nsdJNJoyx?= =?us-ascii?Q?E5+ljqOQOrCuvpZXIIhTDX1NgxX8vMWjtOviFo1lWbUPiLUxZJanQ6FGr2I5?= =?us-ascii?Q?9xlj3Dv63KWjDMoECw6yqkxgeCnfEna+4nHcrGl8A1Eiuw+3Z8TgKUWWCSGs?= =?us-ascii?Q?IxqNct/+LZdyAlEViHJX8x8awcN0lSDLZarO91i7UbcduuCUUyRCdg2KslqG?= =?us-ascii?Q?nmxFefpbz0k+HJIC0JQt9HptO/yw65eUTrY4n6fGGb2DESrjHBJCIKRn9zuo?= =?us-ascii?Q?4WS8/NllRwJR54huvjfsOGL8mSAGs6y+VU2gv/eN6o+PxDj0GN5iuonDpAcw?= =?us-ascii?Q?8nhFiYnWQ/321n4kP0l0jvzpzu0DHK19jPzBmvDPMew79u1PW2wo5nB8C5Gd?= =?us-ascii?Q?aq7eJP+nGe3eBfq/09uaCjE2BTudn7Vmr554TvH/tOYao9lNyd35WfFAHQQH?= =?us-ascii?Q?UzDeVJBIer9m+XCAvgTS9xlV570HTD1uIDm031Eny8aYZnGcFWgMUHs+f8N/?= =?us-ascii?Q?/UtBf2/9EJJDmY8m2gD1+MuxaowdQap8qFI2jxzttDVPU9Cvrfhfm8YNLSOC?= =?us-ascii?Q?Dr7FwGeZyIEW+nkGk+4rDa/rX3rn3lq40PQqO0PUJ15bNonE8c4oXjWFzqh/?= =?us-ascii?Q?GySNR/dRccI+dr+fjeIONLSC3gc3hvYqwDrb439SMdD9JTBuZHP4dLLRYDk7?= =?us-ascii?Q?56DrnCmO5lgbCyHXEJM5nFDMzeEM9546WxNSjL12nsRmfUyQuxZrpsuoqzjo?= =?us-ascii?Q?+pOMTeWkCqGMx6kWtsQ+RtxnC2UzvBBxzfqH6u/MlgrRxqmjBzlOeUE3z8TG?= =?us-ascii?Q?+Q=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5064.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8dfa515a-378f-442a-d40b-08d9c06e3a8c X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Dec 2021 08:29:51.0013 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 72Gckkkfq/+qsidljNmnljh4xpAJV4ndN8NxRTFq/9AzbPZbBXW3DZQIPwmZmJjEf0GEY4CMKW0QBDhfg1rKIA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5928 Return-Path: min.m.xu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi >=20 > On Mon, Dec 13, 2021 at 08:57:02PM +0800, Min Xu wrote: > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3711 > > > > OvmfPkg.dec is removed from [Packages] because it doesn't depend on > > OvmfPkg. LocalApicTimerDxe is moved to UefiCpuPkg. >=20 > > if (mTimerNotifyFunction !=3D NULL) { > > - // > > - // @bug : This does not handle missed timer interrupts > > - // > > mTimerNotifyFunction (mTimerPeriod); > > } >=20 > > if (TimerPeriod =3D=3D 0) { > > + // > > + // Stop the timer > > + // > > + InitializeApicTimer (0, 0, FALSE, LOCAL_APIC_TIMER_VECTOR); > > + >=20 > This is more than a pure move. > Functional changes should be a separate patch. >=20 > > TimerDriverGetTimerPeriod ( > > - IN EFI_TIMER_ARCH_PROTOCOL *This, > > - OUT UINT64 *TimerPeriod > > + IN EFI_TIMER_ARCH_PROTOCOL *This, > > + OUT UINT64 *TimerPeriod >=20 > What's this? uncrustify? > Reformating should be a separate patch too. >=20 Thanks for reminder. It will be in a separate patch. Min