From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web12.7544.1639643026003971207 for ; Thu, 16 Dec 2021 00:23:46 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=SnRfi4Av; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: min.m.xu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1639643026; x=1671179026; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=NTtIknUDQmIZ8IzUy6ejRTjXHr9/fWvdd77zZi7/HZk=; b=SnRfi4AvWpejIqhDUrSFlucrxZ89nKBepFSc/WMs9rayCoW/0i0S+opt NnEretmf+jTxGuGodIQ5EUf9bKy2KqZXpNNMpEh1pNTjMn3OGduAZbRB9 5npH4UXH2pSCQ7/ywXUsC6/quoFCEPZFnU78jv+zdhgPzTCA8lpeEqUOP twd2Jnakh0jniEr4Wj2j7TaG4dO1a4a82TPcRwsL3DKaDNKcjC5QfFkYc +zgyUChTiKfF+l4DsZJ32248l3VX2d4J30rQuFYHYfJrgmNRFo64O5jdZ 5i8kqkTdiHnkiNEs/deRokad60+UdAIVQUfN6vP+ctbfnGCUKgor8K7r4 Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10199"; a="302807318" X-IronPort-AV: E=Sophos;i="5.88,211,1635231600"; d="scan'208";a="302807318" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Dec 2021 00:23:44 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,211,1635231600"; d="scan'208";a="464587342" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga003.jf.intel.com with ESMTP; 16 Dec 2021 00:23:44 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 16 Dec 2021 00:23:43 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Thu, 16 Dec 2021 00:23:43 -0800 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.48) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Thu, 16 Dec 2021 00:23:42 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=coDsgd+HpOSZmWr3fp9oKy8g65H7BWt1n1klMFnk6Gl0lmI9h5VyIENeikPrGjW0h3Qmw68u+9j9P5JXuLw7KeNeKyUQ6wTrwumEPIoBlypFE6nUTBhPl6YkdhPLgqdCleRrzznZyzAKgEkC+s5/mZQF6Nx89dQGT8Pez1mGE8Baz3Nfzh9iiIdNx/y6ePb4wnQiuf4F1zAhdCgLnhohvTtnZzRNEHf0fqPeERUCsel0jCQC9uFpfqOoqhZjqvvart4PtswxTEr2i4IVLDkb2qgE17zUrr8Cms35/t98OL0x7FWTD7ypaKOKmzWpMqweisxtuZNe0YE0dqE2+UVlwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=trk2kZ1oeGcK8nVEqqsJAPPuEMh5BoVJOhyI4xhIMcU=; b=DFZlfPDnO5Bz42dRlSLTc70VmUCfD55eULD35NFa3fkyvMIWOnjCJj/uB/u8L6Gp2V6EBHjDqiSfHI2mybrvbzbCBYGyysCNwaF5by+ozHBQQWjv0RqQKP92eEbTpZwM0t15ho9c/OxGQzUDIIIbXi/Mgt9x5QgMADF695oFBWFIDeyc8FiiwDgke3FE/3OYOqN6AsbjkHpmgYIwAynuDcGOWt6LWeslfn7QjdRCK9WZS3/KrpX8KxXyFC8A2Y2SLTVHAndCrOkd1v0j6TqYDcxoehzQ2JvzsRW4RAwP/DejEIfkgquQ/rMn0kkgGndMqN1q0wbdfMIeqOQQdtxCwA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5064.namprd11.prod.outlook.com (2603:10b6:510:3b::15) by PH0PR11MB4935.namprd11.prod.outlook.com (2603:10b6:510:35::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14; Thu, 16 Dec 2021 08:23:41 +0000 Received: from PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::fd42:b334:5030:af8d]) by PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::fd42:b334:5030:af8d%6]) with mapi id 15.20.4778.018; Thu, 16 Dec 2021 08:23:41 +0000 From: "Min Xu" To: Gerd Hoffmann CC: "devel@edk2.groups.io" , Brijesh Singh , "Aktas, Erdem" , "James Bottomley" , "Yao, Jiewen" , "Tom Lendacky" , "Dong, Eric" , "Ni, Ray" , "Kumar, Rahul1" Subject: Re: [PATCH V4 21/31] UefiCpuPkg: Update AddressEncMask in CpuPageTable Thread-Topic: [PATCH V4 21/31] UefiCpuPkg: Update AddressEncMask in CpuPageTable Thread-Index: AQHX8CFCv+/qcZaetkCBNtRJKrTuDawzPg6AgAGN0tA= Date: Thu, 16 Dec 2021 08:23:41 +0000 Message-ID: References: <20211215083839.l3mwtkeej4aak7up@sirius.home.kraxel.org> In-Reply-To: <20211215083839.l3mwtkeej4aak7up@sirius.home.kraxel.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2c8b340a-1fac-4f69-cfdc-08d9c06d5e5a x-ms-traffictypediagnostic: PH0PR11MB4935:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3826; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 69sUw8arjnaHmxImeiawSRiaKg0k1BSG8NBBA2sejYNY5B47TAv9tr/wTGEc/1QueD/AQwtGfEbYMBEu8bwVyE89FKwEYiZAAjYOsVVjxa937vcYTqE/YSrI9NU6iV9B86ZACYRR2AoXEcDwM8N7c6S5zLAkbWBlneOTIQzkQpD0BAYgjuI7pb9r4VjbDd8ouroqhMGCu5ASAmAbPrYWJI4nTGh8F9aXtfvmQmJmuvhsVGhvJNfasU+GPkvsqb9QTRCtLhZcL7tcESz83L6zRGiIUADYoKWjBqcLRWamlMMNOh2QCGBaqG+1L/70wKal1aIf9wOVCpvLrA8ag+Ry81cYXTmLWI/zw4xXqyIXPvNk9Ml2xKofiSOymyWu7ER2hzHRt8jpP33Nk81WU8MMYkxstGrdaSo4DH6sfJTEZ3IyEk0Y6EzoVKNMuRRrvw2J8NzDtlKszjFBOpXQDLFHMVosZIDWpU5n+h9JrBgYEONsP0x2GrgNV3pJdmNpJLoURmqEWl3hQPADAg+xseMqaRQuXsmsz3umfUkPL8S8ZzUpWlH/Q/joLeJ/TFAGLz2OZ+AbTKWBD5ds/z7IxujO+gGks1bjn6fFKKFpzRSVFivMOgjSYMfLbutpErabZ1+mGoxuCkUzsV/I4IzJjK4/DtTQ5XUynW75v/inDJ4QJEBv0cd6ldNh6eZjyyTENAhOHqeoQD2S2gMhLfzesF1H7w== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5064.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(186003)(66446008)(508600001)(8936002)(4326008)(38100700002)(82960400001)(2906002)(6916009)(26005)(38070700005)(76116006)(66556008)(66476007)(66946007)(64756008)(71200400001)(107886003)(54906003)(9686003)(7696005)(4744005)(316002)(52536014)(122000001)(8676002)(33656002)(5660300002)(86362001)(6506007)(55016003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?JbhlVBt28z8C5WRPGw3GQ2LkKR6mudC6LRd4CH8OAzWViIURCQIMepi8hnVq?= =?us-ascii?Q?HjuxYmAY1ZWrsCS+FOBOSmhlKXJwqW3i4bUcQHzgjUQ2ze08phsNfg+js/pp?= =?us-ascii?Q?WoDrVDIXl2CF/4MDFi4g0L379pdhTt3zlOhLywT+el+zDs2g+ebFyEbRrWR9?= =?us-ascii?Q?cPYApEN8mkfxdR15gaG87OnjNpAwM/BARmmXnvcEVn1EG8hRNPc9oJFRKXDn?= =?us-ascii?Q?qQoz6nmVBc15mnZndXtqCFJTTdl+8AGPslOFKP3kxTAQnCFEQtayvpeyuBnQ?= =?us-ascii?Q?81zYr+iT1SHcj9ttopW+P1auL+xLLl8QDbc2C3eipfbeyVZ7UC/AX7xCep07?= =?us-ascii?Q?kvyIZuC41J00+FGWYaH/JZynySEv82JldMTLw+iOWBdGRCRGa9FQDOGWYrWY?= =?us-ascii?Q?hPvgdtMxXnts+YT8eN56cQW7Rae3yT7gx2zbPFtx5kdJ32NV3GZV/cYwHjEn?= =?us-ascii?Q?4W37llBMPHTEZDMsbQIADHAGelTwhfFC1aMzx+rCvgF8fnAaPMjrsCgqPvTD?= =?us-ascii?Q?uqoCutx4k/lyKwQ7TrawACwv7wZX0fyBihRa7MlL8TC0ZRbOTODst5uc7mR4?= =?us-ascii?Q?Vvmm5pZFVfMGPW2z+ELlFvGfq1U1WqpEmQgiYN28C8zlBYP1jVMUiQtYbfIk?= =?us-ascii?Q?ByT1hOaki/zjo8OYajkZo5PvDAJd2heehzN5exx0MwZcU0DuhwhDoBJmQ4pe?= =?us-ascii?Q?mJ4twf+8IsL1JMg6g6vA+lR5+0nhMs9dUnNTfPp+Xik1oPEmpIJzUYqpJHNL?= =?us-ascii?Q?826NM/5PqljC9Wc8tqAiseqiCB7k9KHdH14eqlEPLXxqGs4dhYAyFgK0e1P4?= =?us-ascii?Q?pAxL3aIDebBSBdeJLUyXdCfsGGVGjekhIpLYUcsV+l7dkgbcmCSHjg3gxpqm?= =?us-ascii?Q?j6aS80fu0fFstUEHSzUM5BdZUc78sOuXg11H0IiiqylIAhkmfFflB6bQP1sg?= =?us-ascii?Q?sih4M9cyT4oJyS4iwOhsU8zA0m5Co5urT761c6SzUqc/bfYwAALtrC20gsdu?= =?us-ascii?Q?XmjDbI95i8+8EfIF0/H+fGhdecdefrR+/DHP2oOeXOlZnW/zNEYNtUR/++eF?= =?us-ascii?Q?f4VvMTt+4ZXm/DBcfbvD8pQLVSSzDtKooFrrb5R6bzLapDI+8hD6xiv4jY8p?= =?us-ascii?Q?pabCWlb/KKDIRmuCYYLqXMRR8aOGFTDk5ermUlZiDei4hULiGZkhtWP/r/HD?= =?us-ascii?Q?lF4XWd3lGexBcK29AmtvwL+GMuYAp1RZoyJnPmtAucwZ9FX81OdMx+BzQvZg?= =?us-ascii?Q?NBfnlJXm0ZmYXriueuCoPuKt0C+Nr6Ehu/XQiYOH5AJkloKu0ks9XkdgrRU+?= =?us-ascii?Q?pJoXaF1vLYPzxcEIkQLDzUF74+otsKThbZngMm5Ryh31vyRJqUmQ04hVxKgs?= =?us-ascii?Q?RjjVPBu05aA4bkTPYs78S+1wNCEqyYBklpM2oRLX920xR30eSpw+y6uJ/Iv6?= =?us-ascii?Q?nxmnv7Wp37kSB6+s+Z55RECxrBtMnbaqp2TeAd20taX6UyU+x8ZwZnDtWQnO?= =?us-ascii?Q?qYo3GbPSKaXSvQt9nRflmNg6BN63F685Ob5FKnV2UyMnQqJvuZeUn1ge0fDU?= =?us-ascii?Q?SVygWZY4ZGPinpIyr8NCe8RF7k1RMAcSGaFq8r/tcz5j33dAwqMhTZ8rzd0T?= =?us-ascii?Q?WQ=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5064.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2c8b340a-1fac-4f69-cfdc-08d9c06d5e5a X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Dec 2021 08:23:41.5170 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 6IqI6x4OjfK9HCrtV9EqA0zWw6ROaCCbFwCvbaqoUumlsexnviPSLdGr8yWONzMJus0KwKMEgBcGmYzhVVXqzQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4935 Return-Path: min.m.xu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi > > @@ -357,6 +360,7 @@ GetPageTableEntry ( > > > > // 4k > > L1PageTable =3D (UINT64 *)(UINTN)(L2PageTable[Index2] & ~AddressEncM= ask > & PAGING_4K_ADDRESS_MASK_64); > > + > > if ((L1PageTable[Index1] =3D=3D 0) && (Address !=3D 0)) { >=20 > Hmm? The blank line will be dropped. >=20 > With that dropped: > Acked-by: Gerd Hoffmann >=20 Thanks Min