From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web10.9439.1642753967908536141 for ; Fri, 21 Jan 2022 00:32:48 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=RkekyZoq; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: min.m.xu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642753967; x=1674289967; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=WJKnfCb25h19DOzht0VBH89JtKQlOmOrh5qxfNnxuxw=; b=RkekyZoqk0mpMvcK/80Z4BapUvGfpY22itFdwgWweNyIBAwaNvKu9+mX jvcfFsO346NVAtJ9JaIBJrrt7Rp2GuxggktLwhANyefiAz+xzzyIwseLp /+tDbGL7DttQIvE8Fc6a1w3njmBZp4K8xb2Lm3oiBbN+U1v0W8NCGJxPZ mza3tGTwohRr4o1QJQG+9ZLbBGU8pliWrrfq5E5CjpnONtT8sVOTpBvF/ XZ9gJ1AdZuDwO8zg/BqHxBf4CgM5szXXwi2dL8TdjVYK4d5OiGnysOsaX HDuxtrnkTl5RaObDzxCHAfzH9vu64gNAQrihyCGvIoRGeBbSdDjyyqd/C g==; X-IronPort-AV: E=McAfee;i="6200,9189,10233"; a="243194536" X-IronPort-AV: E=Sophos;i="5.88,304,1635231600"; d="scan'208";a="243194536" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jan 2022 00:32:47 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,304,1635231600"; d="scan'208";a="518983942" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by orsmga007.jf.intel.com with ESMTP; 21 Jan 2022 00:32:47 -0800 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Fri, 21 Jan 2022 00:32:46 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Fri, 21 Jan 2022 00:32:46 -0800 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.44) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Fri, 21 Jan 2022 00:32:21 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PL7ExBDi+w5t4igCiUqUUygAfT4wABW59VJLGEOEqLGC4u2eNUEz8m0hhYeNO2xvZWr+/eIEp5j3HsBUV63iV6+tY9nD3k2WOx/SUQPWOoCRsABiRfh6Hoz6bmiMpW52Wc7Cg7/2ZGnz5bWE/QyJbtoaLUEytnkmaq74w131CU2jEr82o2NRWiyaxPrA/8k/P0Dw6cXrhv9Cp5O2ygpTA1+joTs+MnYOGM5E0hC5FjXUZbBEZA429fzPAgdFmIPSsLkVbQHyYvXIlFt9WRFnxnGtXPgWFGrN9b1PUnDWRbOwdtJjoOm/pJ9GKdF+xpFDYqyOda4/0UcwhJRo0NKyIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=M1QuuJtyTey/ECCsJ0ZyHsXggddJSREwDONZJYQA2JA=; b=HmSt36dLx2+dko7iMSf2Kff+P1I+htq37IJFZZqPjC26zghyVS1w2jxoEkRu4rpffnS6tCtFWYwBCZvXcu9tvwbyqh23lmFjbmb3lm+4Mr2NoPvJ8sBTX8BOxXGBw38iLqQP6HpPa1JBj2S/FuBVbARduotDJ8hHoG1W8KE21D37z5dBEKgWkDTYpgpussVyVozEIeoVrLA1UEoO9kncJQMPE09UWbLh9YHUVq0vY1rxI46iBldSnBbdzuxNPO3hn1DtXNA+S/olr0kmEVEZFjq+05khcxJiIyKgp55y7qnRT1Yb7Peu7k4dcJdRT5YTNcl2OXCPcLiN7krlD6IKjw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from PH0PR11MB5064.namprd11.prod.outlook.com (2603:10b6:510:3b::15) by DM6PR11MB2602.namprd11.prod.outlook.com (2603:10b6:5:c0::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4909.8; Fri, 21 Jan 2022 08:31:47 +0000 Received: from PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::ed65:b010:fc2c:f48c]) by PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::ed65:b010:fc2c:f48c%7]) with mapi id 15.20.4909.012; Fri, 21 Jan 2022 08:31:46 +0000 From: "Min Xu" To: "devel@edk2.groups.io" , "kraxel@redhat.com" CC: Ard Biesheuvel , "Justen, Jordan L" , Brijesh Singh , "Aktas, Erdem" , James Bottomley , "Yao, Jiewen" , Tom Lendacky Subject: Re: [edk2-devel] [PATCH V4 25/31] OvmfPkg/BaseMemEncryptTdxLib: Add TDX helper library Thread-Topic: [edk2-devel] [PATCH V4 25/31] OvmfPkg/BaseMemEncryptTdxLib: Add TDX helper library Thread-Index: AQHX8CFJmDVHtLIPVEO7sEWFrXRlX6wzSH0AgDm6pdCAAFeJAIAAB2Tw Date: Fri, 21 Jan 2022 08:31:46 +0000 Message-ID: References: <20211215091600.q63ltwlbliwjbm4q@sirius.home.kraxel.org> <20220121080408.75lupx2n7e5iwbsa@sirius.home.kraxel.org> In-Reply-To: <20220121080408.75lupx2n7e5iwbsa@sirius.home.kraxel.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f5c548f1-160c-49f8-21de-08d9dcb87659 x-ms-traffictypediagnostic: DM6PR11MB2602:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Wk5Z4bYup8mHQOsiw6xFkSBszdQ5eAXS3xvVfCQn+sFrb9j2spcy0ZvH3Cpi70rXF1PIaUP1b5PHU6GgYLtrpazNiHqRrPlo81x8cpGleNDjuOFsEdgrmh+p+ERmQ3wH4TdgOMF9vbv/yDbPhVcXIJGv2jxRNmvqdMEqvYROr5O1Oprx2Eq6D5tE42OMtIS3aK/YDoHHkFdBwop9wFxbNseQcKU6Wp32a0lA3hoNH3JYjisHtsgmK3eOHwd1dT4nmzPfF5g1Pe/sNooOsuxwtHrNkl94PaypMHcoPEJkScK7KqK7Bj4dzmR3fKViT24ajsqD3/zKFfSQvS1Y0NOoKii3zKAgTWh1AqVq4QyBALyinaWowTzSVcJ5b0zwTbXDQV5/TKmjA3Nh3o13kuhSBYFkCIAl58veBM9e0eaRYZx8ojl8AzRKpm/QeRw9lbSK59aePoMXIfPcqx8OO+wCOD7QMefa4tSWKjpaE9xAwMdz3CqlD2S/+YiWyYBJGvI/cbAKQjPQ6SWjAgWBGdOD3w6k4VvcyzAhBemd4gEFbLaOvKHaSKmNKMO4ezr0BWvakOBFLC/GK5zUic6pJO+AwvCN1MIFpossdRVBGdePmJsH8mMP1JgtS6L2ruXpRmjTk7PLN0uUzsj0NxV1OobGK4JgZb6UydSbnoUFYrjcpZIscRVdBowQNfhMh0S4tPQ0fSPC6nGviijf9HpFlAhSvOQs50NuofsMvYopdKxAd+i7WQgOWaD+TyNeFJmC71PYKN2g4Eqfm0TYz4SEXdhdEsgEeP6Zqpp4DlmmDuRZGH7jpJZbZyFo4j/sogEULewHrMo2SOeh3aySKv6Rn+1uBxrTy8nNKr6wc3STvJmxVPQ= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5064.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66446008)(4744005)(38100700002)(122000001)(86362001)(316002)(66556008)(71200400001)(66476007)(83380400001)(66946007)(4326008)(5660300002)(8936002)(54906003)(508600001)(64756008)(38070700005)(8676002)(7696005)(9686003)(55016003)(110136005)(52536014)(186003)(966005)(2906002)(6506007)(82960400001)(76116006)(33656002)(26005)(213903007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?pCFll9nERXeZV1+VswV30wskFvOhQVqs6kONyRTNfAsmr7lkmxlofev8PDjH?= =?us-ascii?Q?AXLlCs/FJJVmct/b+WDPso0AAw/acXDcgi5Yfh9fX7otVsIIpn7Pi6NquVjM?= =?us-ascii?Q?hBpQWSKnNVtYa6v1jvaOtbAPd6XFPzCwGMY3481HTkIjA0H6yo2QyaZZmnEG?= =?us-ascii?Q?0MdumRwmgZPaJ5ovYiuJXBmDfclAIZBxfPOEZ8PycCO732FHD05hgj8dT3b2?= =?us-ascii?Q?+b3TzXICDp+DR19DqxQMvN+4rJr2fHYpdFK+CcOM0ZFlbYBilwy3Vl07WTsc?= =?us-ascii?Q?Vj10SjOKM4ivhOm3fP7WvzH8q/Vp3s78qilV4T3cZHVYJ4d77+wrs0TOo/JA?= =?us-ascii?Q?TNhi+VNpKvsMF6l8DsccrY7Cw/D43HMlPdoOW4jQI5TwB+OeKGKkeB5qMva3?= =?us-ascii?Q?ttuUoPgIW9DWUjxooaK6VfPmHEY+8LP5mwN+zLOiscC2lgmiz1okkCxyXsed?= =?us-ascii?Q?JR8I69WjWaJ84IHieWkeemc/c0z9WPHLe3ANSqvv/29N6JZpc9ysj7cNWUmc?= =?us-ascii?Q?wz8p2AoSBhQTj+km05olKftcdKykCCvVk53g6ZrFV39uMtTRlBcM4vYH/OR+?= =?us-ascii?Q?ge+TcWhwtVHwvSeoTCqwpp40pBH3UjkkJ9qDpakKn7VwgDEFpI89/AXAZfJD?= =?us-ascii?Q?7bt+7a1mLEP9kQKseZjr73Oaq53rqbGC8aIQt9YtvQs7B3d1n4rG0odPq9//?= =?us-ascii?Q?ZTyEpPnUn3RUCz32vVLrvLasAs57gYifswy1UZPxflexy8ymHCTW6EvalC4F?= =?us-ascii?Q?MQly/+3nZl+9HdTmUUMwneV0kCZRGPjFP906fhLRyvRyU1FJiquPv2aFc8TD?= =?us-ascii?Q?YLqwlTCwIbUhEzFT93URmxmiNAuGIrWJyREoG4icLHfdznSQGsRvBhbNZ2vq?= =?us-ascii?Q?A8al4dVGzfBs9i3Ehpus6oAKpPTI5QqVtWvJCIDTYO2bPs1TSF3f8/TTSjEk?= =?us-ascii?Q?24Ah+/ppqmuUCYmypPlNbGsPnHaIPi+7x/MO6thlYZ86oHd2KV1ejVY12B2O?= =?us-ascii?Q?Xe+DOcqkgXNI0Plsg4v5RRIy1fVmbS84QYuNsMQGUqNH6vTgRqaYJ9+GHQkN?= =?us-ascii?Q?puuMEBC0g99TWQDqumJP3F3FjpQ005Zj+/3oEpu4pzAXbfkB2EtiFTO9G/F6?= =?us-ascii?Q?3kSIxbnEqiOMnk10kEzLv+CKTjiKhpvXoiHTviB6NtPbJjc4K8c8nCccuNEo?= =?us-ascii?Q?0ltSZiDP4ABoBgN9ZBtAZP+I5AcaHLzTdxkg30PuW5oR0OB4CeQjO86iB/RJ?= =?us-ascii?Q?o9C0fu7IeZdfMkigjXdjm/qPGUJDuwHnypTVMBUZUBwFvhxEA96wXRu15L/x?= =?us-ascii?Q?i3W+MIFY0wzSnFGKPzCJHt0H4M6t1bjLBhHCQ4+hCxDTHXeaVyJ0wbhiQp6A?= =?us-ascii?Q?6MyT5L2283vkxo2xuCrwHMO+nFh1SGuEwILGnGm8hpKS1mC3o52fuQ05KIxM?= =?us-ascii?Q?53JPe1wOf3v5nqOacU+X9Tv/g5xoSfM/FDB0JlP2RdefWKp26geu/HpcfFU3?= =?us-ascii?Q?ZikKTH3AnqkdnxF5WCgVg4dU7Jn8YvPu+7mEG2iw180OhwNzk0ZRuYij/Vh5?= =?us-ascii?Q?JSqPUdW5SJZoSbR14OZn04o6BF0h1FVG8ivxUbBGxkpwC9kgk3rjbkMiIRNr?= =?us-ascii?Q?9OLAlZPU5hddXH5C4x1nEvw=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5064.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f5c548f1-160c-49f8-21de-08d9dcb87659 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jan 2022 08:31:46.6188 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: R5RzYHiXC9mTSrYO8oHAc/+jIeqEx/jqDXHqdZBcYamRPSiqDO374hTAWLlLTeZmEwjwWQ0553ogYADx8xS4Fg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB2602 Return-Path: min.m.xu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable On January 21, 2022 4:04 PM, Gerd Hoffmann wrote: > > > Can we move most of the code to a (x64) page table library instead > > > of > > > cut+pasting like this, please? >=20 > > As I explained in https://edk2.groups.io/g/devel/message/85582, there > > has already been a same feature requirement. > > https://bugzilla.tianocore.org/show_bug.cgi?id=3D847 . (Create page > > table library to abstract all page table manipulations) I discussed > > with the feature owner (Ni, Ray). He said this feature is in his plan > > of 2022. He suggest I can wait for the library. >=20 > Ok. Can you add a comment to the source code saying this is temporary un= til > the lib is there, and a link to the bug? Sure. I will add the comments and thanks for your understanding. Thanks Min